From 877899739a94e5ecf1e80784ecdaa500899831ba Mon Sep 17 00:00:00 2001
From: Andre Klapper <a9016009@gmx.de>
Date: Sat, 10 Jan 2026 14:38:24 +0100
Subject: [PATCH] Misc PhpDoc corrections and additions

Summary: Fix/add/move some PhpDoc stuff.

Test Plan: Look at the corresponding function code.

Reviewers: O1 Blessed Committers, mainframe98

Reviewed By: O1 Blessed Committers, mainframe98

Subscribers: mainframe98, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D26669
---
 .../config/option/PhabricatorConfigOption.php            | 1 -
 .../differential/parser/DifferentialHunkParser.php       | 4 ++--
 .../maniphest/xaction/ManiphestTaskAttachTransaction.php | 9 ++++++---
 .../search/menuitem/PhabricatorProfileMenuItem.php       | 2 +-
 src/view/phui/PHUIButtonView.php                         | 8 ++++++++
 src/view/phui/PHUIHeaderView.php                         | 4 ++++
 6 files changed, 21 insertions(+), 7 deletions(-)

diff --git a/src/applications/config/option/PhabricatorConfigOption.php b/src/applications/config/option/PhabricatorConfigOption.php
index a39b44df77..e06147e7db 100644
--- a/src/applications/config/option/PhabricatorConfigOption.php
+++ b/src/applications/config/option/PhabricatorConfigOption.php
@@ -207,7 +207,6 @@ final class PhabricatorConfigOption
   /**
    * Get the type key.
    *
-   * @param string $type Type key.
    * @return string|null
    */
   public function getType() {
diff --git a/src/applications/differential/parser/DifferentialHunkParser.php b/src/applications/differential/parser/DifferentialHunkParser.php
index 80994b3327..50d084b01e 100644
--- a/src/applications/differential/parser/DifferentialHunkParser.php
+++ b/src/applications/differential/parser/DifferentialHunkParser.php
@@ -673,7 +673,7 @@ final class DifferentialHunkParser extends Phobject {
   }
 
   /**
-   * @param array<DifferentialHunk> $new_hunks
+   * @param array<DifferentialHunk> $hunks
    * @param bool $is_new
    * @param int $line_number
    * @param int $line_length
@@ -766,7 +766,7 @@ final class DifferentialHunkParser extends Phobject {
   }
 
   /**
-   * @param array<DifferentialHunk> $new_hunks
+   * @param array<DifferentialHunk> $hunks
    */
   private function computeOffsets(array $hunks) {
     assert_instances_of($hunks, DifferentialHunk::class);
diff --git a/src/applications/maniphest/xaction/ManiphestTaskAttachTransaction.php b/src/applications/maniphest/xaction/ManiphestTaskAttachTransaction.php
index 0a04f074b8..723dad386e 100644
--- a/src/applications/maniphest/xaction/ManiphestTaskAttachTransaction.php
+++ b/src/applications/maniphest/xaction/ManiphestTaskAttachTransaction.php
@@ -1,11 +1,14 @@
 <?php
 
+/*
+ * This transaction type is deprecated. We keep it around for legacy installs
+ * so any transactions render correctly.
+ *
+ * @deprecated
+ */
 final class ManiphestTaskAttachTransaction
   extends ManiphestTaskTransactionType {
 
-  // NOTE: this type is deprecated. Keep it around for legacy installs
-  // so any transactions render correctly.
-
   const TRANSACTIONTYPE = 'attach';
 
   public function getActionName() {
diff --git a/src/applications/search/menuitem/PhabricatorProfileMenuItem.php b/src/applications/search/menuitem/PhabricatorProfileMenuItem.php
index d5fe3f42e5..bcfffc60b7 100644
--- a/src/applications/search/menuitem/PhabricatorProfileMenuItem.php
+++ b/src/applications/search/menuitem/PhabricatorProfileMenuItem.php
@@ -77,7 +77,7 @@ abstract class PhabricatorProfileMenuItem extends Phobject {
 
   /**
    * @param PhabricatorProfileMenuItemConfiguration $config
-   * @param array<PhabricatorProfileMenuItemView> $list
+   * @return array<PhabricatorProfileMenuItemView>
    */
   final public function getMenuItemViewList(
     PhabricatorProfileMenuItemConfiguration $config) {
diff --git a/src/view/phui/PHUIButtonView.php b/src/view/phui/PHUIButtonView.php
index 592de7f9c6..714a827be5 100644
--- a/src/view/phui/PHUIButtonView.php
+++ b/src/view/phui/PHUIButtonView.php
@@ -81,6 +81,10 @@ final class PHUIButtonView extends AphrontTagView {
     return $this;
   }
 
+  /**
+   * Set the HTML tag for the button, e.g. 'button', 'input', 'a'.
+   * @param string $tag
+   */
   public function setTag($tag) {
     $this->tag = $tag;
     return $this;
@@ -147,6 +151,10 @@ final class PHUIButtonView extends AphrontTagView {
     return $this;
   }
 
+  /**
+   * Get the HTML tag set for the button, e.g. 'button', 'input', 'a'.
+   * @return string
+   */
   protected function getTagName() {
     return $this->tag;
   }
diff --git a/src/view/phui/PHUIHeaderView.php b/src/view/phui/PHUIHeaderView.php
index 8db2f75ef9..e0b909d5ed 100644
--- a/src/view/phui/PHUIHeaderView.php
+++ b/src/view/phui/PHUIHeaderView.php
@@ -168,6 +168,10 @@ final class PHUIHeaderView extends AphrontTagView {
     return $this->href;
   }
 
+  /**
+   * Get the HTML tag
+   * @return string
+   */
   protected function getTagName() {
     if ($this->collapsible) {
       return 'summary';
-- 
2.51.2