From 833b8a78d89f807ecd50794d012641be43cf96c3 Mon Sep 17 00:00:00 2001 From: epriestley Date: Tue, 18 Mar 2014 16:01:21 -0700 Subject: [PATCH] Reload subscribers before sending mail, etc Summary: Fixes T4629. CCs added by Herald don't get added to the cached subscriber list. Just reload subscribers before sending mail to pick up effects. Test Plan: Created an "always add X as CC" Herald rule for revisions, created a revision, saw them get initial mail. Reviewers: btrahan Reviewed By: btrahan Subscribers: spicyj, epriestley Maniphest Tasks: T4629 Differential Revision: https://secure.phabricator.com/D8565 --- .../editor/PhabricatorApplicationTransactionEditor.php | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php index 63585c5364..6f9279fec8 100644 --- a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php +++ b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php @@ -695,6 +695,11 @@ abstract class PhabricatorApplicationTransactionEditor } } + // Before sending mail or publishing feed stories, reload the object + // subscribers to pick up changes caused by Herald (or by other side effects + // in various transaction phases). + $this->loadSubscribers($object); + $this->loadHandles($xactions); $mail = null; -- 2.51.2