From 7afe31b888cc5a8b995eef0c34b29680da9b0d1b Mon Sep 17 00:00:00 2001 From: Andre Klapper Date: Tue, 12 Aug 2025 22:01:08 +0200 Subject: [PATCH] Personal Flags: Require login for its UI Summary: Flags are personal bookmarks. They are not exposed to any other users. That means you have to be logged in to see, store, or edit flags. Closess T16210 Test Plan: * Set "Can Use Application" to "Public" on http://phorge.localhost/applications/view/PhabricatorFlagsApplication/ * While being logged out, ** go to http://phorge.localhost/flag/ ** go to http://phorge.localhost/flag/query/advanced/ ** go to http://phorge.localhost/flag/query/all/ ** set "Can Use Application" to "Public" on https://phabricator.wikimedia.org/applications/view/PhabricatorManiphestApplication/, go to http://phorge.localhost/T1 (and set the View Policy of `T1` also to Public), click "Flag For Later" in the sidebar (no change, still getting a Login dialog) * Go to Maniphest Advanced Search and search for a task which has a flag set by some user Do the same while being logged in: All still works. Reviewers: O1 Blessed Committers, mainframe98, valerio.bozzolan Reviewed By: O1 Blessed Committers, mainframe98, valerio.bozzolan Subscribers: mainframe98, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Maniphest Tasks: T16210 Differential Revision: https://we.phorge.it/D26259 --- .../flag/controller/PhabricatorFlagListController.php | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/applications/flag/controller/PhabricatorFlagListController.php b/src/applications/flag/controller/PhabricatorFlagListController.php index 88a6bcf7e0..1f0e584fb4 100644 --- a/src/applications/flag/controller/PhabricatorFlagListController.php +++ b/src/applications/flag/controller/PhabricatorFlagListController.php @@ -2,10 +2,6 @@ final class PhabricatorFlagListController extends PhabricatorFlagController { - public function shouldAllowPublic() { - return true; - } - public function handleRequest(AphrontRequest $request) { $viewer = $request->getViewer(); $querykey = $request->getURIData('queryKey'); -- 2.51.2