From 7a9be1a370a3daa932776201640c37eacfc80c06 Mon Sep 17 00:00:00 2001
From: Andre Klapper <a9016009@gmx.de>
Date: Sun, 6 Jul 2025 20:20:35 +0200
Subject: [PATCH] CSS: Fix vertical position of page footer

Summary:
rPd3cbfd95 introduced a regression on some pages when a page footer is configured via `/config/edit/ui.footer-items/`: The footer is not displayed at the bottom.

Closes T16147

Test Plan:
* Configure a page footer via `/config/edit/ui.footer-items/`
* Visit a lot of pages (incl https://we.phorge.it/uiexample/view/PHUIFeedStoryExample/ on which I found this problem) and scroll down (and be aware that some pages like project workboards do not display a footer anyway).

Reviewers: O1 Blessed Committers, amybones, mainframe98

Reviewed By: O1 Blessed Committers, amybones, mainframe98

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T16147

Differential Revision: https://we.phorge.it/D26133
---
 resources/celerity/map.php                    | 6 +++---
 webroot/rsrc/css/phui/phui-basic-nav-view.css | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
index 481def284b..7bed125252 100644
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -9,7 +9,7 @@ return array(
   'names' => array(
     'conpherence.pkg.css' => '384ce2d9',
     'conpherence.pkg.js' => '020aebcf',
-    'core.pkg.css' => 'bbec6c7d',
+    'core.pkg.css' => '16941b93',
     'core.pkg.js' => '83580d78',
     'dark-console.pkg.js' => '187792c2',
     'differential.pkg.css' => 'a0c57051',
@@ -132,7 +132,7 @@ return array(
     'rsrc/css/phui/phui-action-list.css' => 'b46ef6bd',
     'rsrc/css/phui/phui-action-panel.css' => 'c0db6855',
     'rsrc/css/phui/phui-badge.css' => 'aa49028c',
-    'rsrc/css/phui/phui-basic-nav-view.css' => '44e1edaf',
+    'rsrc/css/phui/phui-basic-nav-view.css' => 'a2841568',
     'rsrc/css/phui/phui-big-info-view.css' => '362ad37b',
     'rsrc/css/phui/phui-box.css' => '5ed3b8cb',
     'rsrc/css/phui/phui-bulk-editor.css' => '374d5e30',
@@ -784,7 +784,7 @@ return array(
     'phriction-document-css' => 'd8f8cdd6',
     'phui-action-panel-css' => 'c0db6855',
     'phui-badge-view-css' => 'aa49028c',
-    'phui-basic-nav-view-css' => '44e1edaf',
+    'phui-basic-nav-view-css' => 'a2841568',
     'phui-big-info-view-css' => '362ad37b',
     'phui-box-css' => '5ed3b8cb',
     'phui-bulk-editor-css' => '374d5e30',
diff --git a/webroot/rsrc/css/phui/phui-basic-nav-view.css b/webroot/rsrc/css/phui/phui-basic-nav-view.css
index f9bfe410a3..82ed777864 100644
--- a/webroot/rsrc/css/phui/phui-basic-nav-view.css
+++ b/webroot/rsrc/css/phui/phui-basic-nav-view.css
@@ -5,7 +5,7 @@
 .device-desktop .phui-navigation-shell,
 .phabricator-home.device .phui-navigation-shell {
   width: 100%;
-  height: calc(100vh - {$menu.main.height});
+  min-height: calc(100vh - {$menu.main.height});
 }
 
 .device-desktop .phui-navigation-shell .phabricator-nav,
-- 
2.51.2