From 799ecdc27886119cef36c9e8110a8d1a33db6f1b Mon Sep 17 00:00:00 2001 From: Josh Cox Date: Thu, 15 Sep 2016 20:45:36 -0400 Subject: [PATCH] Update RedirectController for handleRequest Summary: Ref T8628. Test Plan: Performed an action that uses the redirect controller (trying to visit a repo page while not logged in). Logged in and was redirected as expected Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, yelirekim Maniphest Tasks: T8628 Differential Revision: https://secure.phabricator.com/D16571 --- .../controller/PhabricatorRedirectController.php | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/src/applications/base/controller/PhabricatorRedirectController.php b/src/applications/base/controller/PhabricatorRedirectController.php index d12c728e1c..491382e192 100644 --- a/src/applications/base/controller/PhabricatorRedirectController.php +++ b/src/applications/base/controller/PhabricatorRedirectController.php @@ -2,9 +2,6 @@ final class PhabricatorRedirectController extends PhabricatorController { - private $uri; - private $allowExternal; - public function shouldRequireLogin() { return false; } @@ -13,15 +10,12 @@ final class PhabricatorRedirectController extends PhabricatorController { return false; } - public function willProcessRequest(array $data) { - $this->uri = $data['uri']; - $this->allowExternal = idx($data, 'external', false); - } - - public function processRequest() { + public function handleRequest(AphrontRequest $request) { + $uri = $request->getURIData('uri'); + $external = $request->getURIData('external', false); return id(new AphrontRedirectResponse()) - ->setURI($this->uri) - ->setIsExternal($this->allowExternal); + ->setURI($uri) + ->setIsExternal($external); } } -- 2.51.2