diff --git a/src/aphront/site/PhabricatorShortSite.php b/src/aphront/site/PhabricatorShortSite.php index 01151f49c1..17f05c9c01 100644 --- a/src/aphront/site/PhabricatorShortSite.php +++ b/src/aphront/site/PhabricatorShortSite.php @@ -19,7 +19,7 @@ final class PhabricatorShortSite extends PhabricatorSite { } $phurl_installed = PhabricatorApplication::isClassInstalled( - 'PhabricatorPhurlApplication'); + PhabricatorPhurlApplication::class); if (!$phurl_installed) { return false; } diff --git a/src/applications/audit/mail/PhabricatorAuditMailReceiver.php b/src/applications/audit/mail/PhabricatorAuditMailReceiver.php index 9b55151747..2a42ca6514 100644 --- a/src/applications/audit/mail/PhabricatorAuditMailReceiver.php +++ b/src/applications/audit/mail/PhabricatorAuditMailReceiver.php @@ -4,7 +4,7 @@ final class PhabricatorAuditMailReceiver extends PhabricatorObjectMailReceiver { public function isEnabled() { return PhabricatorApplication::isClassInstalled( - 'PhabricatorDiffusionApplication'); + PhabricatorDiffusionApplication::class); } protected function getObjectPattern() { diff --git a/src/applications/audit/query/PhabricatorCommitSearchEngine.php b/src/applications/audit/query/PhabricatorCommitSearchEngine.php index 40d7d52aea..b2caeacf68 100644 --- a/src/applications/audit/query/PhabricatorCommitSearchEngine.php +++ b/src/applications/audit/query/PhabricatorCommitSearchEngine.php @@ -72,7 +72,7 @@ final class PhabricatorCommitSearchEngine protected function buildCustomSearchFields() { $show_audit_fields = (id(new PhabricatorAuditApplication())->isInstalled()); $show_packages = PhabricatorApplication::isClassInstalled( - 'PhabricatorPackagesApplication'); + PhabricatorPackagesApplication::class); return array( id(new PhabricatorSearchDatasourceField()) ->setLabel(pht('Responsible Users')) diff --git a/src/applications/badges/mail/PhabricatorBadgesMailReceiver.php b/src/applications/badges/mail/PhabricatorBadgesMailReceiver.php index 4e72c8422d..a50025f44c 100644 --- a/src/applications/badges/mail/PhabricatorBadgesMailReceiver.php +++ b/src/applications/badges/mail/PhabricatorBadgesMailReceiver.php @@ -5,7 +5,7 @@ final class PhabricatorBadgesMailReceiver public function isEnabled() { return PhabricatorApplication::isClassInstalled( - 'PhabricatorBadgesApplication'); + PhabricatorBadgesApplication::class); } protected function getObjectPattern() { diff --git a/src/applications/calendar/mail/PhabricatorCalendarEventMailReceiver.php b/src/applications/calendar/mail/PhabricatorCalendarEventMailReceiver.php index 01a0367234..084918b717 100644 --- a/src/applications/calendar/mail/PhabricatorCalendarEventMailReceiver.php +++ b/src/applications/calendar/mail/PhabricatorCalendarEventMailReceiver.php @@ -4,8 +4,8 @@ final class PhabricatorCalendarEventMailReceiver extends PhabricatorObjectMailReceiver { public function isEnabled() { - $app_class = 'PhabricatorCalendarApplication'; - return PhabricatorApplication::isClassInstalled($app_class); + return PhabricatorApplication::isClassInstalled( + PhabricatorCalendarApplication::class); } protected function getObjectPattern() { diff --git a/src/applications/calendar/notifications/PhabricatorCalendarNotificationEngine.php b/src/applications/calendar/notifications/PhabricatorCalendarNotificationEngine.php index cf7fc30554..58f7ac4a24 100644 --- a/src/applications/calendar/notifications/PhabricatorCalendarNotificationEngine.php +++ b/src/applications/calendar/notifications/PhabricatorCalendarNotificationEngine.php @@ -41,7 +41,7 @@ final class PhabricatorCalendarNotificationEngine return; } - $calendar_class = 'PhabricatorCalendarApplication'; + $calendar_class = PhabricatorCalendarApplication::class; if (!PhabricatorApplication::isClassInstalled($calendar_class)) { return; } diff --git a/src/applications/conduit/method/ConduitGetCapabilitiesConduitAPIMethod.php b/src/applications/conduit/method/ConduitGetCapabilitiesConduitAPIMethod.php index 2f549dbd73..42619d8a9c 100644 --- a/src/applications/conduit/method/ConduitGetCapabilitiesConduitAPIMethod.php +++ b/src/applications/conduit/method/ConduitGetCapabilitiesConduitAPIMethod.php @@ -36,8 +36,8 @@ final class ConduitGetCapabilitiesConduitAPIMethod extends ConduitAPIMethod { 'sessionless', ); - $oauth_app = PhabricatorOAuthServerApplication::class; - if (PhabricatorApplication::isClassInstalled($oauth_app)) { + $oauth_class = PhabricatorOAuthServerApplication::class; + if (PhabricatorApplication::isClassInstalled($oauth_class)) { $authentication[] = 'oauth'; } diff --git a/src/applications/conpherence/mail/ConpherenceThreadMailReceiver.php b/src/applications/conpherence/mail/ConpherenceThreadMailReceiver.php index aeb4e28997..d87c037c26 100644 --- a/src/applications/conpherence/mail/ConpherenceThreadMailReceiver.php +++ b/src/applications/conpherence/mail/ConpherenceThreadMailReceiver.php @@ -4,8 +4,8 @@ final class ConpherenceThreadMailReceiver extends PhabricatorObjectMailReceiver { public function isEnabled() { - $app_class = 'PhabricatorConpherenceApplication'; - return PhabricatorApplication::isClassInstalled($app_class); + return PhabricatorApplication::isClassInstalled( + PhabricatorConpherenceApplication::class); } protected function getObjectPattern() { diff --git a/src/applications/countdown/mail/PhabricatorCountdownMailReceiver.php b/src/applications/countdown/mail/PhabricatorCountdownMailReceiver.php index 9b448ef10f..7157a8aa54 100644 --- a/src/applications/countdown/mail/PhabricatorCountdownMailReceiver.php +++ b/src/applications/countdown/mail/PhabricatorCountdownMailReceiver.php @@ -5,7 +5,7 @@ final class PhabricatorCountdownMailReceiver public function isEnabled() { return PhabricatorApplication::isClassInstalled( - 'PhabricatorCountdownApplication'); + PhabricatorCountdownApplication::class); } protected function getObjectPattern() { diff --git a/src/applications/differential/customfield/DifferentialRequiredSignaturesField.php b/src/applications/differential/customfield/DifferentialRequiredSignaturesField.php index 421c129fdb..a2aebc2746 100644 --- a/src/applications/differential/customfield/DifferentialRequiredSignaturesField.php +++ b/src/applications/differential/customfield/DifferentialRequiredSignaturesField.php @@ -24,8 +24,8 @@ final class DifferentialRequiredSignaturesField } public static function loadForRevision($revision) { - $app_legalpad = 'PhabricatorLegalpadApplication'; - if (!PhabricatorApplication::isClassInstalled($app_legalpad)) { + $legalpad_class = PhabricatorLegalpadApplication::class; + if (!PhabricatorApplication::isClassInstalled($legalpad_class)) { return array(); } diff --git a/src/applications/differential/editor/DifferentialTransactionEditor.php b/src/applications/differential/editor/DifferentialTransactionEditor.php index cd5245bfa6..0e19737ee0 100644 --- a/src/applications/differential/editor/DifferentialTransactionEditor.php +++ b/src/applications/differential/editor/DifferentialTransactionEditor.php @@ -211,8 +211,8 @@ final class DifferentialTransactionEditor // "T123" or similar, automatically associate the commit with the // task that the branch names. - $maniphest = 'PhabricatorManiphestApplication'; - if (PhabricatorApplication::isClassInstalled($maniphest)) { + $maniphest_class = PhabricatorManiphestApplication::class; + if (PhabricatorApplication::isClassInstalled($maniphest_class)) { $diff = $this->requireDiff($xaction->getNewValue()); $branch = $diff->getBranch(); diff --git a/src/applications/differential/engineextension/DifferentialHovercardEngineExtension.php b/src/applications/differential/engineextension/DifferentialHovercardEngineExtension.php index 3b92c2b4dd..f4b1664579 100644 --- a/src/applications/differential/engineextension/DifferentialHovercardEngineExtension.php +++ b/src/applications/differential/engineextension/DifferentialHovercardEngineExtension.php @@ -7,7 +7,7 @@ final class DifferentialHovercardEngineExtension public function isExtensionEnabled() { return PhabricatorApplication::isClassInstalled( - 'PhabricatorDifferentialApplication'); + PhabricatorDifferentialApplication::class); } public function getExtensionName() { diff --git a/src/applications/differential/mail/DifferentialRevisionMailReceiver.php b/src/applications/differential/mail/DifferentialRevisionMailReceiver.php index 0fe8583a1d..1dc5902542 100644 --- a/src/applications/differential/mail/DifferentialRevisionMailReceiver.php +++ b/src/applications/differential/mail/DifferentialRevisionMailReceiver.php @@ -5,7 +5,7 @@ final class DifferentialRevisionMailReceiver public function isEnabled() { return PhabricatorApplication::isClassInstalled( - 'PhabricatorDifferentialApplication'); + PhabricatorDifferentialApplication::class); } protected function getObjectPattern() { diff --git a/src/applications/diffusion/engineextension/DiffusionHovercardEngineExtension.php b/src/applications/diffusion/engineextension/DiffusionHovercardEngineExtension.php index 91e09b9ba2..f0179cc9b3 100644 --- a/src/applications/diffusion/engineextension/DiffusionHovercardEngineExtension.php +++ b/src/applications/diffusion/engineextension/DiffusionHovercardEngineExtension.php @@ -7,7 +7,7 @@ final class DiffusionHovercardEngineExtension public function isExtensionEnabled() { return PhabricatorApplication::isClassInstalled( - 'PhabricatorDiffusionApplication'); + PhabricatorDiffusionApplication::class); } public function getExtensionName() { diff --git a/src/applications/drydock/blueprint/DrydockAlmanacServiceHostBlueprintImplementation.php b/src/applications/drydock/blueprint/DrydockAlmanacServiceHostBlueprintImplementation.php index 95c4229c96..3bc95ff5f3 100644 --- a/src/applications/drydock/blueprint/DrydockAlmanacServiceHostBlueprintImplementation.php +++ b/src/applications/drydock/blueprint/DrydockAlmanacServiceHostBlueprintImplementation.php @@ -7,8 +7,8 @@ final class DrydockAlmanacServiceHostBlueprintImplementation private $freeBindings; public function isEnabled() { - $almanac_app = PhabricatorAlmanacApplication::class; - return PhabricatorApplication::isClassInstalled($almanac_app); + return PhabricatorApplication::isClassInstalled( + PhabricatorAlmanacApplication::class); } public function getBlueprintName() { diff --git a/src/applications/files/mail/FileMailReceiver.php b/src/applications/files/mail/FileMailReceiver.php index f4074d9ba0..22935b5f4e 100644 --- a/src/applications/files/mail/FileMailReceiver.php +++ b/src/applications/files/mail/FileMailReceiver.php @@ -4,7 +4,7 @@ final class FileMailReceiver extends PhabricatorObjectMailReceiver { public function isEnabled() { return PhabricatorApplication::isClassInstalled( - 'PhabricatorFilesApplication'); + PhabricatorFilesApplication::class); } protected function getObjectPattern() { diff --git a/src/applications/harbormaster/stepgroup/HarbormasterDrydockBuildStepGroup.php b/src/applications/harbormaster/stepgroup/HarbormasterDrydockBuildStepGroup.php index 606a47a114..2912fc1dba 100644 --- a/src/applications/harbormaster/stepgroup/HarbormasterDrydockBuildStepGroup.php +++ b/src/applications/harbormaster/stepgroup/HarbormasterDrydockBuildStepGroup.php @@ -14,7 +14,7 @@ final class HarbormasterDrydockBuildStepGroup } public function isEnabled() { - $drydock_class = 'PhabricatorDrydockApplication'; + $drydock_class = PhabricatorDrydockApplication::class; return PhabricatorApplication::isClassInstalled($drydock_class); } diff --git a/src/applications/legalpad/mail/LegalpadMailReceiver.php b/src/applications/legalpad/mail/LegalpadMailReceiver.php index 679812e4ad..0e0d729402 100644 --- a/src/applications/legalpad/mail/LegalpadMailReceiver.php +++ b/src/applications/legalpad/mail/LegalpadMailReceiver.php @@ -4,7 +4,7 @@ final class LegalpadMailReceiver extends PhabricatorObjectMailReceiver { public function isEnabled() { return PhabricatorApplication::isClassInstalled( - 'PhabricatorLegalpadApplication'); + PhabricatorLegalpadApplication::class); } protected function getObjectPattern() { diff --git a/src/applications/macro/mail/PhabricatorMacroMailReceiver.php b/src/applications/macro/mail/PhabricatorMacroMailReceiver.php index 222524a377..cb4349a590 100644 --- a/src/applications/macro/mail/PhabricatorMacroMailReceiver.php +++ b/src/applications/macro/mail/PhabricatorMacroMailReceiver.php @@ -4,7 +4,7 @@ final class PhabricatorMacroMailReceiver extends PhabricatorObjectMailReceiver { public function isEnabled() { return PhabricatorApplication::isClassInstalled( - 'PhabricatorManiphestApplication'); + PhabricatorManiphestApplication::class); } protected function getObjectPattern() { diff --git a/src/applications/maniphest/engineextension/ManiphestHovercardEngineExtension.php b/src/applications/maniphest/engineextension/ManiphestHovercardEngineExtension.php index 7474f9cfaf..070030bdba 100644 --- a/src/applications/maniphest/engineextension/ManiphestHovercardEngineExtension.php +++ b/src/applications/maniphest/engineextension/ManiphestHovercardEngineExtension.php @@ -7,7 +7,7 @@ final class ManiphestHovercardEngineExtension public function isExtensionEnabled() { return PhabricatorApplication::isClassInstalled( - 'PhabricatorManiphestApplication'); + PhabricatorManiphestApplication::class); } public function getExtensionName() { diff --git a/src/applications/maniphest/mail/ManiphestTaskMailReceiver.php b/src/applications/maniphest/mail/ManiphestTaskMailReceiver.php index 54ac72fd57..37eeaee62d 100644 --- a/src/applications/maniphest/mail/ManiphestTaskMailReceiver.php +++ b/src/applications/maniphest/mail/ManiphestTaskMailReceiver.php @@ -4,7 +4,7 @@ final class ManiphestTaskMailReceiver extends PhabricatorObjectMailReceiver { public function isEnabled() { return PhabricatorApplication::isClassInstalled( - 'PhabricatorManiphestApplication'); + PhabricatorManiphestApplication::class); } protected function getObjectPattern() { diff --git a/src/applications/oauthserver/panel/PhabricatorOAuthServerAuthorizationsSettingsPanel.php b/src/applications/oauthserver/panel/PhabricatorOAuthServerAuthorizationsSettingsPanel.php index 8f74460ec7..a43dfa3d69 100644 --- a/src/applications/oauthserver/panel/PhabricatorOAuthServerAuthorizationsSettingsPanel.php +++ b/src/applications/oauthserver/panel/PhabricatorOAuthServerAuthorizationsSettingsPanel.php @@ -21,7 +21,7 @@ final class PhabricatorOAuthServerAuthorizationsSettingsPanel public function isEnabled() { return PhabricatorApplication::isClassInstalled( - 'PhabricatorOAuthServerApplication'); + PhabricatorOAuthServerApplication::class); } public function processRequest(AphrontRequest $request) { diff --git a/src/applications/owners/engineextension/PhabricatorOwnersHovercardEngineExtension.php b/src/applications/owners/engineextension/PhabricatorOwnersHovercardEngineExtension.php index 39fe30ad28..0b8bb95397 100644 --- a/src/applications/owners/engineextension/PhabricatorOwnersHovercardEngineExtension.php +++ b/src/applications/owners/engineextension/PhabricatorOwnersHovercardEngineExtension.php @@ -7,7 +7,7 @@ final class PhabricatorOwnersHovercardEngineExtension public function isExtensionEnabled() { return PhabricatorApplication::isClassInstalled( - 'PhabricatorOwnersApplication'); + PhabricatorOwnersApplication::class); } public function getExtensionName() { diff --git a/src/applications/paste/mail/PasteMailReceiver.php b/src/applications/paste/mail/PasteMailReceiver.php index f0b2f4674c..f4c547f533 100644 --- a/src/applications/paste/mail/PasteMailReceiver.php +++ b/src/applications/paste/mail/PasteMailReceiver.php @@ -3,8 +3,8 @@ final class PasteMailReceiver extends PhabricatorObjectMailReceiver { public function isEnabled() { - $app_class = 'PhabricatorPasteApplication'; - return PhabricatorApplication::isClassInstalled($app_class); + return PhabricatorApplication::isClassInstalled( + PhabricatorPasteApplication::class); } protected function getObjectPattern() { diff --git a/src/applications/people/customfield/PhabricatorUserStatusField.php b/src/applications/people/customfield/PhabricatorUserStatusField.php index 1716e8e198..fb0b3d0cb0 100644 --- a/src/applications/people/customfield/PhabricatorUserStatusField.php +++ b/src/applications/people/customfield/PhabricatorUserStatusField.php @@ -23,7 +23,7 @@ final class PhabricatorUserStatusField public function isFieldEnabled() { return PhabricatorApplication::isClassInstalled( - 'PhabricatorCalendarApplication'); + PhabricatorCalendarApplication::class); } public function renderPropertyViewValue(array $handles) { diff --git a/src/applications/phame/mail/PhamePostMailReceiver.php b/src/applications/phame/mail/PhamePostMailReceiver.php index 3e2f493d3a..2a5988d469 100644 --- a/src/applications/phame/mail/PhamePostMailReceiver.php +++ b/src/applications/phame/mail/PhamePostMailReceiver.php @@ -5,7 +5,7 @@ final class PhamePostMailReceiver public function isEnabled() { return PhabricatorApplication::isClassInstalled( - 'PhabricatorPhameApplication'); + PhabricatorPhameApplication::class); } protected function getObjectPattern() { diff --git a/src/applications/phame/site/PhameSite.php b/src/applications/phame/site/PhameSite.php index 57ac543f30..844f3ac2b3 100644 --- a/src/applications/phame/site/PhameSite.php +++ b/src/applications/phame/site/PhameSite.php @@ -10,7 +10,7 @@ abstract class PhameSite extends PhabricatorSite { } $phame_installed = PhabricatorApplication::isClassInstalled( - 'PhabricatorPhameApplication'); + PhabricatorPhameApplication::class); if (!$phame_installed) { // Don't activate Phame if the the application is uninstalled. return false; diff --git a/src/applications/pholio/mail/PholioMockMailReceiver.php b/src/applications/pholio/mail/PholioMockMailReceiver.php index 13fdc559ec..0a33a30e04 100644 --- a/src/applications/pholio/mail/PholioMockMailReceiver.php +++ b/src/applications/pholio/mail/PholioMockMailReceiver.php @@ -3,8 +3,8 @@ final class PholioMockMailReceiver extends PhabricatorObjectMailReceiver { public function isEnabled() { - $app_class = 'PhabricatorPholioApplication'; - return PhabricatorApplication::isClassInstalled($app_class); + return PhabricatorApplication::isClassInstalled( + PhabricatorPholioApplication::class); } protected function getObjectPattern() { diff --git a/src/applications/phriction/controller/PhrictionController.php b/src/applications/phriction/controller/PhrictionController.php index 06f0102526..c159723a64 100644 --- a/src/applications/phriction/controller/PhrictionController.php +++ b/src/applications/phriction/controller/PhrictionController.php @@ -37,7 +37,7 @@ abstract class PhrictionController extends PhabricatorController { protected function buildApplicationCrumbs() { $crumbs = parent::buildApplicationCrumbs(); - if (get_class($this) != 'PhrictionListController') { + if (get_class($this) != PhrictionListController::class) { $crumbs->addAction( id(new PHUIListItemView()) ->setName(pht('Index')) diff --git a/src/applications/phriction/engineextension/PhrictionHovercardEngineExtension.php b/src/applications/phriction/engineextension/PhrictionHovercardEngineExtension.php index 14e63b9521..7129eb0d3f 100644 --- a/src/applications/phriction/engineextension/PhrictionHovercardEngineExtension.php +++ b/src/applications/phriction/engineextension/PhrictionHovercardEngineExtension.php @@ -7,7 +7,7 @@ final class PhrictionHovercardEngineExtension public function isExtensionEnabled() { return PhabricatorApplication::isClassInstalled( - 'PhabricatorPhrictionApplication'); + PhabricatorPhrictionApplication::class); } public function getExtensionName() { diff --git a/src/applications/phurl/mail/PhabricatorPhurlURLMailReceiver.php b/src/applications/phurl/mail/PhabricatorPhurlURLMailReceiver.php index 14a953bc31..4d4a9b3aa4 100644 --- a/src/applications/phurl/mail/PhabricatorPhurlURLMailReceiver.php +++ b/src/applications/phurl/mail/PhabricatorPhurlURLMailReceiver.php @@ -5,7 +5,7 @@ final class PhabricatorPhurlURLMailReceiver public function isEnabled() { return PhabricatorApplication::isClassInstalled( - 'PhabricatorPhurlApplication'); + PhabricatorPhurlApplication::class); } protected function getObjectPattern() { diff --git a/src/applications/ponder/mail/PonderAnswerMailReceiver.php b/src/applications/ponder/mail/PonderAnswerMailReceiver.php index dfa252c4a1..34ffc8dd6b 100644 --- a/src/applications/ponder/mail/PonderAnswerMailReceiver.php +++ b/src/applications/ponder/mail/PonderAnswerMailReceiver.php @@ -3,8 +3,8 @@ final class PonderAnswerMailReceiver extends PhabricatorObjectMailReceiver { public function isEnabled() { - $app_class = 'PhabricatorPonderApplication'; - return PhabricatorApplication::isClassInstalled($app_class); + return PhabricatorApplication::isClassInstalled( + PhabricatorPonderApplication::class); } protected function getObjectPattern() { diff --git a/src/applications/ponder/mail/PonderQuestionMailReceiver.php b/src/applications/ponder/mail/PonderQuestionMailReceiver.php index e68d6c0ecb..ec95f1fdbd 100644 --- a/src/applications/ponder/mail/PonderQuestionMailReceiver.php +++ b/src/applications/ponder/mail/PonderQuestionMailReceiver.php @@ -3,8 +3,8 @@ final class PonderQuestionMailReceiver extends PhabricatorObjectMailReceiver { public function isEnabled() { - $app_class = 'PhabricatorPonderApplication'; - return PhabricatorApplication::isClassInstalled($app_class); + return PhabricatorApplication::isClassInstalled( + PhabricatorPonderApplication::class); } protected function getObjectPattern() { diff --git a/src/applications/project/engineextension/PhabricatorProjectsEditEngineExtension.php b/src/applications/project/engineextension/PhabricatorProjectsEditEngineExtension.php index a388a39a97..909d5532f5 100644 --- a/src/applications/project/engineextension/PhabricatorProjectsEditEngineExtension.php +++ b/src/applications/project/engineextension/PhabricatorProjectsEditEngineExtension.php @@ -15,7 +15,7 @@ final class PhabricatorProjectsEditEngineExtension public function isExtensionEnabled() { return PhabricatorApplication::isClassInstalled( - 'PhabricatorProjectApplication'); + PhabricatorProjectApplication::class); } public function getExtensionName() { diff --git a/src/applications/project/engineextension/PhabricatorProjectsSearchEngineExtension.php b/src/applications/project/engineextension/PhabricatorProjectsSearchEngineExtension.php index 031dad7577..79c34d6532 100644 --- a/src/applications/project/engineextension/PhabricatorProjectsSearchEngineExtension.php +++ b/src/applications/project/engineextension/PhabricatorProjectsSearchEngineExtension.php @@ -7,7 +7,7 @@ final class PhabricatorProjectsSearchEngineExtension public function isExtensionEnabled() { return PhabricatorApplication::isClassInstalled( - 'PhabricatorProjectApplication'); + PhabricatorProjectApplication::class); } public function getExtensionName() { diff --git a/src/applications/repository/worker/PhabricatorRepositoryCommitPublishWorker.php b/src/applications/repository/worker/PhabricatorRepositoryCommitPublishWorker.php index 9d70e3db1c..4bebf294bd 100644 --- a/src/applications/repository/worker/PhabricatorRepositoryCommitPublishWorker.php +++ b/src/applications/repository/worker/PhabricatorRepositoryCommitPublishWorker.php @@ -428,8 +428,8 @@ final class PhabricatorRepositoryCommitPublishWorker PhabricatorUser $actor, PhabricatorRepositoryCommit $commit) { - $differential = 'PhabricatorDifferentialApplication'; - if (!PhabricatorApplication::isClassInstalled($differential)) { + $differential_class = PhabricatorDifferentialApplication::class; + if (!PhabricatorApplication::isClassInstalled($differential_class)) { return; } diff --git a/src/applications/search/controller/PhabricatorSearchDefaultController.php b/src/applications/search/controller/PhabricatorSearchDefaultController.php index a4f68e503a..61fa3105bc 100644 --- a/src/applications/search/controller/PhabricatorSearchDefaultController.php +++ b/src/applications/search/controller/PhabricatorSearchDefaultController.php @@ -7,7 +7,7 @@ final class PhabricatorSearchDefaultController $viewer = $this->getViewer(); $engine_class = $request->getURIData('engine'); - $base_class = 'PhabricatorApplicationSearchEngine'; + $base_class = PhabricatorApplicationSearchEngine::class; if (!is_subclass_of($engine_class, $base_class)) { return new Aphront400Response(); } diff --git a/src/applications/settings/panel/PhabricatorNotificationsSettingsPanel.php b/src/applications/settings/panel/PhabricatorNotificationsSettingsPanel.php index 96eddcc96d..04d5d7ae84 100644 --- a/src/applications/settings/panel/PhabricatorNotificationsSettingsPanel.php +++ b/src/applications/settings/panel/PhabricatorNotificationsSettingsPanel.php @@ -10,7 +10,7 @@ final class PhabricatorNotificationsSettingsPanel } return PhabricatorApplication::isClassInstalled( - 'PhabricatorNotificationsApplication'); + PhabricatorNotificationsApplication::class); } public function getPanelKey() { diff --git a/src/applications/slowvote/mail/PhabricatorSlowvoteMailReceiver.php b/src/applications/slowvote/mail/PhabricatorSlowvoteMailReceiver.php index 7b7459d4c3..98ad0bdf84 100644 --- a/src/applications/slowvote/mail/PhabricatorSlowvoteMailReceiver.php +++ b/src/applications/slowvote/mail/PhabricatorSlowvoteMailReceiver.php @@ -5,7 +5,7 @@ final class PhabricatorSlowvoteMailReceiver public function isEnabled() { return PhabricatorApplication::isClassInstalled( - 'PhabricatorSlowvoteApplication'); + PhabricatorSlowvoteApplication::class); } protected function getObjectPattern() { diff --git a/src/applications/spaces/engineextension/PhabricatorSpacesSearchEngineExtension.php b/src/applications/spaces/engineextension/PhabricatorSpacesSearchEngineExtension.php index 829b7b2b93..2db473808c 100644 --- a/src/applications/spaces/engineextension/PhabricatorSpacesSearchEngineExtension.php +++ b/src/applications/spaces/engineextension/PhabricatorSpacesSearchEngineExtension.php @@ -7,7 +7,7 @@ final class PhabricatorSpacesSearchEngineExtension public function isExtensionEnabled() { return PhabricatorApplication::isClassInstalled( - 'PhabricatorSpacesApplication'); + PhabricatorSpacesApplication::class); } public function getExtensionName() { diff --git a/src/applications/subscriptions/engineextension/PhabricatorSubscriptionsSearchEngineExtension.php b/src/applications/subscriptions/engineextension/PhabricatorSubscriptionsSearchEngineExtension.php index d1945aadee..5c48c91ea7 100644 --- a/src/applications/subscriptions/engineextension/PhabricatorSubscriptionsSearchEngineExtension.php +++ b/src/applications/subscriptions/engineextension/PhabricatorSubscriptionsSearchEngineExtension.php @@ -7,7 +7,7 @@ final class PhabricatorSubscriptionsSearchEngineExtension public function isExtensionEnabled() { return PhabricatorApplication::isClassInstalled( - 'PhabricatorSubscriptionsApplication'); + PhabricatorSubscriptionsApplication::class); } public function getExtensionName() { diff --git a/src/infrastructure/daemon/workers/PhabricatorTriggerDaemon.php b/src/infrastructure/daemon/workers/PhabricatorTriggerDaemon.php index 4cf6a69048..b6ccfaec31 100644 --- a/src/infrastructure/daemon/workers/PhabricatorTriggerDaemon.php +++ b/src/infrastructure/daemon/workers/PhabricatorTriggerDaemon.php @@ -415,8 +415,8 @@ final class PhabricatorTriggerDaemon private function updateNuanceImportCursors() { - $nuance_app = PhabricatorNuanceApplication::class; - if (!PhabricatorApplication::isClassInstalled($nuance_app)) { + $nuance_class = PhabricatorNuanceApplication::class; + if (!PhabricatorApplication::isClassInstalled($nuance_class)) { return false; }