From 75d8c84c13727804e5a48398fa223e2ef5077276 Mon Sep 17 00:00:00 2001 From: Andre Klapper Date: Sun, 30 Mar 2025 23:05:12 +0200 Subject: [PATCH] PHPDoc: Make some parameter types match type in signatures Summary: For explicitly mentioned Phorge class types in the function signature, use the same type in the PHPDoc for the parameter. Test Plan: Compare classname type in function signature and in PHPDoc; run static code analysis. Reviewers: O1 Blessed Committers, avivey Reviewed By: O1 Blessed Committers, avivey Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Differential Revision: https://we.phorge.it/D25937 --- .../harbormaster/engine/HarbormasterBuildEngine.php | 2 +- .../customfield/field/PhabricatorCustomField.php | 3 ++- src/infrastructure/markup/PhabricatorMarkupInterface.php | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/applications/harbormaster/engine/HarbormasterBuildEngine.php b/src/applications/harbormaster/engine/HarbormasterBuildEngine.php index 266fed3804..8b43f6fa14 100644 --- a/src/applications/harbormaster/engine/HarbormasterBuildEngine.php +++ b/src/applications/harbormaster/engine/HarbormasterBuildEngine.php @@ -437,7 +437,7 @@ final class HarbormasterBuildEngine extends Phobject { * the overall state of the associated buildable. Compute the new aggregate * state and save it on the buildable. * - * @param HarbormasterBuild $buildable The buildable to update. + * @param HarbormasterBuildable $buildable The buildable to update. * @return void */ public function updateBuildable(HarbormasterBuildable $buildable) { diff --git a/src/infrastructure/customfield/field/PhabricatorCustomField.php b/src/infrastructure/customfield/field/PhabricatorCustomField.php index 8ce532e468..436db6ab02 100644 --- a/src/infrastructure/customfield/field/PhabricatorCustomField.php +++ b/src/infrastructure/customfield/field/PhabricatorCustomField.php @@ -1004,7 +1004,8 @@ abstract class PhabricatorCustomField extends Phobject { * when a transaction would set a field to an invalid value, or when a field * is required but no transactions provide value. * - * @param PhabricatorLiskDAO $editor Editor applying the transactions. + * @param PhabricatorApplicationTransactionEditor $editor Editor applying the + * transactions. * @param string $type Transaction type. This type is always * `PhabricatorTransactions::TYPE_CUSTOMFIELD`, it is provided for * convenience when constructing exceptions. diff --git a/src/infrastructure/markup/PhabricatorMarkupInterface.php b/src/infrastructure/markup/PhabricatorMarkupInterface.php index fdc39407b3..71437d3c6c 100644 --- a/src/infrastructure/markup/PhabricatorMarkupInterface.php +++ b/src/infrastructure/markup/PhabricatorMarkupInterface.php @@ -62,7 +62,7 @@ interface PhabricatorMarkupInterface { * * @param string $field Field name. * @param string $output The finalized output of the engine. - * @param string $engine The engine which generated the output. + * @param PhutilMarkupEngine $engine The engine which generated the output. * @return string Final output. * @task markup */ -- 2.51.2