From 755448b456815c5bd0ccfed3f42ead6ee3880ab3 Mon Sep 17 00:00:00 2001
From: Andre Klapper <a9016009@gmx.de>
Date: Mon, 29 Sep 2025 14:44:35 +0200
Subject: [PATCH] Fix Dark Mode for hovering top bar dropdown menu items

Summary:
* Make colors for `hoverselectedgrey` and `hoverselectedblue` in Dark Mode not to use Default Mode colors.
* Replace hardcoded text color for for strike-through links (`a.handle-status-closed`) `#676767` with close-enough variable `{$lightgreytext}`, and in case of hovering such a strike-through link `#19558D` with `{$darkbluetext}`.

Refs T15056

Test Plan:
* Go to http://phorge.localhost/settings/panel/display/ and set `Accessibility` to `Dark Mode (Experimental)`
* Create notifications, have setup issues, etc. Open top bar menu items and hover. Find a strike-through link and hover.
* Probably also check other pages for `a.handle-status-closed` but I'm too lazy for that.

Reviewers: O1 Blessed Committers, mainframe98

Reviewed By: O1 Blessed Committers, mainframe98

Subscribers: mainframe98, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15056

Differential Revision: https://we.phorge.it/D26393
---
 resources/celerity/map.php                                  | 6 +++---
 .../postprocessor/CelerityDarkModePostprocessor.php         | 4 ++--
 webroot/rsrc/css/application/base/standard-page-view.css    | 4 ++--
 3 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
index 24d5a2f9c0..c2df62d55f 100644
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -9,7 +9,7 @@ return array(
   'names' => array(
     'conpherence.pkg.css' => 'beb13d57',
     'conpherence.pkg.js' => '020aebcf',
-    'core.pkg.css' => '95002cb9',
+    'core.pkg.css' => '9fa10710',
     'core.pkg.js' => '83580d78',
     'dark-console.pkg.js' => '187792c2',
     'differential.pkg.css' => '6691591b',
@@ -40,7 +40,7 @@ return array(
     'rsrc/css/application/base/main-menu-view.css' => 'c731af7c',
     'rsrc/css/application/base/notification-menu.css' => '90e445b9',
     'rsrc/css/application/base/phui-theme.css' => '35883b37',
-    'rsrc/css/application/base/standard-page-view.css' => '45aa515d',
+    'rsrc/css/application/base/standard-page-view.css' => '17fb97b1',
     'rsrc/css/application/conduit/conduit-api.css' => 'ce2cfc41',
     'rsrc/css/application/config/config-options.css' => '25d545a9',
     'rsrc/css/application/config/config-template.css' => '20babf50',
@@ -752,7 +752,7 @@ return array(
     'phabricator-shaped-request' => '995f5102',
     'phabricator-slowvote-css' => '0f219c39',
     'phabricator-source-code-view-css' => 'e994d13f',
-    'phabricator-standard-page-view' => '45aa515d',
+    'phabricator-standard-page-view' => '17fb97b1',
     'phabricator-textareautils' => 'f340a484',
     'phabricator-title' => '43bc9360',
     'phabricator-tooltip' => '83754533',
diff --git a/src/applications/celerity/postprocessor/CelerityDarkModePostprocessor.php b/src/applications/celerity/postprocessor/CelerityDarkModePostprocessor.php
index b53566b407..254d757bcc 100644
--- a/src/applications/celerity/postprocessor/CelerityDarkModePostprocessor.php
+++ b/src/applications/celerity/postprocessor/CelerityDarkModePostprocessor.php
@@ -55,8 +55,8 @@ final class CelerityDarkModePostprocessor
       'hovergrey'     => '#c5cbcf',
       'hoverblue'     => '#2a425f',
       'hoverborder'   => '#dfe1e9',
-      'hoverselectedgrey' => '#bbc4ca',
-      'hoverselectedblue' => '#e6e9ee',
+      'hoverselectedgrey' => '#4f5b64',
+      'hoverselectedblue' => '#48546a',
       'borderinset' => 'inset 0 0 0 1px rgba(55,55,55,.15)',
       'timeline'    => '#4e6078',
       'timeline.icon.background' => '#416086',
diff --git a/webroot/rsrc/css/application/base/standard-page-view.css b/webroot/rsrc/css/application/base/standard-page-view.css
index 82278240c8..74d60b06f6 100644
--- a/webroot/rsrc/css/application/base/standard-page-view.css
+++ b/webroot/rsrc/css/application/base/standard-page-view.css
@@ -89,12 +89,12 @@ body.white-background {
 
 a.handle-status-closed {
   text-decoration: line-through;
-  color: #676767;
+  color: {$lightgreytext};
 }
 
 a.handle-status-closed:hover {
   text-decoration: line-through;
-  color: #19558D;
+  color: {$darkbluetext};
 }
 
 .handle-availability-none .perfect-circle {
-- 
2.51.2