From 6e29e809b484dffc466bae7c4dd94054d3d95115 Mon Sep 17 00:00:00 2001 From: epriestley Date: Tue, 24 Sep 2013 11:10:31 -0700 Subject: [PATCH] Fix "edit" for Maniphest comments Summary: Ref T2217. Fixes T3876. We incorrectly have a unique key on `(authorPHID, transactionPHID)`, which prevents saving multiple versions of a comment. I'm not entirely sure why this exists. I think it came from Pholio (where it works for inlines, because it has an additional component, but maybe should be adjusted) but we might need to wipe it out of more apps too. Test Plan: Edited a comment in Maniphest. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2217, T3876 Differential Revision: https://secure.phabricator.com/D7102 --- resources/sql/patches/20130924.mdraftkey.sql | 2 ++ .../storage/patch/PhabricatorBuiltinPatchList.php | 4 ++++ 2 files changed, 6 insertions(+) create mode 100644 resources/sql/patches/20130924.mdraftkey.sql diff --git a/resources/sql/patches/20130924.mdraftkey.sql b/resources/sql/patches/20130924.mdraftkey.sql new file mode 100644 index 0000000000..677b97246d --- /dev/null +++ b/resources/sql/patches/20130924.mdraftkey.sql @@ -0,0 +1,2 @@ +ALTER TABLE {$NAMESPACE}_maniphest.maniphest_transaction_comment + DROP KEY `key_draft`; diff --git a/src/infrastructure/storage/patch/PhabricatorBuiltinPatchList.php b/src/infrastructure/storage/patch/PhabricatorBuiltinPatchList.php index 519d1ea15d..44f48dae0e 100644 --- a/src/infrastructure/storage/patch/PhabricatorBuiltinPatchList.php +++ b/src/infrastructure/storage/patch/PhabricatorBuiltinPatchList.php @@ -1624,6 +1624,10 @@ final class PhabricatorBuiltinPatchList extends PhabricatorSQLPatchList { 'type' => 'sql', 'name' => $this->getPatchPath('20130923.mrename.sql'), ), + '20130924.mdraftkey.sql' => array( + 'type' => 'sql', + 'name' => $this->getPatchPath('20130924.mdraftkey.sql'), + ), ); } } -- 2.51.2