From 63bce19d33c85f6caff6c0881ff19dd510b385b4 Mon Sep 17 00:00:00 2001 From: mainframe98 Date: Sun, 7 Dec 2025 17:27:52 +0100 Subject: [PATCH] Add abstract getRequestExceptionHandlerDescription to AphrontRequestExceptionHandler Summary: PhabricatorConfigRequestExceptionHandlerModule::renderModuleStatus calls this method on all AphrontRequestExceptionHandlers, but implementing the method is not required. This breaks /config/module/exception-handler/ when a custom exception handler does not implement it. Test Plan: Before applying this change: * Create a new RequestExceptionHandler in src/extensions/ and omit getRequestExceptionHandlerDescription * Visit http://phorge.localhost/config/module/exception-handler/ and see an exception After applying this change: * PHP fatal error about missing method * Add getRequestEceptionHandlerDescription * See the description on http://phorge.localhost/config/module/exception-handler/ Reviewers: O1 Blessed Committers, avivey Reviewed By: O1 Blessed Committers, avivey Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Differential Revision: https://we.phorge.it/D26570 --- src/aphront/handler/AphrontRequestExceptionHandler.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/aphront/handler/AphrontRequestExceptionHandler.php b/src/aphront/handler/AphrontRequestExceptionHandler.php index 6f5a23ae05..4df9f19c81 100644 --- a/src/aphront/handler/AphrontRequestExceptionHandler.php +++ b/src/aphront/handler/AphrontRequestExceptionHandler.php @@ -10,6 +10,8 @@ */ abstract class AphrontRequestExceptionHandler extends Phobject { + abstract public function getRequestExceptionHandlerDescription(); + abstract public function getRequestExceptionHandlerPriority(); abstract public function canHandleRequestThrowable( -- 2.51.2