diff --git a/src/infrastructure/storage/connection/mysql/AphrontMySQLiDatabaseConnection.php b/src/infrastructure/storage/connection/mysql/AphrontMySQLiDatabaseConnection.php index c290780882..c9bba8503c 100644 --- a/src/infrastructure/storage/connection/mysql/AphrontMySQLiDatabaseConnection.php +++ b/src/infrastructure/storage/connection/mysql/AphrontMySQLiDatabaseConnection.php @@ -57,11 +57,13 @@ final class AphrontMySQLiDatabaseConnection } } - // See T13588. In PHP 8.1, the default "report mode" for MySQLi has - // changed, which causes MySQLi to raise exceptions. Disable exceptions - // to align behavior with older default behavior under MySQLi, which - // this code expects. Plausibly, this code could be updated to use - // MySQLi exceptions to handle errors under a wider range of PHP versions. + // In PHP 8.1, the default "report mode" for MySQLi has changed, which + // causes MySQLi to raise exceptions. Disable exceptions to align behavior + // with older default behavior under MySQLi, which this code expects. + // https://www.php.net/manual/mysqli-driver.report-mode.php + // https://www.php.net/manual/migration81.incompatible.php#migration81.incompatible.mysqli + // TODO: Plausibly, this code could be updated to use MySQLi exceptions + // to handle errors. See https://we.phorge.it/T16341 mysqli_report(MYSQLI_REPORT_OFF); $conn = mysqli_init();