From 62f5bdbbd2c55e42c85bde52a72784faa07996b6 Mon Sep 17 00:00:00 2001 From: "Arturas Moskvinas arturas@uber.com" Date: Mon, 9 Mar 2020 16:35:40 +0200 Subject: [PATCH] According to Jira Project keys must start with an uppercase letter, followed by one or more uppercase alphanumeric characters Summary: Jira allows creating projects which contain number in names, phabricator will not allow such projects but it should Test Plan: Pasted URL with Jira project which contain number in project name and it was parsed and resolved properly in phabricator Reviewers: epriestley, Pawka, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D21040 --- src/applications/auth/provider/PhabricatorJIRAAuthProvider.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/applications/auth/provider/PhabricatorJIRAAuthProvider.php b/src/applications/auth/provider/PhabricatorJIRAAuthProvider.php index c26c70ce37..8a858f2bea 100644 --- a/src/applications/auth/provider/PhabricatorJIRAAuthProvider.php +++ b/src/applications/auth/provider/PhabricatorJIRAAuthProvider.php @@ -335,7 +335,7 @@ final class PhabricatorJIRAAuthProvider public function getDoorkeeperURIRef(PhutilURI $uri) { $uri_string = phutil_string_cast($uri); - $pattern = '((https?://\S+?)/browse/([A-Z]+-[1-9]\d*))'; + $pattern = '((https?://\S+?)/browse/([A-Z][A-Z0-9]*-[1-9]\d*))'; $matches = null; if (!preg_match($pattern, $uri_string, $matches)) { return null; -- 2.51.2