From 5e05a583b0282588306533ae393f61d772c7a0cb Mon Sep 17 00:00:00 2001 From: Andre Klapper Date: Tue, 17 Feb 2026 19:49:46 +0100 Subject: [PATCH] PHP 8.5: Fix null array key for color in PhabricatorIconRemarkupRule Summary: Setting null as an array key is deprecated since PHP 8.5 per https://www.php.net/releases/8.5/en.php: "Using null as an array offset or when calling array_key_exists() is now deprecated. Use an empty string instead." ``` ERROR 8192: Using null as an array offset is deprecated, use an empty string instead at [/var/www/html/phorge/phorge/src/applications/macro/markup/PhabricatorIconRemarkupRule.php:70] ``` Closes T16446 Test Plan: Unknown Reviewers: O1 Blessed Committers, mainframe98 Reviewed By: O1 Blessed Committers, mainframe98 Subscribers: mainframe98, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Maniphest Tasks: T16446 Differential Revision: https://we.phorge.it/D26764 --- src/applications/macro/markup/PhabricatorIconRemarkupRule.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/applications/macro/markup/PhabricatorIconRemarkupRule.php b/src/applications/macro/markup/PhabricatorIconRemarkupRule.php index e1e6cede07..df22d0f3db 100644 --- a/src/applications/macro/markup/PhabricatorIconRemarkupRule.php +++ b/src/applications/macro/markup/PhabricatorIconRemarkupRule.php @@ -67,7 +67,7 @@ final class PhabricatorIconRemarkupRule extends PhutilRemarkupRule { } $color = $options['color']; - if (empty($color_names[$color])) { + if ($color !== null && empty($color_names[$color])) { $color = null; } -- 2.51.2