From 5bd99a394aed4d12b8a694a0333e96fb6430b066 Mon Sep 17 00:00:00 2001 From: ekubischta Date: Tue, 11 Mar 2025 13:11:39 +0000 Subject: [PATCH] Add instructions to Create Repository form fields for Callsign and Short Name Summary: When I create new repos, I always forget which is which (between Callsign and Short Name) This adds helpful text as a placeholder and as control instructions I am not sure if this layout is 100% better, but this is an option as well **Add new Repository** {F3169761 width=800} **Edit existing Repository** {F3169775 width=800} Closes T15742 Test Plan: Added a new repository and saw these control instructions Reviewers: O1 Blessed Committers, aklapper Reviewed By: O1 Blessed Committers, aklapper Subscribers: aklapper, avivey, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Maniphest Tasks: T15742 Differential Revision: https://we.phorge.it/D25898 --- .../diffusion/editor/DiffusionRepositoryEditEngine.php | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/applications/diffusion/editor/DiffusionRepositoryEditEngine.php b/src/applications/diffusion/editor/DiffusionRepositoryEditEngine.php index c9dbb2b329..84815d9556 100644 --- a/src/applications/diffusion/editor/DiffusionRepositoryEditEngine.php +++ b/src/applications/diffusion/editor/DiffusionRepositoryEditEngine.php @@ -287,6 +287,9 @@ final class DiffusionRepositoryEditEngine id(new PhabricatorTextEditField()) ->setKey('callsign') ->setLabel(pht('Callsign')) + ->setControlInstructions( + pht('Callsign is the monogram rXXXX for this repository. '. + 'It cannot contain spaces.')) ->setTransactionType( PhabricatorRepositoryCallsignTransaction::TRANSACTIONTYPE) ->setDescription(pht('The repository callsign.')) @@ -296,6 +299,9 @@ final class DiffusionRepositoryEditEngine id(new PhabricatorTextEditField()) ->setKey('shortName') ->setLabel(pht('Short Name')) + ->setControlInstructions( + pht('Short Name is part of the URI paths for this repository. '. + 'It cannot contain spaces.')) ->setTransactionType( PhabricatorRepositorySlugTransaction::TRANSACTIONTYPE) ->setDescription(pht('Short, unique repository name.')) -- 2.51.2