From 5a7c875c8c0bf8e344f3128ec6852915301a4868 Mon Sep 17 00:00:00 2001 From: Andre Klapper Date: Fri, 20 Feb 2026 18:57:12 +0100 Subject: [PATCH] Add missing return to PhorgeFlagFlaggedObjectCustomField::setValueFromStorage() Summary: Closes T16512 Test Plan: Run static code analysis; look at other setValueFromStorage() implementations in other `PhabricatorCustomField` subclasses. Reviewers: O1 Blessed Committers, mainframe98 Reviewed By: O1 Blessed Committers, mainframe98 Subscribers: mainframe98, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Maniphest Tasks: T16512 Differential Revision: https://we.phorge.it/D26776 --- .../flag/customfield/PhorgeFlagFlaggedObjectCustomField.php | 1 + 1 file changed, 1 insertion(+) diff --git a/src/applications/flag/customfield/PhorgeFlagFlaggedObjectCustomField.php b/src/applications/flag/customfield/PhorgeFlagFlaggedObjectCustomField.php index 8d2f358efd..f2baf62a9e 100644 --- a/src/applications/flag/customfield/PhorgeFlagFlaggedObjectCustomField.php +++ b/src/applications/flag/customfield/PhorgeFlagFlaggedObjectCustomField.php @@ -31,6 +31,7 @@ final class PhorgeFlagFlaggedObjectCustomField extends PhabricatorCustomField { public function setValueFromStorage($value) { $this->flag = $value; + return $this; } // The parent function is defined to return a PhabricatorCustomFieldStorage, -- 2.51.2