diff --git a/src/applications/calendar/parser/data/PhutilCalendarEventNode.php b/src/applications/calendar/parser/data/PhutilCalendarEventNode.php index 95042539e3..28312a1ab2 100644 --- a/src/applications/calendar/parser/data/PhutilCalendarEventNode.php +++ b/src/applications/calendar/parser/data/PhutilCalendarEventNode.php @@ -116,8 +116,11 @@ final class PhutilCalendarEventNode return $this->organizer; } + /** + * @param array $attendees + */ public function setAttendees(array $attendees) { - assert_instances_of($attendees, 'PhutilCalendarUserNode'); + assert_instances_of($attendees, PhutilCalendarUserNode::class); $this->attendees = $attendees; return $this; } @@ -159,8 +162,11 @@ final class PhutilCalendarEventNode return $this->recurrenceRule; } + /** + * @param array $recurrence_exceptions + */ public function setRecurrenceExceptions(array $recurrence_exceptions) { - assert_instances_of($recurrence_exceptions, 'PhutilCalendarDateTime'); + assert_instances_of($recurrence_exceptions, PhutilCalendarDateTime::class); $this->recurrenceExceptions = $recurrence_exceptions; return $this; } @@ -169,8 +175,11 @@ final class PhutilCalendarEventNode return $this->recurrenceExceptions; } + /** + * @param array $recurrence_dates + */ public function setRecurrenceDates(array $recurrence_dates) { - assert_instances_of($recurrence_dates, 'PhutilCalendarDateTime'); + assert_instances_of($recurrence_dates, PhutilCalendarDateTime::class); $this->recurrenceDates = $recurrence_dates; return $this; } diff --git a/src/applications/calendar/parser/data/PhutilCalendarRecurrenceList.php b/src/applications/calendar/parser/data/PhutilCalendarRecurrenceList.php index 4cbae54ac5..528a646d49 100644 --- a/src/applications/calendar/parser/data/PhutilCalendarRecurrenceList.php +++ b/src/applications/calendar/parser/data/PhutilCalendarRecurrenceList.php @@ -6,8 +6,11 @@ final class PhutilCalendarRecurrenceList private $dates = array(); private $order; + /** + * @param array $dates + */ public function setDates(array $dates) { - assert_instances_of($dates, 'PhutilCalendarDateTime'); + assert_instances_of($dates, PhutilCalendarDateTime::class); $this->dates = $dates; return $this; } diff --git a/src/applications/calendar/parser/ics/PhutilICSWriter.php b/src/applications/calendar/parser/ics/PhutilICSWriter.php index 5cd979973e..0540299a91 100644 --- a/src/applications/calendar/parser/ics/PhutilICSWriter.php +++ b/src/applications/calendar/parser/ics/PhutilICSWriter.php @@ -285,11 +285,16 @@ final class PhutilICSWriter extends Phobject { return $this->newDateTimesProperty($name, array($value), $parameters); } + /** + * @param $name + * @param array $values + * @param array $parameters + */ private function newDateTimesProperty( $name, array $values, array $parameters = array()) { - assert_instances_of($values, 'PhutilCalendarDateTime'); + assert_instances_of($values, PhutilCalendarDateTime::class); if (head($values)->getIsAllDay()) { $parameters[] = array( diff --git a/src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php b/src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php index f39e485ce0..0e3c8b8fd0 100644 --- a/src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php +++ b/src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php @@ -286,11 +286,15 @@ final class PhabricatorCalendarEventSearchEngine return $result; } + /** + * @param array $events + * @param PhabricatorSavedQuery $query + */ private function buildCalendarListView( array $events, PhabricatorSavedQuery $query) { - assert_instances_of($events, 'PhabricatorCalendarEvent'); + assert_instances_of($events, PhabricatorCalendarEvent::class); $viewer = $this->requireViewer(); $list = new PHUIObjectItemListView(); @@ -335,10 +339,14 @@ final class PhabricatorCalendarEventSearchEngine ->setNoDataString(pht('No events found.')); } + /** + * @param array $events + * @param PhabricatorSavedQuery $query + */ private function buildCalendarMonthView( array $events, PhabricatorSavedQuery $query) { - assert_instances_of($events, 'PhabricatorCalendarEvent'); + assert_instances_of($events, PhabricatorCalendarEvent::class); $viewer = $this->requireViewer(); $now = PhabricatorTime::getNow(); diff --git a/src/applications/calendar/query/PhabricatorCalendarExportSearchEngine.php b/src/applications/calendar/query/PhabricatorCalendarExportSearchEngine.php index c718374da2..0ceccf48d4 100644 --- a/src/applications/calendar/query/PhabricatorCalendarExportSearchEngine.php +++ b/src/applications/calendar/query/PhabricatorCalendarExportSearchEngine.php @@ -56,12 +56,17 @@ final class PhabricatorCalendarExportSearchEngine return parent::buildSavedQueryFromBuiltin($query_key); } + /** + * @param array $exports + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $exports, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($exports, 'PhabricatorCalendarExport'); + assert_instances_of($exports, PhabricatorCalendarExport::class); $viewer = $this->requireViewer(); $list = new PHUIObjectItemListView(); diff --git a/src/applications/calendar/query/PhabricatorCalendarImportLogSearchEngine.php b/src/applications/calendar/query/PhabricatorCalendarImportLogSearchEngine.php index fd6896c37d..45e3de046c 100644 --- a/src/applications/calendar/query/PhabricatorCalendarImportLogSearchEngine.php +++ b/src/applications/calendar/query/PhabricatorCalendarImportLogSearchEngine.php @@ -62,12 +62,17 @@ final class PhabricatorCalendarImportLogSearchEngine return parent::buildSavedQueryFromBuiltin($query_key); } + /** + * @param array $logs + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $logs, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($logs, 'PhabricatorCalendarImportLog'); + assert_instances_of($logs, PhabricatorCalendarImportLog::class); $viewer = $this->requireViewer(); $view = id(new PhabricatorCalendarImportLogView()) diff --git a/src/applications/calendar/query/PhabricatorCalendarImportSearchEngine.php b/src/applications/calendar/query/PhabricatorCalendarImportSearchEngine.php index 509b1224e6..98db9a495b 100644 --- a/src/applications/calendar/query/PhabricatorCalendarImportSearchEngine.php +++ b/src/applications/calendar/query/PhabricatorCalendarImportSearchEngine.php @@ -53,12 +53,17 @@ final class PhabricatorCalendarImportSearchEngine return parent::buildSavedQueryFromBuiltin($query_key); } + /** + * @param array $imports + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $imports, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($imports, 'PhabricatorCalendarImport'); + assert_instances_of($imports, PhabricatorCalendarImport::class); $viewer = $this->requireViewer(); $list = new PHUIObjectItemListView(); diff --git a/src/applications/calendar/util/PhabricatorCalendarICSWriter.php b/src/applications/calendar/util/PhabricatorCalendarICSWriter.php index ff5657ae73..43b2a7ec86 100644 --- a/src/applications/calendar/util/PhabricatorCalendarICSWriter.php +++ b/src/applications/calendar/util/PhabricatorCalendarICSWriter.php @@ -14,8 +14,11 @@ final class PhabricatorCalendarICSWriter extends Phobject { return $this->viewer; } + /** + * @param array $events + */ public function setEvents(array $events) { - assert_instances_of($events, 'PhabricatorCalendarEvent'); + assert_instances_of($events, PhabricatorCalendarEvent::class); $this->events = $events; return $this; } diff --git a/src/applications/calendar/view/PhabricatorCalendarImportLogView.php b/src/applications/calendar/view/PhabricatorCalendarImportLogView.php index 8c2c2af68e..6f5a698a53 100644 --- a/src/applications/calendar/view/PhabricatorCalendarImportLogView.php +++ b/src/applications/calendar/view/PhabricatorCalendarImportLogView.php @@ -5,8 +5,11 @@ final class PhabricatorCalendarImportLogView extends AphrontView { private $logs = array(); private $showImportSources = false; + /** + * @param array $logs + */ public function setLogs(array $logs) { - assert_instances_of($logs, 'PhabricatorCalendarImportLog'); + assert_instances_of($logs, PhabricatorCalendarImportLog::class); $this->logs = $logs; return $this; } diff --git a/src/applications/differential/conduit/DifferentialConduitAPIMethod.php b/src/applications/differential/conduit/DifferentialConduitAPIMethod.php index 108f562bfb..3c4210daf2 100644 --- a/src/applications/differential/conduit/DifferentialConduitAPIMethod.php +++ b/src/applications/differential/conduit/DifferentialConduitAPIMethod.php @@ -118,10 +118,14 @@ abstract class DifferentialConduitAPIMethod extends ConduitAPIMethod { ->execute(); } + /** + * @param PhabricatorUser $viewer + * @param array $revisions + */ protected function loadCustomFieldsForRevisions( PhabricatorUser $viewer, array $revisions) { - assert_instances_of($revisions, 'DifferentialRevision'); + assert_instances_of($revisions, DifferentialRevision::class); if (!$revisions) { return array(); diff --git a/src/applications/differential/controller/DifferentialController.php b/src/applications/differential/controller/DifferentialController.php index 334d46c3cb..dd3ab85910 100644 --- a/src/applications/differential/controller/DifferentialController.php +++ b/src/applications/differential/controller/DifferentialController.php @@ -25,8 +25,11 @@ abstract class DifferentialController extends PhabricatorController { return $this->buildSideNavView(true)->getMenu(); } + /** + * @param array $changesets + */ protected function buildPackageMaps(array $changesets) { - assert_instances_of($changesets, 'DifferentialChangeset'); + assert_instances_of($changesets, DifferentialChangeset::class); $this->packageChangesetMap = array(); $this->pathPackageMap = array(); diff --git a/src/applications/differential/controller/DifferentialRevisionViewController.php b/src/applications/differential/controller/DifferentialRevisionViewController.php index e020bab2a4..8a32988bce 100644 --- a/src/applications/differential/controller/DifferentialRevisionViewController.php +++ b/src/applications/differential/controller/DifferentialRevisionViewController.php @@ -861,8 +861,11 @@ final class DifferentialRevisionViewController return $curtain; } + /** + * @param array $diffs + */ private function loadHistoryDiffStatus(array $diffs) { - assert_instances_of($diffs, 'DifferentialDiff'); + assert_instances_of($diffs, DifferentialDiff::class); $diff_phids = mpull($diffs, 'getPHID'); $bad_unit_status = array( @@ -978,10 +981,14 @@ final class DifferentialRevisionViewController return array($changesets, $vs_map, $vs_changesets, $refs); } + /** + * @param PhabricatorRepository $repository + * @param array $unfolded_changesets + */ private function buildSymbolIndexes( PhabricatorRepository $repository, array $unfolded_changesets) { - assert_instances_of($unfolded_changesets, 'DifferentialChangeset'); + assert_instances_of($unfolded_changesets, DifferentialChangeset::class); $engine = PhabricatorSyntaxHighlighter::newEngine(); @@ -1019,11 +1026,16 @@ final class DifferentialRevisionViewController return $symbol_indexes; } + /** + * @param array $changesets + * @param DifferentialDiff $target + * @param PhabricatorRepository $repository + */ private function loadOtherRevisions( array $changesets, DifferentialDiff $target, PhabricatorRepository $repository) { - assert_instances_of($changesets, 'DifferentialChangeset'); + assert_instances_of($changesets, DifferentialChangeset::class); $viewer = $this->getViewer(); @@ -1068,8 +1080,11 @@ final class DifferentialRevisionViewController return $results; } + /** + * @param array $revisions + */ private function renderOtherRevisions(array $revisions) { - assert_instances_of($revisions, 'DifferentialRevision'); + assert_instances_of($revisions, DifferentialRevision::class); $viewer = $this->getViewer(); $header = id(new PHUIHeaderView()) @@ -1082,7 +1097,13 @@ final class DifferentialRevisionViewController ->setNoBox(true); } - + /** + * @param DifferentialRevision $revision + * @param array $changesets + * @param array $vs_changesets + * @param array $vs_map + * @param ?PhabricatorRepository $repository + */ private function buildRawDiffResponse( DifferentialRevision $revision, array $changesets, @@ -1090,8 +1111,8 @@ final class DifferentialRevisionViewController array $vs_map, ?PhabricatorRepository $repository = null) { - assert_instances_of($changesets, 'DifferentialChangeset'); - assert_instances_of($vs_changesets, 'DifferentialChangeset'); + assert_instances_of($changesets, DifferentialChangeset::class); + assert_instances_of($vs_changesets, DifferentialChangeset::class); $viewer = $this->getViewer(); @@ -1350,8 +1371,12 @@ final class DifferentialRevisionViewController ->setShowViewAll(true); } + /** + * @param DifferentialRevision $revision + * @param array $diffs + */ private function getOldDiffID(DifferentialRevision $revision, array $diffs) { - assert_instances_of($diffs, 'DifferentialDiff'); + assert_instances_of($diffs, DifferentialDiff::class); $request = $this->getRequest(); $diffs = mpull($diffs, null, 'getID'); @@ -1459,8 +1484,12 @@ final class DifferentialRevisionViewController return null; } + /** + * @param DifferentialRevision $revision + * @param array $diffs + */ private function getNewDiffID(DifferentialRevision $revision, array $diffs) { - assert_instances_of($diffs, 'DifferentialDiff'); + assert_instances_of($diffs, DifferentialDiff::class); $request = $this->getRequest(); $diffs = mpull($diffs, null, 'getID'); diff --git a/src/applications/differential/engine/DifferentialChangesetEngine.php b/src/applications/differential/engine/DifferentialChangesetEngine.php index c5c9fc57eb..f93e97017c 100644 --- a/src/applications/differential/engine/DifferentialChangesetEngine.php +++ b/src/applications/differential/engine/DifferentialChangesetEngine.php @@ -13,8 +13,11 @@ final class DifferentialChangesetEngine extends Phobject { return $this->viewer; } + /** + * @param array $changesets + */ public function rebuildChangesets(array $changesets) { - assert_instances_of($changesets, 'DifferentialChangeset'); + assert_instances_of($changesets, DifferentialChangeset::class); $changesets = $this->loadChangesetFiles($changesets); diff --git a/src/applications/differential/parser/DifferentialChangesetParser.php b/src/applications/differential/parser/DifferentialChangesetParser.php index b7137e02e3..707235187b 100644 --- a/src/applications/differential/parser/DifferentialChangesetParser.php +++ b/src/applications/differential/parser/DifferentialChangesetParser.php @@ -334,8 +334,11 @@ final class DifferentialChangesetParser extends Phobject { return $this; } + /** + * @param array $handles + */ public function setHandles(array $handles) { - assert_instances_of($handles, 'PhabricatorObjectHandle'); + assert_instances_of($handles, PhabricatorObjectHandle::class); $this->handles = $handles; return $this; } diff --git a/src/applications/differential/parser/DifferentialCommitMessageParser.php b/src/applications/differential/parser/DifferentialCommitMessageParser.php index 3a73428e4b..a900e68a50 100644 --- a/src/applications/differential/parser/DifferentialCommitMessageParser.php +++ b/src/applications/differential/parser/DifferentialCommitMessageParser.php @@ -65,10 +65,11 @@ final class DifferentialCommitMessageParser extends Phobject { /** + * @param array $fields * @task config */ public function setCommitMessageFields(array $fields) { - assert_instances_of($fields, 'DifferentialCommitMessageField'); + assert_instances_of($fields, DifferentialCommitMessageField::class); $fields = mpull($fields, null, 'getCommitMessageFieldKey'); $this->commitMessageFields = $fields; return $this; diff --git a/src/applications/differential/parser/DifferentialHunkParser.php b/src/applications/differential/parser/DifferentialHunkParser.php index 78c6d62094..80994b3327 100644 --- a/src/applications/differential/parser/DifferentialHunkParser.php +++ b/src/applications/differential/parser/DifferentialHunkParser.php @@ -14,11 +14,12 @@ final class DifferentialHunkParser extends Phobject { * datastructure is used to determine when to render "Context not available." * in diffs with multiple hunks. * + * @param array $hunks * @return array Map of lines where hunks start, other than * line 1. */ public function getHunkStartLines(array $hunks) { - assert_instances_of($hunks, 'DifferentialHunk'); + assert_instances_of($hunks, DifferentialHunk::class); $map = array(); foreach ($hunks as $hunk) { @@ -475,8 +476,11 @@ final class DifferentialHunkParser extends Phobject { return $corpus; } + /** + * @param array $hunks + */ public function parseHunksForLineData(array $hunks) { - assert_instances_of($hunks, 'DifferentialHunk'); + assert_instances_of($hunks, DifferentialHunk::class); $old_lines = array(); $new_lines = array(); @@ -564,13 +568,18 @@ final class DifferentialHunkParser extends Phobject { return $this; } + /** + * @param array $changeset_hunks + * @param array $old_hunks + * @param array $new_hunks + */ public function parseHunksForHighlightMasks( array $changeset_hunks, array $old_hunks, array $new_hunks) { - assert_instances_of($changeset_hunks, 'DifferentialHunk'); - assert_instances_of($old_hunks, 'DifferentialHunk'); - assert_instances_of($new_hunks, 'DifferentialHunk'); + assert_instances_of($changeset_hunks, DifferentialHunk::class); + assert_instances_of($old_hunks, DifferentialHunk::class); + assert_instances_of($new_hunks, DifferentialHunk::class); // Put changes side by side. $olds = array(); @@ -663,6 +672,13 @@ final class DifferentialHunkParser extends Phobject { return array($highlight_old, $highlight_new); } + /** + * @param array $new_hunks + * @param bool $is_new + * @param int $line_number + * @param int $line_length + * @param int $add_context + */ public function makeContextDiff( array $hunks, $is_new, @@ -670,7 +686,7 @@ final class DifferentialHunkParser extends Phobject { $line_length, $add_context) { - assert_instances_of($hunks, 'DifferentialHunk'); + assert_instances_of($hunks, DifferentialHunk::class); $context = array(); @@ -749,8 +765,11 @@ final class DifferentialHunkParser extends Phobject { return implode("\n", $context); } + /** + * @param array $new_hunks + */ private function computeOffsets(array $hunks) { - assert_instances_of($hunks, 'DifferentialHunk'); + assert_instances_of($hunks, DifferentialHunk::class); $offsets = array(); $n = 1; diff --git a/src/applications/differential/parser/DifferentialLineAdjustmentMap.php b/src/applications/differential/parser/DifferentialLineAdjustmentMap.php index 6c9bfad98b..33c4640f32 100644 --- a/src/applications/differential/parser/DifferentialLineAdjustmentMap.php +++ b/src/applications/differential/parser/DifferentialLineAdjustmentMap.php @@ -158,8 +158,11 @@ final class DifferentialLineAdjustmentMap extends Phobject { return $this; } + /** + * @param array $hunks + */ public static function newFromHunks(array $hunks) { - assert_instances_of($hunks, 'DifferentialHunk'); + assert_instances_of($hunks, DifferentialHunk::class); $map = array(); $o = 0; diff --git a/src/applications/differential/query/DifferentialChangesetQuery.php b/src/applications/differential/query/DifferentialChangesetQuery.php index a76c90791f..a1b932cfee 100644 --- a/src/applications/differential/query/DifferentialChangesetQuery.php +++ b/src/applications/differential/query/DifferentialChangesetQuery.php @@ -25,8 +25,11 @@ final class DifferentialChangesetQuery return $this; } + /** + * @param array $diffs + */ public function withDiffs(array $diffs) { - assert_instances_of($diffs, 'DifferentialDiff'); + assert_instances_of($diffs, DifferentialDiff::class); $this->diffs = $diffs; return $this; } diff --git a/src/applications/differential/query/DifferentialChangesetSearchEngine.php b/src/applications/differential/query/DifferentialChangesetSearchEngine.php index f3235443e9..033812a1f2 100644 --- a/src/applications/differential/query/DifferentialChangesetSearchEngine.php +++ b/src/applications/differential/query/DifferentialChangesetSearchEngine.php @@ -86,12 +86,17 @@ final class DifferentialChangesetSearchEngine return parent::buildSavedQueryFromBuiltin($query_key); } + /** + * @param array $changesets + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $changesets, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($changesets, 'DifferentialChangeset'); + assert_instances_of($changesets, DifferentialChangeset::class); $viewer = $this->requireViewer(); $rows = array(); diff --git a/src/applications/differential/query/DifferentialDiffSearchEngine.php b/src/applications/differential/query/DifferentialDiffSearchEngine.php index 31393d4681..e4505344cc 100644 --- a/src/applications/differential/query/DifferentialDiffSearchEngine.php +++ b/src/applications/differential/query/DifferentialDiffSearchEngine.php @@ -62,11 +62,16 @@ final class DifferentialDiffSearchEngine return parent::buildSavedQueryFromBuiltin($query_key); } + /** + * @param array $revisions + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $revisions, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($revisions, 'DifferentialDiff'); + assert_instances_of($revisions, DifferentialDiff::class); $viewer = $this->requireViewer(); diff --git a/src/applications/differential/query/DifferentialHunkQuery.php b/src/applications/differential/query/DifferentialHunkQuery.php index 0f736498ae..6d5ecf9fd5 100644 --- a/src/applications/differential/query/DifferentialHunkQuery.php +++ b/src/applications/differential/query/DifferentialHunkQuery.php @@ -9,8 +9,11 @@ final class DifferentialHunkQuery private $changesets; private $shouldAttachToChangesets; + /** + * @param array $changesets + */ public function withChangesets(array $changesets) { - assert_instances_of($changesets, 'DifferentialChangeset'); + assert_instances_of($changesets, DifferentialChangeset::class); $this->changesets = $changesets; return $this; } diff --git a/src/applications/differential/query/DifferentialRevisionQuery.php b/src/applications/differential/query/DifferentialRevisionQuery.php index dd127768b9..d1724e0f3b 100644 --- a/src/applications/differential/query/DifferentialRevisionQuery.php +++ b/src/applications/differential/query/DifferentialRevisionQuery.php @@ -864,8 +864,11 @@ final class DifferentialRevisionQuery ); } + /** + * @param array $revisions + */ private function loadCommitPHIDs(array $revisions) { - assert_instances_of($revisions, 'DifferentialRevision'); + assert_instances_of($revisions, DifferentialRevision::class); if (!$revisions) { return; @@ -887,8 +890,12 @@ final class DifferentialRevisionQuery } } + /** + * @param AphrontDatabaseConnection $conn_r + * @param array $revisions + */ private function loadDiffIDs($conn_r, array $revisions) { - assert_instances_of($revisions, 'DifferentialRevision'); + assert_instances_of($revisions, DifferentialRevision::class); $diff_table = new DifferentialDiff(); @@ -907,8 +914,12 @@ final class DifferentialRevisionQuery } } + /** + * @param AphrontDatabaseConnection $conn_r + * @param array $revisions + */ private function loadActiveDiffs($conn_r, array $revisions) { - assert_instances_of($revisions, 'DifferentialRevision'); + assert_instances_of($revisions, DifferentialRevision::class); $diff_table = new DifferentialDiff(); @@ -933,10 +944,14 @@ final class DifferentialRevisionQuery } } + /** + * @param AphrontDatabaseConnection $conn_r + * @param array $revisions + */ private function loadHashes( AphrontDatabaseConnection $conn_r, array $revisions) { - assert_instances_of($revisions, 'DifferentialRevision'); + assert_instances_of($revisions, DifferentialRevision::class); $data = queryfx_all( $conn_r, @@ -955,11 +970,15 @@ final class DifferentialRevisionQuery } } + /** + * @param AphrontDatabaseConnection $conn + * @param array $revisions + */ private function loadReviewers( AphrontDatabaseConnection $conn, array $revisions) { - assert_instances_of($revisions, 'DifferentialRevision'); + assert_instances_of($revisions, DifferentialRevision::class); $reviewer_table = new DifferentialReviewer(); $reviewer_rows = queryfx_all( diff --git a/src/applications/differential/query/DifferentialRevisionSearchEngine.php b/src/applications/differential/query/DifferentialRevisionSearchEngine.php index 4055a38166..4f876ab75d 100644 --- a/src/applications/differential/query/DifferentialRevisionSearchEngine.php +++ b/src/applications/differential/query/DifferentialRevisionSearchEngine.php @@ -172,11 +172,16 @@ final class DifferentialRevisionSearchEngine return parent::buildSavedQueryFromBuiltin($query_key); } + /** + * @param array $revisions + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $revisions, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($revisions, 'DifferentialRevision'); + assert_instances_of($revisions, DifferentialRevision::class); $viewer = $this->requireViewer(); $template = id(new DifferentialRevisionListView()) diff --git a/src/applications/differential/render/DifferentialChangesetRenderer.php b/src/applications/differential/render/DifferentialChangesetRenderer.php index 12b1efac80..3217a51e30 100644 --- a/src/applications/differential/render/DifferentialChangesetRenderer.php +++ b/src/applications/differential/render/DifferentialChangesetRenderer.php @@ -177,8 +177,11 @@ abstract class DifferentialChangesetRenderer extends Phobject { return $this->markupEngine; } + /** + * @param array $handles + */ public function setHandles(array $handles) { - assert_instances_of($handles, 'PhabricatorObjectHandle'); + assert_instances_of($handles, PhabricatorObjectHandle::class); $this->handles = $handles; return $this; } @@ -261,20 +264,27 @@ abstract class DifferentialChangesetRenderer extends Phobject { return $this->documentEngineBlocks; } + /** + * @param array $new_comments + */ public function setNewComments(array $new_comments) { foreach ($new_comments as $line_number => $comments) { - assert_instances_of($comments, 'PhabricatorInlineComment'); + assert_instances_of($comments, PhabricatorInlineComment::class); } $this->newComments = $new_comments; return $this; } + protected function getNewComments() { return $this->newComments; } + /** + * @param array $old_comments + */ public function setOldComments(array $old_comments) { foreach ($old_comments as $line_number => $comments) { - assert_instances_of($comments, 'PhabricatorInlineComment'); + assert_instances_of($comments, PhabricatorInlineComment::class); } $this->oldComments = $old_comments; return $this; diff --git a/src/applications/differential/render/DifferentialRawDiffRenderer.php b/src/applications/differential/render/DifferentialRawDiffRenderer.php index 4f25646e4a..152e207f19 100644 --- a/src/applications/differential/render/DifferentialRawDiffRenderer.php +++ b/src/applications/differential/render/DifferentialRawDiffRenderer.php @@ -16,8 +16,11 @@ final class DifferentialRawDiffRenderer extends Phobject { return $this->format; } + /** + * @param array $changesets + */ public function setChangesets(array $changesets) { - assert_instances_of($changesets, 'DifferentialChangeset'); + assert_instances_of($changesets, DifferentialChangeset::class); $this->changesets = $changesets; return $this; diff --git a/src/applications/differential/storage/DifferentialChangeset.php b/src/applications/differential/storage/DifferentialChangeset.php index 8f45362057..ca053e3cc3 100644 --- a/src/applications/differential/storage/DifferentialChangeset.php +++ b/src/applications/differential/storage/DifferentialChangeset.php @@ -85,8 +85,11 @@ final class DifferentialChangeset return $this->getAddLines() + $this->getDelLines(); } + /** + * @param array $hunks + */ public function attachHunks(array $hunks) { - assert_instances_of($hunks, 'DifferentialHunk'); + assert_instances_of($hunks, DifferentialHunk::class); $this->hunks = $hunks; return $this; } diff --git a/src/applications/differential/storage/DifferentialDiff.php b/src/applications/differential/storage/DifferentialDiff.php index 3a757434ef..c749b2c272 100644 --- a/src/applications/differential/storage/DifferentialDiff.php +++ b/src/applications/differential/storage/DifferentialDiff.php @@ -98,8 +98,11 @@ final class DifferentialDiff return $this; } + /** + * @param array $changesets + */ public function attachChangesets(array $changesets) { - assert_instances_of($changesets, 'DifferentialChangeset'); + assert_instances_of($changesets, DifferentialChangeset::class); $this->changesets = $changesets; return $this; } @@ -148,18 +151,25 @@ final class DifferentialDiff return $diff; } + /** + * @param PhabricatorUser $actor + * @param array $changes + */ public static function newFromRawChanges( PhabricatorUser $actor, array $changes) { - assert_instances_of($changes, 'ArcanistDiffChange'); + assert_instances_of($changes, ArcanistDiffChange::class); $diff = self::initializeNewDiff($actor); return self::buildChangesetsFromRawChanges($diff, $changes); } + /** + * @param array $changes + */ public static function newEphemeralFromRawChanges(array $changes) { - assert_instances_of($changes, 'ArcanistDiffChange'); + assert_instances_of($changes, ArcanistDiffChange::class); $diff = id(new DifferentialDiff())->makeEphemeral(); return self::buildChangesetsFromRawChanges($diff, $changes); diff --git a/src/applications/differential/storage/DifferentialRevision.php b/src/applications/differential/storage/DifferentialRevision.php index 0dcfe0ce1c..b31614ab66 100644 --- a/src/applications/differential/storage/DifferentialRevision.php +++ b/src/applications/differential/storage/DifferentialRevision.php @@ -554,8 +554,11 @@ final class DifferentialRevision extends DifferentialDAO return $this->assertAttached($this->reviewerStatus); } + /** + * @param array $reviewers + */ public function attachReviewers(array $reviewers) { - assert_instances_of($reviewers, 'DifferentialReviewer'); + assert_instances_of($reviewers, DifferentialReviewer::class); $reviewers = mpull($reviewers, null, 'getReviewerPHID'); $this->reviewerStatus = $reviewers; return $this; diff --git a/src/applications/differential/storage/DifferentialTransactionComment.php b/src/applications/differential/storage/DifferentialTransactionComment.php index 7e2621e7aa..c4d16cc416 100644 --- a/src/applications/differential/storage/DifferentialTransactionComment.php +++ b/src/applications/differential/storage/DifferentialTransactionComment.php @@ -72,11 +72,15 @@ final class DifferentialTransactionComment return ($this->getTransactionPHID() != null); } + /** + * @param array $inlines + * @param array $changesets + */ public static function sortAndGroupInlines( array $inlines, array $changesets) { - assert_instances_of($inlines, 'DifferentialTransaction'); - assert_instances_of($changesets, 'DifferentialChangeset'); + assert_instances_of($inlines, DifferentialTransaction::class); + assert_instances_of($changesets, DifferentialChangeset::class); $changesets = mpull($changesets, null, 'getID'); $changesets = msort($changesets, 'getFilename'); diff --git a/src/applications/differential/view/DifferentialLocalCommitsView.php b/src/applications/differential/view/DifferentialLocalCommitsView.php index 4ac2bc14b3..2fbe414043 100644 --- a/src/applications/differential/view/DifferentialLocalCommitsView.php +++ b/src/applications/differential/view/DifferentialLocalCommitsView.php @@ -10,8 +10,11 @@ final class DifferentialLocalCommitsView extends AphrontView { return $this; } + /** + * @param array $commits + */ public function setCommitsForLinks(array $commits) { - assert_instances_of($commits, 'PhabricatorRepositoryCommit'); + assert_instances_of($commits, PhabricatorRepositoryCommit::class); $this->commitsForLinks = $commits; return $this; } diff --git a/src/applications/differential/view/DifferentialReviewersView.php b/src/applications/differential/view/DifferentialReviewersView.php index ad6bf1462b..684c3e2fec 100644 --- a/src/applications/differential/view/DifferentialReviewersView.php +++ b/src/applications/differential/view/DifferentialReviewersView.php @@ -6,14 +6,20 @@ final class DifferentialReviewersView extends AphrontView { private $handles; private $diff; + /** + * @param array $reviewers + */ public function setReviewers(array $reviewers) { - assert_instances_of($reviewers, 'DifferentialReviewer'); + assert_instances_of($reviewers, DifferentialReviewer::class); $this->reviewers = $reviewers; return $this; } + /** + * @param array $handles + */ public function setHandles(array $handles) { - assert_instances_of($handles, 'PhabricatorObjectHandle'); + assert_instances_of($handles, PhabricatorObjectHandle::class); $this->handles = $handles; return $this; } diff --git a/src/applications/differential/view/DifferentialRevisionListView.php b/src/applications/differential/view/DifferentialRevisionListView.php index c091fc1615..5de2d74af3 100644 --- a/src/applications/differential/view/DifferentialRevisionListView.php +++ b/src/applications/differential/view/DifferentialRevisionListView.php @@ -32,8 +32,11 @@ final class DifferentialRevisionListView extends AphrontView { return $this; } + /** + * @param array $revisions + */ public function setRevisions(array $revisions) { - assert_instances_of($revisions, 'DifferentialRevision'); + assert_instances_of($revisions, DifferentialRevision::class); $this->revisions = $revisions; return $this; } diff --git a/src/applications/differential/view/DifferentialRevisionUpdateHistoryView.php b/src/applications/differential/view/DifferentialRevisionUpdateHistoryView.php index 2e074a2f7e..b3f02c18d3 100644 --- a/src/applications/differential/view/DifferentialRevisionUpdateHistoryView.php +++ b/src/applications/differential/view/DifferentialRevisionUpdateHistoryView.php @@ -8,8 +8,11 @@ final class DifferentialRevisionUpdateHistoryView extends AphrontView { private $commitsForLinks = array(); private $unitStatus = array(); + /** + * @param array $diffs + */ public function setDiffs(array $diffs) { - assert_instances_of($diffs, 'DifferentialDiff'); + assert_instances_of($diffs, DifferentialDiff::class); $this->diffs = $diffs; return $this; } @@ -24,8 +27,11 @@ final class DifferentialRevisionUpdateHistoryView extends AphrontView { return $this; } + /** + * @param array $commits + */ public function setCommitsForLinks(array $commits) { - assert_instances_of($commits, 'PhabricatorRepositoryCommit'); + assert_instances_of($commits, PhabricatorRepositoryCommit::class); $this->commitsForLinks = $commits; return $this; } diff --git a/src/applications/differential/view/DifferentialTransactionView.php b/src/applications/differential/view/DifferentialTransactionView.php index 5fb8c1320c..c4b6e04e33 100644 --- a/src/applications/differential/view/DifferentialTransactionView.php +++ b/src/applications/differential/view/DifferentialTransactionView.php @@ -35,8 +35,11 @@ final class DifferentialTransactionView return $this->revision; } + /** + * @param array $changesets + */ public function setChangesets(array $changesets) { - assert_instances_of($changesets, 'DifferentialChangeset'); + assert_instances_of($changesets, DifferentialChangeset::class); $this->changesets = $changesets; return $this; } diff --git a/src/applications/herald/adapter/HeraldAdapter.php b/src/applications/herald/adapter/HeraldAdapter.php index 9188d15f4a..82665e420f 100644 --- a/src/applications/herald/adapter/HeraldAdapter.php +++ b/src/applications/herald/adapter/HeraldAdapter.php @@ -143,8 +143,11 @@ abstract class HeraldAdapter extends Phobject { ->getHeraldFieldValue($this->getObject()); } + /** + * @param array $effects + */ public function applyHeraldEffects(array $effects) { - assert_instances_of($effects, 'HeraldEffect'); + assert_instances_of($effects, HeraldEffect::class); $result = array(); foreach ($effects as $effect) { @@ -171,12 +174,12 @@ abstract class HeraldAdapter extends Phobject { * These transactions are set by @{class:PhabricatorApplicationEditor} * automatically, before it invokes Herald. * - * @param list $xactions List of + * @param array $xactions List of * transactions. * @return $this */ final public function setAppliedTransactions(array $xactions) { - assert_instances_of($xactions, 'PhabricatorApplicationTransaction'); + assert_instances_of($xactions, PhabricatorApplicationTransaction::class); $this->appliedTransactions = $xactions; return $this; } diff --git a/src/applications/herald/controller/HeraldRuleController.php b/src/applications/herald/controller/HeraldRuleController.php index 46a970a002..431a39b1fc 100644 --- a/src/applications/herald/controller/HeraldRuleController.php +++ b/src/applications/herald/controller/HeraldRuleController.php @@ -710,8 +710,12 @@ final class HeraldRuleController extends HeraldController { HeraldActionGroup::getAllActionGroups()); } + /** + * @param array $item_map + * @param array $group_list + */ private function getGroups(array $item_map, array $group_list) { - assert_instances_of($group_list, 'HeraldGroup'); + assert_instances_of($group_list, HeraldGroup::class); $groups = array(); foreach ($item_map as $group_key => $options) { diff --git a/src/applications/herald/editor/HeraldRuleSerializer.php b/src/applications/herald/editor/HeraldRuleSerializer.php index cf045fc9bf..fa4d4b3ea4 100644 --- a/src/applications/herald/editor/HeraldRuleSerializer.php +++ b/src/applications/herald/editor/HeraldRuleSerializer.php @@ -12,14 +12,21 @@ final class HeraldRuleSerializer extends Phobject { $rule->getRepetitionPolicyStringConstant()); } + /** + * @param $match_all + * @param array $conditions + * @param array $actions + * @param $repetition_policy + * @return array + */ public function serializeRuleComponents( $match_all, array $conditions, array $actions, $repetition_policy) { - assert_instances_of($conditions, 'HeraldCondition'); - assert_instances_of($actions, 'HeraldActionRecord'); + assert_instances_of($conditions, HeraldCondition::class); + assert_instances_of($actions, HeraldActionRecord::class); $conditions_array = array(); foreach ($conditions as $condition) { diff --git a/src/applications/herald/engine/HeraldEngine.php b/src/applications/herald/engine/HeraldEngine.php index 852fbab090..905b7e291f 100644 --- a/src/applications/herald/engine/HeraldEngine.php +++ b/src/applications/herald/engine/HeraldEngine.php @@ -122,8 +122,13 @@ final class HeraldEngine extends Phobject { return $this->ruleResults[$phid]; } + /** + * @param array $rules + * @param HeraldAdapter $object + * @return array + */ public function applyRules(array $rules, HeraldAdapter $object) { - assert_instances_of($rules, 'HeraldRule'); + assert_instances_of($rules, HeraldRule::class); $t_start = microtime(true); // Rules execute in a well-defined order: sort them into execution order. @@ -254,12 +259,18 @@ final class HeraldEngine extends Phobject { return $effects; } + /** + * @param array $effects + * @param HeraldAdapter $adapter + * @param array $rules + * @return array + */ public function applyEffects( array $effects, HeraldAdapter $adapter, array $rules) { - assert_instances_of($effects, 'HeraldEffect'); - assert_instances_of($rules, 'HeraldRule'); + assert_instances_of($effects, HeraldEffect::class); + assert_instances_of($rules, HeraldRule::class); $this->transcript->setDryRun((int)$this->getDryRun()); @@ -275,7 +286,7 @@ final class HeraldEngine extends Phobject { $xscripts = $adapter->applyHeraldEffects($effects); } - assert_instances_of($xscripts, 'HeraldApplyTranscript'); + assert_instances_of($xscripts, HeraldApplyTranscript::class); foreach ($xscripts as $apply_xscript) { $this->transcript->addApplyTranscript($apply_xscript); } diff --git a/src/applications/herald/query/HeraldRuleSearchEngine.php b/src/applications/herald/query/HeraldRuleSearchEngine.php index b4e10035a3..b1639cc28d 100644 --- a/src/applications/herald/query/HeraldRuleSearchEngine.php +++ b/src/applications/herald/query/HeraldRuleSearchEngine.php @@ -130,11 +130,16 @@ final class HeraldRuleSearchEngine extends PhabricatorApplicationSearchEngine { return parent::buildSavedQueryFromBuiltin($query_key); } + /** + * @param array $rules + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $rules, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($rules, 'HeraldRule'); + assert_instances_of($rules, HeraldRule::class); $viewer = $this->requireViewer(); $list = id(new HeraldRuleListView()) diff --git a/src/applications/herald/query/HeraldTranscriptSearchEngine.php b/src/applications/herald/query/HeraldTranscriptSearchEngine.php index 02e5b6b6e4..5c4b11ead8 100644 --- a/src/applications/herald/query/HeraldTranscriptSearchEngine.php +++ b/src/applications/herald/query/HeraldTranscriptSearchEngine.php @@ -104,11 +104,16 @@ final class HeraldTranscriptSearchEngine return mpull($transcripts, 'getObjectPHID'); } + /** + * @param array $transcripts + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $transcripts, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($transcripts, 'HeraldTranscript'); + assert_instances_of($transcripts, HeraldTranscript::class); $viewer = $this->requireViewer(); diff --git a/src/applications/herald/query/HeraldWebhookSearchEngine.php b/src/applications/herald/query/HeraldWebhookSearchEngine.php index ba898f4434..5c52438c50 100644 --- a/src/applications/herald/query/HeraldWebhookSearchEngine.php +++ b/src/applications/herald/query/HeraldWebhookSearchEngine.php @@ -68,11 +68,16 @@ final class HeraldWebhookSearchEngine return parent::buildSavedQueryFromBuiltin($query_key); } + /** + * @param array $hooks + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $hooks, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($hooks, 'HeraldWebhook'); + assert_instances_of($hooks, HeraldWebhook::class); $viewer = $this->requireViewer(); diff --git a/src/applications/herald/storage/HeraldRule.php b/src/applications/herald/storage/HeraldRule.php index 297dba33d6..bef915cd0b 100644 --- a/src/applications/herald/storage/HeraldRule.php +++ b/src/applications/herald/storage/HeraldRule.php @@ -90,8 +90,11 @@ final class HeraldRule extends HeraldDAO $this->getID()); } + /** + * @param array $conditions + */ public function attachConditions(array $conditions) { - assert_instances_of($conditions, 'HeraldCondition'); + assert_instances_of($conditions, HeraldCondition::class); $this->conditions = $conditions; return $this; } @@ -110,9 +113,12 @@ final class HeraldRule extends HeraldDAO $this->getID()); } + /** + * @param array $actions + */ public function attachActions(array $actions) { // TODO: validate actions have been attached. - assert_instances_of($actions, 'HeraldActionRecord'); + assert_instances_of($actions, HeraldActionRecord::class); $this->actions = $actions; return $this; } @@ -121,22 +127,32 @@ final class HeraldRule extends HeraldDAO return $this->actions; } + /** + * @param array $conditions + */ public function saveConditions(array $conditions) { - assert_instances_of($conditions, 'HeraldCondition'); + assert_instances_of($conditions, HeraldCondition::class); return $this->saveChildren( id(new HeraldCondition())->getTableName(), $conditions); } + /** + * @param array $actions + */ public function saveActions(array $actions) { - assert_instances_of($actions, 'HeraldActionRecord'); + assert_instances_of($actions, HeraldActionRecord::class); return $this->saveChildren( id(new HeraldActionRecord())->getTableName(), $actions); } + /** + * @param string $table_name + * @param array $children + */ protected function saveChildren($table_name, array $children) { - assert_instances_of($children, 'HeraldDAO'); + assert_instances_of($children, parent::class); if (!$this->getID()) { throw new PhutilInvalidStateException('save'); diff --git a/src/applications/herald/view/HeraldRuleListView.php b/src/applications/herald/view/HeraldRuleListView.php index 150499ce87..f2a2c25d7c 100644 --- a/src/applications/herald/view/HeraldRuleListView.php +++ b/src/applications/herald/view/HeraldRuleListView.php @@ -5,8 +5,11 @@ final class HeraldRuleListView private $rules; + /** + * @param array $rules + */ public function setRules(array $rules) { - assert_instances_of($rules, 'HeraldRule'); + assert_instances_of($rules, HeraldRule::class); $this->rules = $rules; return $this; } diff --git a/src/applications/herald/view/HeraldWebhookRequestListView.php b/src/applications/herald/view/HeraldWebhookRequestListView.php index 082d320bba..b45c99006e 100644 --- a/src/applications/herald/view/HeraldWebhookRequestListView.php +++ b/src/applications/herald/view/HeraldWebhookRequestListView.php @@ -6,8 +6,11 @@ final class HeraldWebhookRequestListView private $requests; private $highlightID; + /** + * @param array $requests + */ public function setRequests(array $requests) { - assert_instances_of($requests, 'HeraldWebhookRequest'); + assert_instances_of($requests, HeraldWebhookRequest::class); $this->requests = $requests; return $this; } diff --git a/src/applications/paste/query/PhabricatorPasteSearchEngine.php b/src/applications/paste/query/PhabricatorPasteSearchEngine.php index 88482b94cc..9a9dbfa0be 100644 --- a/src/applications/paste/query/PhabricatorPasteSearchEngine.php +++ b/src/applications/paste/query/PhabricatorPasteSearchEngine.php @@ -131,11 +131,16 @@ final class PhabricatorPasteSearchEngine return mpull($pastes, 'getAuthorPHID'); } + /** + * @param array $pastes + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $pastes, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($pastes, 'PhabricatorPaste'); + assert_instances_of($pastes, PhabricatorPaste::class); $viewer = $this->requireViewer(); diff --git a/src/applications/pholio/query/PholioImageQuery.php b/src/applications/pholio/query/PholioImageQuery.php index 59bf9255f8..bc64820005 100644 --- a/src/applications/pholio/query/PholioImageQuery.php +++ b/src/applications/pholio/query/PholioImageQuery.php @@ -23,8 +23,11 @@ final class PholioImageQuery return $this; } + /** + * @param array $mocks + */ public function withMocks(array $mocks) { - assert_instances_of($mocks, 'PholioMock'); + assert_instances_of($mocks, PholioMock::class); $mocks = mpull($mocks, null, 'getPHID'); $this->mocks = $mocks; @@ -74,8 +77,11 @@ final class PholioImageQuery return $where; } + /** + * @param array $images + */ protected function willFilterPage(array $images) { - assert_instances_of($images, 'PholioImage'); + assert_instances_of($images, PholioImage::class); $mock_phids = array(); foreach ($images as $image) { @@ -117,8 +123,11 @@ final class PholioImageQuery return $images; } + /** + * @param array $images + */ protected function didFilterPage(array $images) { - assert_instances_of($images, 'PholioImage'); + assert_instances_of($images, PholioImage::class); $file_phids = mpull($images, 'getFilePHID'); diff --git a/src/applications/pholio/query/PholioMockSearchEngine.php b/src/applications/pholio/query/PholioMockSearchEngine.php index e7c8a057c1..c62731b3e5 100644 --- a/src/applications/pholio/query/PholioMockSearchEngine.php +++ b/src/applications/pholio/query/PholioMockSearchEngine.php @@ -83,11 +83,16 @@ final class PholioMockSearchEngine extends PhabricatorApplicationSearchEngine { return parent::buildSavedQueryFromBuiltin($query_key); } + /** + * @param array $mocks + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $mocks, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($mocks, 'PholioMock'); + assert_instances_of($mocks, PholioMock::class); $viewer = $this->requireViewer(); $handles = $viewer->loadHandles(mpull($mocks, 'getAuthorPHID')); diff --git a/src/applications/pholio/storage/PholioImage.php b/src/applications/pholio/storage/PholioImage.php index 782f4d0d44..dcdf8b6f2e 100644 --- a/src/applications/pholio/storage/PholioImage.php +++ b/src/applications/pholio/storage/PholioImage.php @@ -70,8 +70,11 @@ final class PholioImage extends PholioDAO return (bool)$this->getMockPHID(); } + /** + * @param array $inline_comments + */ public function attachInlineComments(array $inline_comments) { - assert_instances_of($inline_comments, 'PholioTransactionComment'); + assert_instances_of($inline_comments, PholioTransactionComment::class); $this->inlineComments = $inline_comments; return $this; } diff --git a/src/applications/pholio/storage/PholioMock.php b/src/applications/pholio/storage/PholioMock.php index 9d5a0eb117..6431c8eeb5 100644 --- a/src/applications/pholio/storage/PholioMock.php +++ b/src/applications/pholio/storage/PholioMock.php @@ -78,8 +78,11 @@ final class PholioMock extends PholioDAO return PholioMockPHIDType::TYPECONST; } + /** + * @param array $images + */ public function attachImages(array $images) { - assert_instances_of($images, 'PholioImage'); + assert_instances_of($images, PholioImage::class); $images = mpull($images, null, 'getPHID'); $images = msort($images, 'getSequence'); $this->images = $images; diff --git a/src/applications/phriction/controller/PhrictionDiffController.php b/src/applications/phriction/controller/PhrictionDiffController.php index 537f743eba..e3f51c9d81 100644 --- a/src/applications/phriction/controller/PhrictionDiffController.php +++ b/src/applications/phriction/controller/PhrictionDiffController.php @@ -215,8 +215,11 @@ final class PhrictionDiffController extends PhrictionController { $label); } + /** + * @param array $content + */ private function renderComparisonTable(array $content) { - assert_instances_of($content, 'PhrictionContent'); + assert_instances_of($content, PhrictionContent::class); $viewer = $this->getViewer(); diff --git a/src/applications/phriction/query/PhrictionContentSearchEngine.php b/src/applications/phriction/query/PhrictionContentSearchEngine.php index c31ee689c0..3c8d59deef 100644 --- a/src/applications/phriction/query/PhrictionContentSearchEngine.php +++ b/src/applications/phriction/query/PhrictionContentSearchEngine.php @@ -72,11 +72,16 @@ final class PhrictionContentSearchEngine return parent::buildSavedQueryFromBuiltin($query_key); } + /** + * @param array $contents + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $contents, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($contents, 'PhrictionContent'); + assert_instances_of($contents, PhrictionContent::class); throw new PhutilMethodNotImplementedException(); } diff --git a/src/applications/phriction/query/PhrictionDocumentSearchEngine.php b/src/applications/phriction/query/PhrictionDocumentSearchEngine.php index ed90360240..52b3708d19 100644 --- a/src/applications/phriction/query/PhrictionDocumentSearchEngine.php +++ b/src/applications/phriction/query/PhrictionDocumentSearchEngine.php @@ -104,12 +104,16 @@ final class PhrictionDocumentSearchEngine return $phids; } - + /** + * @param array $documents + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $documents, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($documents, 'PhrictionDocument'); + assert_instances_of($documents, PhrictionDocument::class); $viewer = $this->requireViewer(); diff --git a/src/applications/repository/engine/PhabricatorRepositoryEngine.php b/src/applications/repository/engine/PhabricatorRepositoryEngine.php index edf54d1d2b..88856ad74b 100644 --- a/src/applications/repository/engine/PhabricatorRepositoryEngine.php +++ b/src/applications/repository/engine/PhabricatorRepositoryEngine.php @@ -124,10 +124,14 @@ abstract class PhabricatorRepositoryEngine extends Phobject { PhabricatorWorker::scheduleTask($class, $data, $options); } + /** + * @param PhabricatorRepository $repository + * @param array $refs + */ final protected function getImportTaskPriority( PhabricatorRepository $repository, array $refs) { - assert_instances_of($refs, 'PhabricatorRepositoryCommitRef'); + assert_instances_of($refs, PhabricatorRepositoryCommitRef::class); // If the repository is importing for the first time, we schedule tasks // at IMPORT priority, which is very low. Making progress on importing a diff --git a/src/applications/repository/engine/PhabricatorRepositoryRefEngine.php b/src/applications/repository/engine/PhabricatorRepositoryRefEngine.php index 6cb9f27384..db72d3173f 100644 --- a/src/applications/repository/engine/PhabricatorRepositoryRefEngine.php +++ b/src/applications/repository/engine/PhabricatorRepositoryRefEngine.php @@ -121,10 +121,14 @@ final class PhabricatorRepositoryRefEngine } } + /** + * @param PhabricatorRepository $repository + * @param array $cursors + */ private function getCursorsForUpdate( PhabricatorRepository $repository, array $cursors) { - assert_instances_of($cursors, 'PhabricatorRepositoryRefCursor'); + assert_instances_of($cursors, PhabricatorRepositoryRefCursor::class); $publisher = $repository->newPublisher(); @@ -145,11 +149,15 @@ final class PhabricatorRepositoryRefEngine return $results; } + /** + * @param PhabricatorRepository $repository + * @param array $branches + */ private function updateBranchStates( PhabricatorRepository $repository, array $branches) { - assert_instances_of($branches, 'DiffusionRepositoryRef'); + assert_instances_of($branches, DiffusionRepositoryRef::class); $viewer = $this->getViewer(); $all_cursors = id(new PhabricatorRepositoryRefCursorQuery()) diff --git a/src/applications/repository/query/PhabricatorRepositoryQuery.php b/src/applications/repository/query/PhabricatorRepositoryQuery.php index e054443962..2c916db668 100644 --- a/src/applications/repository/query/PhabricatorRepositoryQuery.php +++ b/src/applications/repository/query/PhabricatorRepositoryQuery.php @@ -234,8 +234,11 @@ final class PhabricatorRepositoryQuery return $repositories; } + /** + * @param array $repositories + */ protected function willFilterPage(array $repositories) { - assert_instances_of($repositories, 'PhabricatorRepository'); + assert_instances_of($repositories, PhabricatorRepository::class); // TODO: Denormalize repository status into the PhabricatorRepository // table so we can do this filtering in the database. diff --git a/src/applications/repository/query/PhabricatorRepositorySearchEngine.php b/src/applications/repository/query/PhabricatorRepositorySearchEngine.php index eaf5f3bad1..a229de23a9 100644 --- a/src/applications/repository/query/PhabricatorRepositorySearchEngine.php +++ b/src/applications/repository/query/PhabricatorRepositorySearchEngine.php @@ -162,11 +162,16 @@ final class PhabricatorRepositorySearchEngine return array_mergev(mpull($repositories, 'getProjectPHIDs')); } + /** + * @param array $repositories + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $repositories, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($repositories, 'PhabricatorRepository'); + assert_instances_of($repositories, PhabricatorRepository::class); $viewer = $this->requireViewer(); diff --git a/src/applications/repository/storage/PhabricatorRepository.php b/src/applications/repository/storage/PhabricatorRepository.php index 8a639a8f58..2c6dce0fd9 100644 --- a/src/applications/repository/storage/PhabricatorRepository.php +++ b/src/applications/repository/storage/PhabricatorRepository.php @@ -1954,14 +1954,20 @@ final class PhabricatorRepository extends PhabricatorRepositoryDAO return array_values($refs); } + /** + * @param array $refs + */ private function sortReadableAlmanacServiceRefs(array $refs) { - assert_instances_of($refs, 'DiffusionServiceRef'); + assert_instances_of($refs, DiffusionServiceRef::class); shuffle($refs); return $refs; } + /** + * @param array $refs + */ private function sortWritableAlmanacServiceRefs(array $refs) { - assert_instances_of($refs, 'DiffusionServiceRef'); + assert_instances_of($refs, DiffusionServiceRef::class); // See T13109 for discussion of how this method routes requests. diff --git a/src/applications/repository/storage/PhabricatorRepositoryCommit.php b/src/applications/repository/storage/PhabricatorRepositoryCommit.php index a6b3c1f3aa..49828ec3f3 100644 --- a/src/applications/repository/storage/PhabricatorRepositoryCommit.php +++ b/src/applications/repository/storage/PhabricatorRepositoryCommit.php @@ -183,8 +183,11 @@ final class PhabricatorRepositoryCommit return $this->assertAttached($this->commitData); } + /** + * @param array $audits + */ public function attachAudits(array $audits) { - assert_instances_of($audits, 'PhabricatorRepositoryAuditRequest'); + assert_instances_of($audits, PhabricatorRepositoryAuditRequest::class); $this->audits = $audits; return $this; } @@ -302,9 +305,11 @@ final class PhabricatorRepositoryCommit /** * Synchronize a commit's overall audit status with the individual audit * triggers. + * + * @param array $requests */ public function updateAuditStatus(array $requests) { - assert_instances_of($requests, 'PhabricatorRepositoryAuditRequest'); + assert_instances_of($requests, PhabricatorRepositoryAuditRequest::class); $any_concern = false; $any_accept = false; diff --git a/src/applications/repository/storage/PhabricatorRepositoryPushEvent.php b/src/applications/repository/storage/PhabricatorRepositoryPushEvent.php index c0936e9c6e..5f8867996b 100644 --- a/src/applications/repository/storage/PhabricatorRepositoryPushEvent.php +++ b/src/applications/repository/storage/PhabricatorRepositoryPushEvent.php @@ -81,8 +81,11 @@ final class PhabricatorRepositoryPushEvent return $this->assertAttached($this->logs); } + /** + * @param array $logs + */ public function saveWithLogs(array $logs) { - assert_instances_of($logs, 'PhabricatorRepositoryPushLog'); + assert_instances_of($logs, PhabricatorRepositoryPushLog::class); $this->openTransaction(); $this->save(); diff --git a/src/applications/repository/storage/PhabricatorRepositoryRefCursor.php b/src/applications/repository/storage/PhabricatorRepositoryRefCursor.php index e661e94295..337d333181 100644 --- a/src/applications/repository/storage/PhabricatorRepositoryRefCursor.php +++ b/src/applications/repository/storage/PhabricatorRepositoryRefCursor.php @@ -74,8 +74,11 @@ final class PhabricatorRepositoryRefCursor return $this->assertAttached($this->repository); } + /** + * @param array $positions + */ public function attachPositions(array $positions) { - assert_instances_of($positions, 'PhabricatorRepositoryRefPosition'); + assert_instances_of($positions, PhabricatorRepositoryRefPosition::class); $this->positions = $positions; return $this; } diff --git a/src/applications/subscriptions/view/SubscriptionListDialogBuilder.php b/src/applications/subscriptions/view/SubscriptionListDialogBuilder.php index da157848ea..d2867d748d 100644 --- a/src/applications/subscriptions/view/SubscriptionListDialogBuilder.php +++ b/src/applications/subscriptions/view/SubscriptionListDialogBuilder.php @@ -16,8 +16,11 @@ final class SubscriptionListDialogBuilder extends Phobject { return $this->viewer; } + /** + * @param array $handles + */ public function setHandles(array $handles) { - assert_instances_of($handles, 'PhabricatorObjectHandle'); + assert_instances_of($handles, PhabricatorObjectHandle::class); $this->handles = $handles; return $this; }