diff --git a/src/aphront/sink/__tests__/AphrontHTTPSinkTestCase.php b/src/aphront/sink/__tests__/AphrontHTTPSinkTestCase.php index 7858aeea31..4447dad520 100644 --- a/src/aphront/sink/__tests__/AphrontHTTPSinkTestCase.php +++ b/src/aphront/sink/__tests__/AphrontHTTPSinkTestCase.php @@ -16,7 +16,7 @@ final class AphrontHTTPSinkTestCase extends PhabricatorTestCase { } public function testHTTPSinkStatusCode() { - $input = $this->tryTestCaseMap( + $this->tryTestCaseMap( array( 200 => true, '201' => true, @@ -34,7 +34,7 @@ final class AphrontHTTPSinkTestCase extends PhabricatorTestCase { } public function testHTTPSinkResponseSplitting() { - $input = $this->tryTestCaseMap( + $this->tryTestCaseMap( array( 'test' => true, "test\nx" => false, @@ -50,7 +50,7 @@ final class AphrontHTTPSinkTestCase extends PhabricatorTestCase { } public function testHTTPHeaderNames() { - $input = $this->tryTestCaseMap( + $this->tryTestCaseMap( array( 'test' => true, 'test:' => false, diff --git a/src/applications/base/controller/PhabricatorController.php b/src/applications/base/controller/PhabricatorController.php index 3bcd48b9de..b506faea31 100644 --- a/src/applications/base/controller/PhabricatorController.php +++ b/src/applications/base/controller/PhabricatorController.php @@ -613,7 +613,7 @@ abstract class PhabricatorController extends AphrontController { // If nothing needs to be signed (either because there are no documents // which require a signature, or because the user has already signed // all of them) mark the session as good and continue. - $engine = id(new PhabricatorAuthSessionEngine()) + id(new PhabricatorAuthSessionEngine()) ->signLegalpadDocuments($viewer, $sign_docs); return null;