From 532bc04d16eb9fce0bc5f079908a36c190a850ef Mon Sep 17 00:00:00 2001 From: Andre Klapper Date: Sun, 14 Sep 2025 11:16:26 +0200 Subject: [PATCH] Improve dark mode for Tags with sky background color Summary: Replace hardcoded sky background color with a variable so it becomes possible to tweak this for Dark Mode support. Refs T15056 Test Plan: Unclear as I fail to find a place where this color is taken into account. Reviewers: O1 Blessed Committers, mainframe98 Reviewed By: O1 Blessed Committers, mainframe98 Subscribers: mainframe98, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Maniphest Tasks: T15056 Differential Revision: https://we.phorge.it/D26349 --- resources/celerity/map.php | 6 +++--- .../postprocessor/CelerityDarkModePostprocessor.php | 3 +++ .../celerity/postprocessor/CelerityDefaultPostprocessor.php | 3 +++ webroot/rsrc/css/phui/phui-tag-view.css | 2 +- 4 files changed, 10 insertions(+), 4 deletions(-) diff --git a/resources/celerity/map.php b/resources/celerity/map.php index df3e236fec..10dde1d403 100644 --- a/resources/celerity/map.php +++ b/resources/celerity/map.php @@ -9,7 +9,7 @@ return array( 'names' => array( 'conpherence.pkg.css' => 'beb13d57', 'conpherence.pkg.js' => '020aebcf', - 'core.pkg.css' => '9bba59a9', + 'core.pkg.css' => 'b29cd0cd', 'core.pkg.js' => '83580d78', 'dark-console.pkg.js' => '187792c2', 'differential.pkg.css' => '77189aae', @@ -170,7 +170,7 @@ return array( 'rsrc/css/phui/phui-segment-bar-view.css' => '5166b370', 'rsrc/css/phui/phui-spacing.css' => 'b05cadc3', 'rsrc/css/phui/phui-status.css' => '293b5dad', - 'rsrc/css/phui/phui-tag-view.css' => '8613be82', + 'rsrc/css/phui/phui-tag-view.css' => 'ef373d9a', 'rsrc/css/phui/phui-timeline-view.css' => '0277217e', 'rsrc/css/phui/phui-two-column-view.css' => '54fb9794', 'rsrc/css/phui/workboards/phui-workboard-color.css' => '27fbe0ac', @@ -825,7 +825,7 @@ return array( 'phui-segment-bar-view-css' => '5166b370', 'phui-spacing-css' => 'b05cadc3', 'phui-status-list-view-css' => '293b5dad', - 'phui-tag-view-css' => '8613be82', + 'phui-tag-view-css' => 'ef373d9a', 'phui-theme-css' => '35883b37', 'phui-timeline-view-css' => '0277217e', 'phui-two-column-view-css' => '54fb9794', diff --git a/src/applications/celerity/postprocessor/CelerityDarkModePostprocessor.php b/src/applications/celerity/postprocessor/CelerityDarkModePostprocessor.php index ed0f69b258..0a1811ff66 100644 --- a/src/applications/celerity/postprocessor/CelerityDarkModePostprocessor.php +++ b/src/applications/celerity/postprocessor/CelerityDarkModePostprocessor.php @@ -148,6 +148,9 @@ final class CelerityDarkModePostprocessor 'sh-bluetext' => '#464c5c', 'sh-bluebackground' => '#dee7f8', + // Shade Sky (mostly re-uses Blue colors above) + 'sh-skybackground' => '#e0f0fa', + // Shade Indigo 'sh-lightindigoborder' => '#d1c9ee', 'sh-indigoborder' => '#bcb4da', diff --git a/src/applications/celerity/postprocessor/CelerityDefaultPostprocessor.php b/src/applications/celerity/postprocessor/CelerityDefaultPostprocessor.php index e5b0d76f4e..2bc562609d 100644 --- a/src/applications/celerity/postprocessor/CelerityDefaultPostprocessor.php +++ b/src/applications/celerity/postprocessor/CelerityDefaultPostprocessor.php @@ -161,6 +161,9 @@ final class CelerityDefaultPostprocessor 'sh-bluetext' => '#464c5c', 'sh-bluebackground' => '#dee7f8', + // Shade Sky (mostly re-uses Blue colors above) + 'sh-skybackground' => '#e0f0fa', + // Shade Indigo 'sh-lightindigoborder' => '#d1c9ee', 'sh-indigoborder' => '#bcb4da', diff --git a/webroot/rsrc/css/phui/phui-tag-view.css b/webroot/rsrc/css/phui/phui-tag-view.css index 8d24867ce1..8ae908a702 100644 --- a/webroot/rsrc/css/phui/phui-tag-view.css +++ b/webroot/rsrc/css/phui/phui-tag-view.css @@ -285,7 +285,7 @@ a.phui-tag-view:hover.phui-tag-blue .phui-tag-core, .phui-tag-sky .phui-tag-core, .jx-tokenizer-token.sky { - background: #E0F0FA; + background: {$sh-skybackground}; border-color: {$sh-lightblueborder}; color: {$sh-bluetext}; } -- 2.51.2