From 4fd9d2d4bbdb8fb7013b5bea5e0a5ec121db526f Mon Sep 17 00:00:00 2001 From: epriestley Date: Sat, 7 Oct 2017 13:23:18 -0700 Subject: [PATCH] Fix "bin/storage dump" with no "--output" Ref T13004. (I distinctly remember testing this, but must have tweaked things afterward.) --- .../workflow/PhabricatorStorageManagementDumpWorkflow.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementDumpWorkflow.php b/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementDumpWorkflow.php index dced62eee9..17491d55e9 100644 --- a/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementDumpWorkflow.php +++ b/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementDumpWorkflow.php @@ -237,7 +237,7 @@ final class PhabricatorStorageManagementDumpWorkflow $file = fopen($output_file, 'wb'); } - if (!$file) { + if (($output_file !== null) && !$file) { throw new Exception( pht( 'Failed to open file "%s" for writing.', -- 2.51.2