From 4b529e6009285a7f8a850e6b1f35e1bc2ea4c30c Mon Sep 17 00:00:00 2001 From: epriestley Date: Fri, 12 Mar 2021 09:06:48 -0800 Subject: [PATCH] Fix a followup notification paging error with partial objects Summary: Ref T13623. In D21603, I made the "partial object" this query returns a raw row, which paging keys can no longer be extracted from properly. Test Plan: Paged notifications to page 2, no longer saw an error. Maniphest Tasks: T13623 Differential Revision: https://secure.phabricator.com/D21609 --- .../notification/query/PhabricatorNotificationQuery.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/applications/notification/query/PhabricatorNotificationQuery.php b/src/applications/notification/query/PhabricatorNotificationQuery.php index 69eb41695b..2cd97f25c8 100644 --- a/src/applications/notification/query/PhabricatorNotificationQuery.php +++ b/src/applications/notification/query/PhabricatorNotificationQuery.php @@ -181,7 +181,7 @@ final class PhabricatorNotificationQuery protected function newPagingMapFromPartialObject($object) { return array( - 'key' => $object->getChronologicalKey(), + 'key' => $object['chronologicalKey'], ); } -- 2.51.2