From 4918773afe35918b8acfbb939fceb1e5c0520231 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Thu, 17 Apr 2014 16:01:06 -0700
Subject: [PATCH] Drop nonsense buildStatus field from Buildable

Summary:
Ref T4809. Buildables currently have buildStatus and buildableStatus. Neither are used, and no one knows why we have two.

I'm going to use buildableStatus shortly, but buildStatus is meaningless; burn it.

Test Plan: `grep`, examined similar get/set calls, created a new buildable, ran storage upgrade.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T4809

Differential Revision: https://secure.phabricator.com/D8796
---
 resources/sql/autopatches/20140416.harbor.1.sql                 | 2 ++
 src/applications/harbormaster/storage/HarbormasterBuildable.php | 2 --
 2 files changed, 2 insertions(+), 2 deletions(-)
 create mode 100644 resources/sql/autopatches/20140416.harbor.1.sql

diff --git a/resources/sql/autopatches/20140416.harbor.1.sql b/resources/sql/autopatches/20140416.harbor.1.sql
new file mode 100644
index 0000000000..0cc30cfdf1
--- /dev/null
+++ b/resources/sql/autopatches/20140416.harbor.1.sql
@@ -0,0 +1,2 @@
+ALTER TABLE {$NAMESPACE}_harbormaster.harbormaster_buildable
+  DROP buildStatus;
diff --git a/src/applications/harbormaster/storage/HarbormasterBuildable.php b/src/applications/harbormaster/storage/HarbormasterBuildable.php
index 8fbf7a0dd0..c990b003b9 100644
--- a/src/applications/harbormaster/storage/HarbormasterBuildable.php
+++ b/src/applications/harbormaster/storage/HarbormasterBuildable.php
@@ -7,7 +7,6 @@ final class HarbormasterBuildable extends HarbormasterDAO
 
   protected $buildablePHID;
   protected $containerPHID;
-  protected $buildStatus;
   protected $buildableStatus;
   protected $isManualBuildable;
 
@@ -22,7 +21,6 @@ final class HarbormasterBuildable extends HarbormasterDAO
   public static function initializeNewBuildable(PhabricatorUser $actor) {
     return id(new HarbormasterBuildable())
       ->setIsManualBuildable(0)
-      ->setBuildStatus(self::STATUS_WHATEVER)
       ->setBuildableStatus(self::STATUS_WHATEVER);
   }
 
-- 
2.51.2