From 456ba873ca018789fa49c06e7a4434c369d77a16 Mon Sep 17 00:00:00 2001
From: Andre Klapper <a9016009@gmx.de>
Date: Sun, 30 Apr 2023 15:14:36 +0200
Subject: [PATCH] Fix PHP 8.1 "strlen(null)" exceptions which block rendering
 the "Add Panel to Dashboard" overlay dialog

Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15305

Test Plan:
Applied these two changes (on top of `D25144`, `D25145`, `D25146`, `D25147`, `D25150`,
`D25151`, `D25152`, `D25153`, `D25154`)) and "Use Results -> Add Panel to Dashboard"
overlay dialog finally rendered in web browser.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15305

Differential Revision: https://we.phorge.it/D25155
---
 .../PhabricatorDashboardQueryPanelInstallController.php       | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/applications/dashboard/controller/PhabricatorDashboardQueryPanelInstallController.php b/src/applications/dashboard/controller/PhabricatorDashboardQueryPanelInstallController.php
index a229fcb41c..845ce9ee06 100644
--- a/src/applications/dashboard/controller/PhabricatorDashboardQueryPanelInstallController.php
+++ b/src/applications/dashboard/controller/PhabricatorDashboardQueryPanelInstallController.php
@@ -13,12 +13,12 @@ final class PhabricatorDashboardQueryPanelInstallController
     $e_name = true;
 
     $v_engine = $request->getStr('engine');
-    if (!strlen($v_engine)) {
+    if (!phutil_nonempty_string($v_engine)) {
       $v_engine = $request->getURIData('engineKey');
     }
 
     $v_query = $request->getStr('query');
-    if (!strlen($v_query)) {
+    if (!phutil_nonempty_string($v_query)) {
       $v_query = $request->getURIData('queryKey');
     }
 
-- 
2.51.2