From 44c7bfb42ddfe5dedad3d6ae905aae598db1d66c Mon Sep 17 00:00:00 2001 From: Andre Klapper Date: Fri, 21 Feb 2025 13:42:52 +0100 Subject: [PATCH] Include number of modified files in total of attached files Summary: The second parameter in the message `%s updated %s attached file(s), added %s: %s; removed %s: %s; modified %s: %s.` did not take the number of modified files into account but only added and removed files. Closes T15959 Test Plan: Read the code. Additionally, update and remove and modify files attached to a task and count. Reviewers: O1 Blessed Committers, valerio.bozzolan Reviewed By: O1 Blessed Committers, valerio.bozzolan Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Maniphest Tasks: T15959 Differential Revision: https://we.phorge.it/D25892 --- .../transactions/storage/PhabricatorApplicationTransaction.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/applications/transactions/storage/PhabricatorApplicationTransaction.php b/src/applications/transactions/storage/PhabricatorApplicationTransaction.php index ccf279e416..25f20cda17 100644 --- a/src/applications/transactions/storage/PhabricatorApplicationTransaction.php +++ b/src/applications/transactions/storage/PhabricatorApplicationTransaction.php @@ -1118,7 +1118,7 @@ abstract class PhabricatorApplicationTransaction '%s updated %s attached file(s), added %s: %s; removed %s: %s; '. 'modified %s: %s.', $this->renderHandleLink($author_phid), - new PhutilNumber(count($add) + count($rem)), + new PhutilNumber(count($add) + count($rem) + count($mod)), phutil_count($add), $this->renderHandleList($add), phutil_count($rem), -- 2.51.2