From 422b2f2b891e200f2f8b21bb185ba6ee3cf8b369 Mon Sep 17 00:00:00 2001
From: Joshua Spence <josh@joshuaspence.com>
Date: Fri, 2 Jan 2015 09:50:30 +1100
Subject: [PATCH] Remove deprecated `maniphest.find` Conduit method

Summary: This method has been deprecated for a long time (see D2887 and D6336).

Test Plan:
```lang=bash
> echo '{}' | arc --conduit-uri=http://phabricator.local call-conduit 'maniphest.find'
Waiting for JSON parameters on stdin...
{"error":"ERR-CONDUIT-CALL","errorMessage":"ERR-CONDUIT-CALL: ","response":null}
```

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D11117
---
 src/__phutil_library_map__.php                |  2 --
 .../conduit/ManiphestFindConduitAPIMethod.php | 25 -------------------
 .../ManiphestQueryConduitAPIMethod.php        |  7 +-----
 3 files changed, 1 insertion(+), 33 deletions(-)
 delete mode 100644 src/applications/maniphest/conduit/ManiphestFindConduitAPIMethod.php

diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php
index 142377c23d..e9769669e7 100644
--- a/src/__phutil_library_map__.php
+++ b/src/__phutil_library_map__.php
@@ -1005,7 +1005,6 @@ phutil_register_library_map(array(
     'ManiphestExcelDefaultFormat' => 'applications/maniphest/export/ManiphestExcelDefaultFormat.php',
     'ManiphestExcelFormat' => 'applications/maniphest/export/ManiphestExcelFormat.php',
     'ManiphestExportController' => 'applications/maniphest/controller/ManiphestExportController.php',
-    'ManiphestFindConduitAPIMethod' => 'applications/maniphest/conduit/ManiphestFindConduitAPIMethod.php',
     'ManiphestGetTaskTransactionsConduitAPIMethod' => 'applications/maniphest/conduit/ManiphestGetTaskTransactionsConduitAPIMethod.php',
     'ManiphestHovercardEventListener' => 'applications/maniphest/event/ManiphestHovercardEventListener.php',
     'ManiphestInfoConduitAPIMethod' => 'applications/maniphest/conduit/ManiphestInfoConduitAPIMethod.php',
@@ -4116,7 +4115,6 @@ phutil_register_library_map(array(
     'ManiphestEditStatusCapability' => 'PhabricatorPolicyCapability',
     'ManiphestExcelDefaultFormat' => 'ManiphestExcelFormat',
     'ManiphestExportController' => 'ManiphestController',
-    'ManiphestFindConduitAPIMethod' => 'ManiphestQueryConduitAPIMethod',
     'ManiphestGetTaskTransactionsConduitAPIMethod' => 'ManiphestConduitAPIMethod',
     'ManiphestHovercardEventListener' => 'PhabricatorEventListener',
     'ManiphestInfoConduitAPIMethod' => 'ManiphestConduitAPIMethod',
diff --git a/src/applications/maniphest/conduit/ManiphestFindConduitAPIMethod.php b/src/applications/maniphest/conduit/ManiphestFindConduitAPIMethod.php
deleted file mode 100644
index 6bdeed26f6..0000000000
--- a/src/applications/maniphest/conduit/ManiphestFindConduitAPIMethod.php
+++ /dev/null
@@ -1,25 +0,0 @@
-<?php
-
-/**
- * @concrete-extensible
- */
-final class ManiphestFindConduitAPIMethod
-  extends ManiphestQueryConduitAPIMethod {
-
-  public function getAPIMethodName() {
-    return 'maniphest.find';
-  }
-
-  public function getMethodStatus() {
-    return self::METHOD_STATUS_DEPRECATED;
-  }
-
-  public function getMethodStatusDescription() {
-    return "Renamed to 'maniphest.query'.";
-  }
-
-  public function getMethodDescription() {
-    return 'Deprecated alias of maniphest.query';
-  }
-
-}
diff --git a/src/applications/maniphest/conduit/ManiphestQueryConduitAPIMethod.php b/src/applications/maniphest/conduit/ManiphestQueryConduitAPIMethod.php
index 3375f30e5a..6c850b8630 100644
--- a/src/applications/maniphest/conduit/ManiphestQueryConduitAPIMethod.php
+++ b/src/applications/maniphest/conduit/ManiphestQueryConduitAPIMethod.php
@@ -1,11 +1,6 @@
 <?php
 
-/**
- * TODO: Remove maniphest.find, then make this final.
- *
- * @concrete-extensible
- */
-class ManiphestQueryConduitAPIMethod extends ManiphestConduitAPIMethod {
+final class ManiphestQueryConduitAPIMethod extends ManiphestConduitAPIMethod {
 
   public function getAPIMethodName() {
     return 'maniphest.query';
-- 
2.51.2