From 3f49ac5b484c52144ef396f7856dd8e8a86fdda6 Mon Sep 17 00:00:00 2001 From: Andre Klapper Date: Tue, 29 Apr 2025 14:26:42 +0300 Subject: [PATCH] PHPDoc: Correct syntax of variadic function params Summary: PHPDoc standardized syntax for variadic function parameters in https://github.com/phpDocumentor/phpDocumentor/issues/629. Thus follow that syntax. Test Plan: * Check that Phorge docs still render as before: grep for `...` within src/applications/diviner, see that the only result writes and does not read * Run `./bin/diviner generate --clean`, see that "Loading Objects" section on http://phorge.localhost/book/dev/class/LiskDAO/ looks the same before and after * Run static code analysis, get no more parse errors which mention `...` Reviewers: O1 Blessed Committers, valerio.bozzolan Reviewed By: O1 Blessed Committers, valerio.bozzolan Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Differential Revision: https://we.phorge.it/D25980 --- src/infrastructure/storage/lisk/LiskDAO.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/infrastructure/storage/lisk/LiskDAO.php b/src/infrastructure/storage/lisk/LiskDAO.php index 75363b113d..915b98d61d 100644 --- a/src/infrastructure/storage/lisk/LiskDAO.php +++ b/src/infrastructure/storage/lisk/LiskDAO.php @@ -469,7 +469,7 @@ abstract class LiskDAO extends Phobject * The pattern and arguments are as per queryfx(). * * @param string $pattern queryfx()-style SQL WHERE clause. - * @param ... Zero or more conversions. + * @param mixed $args,... Zero or more conversions. * @return dict Dictionary of matching objects, keyed on ID. * * @task load @@ -490,7 +490,7 @@ abstract class LiskDAO extends Phobject * result instead of a list. * * @param string $pattern queryfx()-style SQL WHERE clause. - * @param ... Zero or more conversions. + * @param mixed $args,... Zero or more conversions. * @return object|null Matching object, or null if no object matches. * * @task load -- 2.51.2