From 3aa4c91aedd62c4c4d098412ad11f718301f9e5e Mon Sep 17 00:00:00 2001 From: Andre Klapper Date: Mon, 20 Oct 2025 14:30:12 +0200 Subject: [PATCH] Conduit: Convert nearly all unstable methods to stable Summary: All these "unstable" Conduit API methods have had this status for at least ten years now. Thus in reality they are neither new, nor subject to any planned changes, nor have they actually been "unstable" over the last years. Thus remove the `getMethodStatus()` functions returning `METHOD_STATUS_UNSTABLE` from them. Per their parent class, `getMethodStatus()` returns `METHOD_STATUS_STABLE` when not overwritten. Exclude `NuanceConduitAPIMethod` from this patch, as that application is a prototype and thus unstable. Closes T16313 Test Plan: Go to one of those endpoints, e.g. http://phorge.localhost/conduit/method/macro.creatememe/, and do not see anymore `Stability - Unstable Method: This method is new and unstable. Its interface is subject to change.` Reviewers: O1 Blessed Committers, avivey Reviewed By: O1 Blessed Committers, avivey Subscribers: avivey, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Maniphest Tasks: T16313 Differential Revision: https://we.phorge.it/D26440 --- .../auth/conduit/PhabricatorAuthConduitAPIMethod.php | 4 ---- .../conduit/DiffusionGetLintMessagesConduitAPIMethod.php | 4 ---- .../diffusion/conduit/DiffusionLookSoonConduitAPIMethod.php | 4 ---- .../conduit/DiffusionUpdateCoverageConduitAPIMethod.php | 4 ---- src/applications/feed/conduit/FeedQueryConduitAPIMethod.php | 4 ---- .../macro/conduit/MacroCreateMemeConduitAPIMethod.php | 4 ---- .../phrequent/conduit/PhrequentPopConduitAPIMethod.php | 4 ---- .../phrequent/conduit/PhrequentPushConduitAPIMethod.php | 4 ---- .../phrequent/conduit/PhrequentTrackingConduitAPIMethod.php | 4 ---- .../remarkup/conduit/RemarkupProcessConduitAPIMethod.php | 4 ---- src/applications/tokens/conduit/TokenConduitAPIMethod.php | 4 ---- 11 files changed, 44 deletions(-) diff --git a/src/applications/auth/conduit/PhabricatorAuthConduitAPIMethod.php b/src/applications/auth/conduit/PhabricatorAuthConduitAPIMethod.php index 86b3f7634e..0c8f58e0f7 100644 --- a/src/applications/auth/conduit/PhabricatorAuthConduitAPIMethod.php +++ b/src/applications/auth/conduit/PhabricatorAuthConduitAPIMethod.php @@ -7,10 +7,6 @@ abstract class PhabricatorAuthConduitAPIMethod extends ConduitAPIMethod { PhabricatorAuthApplication::class); } - public function getMethodStatus() { - return self::METHOD_STATUS_UNSTABLE; - } - public function getMethodStatusDescription() { return pht('These methods are recently introduced and subject to change.'); } diff --git a/src/applications/diffusion/conduit/DiffusionGetLintMessagesConduitAPIMethod.php b/src/applications/diffusion/conduit/DiffusionGetLintMessagesConduitAPIMethod.php index cc7cb4a095..bc21e0dafa 100644 --- a/src/applications/diffusion/conduit/DiffusionGetLintMessagesConduitAPIMethod.php +++ b/src/applications/diffusion/conduit/DiffusionGetLintMessagesConduitAPIMethod.php @@ -7,10 +7,6 @@ final class DiffusionGetLintMessagesConduitAPIMethod return 'diffusion.getlintmessages'; } - public function getMethodStatus() { - return self::METHOD_STATUS_UNSTABLE; - } - public function getMethodDescription() { return pht('Get lint messages for existing code.'); } diff --git a/src/applications/diffusion/conduit/DiffusionLookSoonConduitAPIMethod.php b/src/applications/diffusion/conduit/DiffusionLookSoonConduitAPIMethod.php index 4d651b4e52..61bebe1596 100644 --- a/src/applications/diffusion/conduit/DiffusionLookSoonConduitAPIMethod.php +++ b/src/applications/diffusion/conduit/DiffusionLookSoonConduitAPIMethod.php @@ -7,10 +7,6 @@ final class DiffusionLookSoonConduitAPIMethod return 'diffusion.looksoon'; } - public function getMethodStatus() { - return self::METHOD_STATUS_UNSTABLE; - } - public function getMethodDescription() { return pht( 'Advises this server to look for new commits in a repository as soon '. diff --git a/src/applications/diffusion/conduit/DiffusionUpdateCoverageConduitAPIMethod.php b/src/applications/diffusion/conduit/DiffusionUpdateCoverageConduitAPIMethod.php index 256d023345..3ae60c68eb 100644 --- a/src/applications/diffusion/conduit/DiffusionUpdateCoverageConduitAPIMethod.php +++ b/src/applications/diffusion/conduit/DiffusionUpdateCoverageConduitAPIMethod.php @@ -7,10 +7,6 @@ final class DiffusionUpdateCoverageConduitAPIMethod return 'diffusion.updatecoverage'; } - public function getMethodStatus() { - return self::METHOD_STATUS_UNSTABLE; - } - public function getMethodDescription() { return pht('Publish coverage information for a repository.'); } diff --git a/src/applications/feed/conduit/FeedQueryConduitAPIMethod.php b/src/applications/feed/conduit/FeedQueryConduitAPIMethod.php index 53f3fe8f39..dfd265f006 100644 --- a/src/applications/feed/conduit/FeedQueryConduitAPIMethod.php +++ b/src/applications/feed/conduit/FeedQueryConduitAPIMethod.php @@ -6,10 +6,6 @@ final class FeedQueryConduitAPIMethod extends FeedConduitAPIMethod { return 'feed.query'; } - public function getMethodStatus() { - return self::METHOD_STATUS_UNSTABLE; - } - public function getMethodDescription() { return pht('Query the feed for stories'); } diff --git a/src/applications/macro/conduit/MacroCreateMemeConduitAPIMethod.php b/src/applications/macro/conduit/MacroCreateMemeConduitAPIMethod.php index 3c939f97d5..c0c25c840a 100644 --- a/src/applications/macro/conduit/MacroCreateMemeConduitAPIMethod.php +++ b/src/applications/macro/conduit/MacroCreateMemeConduitAPIMethod.php @@ -6,10 +6,6 @@ final class MacroCreateMemeConduitAPIMethod extends MacroConduitAPIMethod { return 'macro.creatememe'; } - public function getMethodStatus() { - return self::METHOD_STATUS_UNSTABLE; - } - public function getMethodDescription() { return pht('Generate a meme.'); } diff --git a/src/applications/phrequent/conduit/PhrequentPopConduitAPIMethod.php b/src/applications/phrequent/conduit/PhrequentPopConduitAPIMethod.php index 59b11bbbdc..364b72a74f 100644 --- a/src/applications/phrequent/conduit/PhrequentPopConduitAPIMethod.php +++ b/src/applications/phrequent/conduit/PhrequentPopConduitAPIMethod.php @@ -10,10 +10,6 @@ final class PhrequentPopConduitAPIMethod extends PhrequentConduitAPIMethod { return pht('Stop tracking time on an object by popping it from the stack.'); } - public function getMethodStatus() { - return self::METHOD_STATUS_UNSTABLE; - } - protected function defineParamTypes() { return array( 'objectPHID' => 'phid', diff --git a/src/applications/phrequent/conduit/PhrequentPushConduitAPIMethod.php b/src/applications/phrequent/conduit/PhrequentPushConduitAPIMethod.php index 1095aeab0d..c6a39cd3c1 100644 --- a/src/applications/phrequent/conduit/PhrequentPushConduitAPIMethod.php +++ b/src/applications/phrequent/conduit/PhrequentPushConduitAPIMethod.php @@ -12,10 +12,6 @@ final class PhrequentPushConduitAPIMethod extends PhrequentConduitAPIMethod { 'pushing it on the tracking stack.'); } - public function getMethodStatus() { - return self::METHOD_STATUS_UNSTABLE; - } - protected function defineParamTypes() { return array( 'objectPHID' => 'required phid', diff --git a/src/applications/phrequent/conduit/PhrequentTrackingConduitAPIMethod.php b/src/applications/phrequent/conduit/PhrequentTrackingConduitAPIMethod.php index 4f73019544..3cceac2a74 100644 --- a/src/applications/phrequent/conduit/PhrequentTrackingConduitAPIMethod.php +++ b/src/applications/phrequent/conduit/PhrequentTrackingConduitAPIMethod.php @@ -11,10 +11,6 @@ final class PhrequentTrackingConduitAPIMethod return pht('Returns current objects being tracked in Phrequent.'); } - public function getMethodStatus() { - return self::METHOD_STATUS_UNSTABLE; - } - protected function defineParamTypes() { return array(); } diff --git a/src/applications/remarkup/conduit/RemarkupProcessConduitAPIMethod.php b/src/applications/remarkup/conduit/RemarkupProcessConduitAPIMethod.php index ae181f9860..6807bbdc42 100644 --- a/src/applications/remarkup/conduit/RemarkupProcessConduitAPIMethod.php +++ b/src/applications/remarkup/conduit/RemarkupProcessConduitAPIMethod.php @@ -6,10 +6,6 @@ final class RemarkupProcessConduitAPIMethod extends ConduitAPIMethod { return 'remarkup.process'; } - public function getMethodStatus() { - return self::METHOD_STATUS_UNSTABLE; - } - public function getMethodDescription() { return pht('Process text through remarkup.'); } diff --git a/src/applications/tokens/conduit/TokenConduitAPIMethod.php b/src/applications/tokens/conduit/TokenConduitAPIMethod.php index bf218d0797..d72dac0e62 100644 --- a/src/applications/tokens/conduit/TokenConduitAPIMethod.php +++ b/src/applications/tokens/conduit/TokenConduitAPIMethod.php @@ -7,10 +7,6 @@ abstract class TokenConduitAPIMethod extends ConduitAPIMethod { PhabricatorTokensApplication::class); } - public function getMethodStatus() { - return self::METHOD_STATUS_UNSTABLE; - } - /** * @param array $tokens */ -- 2.51.2