From 376697903bf22c630021a4f6409381880a4dbd29 Mon Sep 17 00:00:00 2001 From: Andre Klapper Date: Tue, 13 Jan 2026 05:46:32 +0100 Subject: [PATCH] PHP 8.5: Avoid PhpStan warning about possible null array key in PhabricatorApplicationTransactionView Summary: Setting null as an array key is deprecated since PHP 8.5 per https://www.php.net/releases/8.5/en.php: "Using null as an array offset or when calling array_key_exists() is now deprecated. Use an empty string instead." Test Plan: Run static code analysis: ``` /src/applications/transactions/view/PhabricatorApplicationTransactionView.php:372 Possibly invalid array key type int|string|null. ``` Reviewers: O1 Blessed Committers, valerio.bozzolan Reviewed By: O1 Blessed Committers, valerio.bozzolan Subscribers: mainframe98, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Differential Revision: https://we.phorge.it/D26679 --- .../transactions/view/PhabricatorApplicationTransactionView.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/applications/transactions/view/PhabricatorApplicationTransactionView.php b/src/applications/transactions/view/PhabricatorApplicationTransactionView.php index d591f9e38c..1162cd6f75 100644 --- a/src/applications/transactions/view/PhabricatorApplicationTransactionView.php +++ b/src/applications/transactions/view/PhabricatorApplicationTransactionView.php @@ -365,7 +365,7 @@ class PhabricatorApplicationTransactionView extends AphrontView { private function groupRelatedTransactions(array $xactions) { $last = null; - $last_key = null; + $last_key = ''; $groups = array(); foreach ($xactions as $key => $xaction) { if ($last && $this->shouldGroupTransactions($last, $xaction)) { -- 2.51.2