From 309b9aba7bac588e0cee673120424b17f38be063 Mon Sep 17 00:00:00 2001 From: Andre Klapper Date: Sat, 13 Sep 2025 21:37:33 +0200 Subject: [PATCH] Replace some manual class name strings with ::class keyword Summary: Replace classname strings in `PhabricatorApplicationQuery->withClasses()` call parameter with the corresponding `::class` keyword. This will enable static code analysis to throw "Class not found" if such a class did not exist. `::class` is available since PHP 5.5: https://www.php.net/manual/en/language.oop5.basic.php#language.oop5.basic.class.class `::class` returns the fully qualified classname including namespace, however we do not use PHP namespaces except in imported external libraries. Refs T15158 Test Plan: Browse random Phorge pages? Reviewers: O1 Blessed Committers, mainframe98 Reviewed By: O1 Blessed Committers, mainframe98 Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Maniphest Tasks: T15158 Differential Revision: https://we.phorge.it/D26347 --- src/applications/badges/storage/PhabricatorBadgesBadge.php | 2 +- src/applications/calendar/storage/PhabricatorCalendarEvent.php | 2 +- src/applications/countdown/storage/PhabricatorCountdown.php | 2 +- src/applications/differential/storage/DifferentialDiff.php | 2 +- src/applications/differential/storage/DifferentialRevision.php | 2 +- src/applications/drydock/storage/DrydockBlueprint.php | 2 +- .../PhabricatorFavoritesMainMenuBarExtension.php | 2 +- src/applications/files/storage/PhabricatorFile.php | 2 +- src/applications/fund/storage/FundInitiative.php | 2 +- .../storage/configuration/HarbormasterBuildPlan.php | 2 +- src/applications/legalpad/storage/LegalpadDocument.php | 2 +- src/applications/maniphest/storage/ManiphestTask.php | 2 +- src/applications/nuance/storage/NuanceSource.php | 2 +- src/applications/owners/storage/PhabricatorOwnersPackage.php | 2 +- .../packages/storage/PhabricatorPackagesPackage.php | 2 +- .../packages/storage/PhabricatorPackagesPublisher.php | 2 +- src/applications/passphrase/storage/PassphraseCredential.php | 2 +- src/applications/paste/storage/PhabricatorPaste.php | 2 +- src/applications/pholio/storage/PholioMock.php | 2 +- src/applications/phurl/storage/PhabricatorPhurlURL.php | 2 +- src/applications/ponder/storage/PonderAnswer.php | 2 +- src/applications/ponder/storage/PonderQuestion.php | 2 +- src/applications/project/storage/PhabricatorProject.php | 2 +- src/applications/repository/storage/PhabricatorRepository.php | 2 +- src/applications/slowvote/storage/PhabricatorSlowvotePoll.php | 2 +- src/applications/spaces/storage/PhabricatorSpacesNamespace.php | 2 +- src/applications/tokens/storage/PhabricatorTokensToken.php | 2 +- 27 files changed, 27 insertions(+), 27 deletions(-) diff --git a/src/applications/badges/storage/PhabricatorBadgesBadge.php b/src/applications/badges/storage/PhabricatorBadgesBadge.php index 2fc787d9ee..1d80e0220f 100644 --- a/src/applications/badges/storage/PhabricatorBadgesBadge.php +++ b/src/applications/badges/storage/PhabricatorBadgesBadge.php @@ -35,7 +35,7 @@ final class PhabricatorBadgesBadge extends PhabricatorBadgesDAO public static function initializeNewBadge(PhabricatorUser $actor) { $app = id(new PhabricatorApplicationQuery()) ->setViewer($actor) - ->withClasses(array('PhabricatorBadgesApplication')) + ->withClasses(array(PhabricatorBadgesApplication::class)) ->executeOne(); $view_policy = PhabricatorPolicies::getMostOpenPolicy(); diff --git a/src/applications/calendar/storage/PhabricatorCalendarEvent.php b/src/applications/calendar/storage/PhabricatorCalendarEvent.php index e3adc73dd0..63448b045f 100644 --- a/src/applications/calendar/storage/PhabricatorCalendarEvent.php +++ b/src/applications/calendar/storage/PhabricatorCalendarEvent.php @@ -60,7 +60,7 @@ final class PhabricatorCalendarEvent extends PhabricatorCalendarDAO public static function initializeNewCalendarEvent(PhabricatorUser $actor) { $app = id(new PhabricatorApplicationQuery()) ->setViewer($actor) - ->withClasses(array('PhabricatorCalendarApplication')) + ->withClasses(array(PhabricatorCalendarApplication::class)) ->executeOne(); $view_default = PhabricatorCalendarEventDefaultViewCapability::CAPABILITY; diff --git a/src/applications/countdown/storage/PhabricatorCountdown.php b/src/applications/countdown/storage/PhabricatorCountdown.php index 1c61ae7ffc..6e7684f967 100644 --- a/src/applications/countdown/storage/PhabricatorCountdown.php +++ b/src/applications/countdown/storage/PhabricatorCountdown.php @@ -24,7 +24,7 @@ final class PhabricatorCountdown extends PhabricatorCountdownDAO public static function initializeNewCountdown(PhabricatorUser $actor) { $app = id(new PhabricatorApplicationQuery()) ->setViewer($actor) - ->withClasses(array('PhabricatorCountdownApplication')) + ->withClasses(array(PhabricatorCountdownApplication::class)) ->executeOne(); $view_policy = $app->getPolicy( diff --git a/src/applications/differential/storage/DifferentialDiff.php b/src/applications/differential/storage/DifferentialDiff.php index c749b2c272..835e656976 100644 --- a/src/applications/differential/storage/DifferentialDiff.php +++ b/src/applications/differential/storage/DifferentialDiff.php @@ -140,7 +140,7 @@ final class DifferentialDiff public static function initializeNewDiff(PhabricatorUser $actor) { $app = id(new PhabricatorApplicationQuery()) ->setViewer($actor) - ->withClasses(array('PhabricatorDifferentialApplication')) + ->withClasses(array(PhabricatorDifferentialApplication::class)) ->executeOne(); $view_policy = $app->getPolicy( DifferentialDefaultViewCapability::CAPABILITY); diff --git a/src/applications/differential/storage/DifferentialRevision.php b/src/applications/differential/storage/DifferentialRevision.php index b31614ab66..226dc8d998 100644 --- a/src/applications/differential/storage/DifferentialRevision.php +++ b/src/applications/differential/storage/DifferentialRevision.php @@ -67,7 +67,7 @@ final class DifferentialRevision extends DifferentialDAO public static function initializeNewRevision(PhabricatorUser $actor) { $app = id(new PhabricatorApplicationQuery()) ->setViewer($actor) - ->withClasses(array('PhabricatorDifferentialApplication')) + ->withClasses(array(PhabricatorDifferentialApplication::class)) ->executeOne(); $view_policy = $app->getPolicy( diff --git a/src/applications/drydock/storage/DrydockBlueprint.php b/src/applications/drydock/storage/DrydockBlueprint.php index ebe2f9f601..e0a2276576 100644 --- a/src/applications/drydock/storage/DrydockBlueprint.php +++ b/src/applications/drydock/storage/DrydockBlueprint.php @@ -27,7 +27,7 @@ final class DrydockBlueprint extends DrydockDAO public static function initializeNewBlueprint(PhabricatorUser $actor) { $app = id(new PhabricatorApplicationQuery()) ->setViewer($actor) - ->withClasses(array('PhabricatorDrydockApplication')) + ->withClasses(array(PhabricatorDrydockApplication::class)) ->executeOne(); $view_policy = $app->getPolicy( diff --git a/src/applications/favorites/engineextension/PhabricatorFavoritesMainMenuBarExtension.php b/src/applications/favorites/engineextension/PhabricatorFavoritesMainMenuBarExtension.php index a6cd4fc069..2af35f1f79 100644 --- a/src/applications/favorites/engineextension/PhabricatorFavoritesMainMenuBarExtension.php +++ b/src/applications/favorites/engineextension/PhabricatorFavoritesMainMenuBarExtension.php @@ -41,7 +41,7 @@ final class PhabricatorFavoritesMainMenuBarExtension private function newDropdown(PhabricatorUser $viewer) { $applications = id(new PhabricatorApplicationQuery()) ->setViewer($viewer) - ->withClasses(array('PhabricatorFavoritesApplication')) + ->withClasses(array(PhabricatorFavoritesApplication::class)) ->withInstalled(true) ->execute(); $favorites = head($applications); diff --git a/src/applications/files/storage/PhabricatorFile.php b/src/applications/files/storage/PhabricatorFile.php index 46cdfee1c9..89fb879d88 100644 --- a/src/applications/files/storage/PhabricatorFile.php +++ b/src/applications/files/storage/PhabricatorFile.php @@ -74,7 +74,7 @@ final class PhabricatorFile extends PhabricatorFileDAO public static function initializeNewFile() { $app = id(new PhabricatorApplicationQuery()) ->setViewer(PhabricatorUser::getOmnipotentUser()) - ->withClasses(array('PhabricatorFilesApplication')) + ->withClasses(array(PhabricatorFilesApplication::class)) ->executeOne(); $view_policy = $app->getPolicy( diff --git a/src/applications/fund/storage/FundInitiative.php b/src/applications/fund/storage/FundInitiative.php index 7503083c23..37c12c6b21 100644 --- a/src/applications/fund/storage/FundInitiative.php +++ b/src/applications/fund/storage/FundInitiative.php @@ -38,7 +38,7 @@ final class FundInitiative extends FundDAO public static function initializeNewInitiative(PhabricatorUser $actor) { $app = id(new PhabricatorApplicationQuery()) ->setViewer($actor) - ->withClasses(array('PhabricatorFundApplication')) + ->withClasses(array(PhabricatorFundApplication::class)) ->executeOne(); $view_policy = $app->getPolicy(FundDefaultViewCapability::CAPABILITY); diff --git a/src/applications/harbormaster/storage/configuration/HarbormasterBuildPlan.php b/src/applications/harbormaster/storage/configuration/HarbormasterBuildPlan.php index 798201f490..0fc516264e 100644 --- a/src/applications/harbormaster/storage/configuration/HarbormasterBuildPlan.php +++ b/src/applications/harbormaster/storage/configuration/HarbormasterBuildPlan.php @@ -28,7 +28,7 @@ final class HarbormasterBuildPlan extends HarbormasterDAO public static function initializeNewBuildPlan(PhabricatorUser $actor) { $app = id(new PhabricatorApplicationQuery()) ->setViewer($actor) - ->withClasses(array('PhabricatorHarbormasterApplication')) + ->withClasses(array(PhabricatorHarbormasterApplication::class)) ->executeOne(); $view_policy = $app->getPolicy( diff --git a/src/applications/legalpad/storage/LegalpadDocument.php b/src/applications/legalpad/storage/LegalpadDocument.php index f501c69611..f58defed87 100644 --- a/src/applications/legalpad/storage/LegalpadDocument.php +++ b/src/applications/legalpad/storage/LegalpadDocument.php @@ -33,7 +33,7 @@ final class LegalpadDocument extends LegalpadDAO public static function initializeNewDocument(PhabricatorUser $actor) { $app = id(new PhabricatorApplicationQuery()) ->setViewer($actor) - ->withClasses(array('PhabricatorLegalpadApplication')) + ->withClasses(array(PhabricatorLegalpadApplication::class)) ->executeOne(); $view_policy = $app->getPolicy(LegalpadDefaultViewCapability::CAPABILITY); diff --git a/src/applications/maniphest/storage/ManiphestTask.php b/src/applications/maniphest/storage/ManiphestTask.php index 6bd9b40f40..6638c5368b 100644 --- a/src/applications/maniphest/storage/ManiphestTask.php +++ b/src/applications/maniphest/storage/ManiphestTask.php @@ -57,7 +57,7 @@ final class ManiphestTask extends ManiphestDAO public static function initializeNewTask(PhabricatorUser $actor) { $app = id(new PhabricatorApplicationQuery()) ->setViewer($actor) - ->withClasses(array('PhabricatorManiphestApplication')) + ->withClasses(array(PhabricatorManiphestApplication::class)) ->executeOne(); $view_policy = $app->getPolicy(ManiphestDefaultViewCapability::CAPABILITY); diff --git a/src/applications/nuance/storage/NuanceSource.php b/src/applications/nuance/storage/NuanceSource.php index 5e06a5dc0a..7c08d6641b 100644 --- a/src/applications/nuance/storage/NuanceSource.php +++ b/src/applications/nuance/storage/NuanceSource.php @@ -57,7 +57,7 @@ final class NuanceSource extends NuanceDAO NuanceSourceDefinition $definition) { $app = id(new PhabricatorApplicationQuery()) ->setViewer($actor) - ->withClasses(array('PhabricatorNuanceApplication')) + ->withClasses(array(PhabricatorNuanceApplication::class)) ->executeOne(); $view_policy = $app->getPolicy( diff --git a/src/applications/owners/storage/PhabricatorOwnersPackage.php b/src/applications/owners/storage/PhabricatorOwnersPackage.php index 7e58d586b2..d8c2720d80 100644 --- a/src/applications/owners/storage/PhabricatorOwnersPackage.php +++ b/src/applications/owners/storage/PhabricatorOwnersPackage.php @@ -50,7 +50,7 @@ final class PhabricatorOwnersPackage public static function initializeNewPackage(PhabricatorUser $actor) { $app = id(new PhabricatorApplicationQuery()) ->setViewer($actor) - ->withClasses(array('PhabricatorOwnersApplication')) + ->withClasses(array(PhabricatorOwnersApplication::class)) ->executeOne(); $view_policy = $app->getPolicy( diff --git a/src/applications/packages/storage/PhabricatorPackagesPackage.php b/src/applications/packages/storage/PhabricatorPackagesPackage.php index 15748329e7..7cbfb64457 100644 --- a/src/applications/packages/storage/PhabricatorPackagesPackage.php +++ b/src/applications/packages/storage/PhabricatorPackagesPackage.php @@ -22,7 +22,7 @@ final class PhabricatorPackagesPackage public static function initializeNewPackage(PhabricatorUser $actor) { $packages_application = id(new PhabricatorApplicationQuery()) ->setViewer($actor) - ->withClasses(array('PhabricatorPackagesApplication')) + ->withClasses(array(PhabricatorPackagesApplication::class)) ->executeOne(); $view_policy = $packages_application->getPolicy( diff --git a/src/applications/packages/storage/PhabricatorPackagesPublisher.php b/src/applications/packages/storage/PhabricatorPackagesPublisher.php index 21b586dc1f..144efe1425 100644 --- a/src/applications/packages/storage/PhabricatorPackagesPublisher.php +++ b/src/applications/packages/storage/PhabricatorPackagesPublisher.php @@ -18,7 +18,7 @@ final class PhabricatorPackagesPublisher public static function initializeNewPublisher(PhabricatorUser $actor) { $packages_application = id(new PhabricatorApplicationQuery()) ->setViewer($actor) - ->withClasses(array('PhabricatorPackagesApplication')) + ->withClasses(array(PhabricatorPackagesApplication::class)) ->executeOne(); $edit_policy = $packages_application->getPolicy( diff --git a/src/applications/passphrase/storage/PassphraseCredential.php b/src/applications/passphrase/storage/PassphraseCredential.php index 5e10796249..8ea060dd96 100644 --- a/src/applications/passphrase/storage/PassphraseCredential.php +++ b/src/applications/passphrase/storage/PassphraseCredential.php @@ -32,7 +32,7 @@ final class PassphraseCredential extends PassphraseDAO public static function initializeNewCredential(PhabricatorUser $actor) { $app = id(new PhabricatorApplicationQuery()) ->setViewer($actor) - ->withClasses(array('PhabricatorPassphraseApplication')) + ->withClasses(array(PhabricatorPassphraseApplication::class)) ->executeOne(); $view_policy = $app->getPolicy(PassphraseDefaultViewCapability::CAPABILITY); diff --git a/src/applications/paste/storage/PhabricatorPaste.php b/src/applications/paste/storage/PhabricatorPaste.php index 435a89d93b..6c76451cb8 100644 --- a/src/applications/paste/storage/PhabricatorPaste.php +++ b/src/applications/paste/storage/PhabricatorPaste.php @@ -35,7 +35,7 @@ final class PhabricatorPaste extends PhabricatorPasteDAO public static function initializeNewPaste(PhabricatorUser $actor) { $app = id(new PhabricatorApplicationQuery()) ->setViewer($actor) - ->withClasses(array('PhabricatorPasteApplication')) + ->withClasses(array(PhabricatorPasteApplication::class)) ->executeOne(); $view_policy = $app->getPolicy(PasteDefaultViewCapability::CAPABILITY); diff --git a/src/applications/pholio/storage/PholioMock.php b/src/applications/pholio/storage/PholioMock.php index 6431c8eeb5..aa0ccc881d 100644 --- a/src/applications/pholio/storage/PholioMock.php +++ b/src/applications/pholio/storage/PholioMock.php @@ -35,7 +35,7 @@ final class PholioMock extends PholioDAO public static function initializeNewMock(PhabricatorUser $actor) { $app = id(new PhabricatorApplicationQuery()) ->setViewer($actor) - ->withClasses(array('PhabricatorPholioApplication')) + ->withClasses(array(PhabricatorPholioApplication::class)) ->executeOne(); $view_policy = $app->getPolicy(PholioDefaultViewCapability::CAPABILITY); diff --git a/src/applications/phurl/storage/PhabricatorPhurlURL.php b/src/applications/phurl/storage/PhabricatorPhurlURL.php index 02f075bfb0..feeadcbcba 100644 --- a/src/applications/phurl/storage/PhabricatorPhurlURL.php +++ b/src/applications/phurl/storage/PhabricatorPhurlURL.php @@ -31,7 +31,7 @@ final class PhabricatorPhurlURL extends PhabricatorPhurlDAO public static function initializeNewPhurlURL(PhabricatorUser $actor) { $app = id(new PhabricatorApplicationQuery()) ->setViewer($actor) - ->withClasses(array('PhabricatorPhurlApplication')) + ->withClasses(array(PhabricatorPhurlApplication::class)) ->executeOne(); $view_policy = $app->getPolicy( diff --git a/src/applications/ponder/storage/PonderAnswer.php b/src/applications/ponder/storage/PonderAnswer.php index 2ec7fdb2b5..af9b423287 100644 --- a/src/applications/ponder/storage/PonderAnswer.php +++ b/src/applications/ponder/storage/PonderAnswer.php @@ -27,7 +27,7 @@ final class PonderAnswer extends PonderDAO PonderQuestion $question) { $app = id(new PhabricatorApplicationQuery()) ->setViewer($actor) - ->withClasses(array('PhabricatorPonderApplication')) + ->withClasses(array(PhabricatorPonderApplication::class)) ->executeOne(); return id(new PonderAnswer()) diff --git a/src/applications/ponder/storage/PonderQuestion.php b/src/applications/ponder/storage/PonderQuestion.php index b5034f94d8..cbdb4170a8 100644 --- a/src/applications/ponder/storage/PonderQuestion.php +++ b/src/applications/ponder/storage/PonderQuestion.php @@ -38,7 +38,7 @@ final class PonderQuestion extends PonderDAO public static function initializeNewQuestion(PhabricatorUser $actor) { $app = id(new PhabricatorApplicationQuery()) ->setViewer($actor) - ->withClasses(array('PhabricatorPonderApplication')) + ->withClasses(array(PhabricatorPonderApplication::class)) ->executeOne(); $view_policy = $app->getPolicy( diff --git a/src/applications/project/storage/PhabricatorProject.php b/src/applications/project/storage/PhabricatorProject.php index 53dd5f1ff9..394ecb5aa0 100644 --- a/src/applications/project/storage/PhabricatorProject.php +++ b/src/applications/project/storage/PhabricatorProject.php @@ -71,7 +71,7 @@ final class PhabricatorProject extends PhabricatorProjectDAO $app = id(new PhabricatorApplicationQuery()) ->setViewer(PhabricatorUser::getOmnipotentUser()) - ->withClasses(array('PhabricatorProjectApplication')) + ->withClasses(array(PhabricatorProjectApplication::class)) ->executeOne(); $view_policy = $app->getPolicy( diff --git a/src/applications/repository/storage/PhabricatorRepository.php b/src/applications/repository/storage/PhabricatorRepository.php index 481f48dd99..25b2364b3d 100644 --- a/src/applications/repository/storage/PhabricatorRepository.php +++ b/src/applications/repository/storage/PhabricatorRepository.php @@ -73,7 +73,7 @@ final class PhabricatorRepository extends PhabricatorRepositoryDAO public static function initializeNewRepository(PhabricatorUser $actor) { $app = id(new PhabricatorApplicationQuery()) ->setViewer($actor) - ->withClasses(array('PhabricatorDiffusionApplication')) + ->withClasses(array(PhabricatorDiffusionApplication::class)) ->executeOne(); $view_policy = $app->getPolicy(DiffusionDefaultViewCapability::CAPABILITY); diff --git a/src/applications/slowvote/storage/PhabricatorSlowvotePoll.php b/src/applications/slowvote/storage/PhabricatorSlowvotePoll.php index 9ee33c81bb..f715efbfdb 100644 --- a/src/applications/slowvote/storage/PhabricatorSlowvotePoll.php +++ b/src/applications/slowvote/storage/PhabricatorSlowvotePoll.php @@ -30,7 +30,7 @@ final class PhabricatorSlowvotePoll public static function initializeNewPoll(PhabricatorUser $actor) { $app = id(new PhabricatorApplicationQuery()) ->setViewer($actor) - ->withClasses(array('PhabricatorSlowvoteApplication')) + ->withClasses(array(PhabricatorSlowvoteApplication::class)) ->executeOne(); $view_policy = $app->getPolicy( diff --git a/src/applications/spaces/storage/PhabricatorSpacesNamespace.php b/src/applications/spaces/storage/PhabricatorSpacesNamespace.php index e8b2afb435..19db4522ed 100644 --- a/src/applications/spaces/storage/PhabricatorSpacesNamespace.php +++ b/src/applications/spaces/storage/PhabricatorSpacesNamespace.php @@ -17,7 +17,7 @@ final class PhabricatorSpacesNamespace public static function initializeNewNamespace(PhabricatorUser $actor) { $app = id(new PhabricatorApplicationQuery()) ->setViewer($actor) - ->withClasses(array('PhabricatorSpacesApplication')) + ->withClasses(array(PhabricatorSpacesApplication::class)) ->executeOne(); $view_policy = $app->getPolicy( diff --git a/src/applications/tokens/storage/PhabricatorTokensToken.php b/src/applications/tokens/storage/PhabricatorTokensToken.php index 50bada38b9..9c905c68b1 100644 --- a/src/applications/tokens/storage/PhabricatorTokensToken.php +++ b/src/applications/tokens/storage/PhabricatorTokensToken.php @@ -53,7 +53,7 @@ final class PhabricatorTokensToken extends PhabricatorTokenDAO public static function initializeNewToken(PhabricatorUser $actor) { $app = id(new PhabricatorApplicationQuery()) ->setViewer($actor) - ->withClasses(array('PhabricatorTokensApplication')) + ->withClasses(array(PhabricatorTokensApplication::class)) ->executeOne(); $token = id(new self()) -- 2.51.2