From 3006601eb559a6e7b7c09d5a74eab2bfb9b19e18 Mon Sep 17 00:00:00 2001 From: Andre Klapper Date: Wed, 10 Sep 2025 21:00:12 +0200 Subject: [PATCH] Conduit docs: Clarify value type of points in maniphest.edit Summary: Be less mysterious about the type of value required to edit `points` by explicitly setting `int|float`. Test Plan: * Go to http://phorge.localhost/conduit/method/maniphest.edit/#points and look at the Type for the Key `value`, see `int|float` instead of `points` * See that `EXPLAIN phabricator_maniphest.maniphest_task` lists Type `double` for Field `points` * Read https://www.php.net/manual/en/language.types.float.php to confirm that float and double are the same in PHP * Use `maniphest.edit` Conduit API to set Points value of a task, still works Reviewers: O1 Blessed Committers, valerio.bozzolan Reviewed By: O1 Blessed Committers, valerio.bozzolan Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Differential Revision: https://we.phorge.it/D26338 --- .../conduit/parametertype/ConduitPointsParameterType.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/applications/conduit/parametertype/ConduitPointsParameterType.php b/src/applications/conduit/parametertype/ConduitPointsParameterType.php index 9e5be819f2..9f13b94042 100644 --- a/src/applications/conduit/parametertype/ConduitPointsParameterType.php +++ b/src/applications/conduit/parametertype/ConduitPointsParameterType.php @@ -27,7 +27,7 @@ final class ConduitPointsParameterType } protected function getParameterTypeName() { - return 'points'; + return 'int|float'; } protected function getParameterFormatDescriptions() { -- 2.54.0