diff --git a/src/applications/almanac/query/AlmanacDeviceSearchEngine.php b/src/applications/almanac/query/AlmanacDeviceSearchEngine.php index b4f7836720..a3e8af7243 100644 --- a/src/applications/almanac/query/AlmanacDeviceSearchEngine.php +++ b/src/applications/almanac/query/AlmanacDeviceSearchEngine.php @@ -93,11 +93,16 @@ final class AlmanacDeviceSearchEngine return parent::buildSavedQueryFromBuiltin($query_key); } + /** + * @param array $devices + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $devices, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($devices, 'AlmanacDevice'); + assert_instances_of($devices, AlmanacDevice::class); $viewer = $this->requireViewer(); diff --git a/src/applications/almanac/query/AlmanacNamespaceSearchEngine.php b/src/applications/almanac/query/AlmanacNamespaceSearchEngine.php index a4658c5f33..3ac2b76ee0 100644 --- a/src/applications/almanac/query/AlmanacNamespaceSearchEngine.php +++ b/src/applications/almanac/query/AlmanacNamespaceSearchEngine.php @@ -59,11 +59,16 @@ final class AlmanacNamespaceSearchEngine return parent::buildSavedQueryFromBuiltin($query_key); } + /** + * @param array $namespaces + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $namespaces, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($namespaces, 'AlmanacNamespace'); + assert_instances_of($namespaces, AlmanacNamespace::class); $viewer = $this->requireViewer(); diff --git a/src/applications/almanac/query/AlmanacNetworkSearchEngine.php b/src/applications/almanac/query/AlmanacNetworkSearchEngine.php index 7bb8b85116..941d648d67 100644 --- a/src/applications/almanac/query/AlmanacNetworkSearchEngine.php +++ b/src/applications/almanac/query/AlmanacNetworkSearchEngine.php @@ -59,11 +59,16 @@ final class AlmanacNetworkSearchEngine return parent::buildSavedQueryFromBuiltin($query_key); } + /** + * @param array $networks + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $networks, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($networks, 'AlmanacNetwork'); + assert_instances_of($networks, AlmanacNetwork::class); $viewer = $this->requireViewer(); diff --git a/src/applications/almanac/query/AlmanacServiceSearchEngine.php b/src/applications/almanac/query/AlmanacServiceSearchEngine.php index 46a9ebfbad..5f0da6b59e 100644 --- a/src/applications/almanac/query/AlmanacServiceSearchEngine.php +++ b/src/applications/almanac/query/AlmanacServiceSearchEngine.php @@ -86,11 +86,16 @@ final class AlmanacServiceSearchEngine return parent::buildSavedQueryFromBuiltin($query_key); } + /** + * @param array $services + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $services, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($services, 'AlmanacService'); + assert_instances_of($services, AlmanacService::class); $viewer = $this->requireViewer(); diff --git a/src/applications/almanac/storage/AlmanacBinding.php b/src/applications/almanac/storage/AlmanacBinding.php index 011a085151..f07a4e32fe 100644 --- a/src/applications/almanac/storage/AlmanacBinding.php +++ b/src/applications/almanac/storage/AlmanacBinding.php @@ -98,8 +98,11 @@ final class AlmanacBinding /* -( AlmanacPropertyInterface )------------------------------------------- */ + /** + * @param array $properties + */ public function attachAlmanacProperties(array $properties) { - assert_instances_of($properties, 'AlmanacProperty'); + assert_instances_of($properties, AlmanacProperty::class); $this->almanacProperties = mpull($properties, null, 'getFieldName'); return $this; } diff --git a/src/applications/almanac/storage/AlmanacDevice.php b/src/applications/almanac/storage/AlmanacDevice.php index 87704d89d8..f8a22edc4d 100644 --- a/src/applications/almanac/storage/AlmanacDevice.php +++ b/src/applications/almanac/storage/AlmanacDevice.php @@ -119,8 +119,11 @@ final class AlmanacDevice /* -( AlmanacPropertyInterface )------------------------------------------- */ + /** + * @param array $properties + */ public function attachAlmanacProperties(array $properties) { - assert_instances_of($properties, 'AlmanacProperty'); + assert_instances_of($properties, AlmanacProperty::class); $this->almanacProperties = mpull($properties, null, 'getFieldName'); return $this; } diff --git a/src/applications/almanac/storage/AlmanacService.php b/src/applications/almanac/storage/AlmanacService.php index 58a3f681df..18e643756e 100644 --- a/src/applications/almanac/storage/AlmanacService.php +++ b/src/applications/almanac/storage/AlmanacService.php @@ -133,8 +133,11 @@ final class AlmanacService /* -( AlmanacPropertyInterface )------------------------------------------- */ + /** + * @param array $properties + */ public function attachAlmanacProperties(array $properties) { - assert_instances_of($properties, 'AlmanacProperty'); + assert_instances_of($properties, AlmanacProperty::class); $this->almanacProperties = mpull($properties, null, 'getFieldName'); return $this; } diff --git a/src/applications/audit/query/PhabricatorCommitSearchEngine.php b/src/applications/audit/query/PhabricatorCommitSearchEngine.php index dfc038c197..40d7d52aea 100644 --- a/src/applications/audit/query/PhabricatorCommitSearchEngine.php +++ b/src/applications/audit/query/PhabricatorCommitSearchEngine.php @@ -222,11 +222,16 @@ final class PhabricatorCommitSearchEngine return parent::buildSavedQueryFromBuiltin($query_key); } + /** + * @param array $commits + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $commits, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($commits, 'PhabricatorRepositoryCommit'); + assert_instances_of($commits, PhabricatorRepositoryCommit::class); $viewer = $this->requireViewer(); $bucket = $this->getResultBucket($query); diff --git a/src/applications/auth/adapter/PhutilAuthAdapter.php b/src/applications/auth/adapter/PhutilAuthAdapter.php index f8a980313c..92bfb73f54 100644 --- a/src/applications/auth/adapter/PhutilAuthAdapter.php +++ b/src/applications/auth/adapter/PhutilAuthAdapter.php @@ -19,7 +19,7 @@ abstract class PhutilAuthAdapter extends Phobject { final public function getAccountIdentifiers() { $result = $this->newAccountIdentifiers(); - assert_instances_of($result, 'PhabricatorExternalAccountIdentifier'); + assert_instances_of($result, PhabricatorExternalAccountIdentifier::class); return $result; } diff --git a/src/applications/auth/controller/PhabricatorAuthStartController.php b/src/applications/auth/controller/PhabricatorAuthStartController.php index 57e294f6dc..a0a9b0b370 100644 --- a/src/applications/auth/controller/PhabricatorAuthStartController.php +++ b/src/applications/auth/controller/PhabricatorAuthStartController.php @@ -298,8 +298,11 @@ final class PhabricatorAuthStartController ->setURI($auto_uri); } + /** + * @param array $configs + */ private function newEmailLoginView(array $configs) { - assert_instances_of($configs, 'PhabricatorAuthProviderConfig'); + assert_instances_of($configs, PhabricatorAuthProviderConfig::class); // Check if password auth is enabled. If it is, the password login form // renders a "Forgot password?" link, so we don't need to provide a diff --git a/src/applications/auth/engine/PhabricatorAuthPasswordEngine.php b/src/applications/auth/engine/PhabricatorAuthPasswordEngine.php index 0efb1fe4fc..6a7228489f 100644 --- a/src/applications/auth/engine/PhabricatorAuthPasswordEngine.php +++ b/src/applications/auth/engine/PhabricatorAuthPasswordEngine.php @@ -339,11 +339,15 @@ final class PhabricatorAuthPasswordEngine return $matches; } + /** + * @param PhutilOpaqueEnvelope $envelope + * @param array $passwords + */ private function upgradeHashers( PhutilOpaqueEnvelope $envelope, array $passwords) { - assert_instances_of($passwords, 'PhabricatorAuthPassword'); + assert_instances_of($passwords, PhabricatorAuthPassword::class); $need_upgrade = array(); foreach ($passwords as $password) { diff --git a/src/applications/auth/engine/PhabricatorAuthSessionEngine.php b/src/applications/auth/engine/PhabricatorAuthSessionEngine.php index 6de9b64db3..0a62103ef7 100644 --- a/src/applications/auth/engine/PhabricatorAuthSessionEngine.php +++ b/src/applications/auth/engine/PhabricatorAuthSessionEngine.php @@ -739,7 +739,7 @@ final class PhabricatorAuthSessionEngine extends Phobject { * Render a form for providing relevant multi-factor credentials. * * @param array $factors - * @param array $validation_results + * @param array $validation_results * @param PhabricatorUser $viewer Viewing user. * @param AphrontRequest $request Current request. * @return AphrontFormView Renderable form. @@ -750,7 +750,9 @@ final class PhabricatorAuthSessionEngine extends Phobject { array $validation_results, PhabricatorUser $viewer, AphrontRequest $request) { - assert_instances_of($validation_results, 'PhabricatorAuthFactorResult'); + assert_instances_of( + $validation_results, + PhabricatorAuthFactorResult::class); $form = id(new AphrontFormView()) ->setUser($viewer) diff --git a/src/applications/auth/exception/PhabricatorAuthHighSecurityRequiredException.php b/src/applications/auth/exception/PhabricatorAuthHighSecurityRequiredException.php index dc197b3a43..3defad7d00 100644 --- a/src/applications/auth/exception/PhabricatorAuthHighSecurityRequiredException.php +++ b/src/applications/auth/exception/PhabricatorAuthHighSecurityRequiredException.php @@ -7,8 +7,11 @@ final class PhabricatorAuthHighSecurityRequiredException extends Exception { private $factorValidationResults; private $isSessionUpgrade; + /** + * @param array $results + */ public function setFactorValidationResults(array $results) { - assert_instances_of($results, 'PhabricatorAuthFactorResult'); + assert_instances_of($results, PhabricatorAuthFactorResult::class); $this->factorValidationResults = $results; return $this; } @@ -17,8 +20,11 @@ final class PhabricatorAuthHighSecurityRequiredException extends Exception { return $this->factorValidationResults; } + /** + * @param array $factors + */ public function setFactors(array $factors) { - assert_instances_of($factors, 'PhabricatorAuthFactorConfig'); + assert_instances_of($factors, PhabricatorAuthFactorConfig::class); $this->factors = $factors; return $this; } diff --git a/src/applications/auth/factor/PhabricatorAuthFactor.php b/src/applications/auth/factor/PhabricatorAuthFactor.php index f7f6c52650..9bfd5ddad2 100644 --- a/src/applications/auth/factor/PhabricatorAuthFactor.php +++ b/src/applications/auth/factor/PhabricatorAuthFactor.php @@ -139,11 +139,16 @@ abstract class PhabricatorAuthFactor extends Phobject { PhabricatorAuthFactorConfig $config, AphrontRequest $response); + /** + * @param PhabricatorAuthFactorConfig $config + * @param PhabricatorUser $viewer + * @param array $challenges + */ final public function getNewIssuedChallenges( PhabricatorAuthFactorConfig $config, PhabricatorUser $viewer, array $challenges) { - assert_instances_of($challenges, 'PhabricatorAuthChallenge'); + assert_instances_of($challenges, PhabricatorAuthChallenge::class); $now = PhabricatorTime::getNow(); @@ -161,7 +166,7 @@ abstract class PhabricatorAuthFactor extends Phobject { return $new_challenges; } - assert_instances_of($new_challenges, 'PhabricatorAuthChallenge'); + assert_instances_of($new_challenges, PhabricatorAuthChallenge::class); foreach ($new_challenges as $new_challenge) { $ttl = $new_challenge->getChallengeTTL(); @@ -194,11 +199,16 @@ abstract class PhabricatorAuthFactor extends Phobject { PhabricatorUser $viewer, array $challenges); + /** + * @param PhabricatorAuthFactorConfig $config + * @param PhabricatorUser $viewer + * @param array $challenges + */ final public function getResultFromIssuedChallenges( PhabricatorAuthFactorConfig $config, PhabricatorUser $viewer, array $challenges) { - assert_instances_of($challenges, 'PhabricatorAuthChallenge'); + assert_instances_of($challenges, PhabricatorAuthChallenge::class); $result = $this->newResultFromIssuedChallenges( $config, @@ -221,12 +231,18 @@ abstract class PhabricatorAuthFactor extends Phobject { return $result; } + /** + * @param PhabricatorAuthFactorConfig $config + * @param PhabricatorUser $viewer + * @param AphrontRequest $request + * @param array $challenges + */ final public function getResultForPrompt( PhabricatorAuthFactorConfig $config, PhabricatorUser $viewer, AphrontRequest $request, array $challenges) { - assert_instances_of($challenges, 'PhabricatorAuthChallenge'); + assert_instances_of($challenges, PhabricatorAuthChallenge::class); $result = $this->newResultForPrompt( $config, @@ -260,12 +276,18 @@ abstract class PhabricatorAuthFactor extends Phobject { PhabricatorUser $viewer, array $challenges); + /** + * @param PhabricatorAuthFactorConfig $config + * @param PhabricatorUser $viewer + * @param AphrontRequest $request + * @param array $challenges + */ final public function getResultFromChallengeResponse( PhabricatorAuthFactorConfig $config, PhabricatorUser $viewer, AphrontRequest $request, array $challenges) { - assert_instances_of($challenges, 'PhabricatorAuthChallenge'); + assert_instances_of($challenges, PhabricatorAuthChallenge::class); $result = $this->newResultFromChallengeResponse( $config, diff --git a/src/applications/auth/provider/PhabricatorAuthProvider.php b/src/applications/auth/provider/PhabricatorAuthProvider.php index 71e3146744..110b46717e 100644 --- a/src/applications/auth/provider/PhabricatorAuthProvider.php +++ b/src/applications/auth/provider/PhabricatorAuthProvider.php @@ -196,10 +196,14 @@ abstract class PhabricatorAuthProvider extends Phobject { return; } + /** + * @param array $identifiers + */ final protected function newExternalAccountForIdentifiers( array $identifiers) { - assert_instances_of($identifiers, 'PhabricatorExternalAccountIdentifier'); + assert_instances_of($identifiers, + PhabricatorExternalAccountIdentifier::class); if (!$identifiers) { throw new Exception( diff --git a/src/applications/auth/query/PhabricatorAuthInviteSearchEngine.php b/src/applications/auth/query/PhabricatorAuthInviteSearchEngine.php index 8ed2a31e6c..50eb084ad1 100644 --- a/src/applications/auth/query/PhabricatorAuthInviteSearchEngine.php +++ b/src/applications/auth/query/PhabricatorAuthInviteSearchEngine.php @@ -70,11 +70,16 @@ final class PhabricatorAuthInviteSearchEngine return array_keys($phids); } + /** + * @param array $invites + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $invites, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($invites, 'PhabricatorAuthInvite'); + assert_instances_of($invites, PhabricatorAuthInvite::class); $viewer = $this->requireViewer(); diff --git a/src/applications/auth/query/PhabricatorAuthSSHKeyQuery.php b/src/applications/auth/query/PhabricatorAuthSSHKeyQuery.php index d3a436f4b0..02df638636 100644 --- a/src/applications/auth/query/PhabricatorAuthSSHKeyQuery.php +++ b/src/applications/auth/query/PhabricatorAuthSSHKeyQuery.php @@ -35,8 +35,11 @@ final class PhabricatorAuthSSHKeyQuery return $this; } + /** + * @param array $keys + */ public function withKeys(array $keys) { - assert_instances_of($keys, 'PhabricatorAuthSSHPublicKey'); + assert_instances_of($keys, PhabricatorAuthSSHPublicKey::class); $this->keys = $keys; return $this; } diff --git a/src/applications/auth/query/PhabricatorAuthSSHKeySearchEngine.php b/src/applications/auth/query/PhabricatorAuthSSHKeySearchEngine.php index 133389dc8e..f0421d7466 100644 --- a/src/applications/auth/query/PhabricatorAuthSSHKeySearchEngine.php +++ b/src/applications/auth/query/PhabricatorAuthSSHKeySearchEngine.php @@ -73,11 +73,16 @@ final class PhabricatorAuthSSHKeySearchEngine return parent::buildSavedQueryFromBuiltin($query_key); } + /** + * @param array $keys + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $keys, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($keys, 'PhabricatorAuthSSHKey'); + assert_instances_of($keys, PhabricatorAuthSSHKey::class); $viewer = $this->requireViewer(); diff --git a/src/applications/auth/view/PhabricatorAuthSSHKeyTableView.php b/src/applications/auth/view/PhabricatorAuthSSHKeyTableView.php index 0452a14521..b9e3f56e86 100644 --- a/src/applications/auth/view/PhabricatorAuthSSHKeyTableView.php +++ b/src/applications/auth/view/PhabricatorAuthSSHKeyTableView.php @@ -80,8 +80,11 @@ final class PhabricatorAuthSSHKeyTableView extends AphrontView { return $this; } + /** + * @param array $keys + */ public function setKeys(array $keys) { - assert_instances_of($keys, 'PhabricatorAuthSSHKey'); + assert_instances_of($keys, PhabricatorAuthSSHKey::class); $this->keys = $keys; return $this; } diff --git a/src/applications/badges/query/PhabricatorBadgesSearchEngine.php b/src/applications/badges/query/PhabricatorBadgesSearchEngine.php index b08962ed4b..34c0e27db4 100644 --- a/src/applications/badges/query/PhabricatorBadgesSearchEngine.php +++ b/src/applications/badges/query/PhabricatorBadgesSearchEngine.php @@ -93,11 +93,16 @@ final class PhabricatorBadgesSearchEngine return $phids; } + /** + * @param array $badges + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $badges, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($badges, 'PhabricatorBadgesBadge'); + assert_instances_of($badges, PhabricatorBadgesBadge::class); $viewer = $this->requireViewer(); diff --git a/src/applications/conduit/controller/PhabricatorConduitConsoleController.php b/src/applications/conduit/controller/PhabricatorConduitConsoleController.php index b3dfa805a2..aa9a8c2796 100644 --- a/src/applications/conduit/controller/PhabricatorConduitConsoleController.php +++ b/src/applications/conduit/controller/PhabricatorConduitConsoleController.php @@ -126,10 +126,16 @@ final class PhabricatorConduitConsoleController ->appendChild($view); } + /** + * @param ConduitAPIMethod $method + * @param array $documentation_pages + */ private function newDocumentationView( ConduitAPIMethod $method, array $documentation_pages) { - assert_instances_of($documentation_pages, 'ConduitAPIDocumentationPage'); + assert_instances_of( + $documentation_pages, + ConduitAPIDocumentationPage::class); $viewer = $this->getViewer(); @@ -153,10 +159,16 @@ final class PhabricatorConduitConsoleController return $view; } + /** + * @param ConduitAPIMethod $method + * @param array $documentation_pages + */ private function newNavigationView( ConduitAPIMethod $method, array $documentation_pages) { - assert_instances_of($documentation_pages, 'ConduitAPIDocumentationPage'); + assert_instances_of( + $documentation_pages, + ConduitAPIDocumentationPage::class); $console_uri = urisprintf( '/method/%s/', diff --git a/src/applications/conduit/query/PhabricatorConduitLogSearchEngine.php b/src/applications/conduit/query/PhabricatorConduitLogSearchEngine.php index 5155ea0732..99ca37eebe 100644 --- a/src/applications/conduit/query/PhabricatorConduitLogSearchEngine.php +++ b/src/applications/conduit/query/PhabricatorConduitLogSearchEngine.php @@ -174,11 +174,16 @@ final class PhabricatorConduitLogSearchEngine return $export; } + /** + * @param array $logs + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $logs, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($logs, 'PhabricatorConduitMethodCallLog'); + assert_instances_of($logs, PhabricatorConduitMethodCallLog::class); $viewer = $this->requireViewer(); $methods = id(new PhabricatorConduitMethodQuery()) diff --git a/src/applications/conduit/query/PhabricatorConduitSearchEngine.php b/src/applications/conduit/query/PhabricatorConduitSearchEngine.php index 2fd95c3550..59635012b3 100644 --- a/src/applications/conduit/query/PhabricatorConduitSearchEngine.php +++ b/src/applications/conduit/query/PhabricatorConduitSearchEngine.php @@ -122,11 +122,16 @@ final class PhabricatorConduitSearchEngine return parent::buildSavedQueryFromBuiltin($query_key); } + /** + * @param array $methods + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $methods, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($methods, 'ConduitAPIMethod'); + assert_instances_of($methods, ConduitAPIMethod::class); $viewer = $this->requireViewer(); diff --git a/src/applications/config/check/PhabricatorSetupCheck.php b/src/applications/config/check/PhabricatorSetupCheck.php index 29ffcac226..f1d0d932b7 100644 --- a/src/applications/config/check/PhabricatorSetupCheck.php +++ b/src/applications/config/check/PhabricatorSetupCheck.php @@ -131,8 +131,11 @@ abstract class PhabricatorSetupCheck extends Phobject { } } + /** + * @param array $all_issues + */ final public static function getUnignoredIssueKeys(array $all_issues) { - assert_instances_of($all_issues, 'PhabricatorSetupIssue'); + assert_instances_of($all_issues, PhabricatorSetupIssue::class); $keys = array(); foreach ($all_issues as $issue) { if (!$issue->getIsIgnored()) { diff --git a/src/applications/config/controller/issue/PhabricatorConfigIssueListController.php b/src/applications/config/controller/issue/PhabricatorConfigIssueListController.php index b1f00fc013..c66acd3fe4 100644 --- a/src/applications/config/controller/issue/PhabricatorConfigIssueListController.php +++ b/src/applications/config/controller/issue/PhabricatorConfigIssueListController.php @@ -67,8 +67,13 @@ final class PhabricatorConfigIssueListController ->appendChild($content); } + /** + * @param array $issues + * @param string $group + * @param string $fonticon FontAwesome icon name + */ private function buildIssueList(array $issues, $group, $fonticon) { - assert_instances_of($issues, 'PhabricatorSetupIssue'); + assert_instances_of($issues, PhabricatorSetupIssue::class); $list = new PHUIObjectItemListView(); $list->setBig(true); $ignored_items = array(); diff --git a/src/applications/config/view/PhabricatorHTTPParameterTypeTableView.php b/src/applications/config/view/PhabricatorHTTPParameterTypeTableView.php index 25e944a9fd..02d3083f56 100644 --- a/src/applications/config/view/PhabricatorHTTPParameterTypeTableView.php +++ b/src/applications/config/view/PhabricatorHTTPParameterTypeTableView.php @@ -5,8 +5,11 @@ final class PhabricatorHTTPParameterTypeTableView private $types; + /** + * @param array $types + */ public function setHTTPParameterTypes(array $types) { - assert_instances_of($types, 'AphrontHTTPParameterType'); + assert_instances_of($types, AphrontHTTPParameterType::class); $this->types = $types; return $this; } diff --git a/src/applications/conpherence/query/ConpherenceThreadSearchEngine.php b/src/applications/conpherence/query/ConpherenceThreadSearchEngine.php index 747da59fd8..f716c82ec1 100644 --- a/src/applications/conpherence/query/ConpherenceThreadSearchEngine.php +++ b/src/applications/conpherence/query/ConpherenceThreadSearchEngine.php @@ -91,11 +91,16 @@ final class ConpherenceThreadSearchEngine return parent::buildSavedQueryFromBuiltin($query_key); } + /** + * @param array $conpherences + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $conpherences, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($conpherences, 'ConpherenceThread'); + assert_instances_of($conpherences, ConpherenceThread::class); $viewer = $this->requireViewer(); diff --git a/src/applications/conpherence/storage/ConpherenceThread.php b/src/applications/conpherence/storage/ConpherenceThread.php index 4fc027ad21..0e0df273eb 100644 --- a/src/applications/conpherence/storage/ConpherenceThread.php +++ b/src/applications/conpherence/storage/ConpherenceThread.php @@ -76,8 +76,11 @@ final class ConpherenceThread extends ConpherenceDAO return '/'.$this->getMonogram(); } + /** + * @param array $participants + */ public function attachParticipants(array $participants) { - assert_instances_of($participants, 'ConpherenceParticipant'); + assert_instances_of($participants, ConpherenceParticipant::class); $this->participants = $participants; return $this; } @@ -101,8 +104,11 @@ final class ConpherenceThread extends ConpherenceDAO return array_keys($participants); } + /** + * @param array $handles + */ public function attachHandles(array $handles) { - assert_instances_of($handles, 'PhabricatorObjectHandle'); + assert_instances_of($handles, PhabricatorObjectHandle::class); $this->handles = $handles; return $this; } @@ -111,8 +117,11 @@ final class ConpherenceThread extends ConpherenceDAO return $this->assertAttached($this->handles); } + /** + * @param array $transactions + */ public function attachTransactions(array $transactions) { - assert_instances_of($transactions, 'ConpherenceTransaction'); + assert_instances_of($transactions, ConpherenceTransaction::class); $this->transactions = $transactions; return $this; } @@ -295,8 +304,11 @@ final class ConpherenceThread extends ConpherenceDAO return $policy_objects; } + /** + * @param array $policy_objects + */ public function getPolicyIconName(array $policy_objects) { - assert_instances_of($policy_objects, 'PhabricatorPolicy'); + assert_instances_of($policy_objects, PhabricatorPolicy::class); $icon = $policy_objects[$this->getViewPolicy()]->getIcon(); return $icon; diff --git a/src/applications/conpherence/view/ConpherenceDurableColumnView.php b/src/applications/conpherence/view/ConpherenceDurableColumnView.php index 22ca1928b3..556754557c 100644 --- a/src/applications/conpherence/view/ConpherenceDurableColumnView.php +++ b/src/applications/conpherence/view/ConpherenceDurableColumnView.php @@ -12,8 +12,11 @@ final class ConpherenceDurableColumnView extends AphrontTagView { private $policyObjects; private $quicksandConfig = array(); + /** + * @param array $conpherences + */ public function setConpherences(array $conpherences) { - assert_instances_of($conpherences, 'ConpherenceThread'); + assert_instances_of($conpherences, ConpherenceThread::class); $this->conpherences = $conpherences; return $this; } @@ -41,8 +44,11 @@ final class ConpherenceDurableColumnView extends AphrontTagView { return $this->selectedConpherence; } + /** + * @param array $transactions + */ public function setTransactions(array $transactions) { - assert_instances_of($transactions, 'ConpherenceTransaction'); + assert_instances_of($transactions, ConpherenceTransaction::class); $this->transactions = $transactions; return $this; } @@ -78,8 +84,11 @@ final class ConpherenceDurableColumnView extends AphrontTagView { return $this->initialLoad; } + /** + * @param array $objects + */ public function setPolicyObjects(array $objects) { - assert_instances_of($objects, 'PhabricatorPolicy'); + assert_instances_of($objects, PhabricatorPolicy::class); $this->policyObjects = $objects; return $this; diff --git a/src/applications/conpherence/view/ConpherenceThreadListView.php b/src/applications/conpherence/view/ConpherenceThreadListView.php index f51ffea44f..3701acea88 100644 --- a/src/applications/conpherence/view/ConpherenceThreadListView.php +++ b/src/applications/conpherence/view/ConpherenceThreadListView.php @@ -7,8 +7,11 @@ final class ConpherenceThreadListView extends AphrontView { private $baseURI; private $threads; + /** + * @param array $threads + */ public function setThreads(array $threads) { - assert_instances_of($threads, 'ConpherenceThread'); + assert_instances_of($threads, ConpherenceThread::class); $this->threads = $threads; return $this; } diff --git a/src/applications/conpherence/view/ConpherenceTransactionView.php b/src/applications/conpherence/view/ConpherenceTransactionView.php index cf054133cd..d1d4c1b392 100644 --- a/src/applications/conpherence/view/ConpherenceTransactionView.php +++ b/src/applications/conpherence/view/ConpherenceTransactionView.php @@ -28,8 +28,11 @@ final class ConpherenceTransactionView extends AphrontView { return $this->conpherenceTransaction; } + /** + * @param array $handles + */ public function setHandles(array $handles) { - assert_instances_of($handles, 'PhabricatorObjectHandle'); + assert_instances_of($handles, PhabricatorObjectHandle::class); $this->handles = $handles; return $this; } diff --git a/src/applications/countdown/query/PhabricatorCountdownSearchEngine.php b/src/applications/countdown/query/PhabricatorCountdownSearchEngine.php index a0f93763c8..44e9759879 100644 --- a/src/applications/countdown/query/PhabricatorCountdownSearchEngine.php +++ b/src/applications/countdown/query/PhabricatorCountdownSearchEngine.php @@ -86,12 +86,17 @@ final class PhabricatorCountdownSearchEngine return mpull($countdowns, 'getAuthorPHID'); } + /** + * @param array $countdowns + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $countdowns, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($countdowns, 'PhabricatorCountdown'); + assert_instances_of($countdowns, PhabricatorCountdown::class); $viewer = $this->requireViewer(); diff --git a/src/applications/daemon/view/PhabricatorDaemonLogListView.php b/src/applications/daemon/view/PhabricatorDaemonLogListView.php index ba25ac5c5e..7e98f3ecf1 100644 --- a/src/applications/daemon/view/PhabricatorDaemonLogListView.php +++ b/src/applications/daemon/view/PhabricatorDaemonLogListView.php @@ -4,8 +4,11 @@ final class PhabricatorDaemonLogListView extends AphrontView { private $daemonLogs; + /** + * @param array $daemon_logs + */ public function setDaemonLogs(array $daemon_logs) { - assert_instances_of($daemon_logs, 'PhabricatorDaemonLog'); + assert_instances_of($daemon_logs, PhabricatorDaemonLog::class); $this->daemonLogs = $daemon_logs; return $this; } diff --git a/src/applications/dashboard/layoutconfig/PhabricatorDashboardColumn.php b/src/applications/dashboard/layoutconfig/PhabricatorDashboardColumn.php index 3bf17d1a7c..d6ead72a69 100644 --- a/src/applications/dashboard/layoutconfig/PhabricatorDashboardColumn.php +++ b/src/applications/dashboard/layoutconfig/PhabricatorDashboardColumn.php @@ -25,8 +25,11 @@ final class PhabricatorDashboardColumn return $this->classes; } + /** + * @param array $refs + */ public function setPanelRefs(array $refs) { - assert_instances_of($refs, 'PhabricatorDashboardPanelRef'); + assert_instances_of($refs, PhabricatorDashboardPanelRef::class); $this->refs = $refs; return $this; } diff --git a/src/applications/dashboard/query/PhabricatorDashboardPortalSearchEngine.php b/src/applications/dashboard/query/PhabricatorDashboardPortalSearchEngine.php index b5ce3068b7..a6006c1112 100644 --- a/src/applications/dashboard/query/PhabricatorDashboardPortalSearchEngine.php +++ b/src/applications/dashboard/query/PhabricatorDashboardPortalSearchEngine.php @@ -49,12 +49,17 @@ final class PhabricatorDashboardPortalSearchEngine return parent::buildSavedQueryFromBuiltin($query_key); } + /** + * @param array $portals + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $portals, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($portals, 'PhabricatorDashboardPortal'); + assert_instances_of($portals, PhabricatorDashboardPortal::class); $viewer = $this->requireViewer(); diff --git a/src/applications/diffusion/conduit/DiffusionTagsQueryConduitAPIMethod.php b/src/applications/diffusion/conduit/DiffusionTagsQueryConduitAPIMethod.php index 3de5793289..8d0d340dbd 100644 --- a/src/applications/diffusion/conduit/DiffusionTagsQueryConduitAPIMethod.php +++ b/src/applications/diffusion/conduit/DiffusionTagsQueryConduitAPIMethod.php @@ -119,8 +119,11 @@ final class DiffusionTagsQueryConduitAPIMethod return $tag_names; } + /** + * @param array $tags + */ private function loadMessagesForTags(array $tags) { - assert_instances_of($tags, 'DiffusionRepositoryTag'); + assert_instances_of($tags, DiffusionRepositoryTag::class); $drequest = $this->getDiffusionRequest(); $repository = $drequest->getRepository(); diff --git a/src/applications/diffusion/controller/DiffusionCommitController.php b/src/applications/diffusion/controller/DiffusionCommitController.php index 1e2ec10847..143fd125cc 100644 --- a/src/applications/diffusion/controller/DiffusionCommitController.php +++ b/src/applications/diffusion/controller/DiffusionCommitController.php @@ -898,10 +898,16 @@ final class DiffusionCommitController extends DiffusionController { return $file->getRedirectResponse(); } + /** + * @param PhabricatorRepositoryCommit $commit + * @param array $audit_requests + */ private function renderAuditStatusView( PhabricatorRepositoryCommit $commit, array $audit_requests) { - assert_instances_of($audit_requests, 'PhabricatorRepositoryAuditRequest'); + assert_instances_of( + $audit_requests, + PhabricatorRepositoryAuditRequest::class); $viewer = $this->getViewer(); $view = new PHUIStatusListView(); diff --git a/src/applications/diffusion/controller/DiffusionSymbolController.php b/src/applications/diffusion/controller/DiffusionSymbolController.php index 2e1c3a1081..be56c93393 100644 --- a/src/applications/diffusion/controller/DiffusionSymbolController.php +++ b/src/applications/diffusion/controller/DiffusionSymbolController.php @@ -99,7 +99,9 @@ final class DiffusionSymbolController extends DiffusionController { } try { - assert_instances_of($source_results, 'PhabricatorRepositorySymbol'); + assert_instances_of( + $source_results, + PhabricatorRepositorySymbol::class); } catch (InvalidArgumentException $ex) { throw new Exception( pht( diff --git a/src/applications/diffusion/data/DiffusionBrowseResultSet.php b/src/applications/diffusion/data/DiffusionBrowseResultSet.php index f112ab49ed..98cdb40792 100644 --- a/src/applications/diffusion/data/DiffusionBrowseResultSet.php +++ b/src/applications/diffusion/data/DiffusionBrowseResultSet.php @@ -16,8 +16,11 @@ final class DiffusionBrowseResultSet extends Phobject { private $existedAtCommit; private $deletedAtCommit; + /** + * @param array $paths + */ public function setPaths(array $paths) { - assert_instances_of($paths, 'DiffusionRepositoryPath'); + assert_instances_of($paths, DiffusionRepositoryPath::class); $this->paths = $paths; return $this; } diff --git a/src/applications/diffusion/data/DiffusionCommitRef.php b/src/applications/diffusion/data/DiffusionCommitRef.php index 76c3371192..be922a7893 100644 --- a/src/applications/diffusion/data/DiffusionCommitRef.php +++ b/src/applications/diffusion/data/DiffusionCommitRef.php @@ -50,8 +50,11 @@ final class DiffusionCommitRef extends Phobject { ->setHashes($hashes); } + /** + * @param array $hashes + */ public function setHashes(array $hashes) { - assert_instances_of($hashes, 'DiffusionCommitHash'); + assert_instances_of($hashes, DiffusionCommitHash::class); $this->hashes = $hashes; return $this; } diff --git a/src/applications/diffusion/engine/DiffusionCommitHookEngine.php b/src/applications/diffusion/engine/DiffusionCommitHookEngine.php index 27f7410090..9f4b1cab2d 100644 --- a/src/applications/diffusion/engine/DiffusionCommitHookEngine.php +++ b/src/applications/diffusion/engine/DiffusionCommitHookEngine.php @@ -267,8 +267,11 @@ final class DiffusionCommitHookEngine extends Phobject { } } + /** + * @param array $ref_updates + */ private function rejectDangerousChanges(array $ref_updates) { - assert_instances_of($ref_updates, 'PhabricatorRepositoryPushLog'); + assert_instances_of($ref_updates, PhabricatorRepositoryPushLog::class); $repository = $this->getRepository(); if ($repository->shouldAllowDangerousChanges()) { @@ -296,8 +299,11 @@ final class DiffusionCommitHookEngine extends Phobject { } } + /** + * @param array $ref_updates + */ private function findContentUpdates(array $ref_updates) { - assert_instances_of($ref_updates, 'PhabricatorRepositoryPushLog'); + assert_instances_of($ref_updates, PhabricatorRepositoryPushLog::class); $type = $this->getRepository()->getVersionControlSystem(); switch ($type) { @@ -471,9 +477,11 @@ final class DiffusionCommitHookEngine extends Phobject { return $ref_updates; } - + /** + * @param array $ref_updates + */ private function findGitMergeBases(array $ref_updates) { - assert_instances_of($ref_updates, 'PhabricatorRepositoryPushLog'); + assert_instances_of($ref_updates, PhabricatorRepositoryPushLog::class); $futures = array(); foreach ($ref_updates as $key => $ref_update) { @@ -522,9 +530,11 @@ final class DiffusionCommitHookEngine extends Phobject { return $ref_updates; } - + /** + * @param array $ref_updates + */ private function findGitChangeFlags(array $ref_updates) { - assert_instances_of($ref_updates, 'PhabricatorRepositoryPushLog'); + assert_instances_of($ref_updates, PhabricatorRepositoryPushLog::class); foreach ($ref_updates as $key => $ref_update) { $ref_old = $ref_update->getRefOld(); diff --git a/src/applications/diffusion/query/DiffusionCommitHintQuery.php b/src/applications/diffusion/query/DiffusionCommitHintQuery.php index 89362ca722..059b0f1c32 100644 --- a/src/applications/diffusion/query/DiffusionCommitHintQuery.php +++ b/src/applications/diffusion/query/DiffusionCommitHintQuery.php @@ -28,8 +28,11 @@ final class DiffusionCommitHintQuery return $this; } + /** + * @param array $commits + */ public function withCommits(array $commits) { - assert_instances_of($commits, 'PhabricatorRepositoryCommit'); + assert_instances_of($commits, PhabricatorRepositoryCommit::class); $repository_phids = array(); foreach ($commits as $commit) { diff --git a/src/applications/diffusion/query/DiffusionCommitQuery.php b/src/applications/diffusion/query/DiffusionCommitQuery.php index 56582b9a9b..b21a80191b 100644 --- a/src/applications/diffusion/query/DiffusionCommitQuery.php +++ b/src/applications/diffusion/query/DiffusionCommitQuery.php @@ -126,8 +126,11 @@ final class DiffusionCommitQuery return $this; } + /** + * @param array $users + */ public function needAuditAuthority(array $users) { - assert_instances_of($users, 'PhabricatorUser'); + assert_instances_of($users, PhabricatorUser::class); $this->needAuditAuthority = $users; return $this; } diff --git a/src/applications/diffusion/query/DiffusionCommitRevisionQuery.php b/src/applications/diffusion/query/DiffusionCommitRevisionQuery.php index 5ddde36c7f..90e752753d 100644 --- a/src/applications/diffusion/query/DiffusionCommitRevisionQuery.php +++ b/src/applications/diffusion/query/DiffusionCommitRevisionQuery.php @@ -3,10 +3,14 @@ final class DiffusionCommitRevisionQuery extends Phobject { + /** + * @param PhabricatorUser $viewer + * @param array $commits + */ public static function loadRevisionMapForCommits( PhabricatorUser $viewer, array $commits) { - assert_instances_of($commits, 'PhabricatorRepositoryCommit'); + assert_instances_of($commits, PhabricatorRepositoryCommit::class); if (!$commits) { return array(); diff --git a/src/applications/diffusion/query/DiffusionRepositoryIdentitySearchEngine.php b/src/applications/diffusion/query/DiffusionRepositoryIdentitySearchEngine.php index d6877433f7..789585cc19 100644 --- a/src/applications/diffusion/query/DiffusionRepositoryIdentitySearchEngine.php +++ b/src/applications/diffusion/query/DiffusionRepositoryIdentitySearchEngine.php @@ -96,11 +96,16 @@ final class DiffusionRepositoryIdentitySearchEngine return parent::buildSavedQueryFromBuiltin($query_key); } + /** + * @param array $identities + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $identities, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($identities, 'PhabricatorRepositoryIdentity'); + assert_instances_of($identities, PhabricatorRepositoryIdentity::class); $viewer = $this->requireViewer(); diff --git a/src/applications/diffusion/query/DiffusionSymbolQuery.php b/src/applications/diffusion/query/DiffusionSymbolQuery.php index 3415fbbefa..029ec3672a 100644 --- a/src/applications/diffusion/query/DiffusionSymbolQuery.php +++ b/src/applications/diffusion/query/DiffusionSymbolQuery.php @@ -242,10 +242,11 @@ final class DiffusionSymbolQuery extends PhabricatorOffsetPagedQuery { /** + * @param array $symbols * @task internal */ private function loadPaths(array $symbols) { - assert_instances_of($symbols, 'PhabricatorRepositorySymbol'); + assert_instances_of($symbols, PhabricatorRepositorySymbol::class); $path_map = queryfx_all( id(new PhabricatorRepository())->establishConnection('r'), 'SELECT * FROM %T WHERE id IN (%Ld)', @@ -257,12 +258,12 @@ final class DiffusionSymbolQuery extends PhabricatorOffsetPagedQuery { } } - /** + * @param array $symbols * @task internal */ private function loadRepositories(array $symbols) { - assert_instances_of($symbols, 'PhabricatorRepositorySymbol'); + assert_instances_of($symbols, PhabricatorRepositorySymbol::class); $repos = id(new PhabricatorRepositoryQuery()) ->setViewer($this->viewer) diff --git a/src/applications/diffusion/query/lowlevel/DiffusionLowLevelCommitFieldsQuery.php b/src/applications/diffusion/query/lowlevel/DiffusionLowLevelCommitFieldsQuery.php index a0548d5178..962561c2e1 100644 --- a/src/applications/diffusion/query/lowlevel/DiffusionLowLevelCommitFieldsQuery.php +++ b/src/applications/diffusion/query/lowlevel/DiffusionLowLevelCommitFieldsQuery.php @@ -112,9 +112,11 @@ final class DiffusionLowLevelCommitFieldsQuery * there is only one revision found. Otherwise, we try to pick an accepted * revision first, followed by an open revision, and otherwise we go with a * closed or abandoned revision as a last resort. + * + * @param array $revisions */ private function pickBestRevision(array $revisions) { - assert_instances_of($revisions, 'DifferentialRevision'); + assert_instances_of($revisions, DifferentialRevision::class); // If we have more than one revision of a given status, choose the most // recently updated one. diff --git a/src/applications/diffusion/symbol/DiffusionExternalSymbolQuery.php b/src/applications/diffusion/symbol/DiffusionExternalSymbolQuery.php index 719496dcdf..c113fb8918 100644 --- a/src/applications/diffusion/symbol/DiffusionExternalSymbolQuery.php +++ b/src/applications/diffusion/symbol/DiffusionExternalSymbolQuery.php @@ -46,8 +46,11 @@ final class DiffusionExternalSymbolQuery extends Phobject { return $this; } + /** + * @param array $repositories + */ public function withRepositories(array $repositories) { - assert_instances_of($repositories, 'PhabricatorRepository'); + assert_instances_of($repositories, PhabricatorRepository::class); $this->repositories = $repositories; return $this; } diff --git a/src/applications/diffusion/view/DiffusionBranchListView.php b/src/applications/diffusion/view/DiffusionBranchListView.php index c0985858f8..7df1665fd1 100644 --- a/src/applications/diffusion/view/DiffusionBranchListView.php +++ b/src/applications/diffusion/view/DiffusionBranchListView.php @@ -5,14 +5,20 @@ final class DiffusionBranchListView extends DiffusionView { private $branches; private $commits = array(); + /** + * @param array $branches + */ public function setBranches(array $branches) { - assert_instances_of($branches, 'DiffusionRepositoryRef'); + assert_instances_of($branches, DiffusionRepositoryRef::class); $this->branches = $branches; return $this; } + /** + * @param array $commits + */ public function setCommits(array $commits) { - assert_instances_of($commits, 'PhabricatorRepositoryCommit'); + assert_instances_of($commits, PhabricatorRepositoryCommit::class); $this->commits = mpull($commits, null, 'getCommitIdentifier'); return $this; } diff --git a/src/applications/diffusion/view/DiffusionBrowseTableView.php b/src/applications/diffusion/view/DiffusionBrowseTableView.php index 36785ca613..1d5acd29ef 100644 --- a/src/applications/diffusion/view/DiffusionBrowseTableView.php +++ b/src/applications/diffusion/view/DiffusionBrowseTableView.php @@ -4,8 +4,11 @@ final class DiffusionBrowseTableView extends DiffusionView { private $paths; + /** + * @param array $paths + */ public function setPaths(array $paths) { - assert_instances_of($paths, 'DiffusionRepositoryPath'); + assert_instances_of($paths, DiffusionRepositoryPath::class); $this->paths = $paths; return $this; } diff --git a/src/applications/diffusion/view/DiffusionCommitGraphView.php b/src/applications/diffusion/view/DiffusionCommitGraphView.php index 3e8f02fcfb..9f4c615071 100644 --- a/src/applications/diffusion/view/DiffusionCommitGraphView.php +++ b/src/applications/diffusion/view/DiffusionCommitGraphView.php @@ -17,8 +17,11 @@ final class DiffusionCommitGraphView private $showAuditors; + /** + * @param array $history + */ public function setHistory(array $history) { - assert_instances_of($history, 'DiffusionPathChange'); + assert_instances_of($history, DiffusionPathChange::class); $this->history = $history; return $this; } @@ -27,8 +30,11 @@ final class DiffusionCommitGraphView return $this->history; } + /** + * @param array $commits + */ public function setCommits(array $commits) { - assert_instances_of($commits, 'PhabricatorRepositoryCommit'); + assert_instances_of($commits, PhabricatorRepositoryCommit::class); $this->commits = $commits; return $this; } diff --git a/src/applications/diffusion/view/DiffusionPullLogListView.php b/src/applications/diffusion/view/DiffusionPullLogListView.php index 8df35e2922..504ec0727f 100644 --- a/src/applications/diffusion/view/DiffusionPullLogListView.php +++ b/src/applications/diffusion/view/DiffusionPullLogListView.php @@ -4,8 +4,11 @@ final class DiffusionPullLogListView extends AphrontView { private $logs; + /** + * @param array $logs + */ public function setLogs(array $logs) { - assert_instances_of($logs, 'PhabricatorRepositoryPullEvent'); + assert_instances_of($logs, PhabricatorRepositoryPullEvent::class); $this->logs = $logs; return $this; } diff --git a/src/applications/diffusion/view/DiffusionPushLogListView.php b/src/applications/diffusion/view/DiffusionPushLogListView.php index d84667ffb5..a2b8e9c9f5 100644 --- a/src/applications/diffusion/view/DiffusionPushLogListView.php +++ b/src/applications/diffusion/view/DiffusionPushLogListView.php @@ -4,8 +4,11 @@ final class DiffusionPushLogListView extends AphrontView { private $logs; + /** + * @param array $logs + */ public function setLogs(array $logs) { - assert_instances_of($logs, 'PhabricatorRepositoryPushLog'); + assert_instances_of($logs, PhabricatorRepositoryPushLog::class); $this->logs = $logs; return $this; } diff --git a/src/applications/diffusion/view/DiffusionSyncLogListView.php b/src/applications/diffusion/view/DiffusionSyncLogListView.php index b4e195122e..0f317c0e21 100644 --- a/src/applications/diffusion/view/DiffusionSyncLogListView.php +++ b/src/applications/diffusion/view/DiffusionSyncLogListView.php @@ -4,8 +4,11 @@ final class DiffusionSyncLogListView extends AphrontView { private $logs; + /** + * @param array $logs + */ public function setLogs(array $logs) { - assert_instances_of($logs, 'PhabricatorRepositorySyncEvent'); + assert_instances_of($logs, PhabricatorRepositorySyncEvent::class); $this->logs = $logs; return $this; } diff --git a/src/applications/diffusion/view/DiffusionView.php b/src/applications/diffusion/view/DiffusionView.php index 268514ff53..3503c60ce5 100644 --- a/src/applications/diffusion/view/DiffusionView.php +++ b/src/applications/diffusion/view/DiffusionView.php @@ -221,8 +221,11 @@ abstract class DiffusionView extends AphrontView { } + /** + * @param array $commits + */ final protected function loadBuildables(array $commits) { - assert_instances_of($commits, 'PhabricatorRepositoryCommit'); + assert_instances_of($commits, PhabricatorRepositoryCommit::class); if (!$commits) { return array(); diff --git a/src/applications/diviner/controller/DivinerAtomController.php b/src/applications/diviner/controller/DivinerAtomController.php index 100fe0f354..60d50d944b 100644 --- a/src/applications/diviner/controller/DivinerAtomController.php +++ b/src/applications/diviner/controller/DivinerAtomController.php @@ -569,8 +569,11 @@ final class DivinerAtomController extends DivinerController { $out); } + /** + * @param array $symbols + */ private function buildParametersAndReturn(array $symbols) { - assert_instances_of($symbols, 'DivinerLiveSymbol'); + assert_instances_of($symbols, DivinerLiveSymbol::class); $symbols = array_reverse($symbols); $out = array(); diff --git a/src/applications/diviner/controller/DivinerController.php b/src/applications/diviner/controller/DivinerController.php index 46908332e3..42bbd9c3df 100644 --- a/src/applications/diviner/controller/DivinerController.php +++ b/src/applications/diviner/controller/DivinerController.php @@ -7,8 +7,11 @@ abstract class DivinerController extends PhabricatorController { ->setSearchEngine(new DivinerAtomSearchEngine()); } + /** + * @param array $symbols + */ protected function renderAtomList(array $symbols) { - assert_instances_of($symbols, 'DivinerLiveSymbol'); + assert_instances_of($symbols, DivinerLiveSymbol::class); $list = array(); foreach ($symbols as $symbol) { diff --git a/src/applications/diviner/query/DivinerAtomQuery.php b/src/applications/diviner/query/DivinerAtomQuery.php index c1eef8dd51..f764093a5c 100644 --- a/src/applications/diviner/query/DivinerAtomQuery.php +++ b/src/applications/diviner/query/DivinerAtomQuery.php @@ -139,8 +139,11 @@ final class DivinerAtomQuery extends PhabricatorCursorPagedPolicyAwareQuery { return $table->loadAllFromArray($data); } + /** + * @param array $atoms + */ protected function willFilterPage(array $atoms) { - assert_instances_of($atoms, 'DivinerLiveSymbol'); + assert_instances_of($atoms, DivinerLiveSymbol::class); $books = array_unique(mpull($atoms, 'getBookPHID')); @@ -440,14 +443,14 @@ final class DivinerAtomQuery extends PhabricatorCursorPagedPolicyAwareQuery { * children. When recursing, also walk up the tree and collect children of * atoms they extend. * - * @param list $symbols List of symbols to collect child - * hashes of. - * @param bool $recurse_up True to collect children of - * extended atoms, as well. - * @return map Hashes of atoms' children. + * @param array $symbols List of symbols to collect child + * hashes of. + * @param bool $recurse_up True to collect children of + * extended atoms, as well. + * @return map Hashes of atoms' children. */ private function getAllChildHashes(array $symbols, $recurse_up) { - assert_instances_of($symbols, 'DivinerLiveSymbol'); + assert_instances_of($symbols, DivinerLiveSymbol::class); $hashes = array(); foreach ($symbols as $symbol) { @@ -473,8 +476,8 @@ final class DivinerAtomQuery extends PhabricatorCursorPagedPolicyAwareQuery { * Attach child atoms to existing atoms. In recursive mode, also attach child * atoms to atoms that these atoms extend. * - * @param list $symbols List of symbols to attach children - * to. + * @param array $symbols List of symbols to attach + * children to. * @param map $children Map of symbols, keyed by * node hash. * @param bool $recurse_up True to attach children to extended atoms, as @@ -486,8 +489,8 @@ final class DivinerAtomQuery extends PhabricatorCursorPagedPolicyAwareQuery { array $children, $recurse_up) { - assert_instances_of($symbols, 'DivinerLiveSymbol'); - assert_instances_of($children, 'DivinerLiveSymbol'); + assert_instances_of($symbols, DivinerLiveSymbol::class); + assert_instances_of($children, DivinerLiveSymbol::class); foreach ($symbols as $symbol) { $child_hashes = array(); diff --git a/src/applications/diviner/query/DivinerAtomSearchEngine.php b/src/applications/diviner/query/DivinerAtomSearchEngine.php index 47dd418c78..c81660e61a 100644 --- a/src/applications/diviner/query/DivinerAtomSearchEngine.php +++ b/src/applications/diviner/query/DivinerAtomSearchEngine.php @@ -123,12 +123,17 @@ final class DivinerAtomSearchEngine extends PhabricatorApplicationSearchEngine { return parent::buildSavedQueryFromBuiltin($query_key); } + /** + * @param array $symbols + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $symbols, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($symbols, 'DivinerLiveSymbol'); + assert_instances_of($symbols, DivinerLiveSymbol::class); $viewer = $this->requireViewer(); diff --git a/src/applications/diviner/query/DivinerBookQuery.php b/src/applications/diviner/query/DivinerBookQuery.php index 76d2cb3f57..675070d231 100644 --- a/src/applications/diviner/query/DivinerBookQuery.php +++ b/src/applications/diviner/query/DivinerBookQuery.php @@ -70,8 +70,11 @@ final class DivinerBookQuery extends PhabricatorCursorPagedPolicyAwareQuery { return $table->loadAllFromArray($data); } + /** + * @param array $books + */ protected function didFilterPage(array $books) { - assert_instances_of($books, 'DivinerLiveBook'); + assert_instances_of($books, DivinerLiveBook::class); if ($this->needRepositories) { $repositories = id(new PhabricatorRepositoryQuery()) diff --git a/src/applications/diviner/workflow/DivinerGenerateWorkflow.php b/src/applications/diviner/workflow/DivinerGenerateWorkflow.php index 6202a1d959..69d6a78c2d 100644 --- a/src/applications/diviner/workflow/DivinerGenerateWorkflow.php +++ b/src/applications/diviner/workflow/DivinerGenerateWorkflow.php @@ -375,8 +375,12 @@ final class DivinerGenerateWorkflow extends DivinerWorkflow { return $futures; } + /** + * @param array $futures + * @param array $file_hashes + */ private function resolveAtomizerFutures(array $futures, array $file_hashes) { - assert_instances_of($futures, 'Future'); + assert_instances_of($futures, Future::class); $atom_cache = $this->getAtomCache(); $bar = id(new PhutilConsoleProgressBar()) diff --git a/src/applications/doorkeeper/engine/DoorkeeperImportEngine.php b/src/applications/doorkeeper/engine/DoorkeeperImportEngine.php index cab49b30b2..f6f7950f73 100644 --- a/src/applications/doorkeeper/engine/DoorkeeperImportEngine.php +++ b/src/applications/doorkeeper/engine/DoorkeeperImportEngine.php @@ -19,8 +19,11 @@ final class DoorkeeperImportEngine extends Phobject { return $this->viewer; } + /** + * @param array $refs + */ public function setRefs(array $refs) { - assert_instances_of($refs, 'DoorkeeperObjectRef'); + assert_instances_of($refs, DoorkeeperObjectRef::class); $this->refs = $refs; return $this; } diff --git a/src/applications/drydock/blueprint/DrydockAlmanacServiceHostBlueprintImplementation.php b/src/applications/drydock/blueprint/DrydockAlmanacServiceHostBlueprintImplementation.php index 290fae8c63..683e9f9682 100644 --- a/src/applications/drydock/blueprint/DrydockAlmanacServiceHostBlueprintImplementation.php +++ b/src/applications/drydock/blueprint/DrydockAlmanacServiceHostBlueprintImplementation.php @@ -242,8 +242,11 @@ final class DrydockAlmanacServiceHostBlueprintImplementation return $this->services; } + /** + * @param array $services + */ private function getActiveBindings(array $services) { - assert_instances_of($services, 'AlmanacService'); + assert_instances_of($services, AlmanacService::class); $bindings = array_mergev(mpull($services, 'getActiveBindings')); return mpull($bindings, null, 'getPHID'); } diff --git a/src/applications/drydock/management/DrydockManagementLeaseWorkflow.php b/src/applications/drydock/management/DrydockManagementLeaseWorkflow.php index af85f6bbec..2694d2cc64 100644 --- a/src/applications/drydock/management/DrydockManagementLeaseWorkflow.php +++ b/src/applications/drydock/management/DrydockManagementLeaseWorkflow.php @@ -308,10 +308,14 @@ final class DrydockManagementLeaseWorkflow return mpull($map, null, 'getPHID'); } + /** + * @param DrydockLease $lease + * @param array $filter_blueprints + */ private function newAllowedBlueprintPHIDs( DrydockLease $lease, array $filter_blueprints) { - assert_instances_of($filter_blueprints, 'DrydockBlueprint'); + assert_instances_of($filter_blueprints, DrydockBlueprint::class); $viewer = $this->getViewer(); diff --git a/src/applications/drydock/query/DrydockBlueprintSearchEngine.php b/src/applications/drydock/query/DrydockBlueprintSearchEngine.php index f556f90146..0e57971c63 100644 --- a/src/applications/drydock/query/DrydockBlueprintSearchEngine.php +++ b/src/applications/drydock/query/DrydockBlueprintSearchEngine.php @@ -70,11 +70,16 @@ final class DrydockBlueprintSearchEngine return parent::buildSavedQueryFromBuiltin($query_key); } + /** + * @param array $blueprints + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $blueprints, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($blueprints, 'DrydockBlueprint'); + assert_instances_of($blueprints, DrydockBlueprint::class); $viewer = $this->requireViewer(); diff --git a/src/applications/drydock/query/DrydockRepositoryOperationSearchEngine.php b/src/applications/drydock/query/DrydockRepositoryOperationSearchEngine.php index 3ab573dd8f..f276e9ccd5 100644 --- a/src/applications/drydock/query/DrydockRepositoryOperationSearchEngine.php +++ b/src/applications/drydock/query/DrydockRepositoryOperationSearchEngine.php @@ -78,11 +78,16 @@ final class DrydockRepositoryOperationSearchEngine return parent::buildSavedQueryFromBuiltin($query_key); } + /** + * @param array $operations + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $operations, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($operations, 'DrydockRepositoryOperation'); + assert_instances_of($operations, DrydockRepositoryOperation::class); $viewer = $this->requireViewer(); diff --git a/src/applications/drydock/view/DrydockAuthorizationListView.php b/src/applications/drydock/view/DrydockAuthorizationListView.php index 28296b6a3a..f0c44c1c7f 100644 --- a/src/applications/drydock/view/DrydockAuthorizationListView.php +++ b/src/applications/drydock/view/DrydockAuthorizationListView.php @@ -5,8 +5,11 @@ final class DrydockAuthorizationListView extends AphrontView { private $authorizations; private $noDataString; + /** + * @param array $authorizations + */ public function setAuthorizations(array $authorizations) { - assert_instances_of($authorizations, 'DrydockAuthorization'); + assert_instances_of($authorizations, DrydockAuthorization::class); $this->authorizations = $authorizations; return $this; } diff --git a/src/applications/drydock/view/DrydockLeaseListView.php b/src/applications/drydock/view/DrydockLeaseListView.php index fb11457e86..d0d2f9b950 100644 --- a/src/applications/drydock/view/DrydockLeaseListView.php +++ b/src/applications/drydock/view/DrydockLeaseListView.php @@ -4,8 +4,11 @@ final class DrydockLeaseListView extends AphrontView { private $leases; + /** + * @param array $leases + */ public function setLeases(array $leases) { - assert_instances_of($leases, 'DrydockLease'); + assert_instances_of($leases, DrydockLease::class); $this->leases = $leases; return $this; } diff --git a/src/applications/drydock/view/DrydockLogListView.php b/src/applications/drydock/view/DrydockLogListView.php index 32f5d0d7ed..f3a580ffff 100644 --- a/src/applications/drydock/view/DrydockLogListView.php +++ b/src/applications/drydock/view/DrydockLogListView.php @@ -44,8 +44,11 @@ final class DrydockLogListView extends AphrontView { return $this->hideOperations; } + /** + * @param array $logs + */ public function setLogs(array $logs) { - assert_instances_of($logs, 'DrydockLog'); + assert_instances_of($logs, DrydockLog::class); $this->logs = $logs; return $this; } diff --git a/src/applications/drydock/view/DrydockResourceListView.php b/src/applications/drydock/view/DrydockResourceListView.php index f2d105ecc8..01b6d167cb 100644 --- a/src/applications/drydock/view/DrydockResourceListView.php +++ b/src/applications/drydock/view/DrydockResourceListView.php @@ -4,8 +4,11 @@ final class DrydockResourceListView extends AphrontView { private $resources; + /** + * @param array $resources + */ public function setResources(array $resources) { - assert_instances_of($resources, 'DrydockResource'); + assert_instances_of($resources, DrydockResource::class); $this->resources = $resources; return $this; } diff --git a/src/applications/drydock/worker/DrydockLeaseUpdateWorker.php b/src/applications/drydock/worker/DrydockLeaseUpdateWorker.php index 8c00a875c8..2ae83da651 100644 --- a/src/applications/drydock/worker/DrydockLeaseUpdateWorker.php +++ b/src/applications/drydock/worker/DrydockLeaseUpdateWorker.php @@ -240,8 +240,12 @@ final class DrydockLeaseUpdateWorker extends DrydockWorker { throw new PhabricatorWorkerYieldException(15); } + /** + * @param DrydockLease $lease + * @param array $blueprints + */ private function reclaimAnyResource(DrydockLease $lease, array $blueprints) { - assert_instances_of($blueprints, 'DrydockBlueprint'); + assert_instances_of($blueprints, DrydockBlueprint::class); $blueprints = $this->rankBlueprints($blueprints, $lease); @@ -331,10 +335,14 @@ final class DrydockLeaseUpdateWorker extends DrydockWorker { throw new PhabricatorWorkerYieldException(15); } + /** + * @param DrydockLease $lease + * @param array $blueprints + */ private function newLeasedResource( DrydockLease $lease, array $blueprints) { - assert_instances_of($blueprints, 'DrydockBlueprint'); + assert_instances_of($blueprints, DrydockBlueprint::class); $usable_blueprints = $this->removeOverallocatedBlueprints( $blueprints, @@ -390,11 +398,15 @@ final class DrydockLeaseUpdateWorker extends DrydockWorker { throw new PhabricatorWorkerYieldException(15); } + /** + * @param DrydockLease $lease + * @param array $resources + */ private function partitionResources( DrydockLease $lease, array $resources) { - assert_instances_of($resources, 'DrydockResource'); + assert_instances_of($resources, DrydockResource::class); $viewer = $this->getViewer(); $lease_statuses = array( @@ -438,10 +450,14 @@ final class DrydockLeaseUpdateWorker extends DrydockWorker { return array($free_resources, $used_resources); } + /** + * @param DrydockLease $lease + * @param array $blueprints + */ private function newResources( DrydockLease $lease, array $blueprints) { - assert_instances_of($blueprints, 'DrydockBlueprint'); + assert_instances_of($blueprints, DrydockBlueprint::class); $resources = array(); $exceptions = array(); @@ -510,11 +526,14 @@ final class DrydockLeaseUpdateWorker extends DrydockWorker { return $resources; } - + /** + * @param DrydockLease $lease + * @param array $resources + */ private function leaseAnyResource( DrydockLease $lease, array $resources) { - assert_instances_of($resources, 'DrydockResource'); + assert_instances_of($resources, DrydockResource::class); if (!$resources) { return null; @@ -645,17 +664,17 @@ final class DrydockLeaseUpdateWorker extends DrydockWorker { * Load a list of all resources which a given lease can possibly be * allocated against. * - * @param list $blueprints Blueprints which may produce + * @param array $blueprints Blueprints which may produce * suitable resources. * @param DrydockLease $lease Requested lease. - * @return list Resources which may be able to allocate + * @return array Resources which may be able to allocate * the lease. * @task allocator */ private function loadAcquirableResourcesForLease( array $blueprints, DrydockLease $lease) { - assert_instances_of($blueprints, 'DrydockBlueprint'); + assert_instances_of($blueprints, DrydockBlueprint::class); $viewer = $this->getViewer(); $resources = id(new DrydockResourceQuery()) @@ -703,15 +722,16 @@ final class DrydockLeaseUpdateWorker extends DrydockWorker { * Remove blueprints which are too heavily allocated to build a resource for * a lease from a list of blueprints. * - * @param list $blueprints List of blueprints. - * @return list $lease List with blueprints that can not + * @param array $blueprints List of blueprints. + * @param DrydockLease $lease + * @return array $lease List with blueprints that can not * allocate a resource for the lease right now removed. * @task allocator */ private function removeOverallocatedBlueprints( array $blueprints, DrydockLease $lease) { - assert_instances_of($blueprints, 'DrydockBlueprint'); + assert_instances_of($blueprints, DrydockBlueprint::class); $keep = array(); @@ -731,13 +751,13 @@ final class DrydockLeaseUpdateWorker extends DrydockWorker { * Rank blueprints by suitability for building a new resource for a * particular lease. * - * @param list $blueprints List of blueprints. + * @param array $blueprints List of blueprints. * @param DrydockLease $lease Requested lease. - * @return list Ranked list of blueprints. + * @return array Ranked list of blueprints. * @task allocator */ private function rankBlueprints(array $blueprints, DrydockLease $lease) { - assert_instances_of($blueprints, 'DrydockBlueprint'); + assert_instances_of($blueprints, DrydockBlueprint::class); // TODO: Implement improvements to this ranking algorithm if they become // available. @@ -750,13 +770,13 @@ final class DrydockLeaseUpdateWorker extends DrydockWorker { /** * Rank resources by suitability for allocating a particular lease. * - * @param list $resources List of resources. + * @param array $resources List of resources. * @param DrydockLease $lease Requested lease. - * @return list Ranked list of resources. + * @return array Ranked list of resources. * @task allocator */ private function rankResources(array $resources, DrydockLease $lease) { - assert_instances_of($resources, 'DrydockResource'); + assert_instances_of($resources, DrydockResource::class); // TODO: Implement improvements to this ranking algorithm if they become // available. diff --git a/src/applications/fact/chart/PhabricatorChartDataset.php b/src/applications/fact/chart/PhabricatorChartDataset.php index a0266053d6..5b235ab9a8 100644 --- a/src/applications/fact/chart/PhabricatorChartDataset.php +++ b/src/applications/fact/chart/PhabricatorChartDataset.php @@ -17,7 +17,7 @@ abstract class PhabricatorChartDataset * @param array $functions */ final public function setFunctions(array $functions) { - assert_instances_of($functions, 'PhabricatorComposeChartFunction'); + assert_instances_of($functions, PhabricatorComposeChartFunction::class); $this->functions = $functions; diff --git a/src/applications/fact/chart/PhabricatorChartFunction.php b/src/applications/fact/chart/PhabricatorChartFunction.php index 84163b2b7b..0f62ed33ea 100644 --- a/src/applications/fact/chart/PhabricatorChartFunction.php +++ b/src/applications/fact/chart/PhabricatorChartFunction.php @@ -38,7 +38,7 @@ abstract class PhabricatorChartFunction phutil_describe_type($specs))); } - assert_instances_of($specs, 'PhabricatorChartFunctionArgument'); + assert_instances_of($specs, PhabricatorChartFunctionArgument::class); foreach ($specs as $spec) { $parser->addArgument($spec); diff --git a/src/applications/fact/chart/PhabricatorChartStackedAreaDataset.php b/src/applications/fact/chart/PhabricatorChartStackedAreaDataset.php index 714ae435c7..8bfe7fe404 100644 --- a/src/applications/fact/chart/PhabricatorChartStackedAreaDataset.php +++ b/src/applications/fact/chart/PhabricatorChartStackedAreaDataset.php @@ -229,7 +229,7 @@ final class PhabricatorChartStackedAreaDataset PhabricatorChartDataQuery $data_query, array $functions) { - assert_instances_of($functions, 'PhabricatorChartFunction'); + assert_instances_of($functions, PhabricatorChartFunction::class); $points = array(); foreach ($functions as $idx => $function) { diff --git a/src/applications/fact/daemon/PhabricatorFactDaemon.php b/src/applications/fact/daemon/PhabricatorFactDaemon.php index 4b4f7da368..d23af9da23 100644 --- a/src/applications/fact/daemon/PhabricatorFactDaemon.php +++ b/src/applications/fact/daemon/PhabricatorFactDaemon.php @@ -119,9 +119,12 @@ final class PhabricatorFactDaemon extends PhabricatorDaemon { return array_mergev($facts); } + /** + * @param array $map + */ private function updateDatapoints(array $map) { foreach ($map as $phid => $facts) { - assert_instances_of($facts, 'PhabricatorFactIntDatapoint'); + assert_instances_of($facts, PhabricatorFactIntDatapoint::class); } $phids = array_keys($map); diff --git a/src/applications/fact/storage/PhabricatorFactChart.php b/src/applications/fact/storage/PhabricatorFactChart.php index 0fb04ccaa5..94d99bf8b4 100644 --- a/src/applications/fact/storage/PhabricatorFactChart.php +++ b/src/applications/fact/storage/PhabricatorFactChart.php @@ -54,8 +54,11 @@ final class PhabricatorFactChart return parent::save(); } + /** + * @param array $datasets + */ public function attachDatasets(array $datasets) { - assert_instances_of($datasets, 'PhabricatorChartDataset'); + assert_instances_of($datasets, PhabricatorChartDataset::class); $this->datasets = $datasets; return $this; } diff --git a/src/applications/feed/builder/PhabricatorFeedBuilder.php b/src/applications/feed/builder/PhabricatorFeedBuilder.php index a3e862fae4..b674d1d837 100644 --- a/src/applications/feed/builder/PhabricatorFeedBuilder.php +++ b/src/applications/feed/builder/PhabricatorFeedBuilder.php @@ -7,8 +7,11 @@ final class PhabricatorFeedBuilder extends Phobject { private $hovercards = false; private $noDataString; + /** + * @param array $stories + */ public function __construct(array $stories) { - assert_instances_of($stories, 'PhabricatorFeedStory'); + assert_instances_of($stories, PhabricatorFeedStory::class); $this->stories = $stories; } diff --git a/src/applications/feed/query/PhabricatorFeedTransactionSearchEngine.php b/src/applications/feed/query/PhabricatorFeedTransactionSearchEngine.php index cc04532d56..8be7f1576d 100644 --- a/src/applications/feed/query/PhabricatorFeedTransactionSearchEngine.php +++ b/src/applications/feed/query/PhabricatorFeedTransactionSearchEngine.php @@ -90,11 +90,16 @@ final class PhabricatorFeedTransactionSearchEngine return parent::buildSavedQueryFromBuiltin($query_key); } + /** + * @param array $objects + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $objects, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($objects, 'PhabricatorApplicationTransaction'); + assert_instances_of($objects, PhabricatorApplicationTransaction::class); $viewer = $this->requireViewer(); diff --git a/src/applications/feed/story/PhabricatorFeedStory.php b/src/applications/feed/story/PhabricatorFeedStory.php index cf1563eb36..83efaff83d 100644 --- a/src/applications/feed/story/PhabricatorFeedStory.php +++ b/src/applications/feed/story/PhabricatorFeedStory.php @@ -288,8 +288,11 @@ abstract class PhabricatorFeedStory return $this->hasViewed; } + /** + * @param array $handles + */ final public function setHandles(array $handles) { - assert_instances_of($handles, 'PhabricatorObjectHandle'); + assert_instances_of($handles, PhabricatorObjectHandle::class); $this->handles = $handles; return $this; } diff --git a/src/applications/files/diff/PhabricatorDocumentEngineBlocks.php b/src/applications/files/diff/PhabricatorDocumentEngineBlocks.php index 8f8d9da39d..552a5efb6c 100644 --- a/src/applications/files/diff/PhabricatorDocumentEngineBlocks.php +++ b/src/applications/files/diff/PhabricatorDocumentEngineBlocks.php @@ -38,11 +38,15 @@ final class PhabricatorDocumentEngineBlocks return $this->messages; } + /** + * @param ?PhabricatorDocumentRef $ref + * @param array $blocks + */ public function addBlockList( ?PhabricatorDocumentRef $ref = null, array $blocks = array()) { - assert_instances_of($blocks, 'PhabricatorDocumentEngineBlock'); + assert_instances_of($blocks, PhabricatorDocumentEngineBlock::class); $this->lists[] = array( 'ref' => $ref, diff --git a/src/applications/files/favicon/PhabricatorFaviconRefQuery.php b/src/applications/files/favicon/PhabricatorFaviconRefQuery.php index f4e5556150..9147ffde0d 100644 --- a/src/applications/files/favicon/PhabricatorFaviconRefQuery.php +++ b/src/applications/files/favicon/PhabricatorFaviconRefQuery.php @@ -4,8 +4,11 @@ final class PhabricatorFaviconRefQuery extends Phobject { private $refs; + /** + * @param array $refs + */ public function withRefs(array $refs) { - assert_instances_of($refs, 'PhabricatorFaviconRef'); + assert_instances_of($refs, PhabricatorFaviconRef::class); $this->refs = $refs; return $this; } diff --git a/src/applications/files/query/PhabricatorFileSearchEngine.php b/src/applications/files/query/PhabricatorFileSearchEngine.php index fd2dffc1d5..a974bbd09b 100644 --- a/src/applications/files/query/PhabricatorFileSearchEngine.php +++ b/src/applications/files/query/PhabricatorFileSearchEngine.php @@ -122,12 +122,17 @@ final class PhabricatorFileSearchEngine return mpull($files, 'getAuthorPHID'); } + /** + * @param array $files + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $files, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($files, 'PhabricatorFile'); + assert_instances_of($files, PhabricatorFile::class); $request = $this->getRequest(); if ($request) { diff --git a/src/applications/files/storage/PhabricatorFile.php b/src/applications/files/storage/PhabricatorFile.php index 89fb879d88..616807ec08 100644 --- a/src/applications/files/storage/PhabricatorFile.php +++ b/src/applications/files/storage/PhabricatorFile.php @@ -344,7 +344,7 @@ final class PhabricatorFile extends PhabricatorFileDAO } } - assert_instances_of($engines, 'PhabricatorFileStorageEngine'); + assert_instances_of($engines, PhabricatorFileStorageEngine::class); if (!$engines) { throw new Exception(pht('No valid storage engines are available!')); } diff --git a/src/applications/flag/query/PhabricatorFlagSearchEngine.php b/src/applications/flag/query/PhabricatorFlagSearchEngine.php index 4f524d470b..d37dfba015 100644 --- a/src/applications/flag/query/PhabricatorFlagSearchEngine.php +++ b/src/applications/flag/query/PhabricatorFlagSearchEngine.php @@ -126,11 +126,16 @@ final class PhabricatorFlagSearchEngine return $options; } + /** + * @param array $flags + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $flags, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($flags, 'PhabricatorFlag'); + assert_instances_of($flags, PhabricatorFlag::class); $viewer = $this->requireViewer(); diff --git a/src/applications/harbormaster/engine/HarbormasterBuildEngine.php b/src/applications/harbormaster/engine/HarbormasterBuildEngine.php index 8b43f6fa14..32f02bf10d 100644 --- a/src/applications/harbormaster/engine/HarbormasterBuildEngine.php +++ b/src/applications/harbormaster/engine/HarbormasterBuildEngine.php @@ -322,14 +322,14 @@ final class HarbormasterBuildEngine extends Phobject { * particularly relevant when a build uses multiple hosts since it returns * hosts to the pool more quickly. * - * @param list $targets Targets in the build. - * @param list $steps List of running and waiting - * steps. + * @param array $targets Targets in the build. + * @param array $steps List of running and waiting + * steps. * @return void */ private function releaseUnusedArtifacts(array $targets, array $steps) { - assert_instances_of($targets, 'HarbormasterBuildTarget'); - assert_instances_of($steps, 'HarbormasterBuildStep'); + assert_instances_of($targets, HarbormasterBuildTarget::class); + assert_instances_of($steps, HarbormasterBuildStep::class); if (!$targets || !$steps) { return; @@ -373,11 +373,11 @@ final class HarbormasterBuildEngine extends Phobject { * Process messages which were sent to these targets, kicking applicable * targets out of "Waiting" and into either "Passed" or "Failed". * - * @param list $targets List of targets to process. + * @param array $targets List of targets to process. * @return void */ private function updateWaitingTargets(array $targets) { - assert_instances_of($targets, 'HarbormasterBuildTarget'); + assert_instances_of($targets, HarbormasterBuildTarget::class); // We only care about messages for targets which are actually in a waiting // state. diff --git a/src/applications/harbormaster/plan/HarbormasterBuildPlanBehavior.php b/src/applications/harbormaster/plan/HarbormasterBuildPlanBehavior.php index 112926c47c..840ab453ff 100644 --- a/src/applications/harbormaster/plan/HarbormasterBuildPlanBehavior.php +++ b/src/applications/harbormaster/plan/HarbormasterBuildPlanBehavior.php @@ -65,8 +65,11 @@ final class HarbormasterBuildPlanBehavior return mpull($this->options, 'getName', 'getKey'); } + /** + * @param array $options + */ public function setOptions(array $options) { - assert_instances_of($options, 'HarbormasterBuildPlanBehaviorOption'); + assert_instances_of($options, HarbormasterBuildPlanBehaviorOption::class); $key_map = array(); $default = null; diff --git a/src/applications/harbormaster/query/HarbormasterArtifactSearchEngine.php b/src/applications/harbormaster/query/HarbormasterArtifactSearchEngine.php index a839163879..505c2bdfe2 100644 --- a/src/applications/harbormaster/query/HarbormasterArtifactSearchEngine.php +++ b/src/applications/harbormaster/query/HarbormasterArtifactSearchEngine.php @@ -67,11 +67,16 @@ final class HarbormasterArtifactSearchEngine return parent::buildSavedQueryFromBuiltin($query_key); } + /** + * @param array $artifacts + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $artifacts, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($artifacts, 'HarbormasterBuildArtifact'); + assert_instances_of($artifacts, HarbormasterBuildArtifact::class); $viewer = $this->requireViewer(); diff --git a/src/applications/harbormaster/query/HarbormasterBuildPlanSearchEngine.php b/src/applications/harbormaster/query/HarbormasterBuildPlanSearchEngine.php index 930308e496..bb384e31c0 100644 --- a/src/applications/harbormaster/query/HarbormasterBuildPlanSearchEngine.php +++ b/src/applications/harbormaster/query/HarbormasterBuildPlanSearchEngine.php @@ -76,11 +76,16 @@ final class HarbormasterBuildPlanSearchEngine return parent::buildSavedQueryFromBuiltin($query_key); } + /** + * @param array $plans + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $plans, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($plans, 'HarbormasterBuildPlan'); + assert_instances_of($plans, HarbormasterBuildPlan::class); $viewer = $this->requireViewer(); diff --git a/src/applications/harbormaster/query/HarbormasterBuildSearchEngine.php b/src/applications/harbormaster/query/HarbormasterBuildSearchEngine.php index 4b722c4990..9e969d894e 100644 --- a/src/applications/harbormaster/query/HarbormasterBuildSearchEngine.php +++ b/src/applications/harbormaster/query/HarbormasterBuildSearchEngine.php @@ -120,11 +120,16 @@ final class HarbormasterBuildSearchEngine return parent::buildSavedQueryFromBuiltin($query_key); } + /** + * @param array $builds + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $builds, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($builds, 'HarbormasterBuild'); + assert_instances_of($builds, HarbormasterBuild::class); $viewer = $this->requireViewer(); diff --git a/src/applications/harbormaster/query/HarbormasterBuildStepSearchEngine.php b/src/applications/harbormaster/query/HarbormasterBuildStepSearchEngine.php index 3ff1707edf..df34b312ba 100644 --- a/src/applications/harbormaster/query/HarbormasterBuildStepSearchEngine.php +++ b/src/applications/harbormaster/query/HarbormasterBuildStepSearchEngine.php @@ -47,11 +47,16 @@ final class HarbormasterBuildStepSearchEngine return parent::buildSavedQueryFromBuiltin($query_key); } + /** + * @param array $plans + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $plans, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($plans, 'HarbormasterBuildStep'); + assert_instances_of($plans, HarbormasterBuildStep::class); return null; } diff --git a/src/applications/harbormaster/query/HarbormasterBuildTargetSearchEngine.php b/src/applications/harbormaster/query/HarbormasterBuildTargetSearchEngine.php index 5ad5919eb9..4f35490b3a 100644 --- a/src/applications/harbormaster/query/HarbormasterBuildTargetSearchEngine.php +++ b/src/applications/harbormaster/query/HarbormasterBuildTargetSearchEngine.php @@ -117,11 +117,16 @@ final class HarbormasterBuildTargetSearchEngine return parent::buildSavedQueryFromBuiltin($query_key); } + /** + * @param array $builds + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $builds, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($builds, 'HarbormasterBuildTarget'); + assert_instances_of($builds, HarbormasterBuildTarget::class); // Currently, this only supports the "harbormaster.target.search" // API method. diff --git a/src/applications/harbormaster/query/HarbormasterBuildableSearchEngine.php b/src/applications/harbormaster/query/HarbormasterBuildableSearchEngine.php index 88fbd8f8b6..37a215d85a 100644 --- a/src/applications/harbormaster/query/HarbormasterBuildableSearchEngine.php +++ b/src/applications/harbormaster/query/HarbormasterBuildableSearchEngine.php @@ -116,11 +116,16 @@ final class HarbormasterBuildableSearchEngine return parent::buildSavedQueryFromBuiltin($query_key); } + /** + * @param array $buildables + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $buildables, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($buildables, 'HarbormasterBuildable'); + assert_instances_of($buildables, HarbormasterBuildable::class); $viewer = $this->requireViewer(); diff --git a/src/applications/harbormaster/storage/HarbormasterBuildable.php b/src/applications/harbormaster/storage/HarbormasterBuildable.php index e0976c4bd0..d57b60f15b 100644 --- a/src/applications/harbormaster/storage/HarbormasterBuildable.php +++ b/src/applications/harbormaster/storage/HarbormasterBuildable.php @@ -62,7 +62,8 @@ final class HarbormasterBuildable * * @param string $phid PHID of the object to build. * @param string $container_phid Container PHID for the buildable. - * @param list $requests List of builds to perform. + * @param array $requests List of builds to + * perform. * @return void */ public static function applyBuildPlans( @@ -70,7 +71,7 @@ final class HarbormasterBuildable $container_phid, array $requests) { - assert_instances_of($requests, 'HarbormasterBuildRequest'); + assert_instances_of($requests, HarbormasterBuildRequest::class); if (!$requests) { return; @@ -208,8 +209,11 @@ final class HarbormasterBuildable return $this->assertAttached($this->containerObject); } + /** + * @param array $builds + */ public function attachBuilds(array $builds) { - assert_instances_of($builds, 'HarbormasterBuild'); + assert_instances_of($builds, HarbormasterBuild::class); $this->builds = $builds; return $this; } diff --git a/src/applications/harbormaster/storage/build/HarbormasterBuild.php b/src/applications/harbormaster/storage/build/HarbormasterBuild.php index 0b509cd305..3653aa9241 100644 --- a/src/applications/harbormaster/storage/build/HarbormasterBuild.php +++ b/src/applications/harbormaster/storage/build/HarbormasterBuild.php @@ -309,8 +309,11 @@ final class HarbormasterBuild extends HarbormasterDAO return array($pending_status, $apply_messages); } + /** + * @param array $messages + */ public function attachUnprocessedMessages(array $messages) { - assert_instances_of($messages, 'HarbormasterBuildMessage'); + assert_instances_of($messages, HarbormasterBuildMessage::class); $this->unprocessedMessages = $messages; return $this; } diff --git a/src/applications/harbormaster/storage/configuration/HarbormasterBuildPlan.php b/src/applications/harbormaster/storage/configuration/HarbormasterBuildPlan.php index 0fc516264e..43db59ab1c 100644 --- a/src/applications/harbormaster/storage/configuration/HarbormasterBuildPlan.php +++ b/src/applications/harbormaster/storage/configuration/HarbormasterBuildPlan.php @@ -75,8 +75,11 @@ final class HarbormasterBuildPlan extends HarbormasterDAO HarbormasterBuildPlanPHIDType::TYPECONST); } + /** + * @param array $steps + */ public function attachBuildSteps(array $steps) { - assert_instances_of($steps, 'HarbormasterBuildStep'); + assert_instances_of($steps, HarbormasterBuildStep::class); $this->buildSteps = $steps; return $this; } diff --git a/src/applications/harbormaster/view/HarbormasterBuildView.php b/src/applications/harbormaster/view/HarbormasterBuildView.php index f54b1d3ba6..6810df2b14 100644 --- a/src/applications/harbormaster/view/HarbormasterBuildView.php +++ b/src/applications/harbormaster/view/HarbormasterBuildView.php @@ -5,8 +5,11 @@ final class HarbormasterBuildView private $builds = array(); + /** + * @param array $builds + */ public function setBuilds(array $builds) { - assert_instances_of($builds, 'HarbormasterBuild'); + assert_instances_of($builds, HarbormasterBuild::class); $this->builds = $builds; return $this; } diff --git a/src/applications/harbormaster/view/HarbormasterLintPropertyView.php b/src/applications/harbormaster/view/HarbormasterLintPropertyView.php index abfaa7e222..04103de9e8 100644 --- a/src/applications/harbormaster/view/HarbormasterLintPropertyView.php +++ b/src/applications/harbormaster/view/HarbormasterLintPropertyView.php @@ -11,8 +11,11 @@ final class HarbormasterLintPropertyView extends AphrontView { return $this; } + /** + * @param array $messages + */ public function setLintMessages(array $messages) { - assert_instances_of($messages, 'HarbormasterBuildLintMessage'); + assert_instances_of($messages, HarbormasterBuildLintMessage::class); $this->lintMessages = $messages; return $this; } diff --git a/src/applications/harbormaster/view/HarbormasterUnitPropertyView.php b/src/applications/harbormaster/view/HarbormasterUnitPropertyView.php index 2306f5ba64..46d92b4806 100644 --- a/src/applications/harbormaster/view/HarbormasterUnitPropertyView.php +++ b/src/applications/harbormaster/view/HarbormasterUnitPropertyView.php @@ -13,8 +13,11 @@ final class HarbormasterUnitPropertyView extends AphrontView { return $this; } + /** + * @param array $messages + */ public function setUnitMessages(array $messages) { - assert_instances_of($messages, 'HarbormasterBuildUnitMessage'); + assert_instances_of($messages, HarbormasterBuildUnitMessage::class); $this->unitMessages = $messages; return $this; } diff --git a/src/applications/herald/editor/HeraldRuleSerializer.php b/src/applications/herald/editor/HeraldRuleSerializer.php index fa4d4b3ea4..acff547622 100644 --- a/src/applications/herald/editor/HeraldRuleSerializer.php +++ b/src/applications/herald/editor/HeraldRuleSerializer.php @@ -13,10 +13,11 @@ final class HeraldRuleSerializer extends Phobject { } /** +<<<<<<< HEAD * @param $match_all * @param array $conditions * @param array $actions - * @param $repetition_policy + * @param string $repetition_policy One of the HeraldRule::REPEAT_ constants * @return array */ public function serializeRuleComponents( diff --git a/src/applications/herald/engine/HeraldEngine.php b/src/applications/herald/engine/HeraldEngine.php index 905b7e291f..fc563c753d 100644 --- a/src/applications/herald/engine/HeraldEngine.php +++ b/src/applications/herald/engine/HeraldEngine.php @@ -125,7 +125,7 @@ final class HeraldEngine extends Phobject { /** * @param array $rules * @param HeraldAdapter $object - * @return array + * @return array */ public function applyRules(array $rules, HeraldAdapter $object) { assert_instances_of($rules, HeraldRule::class); diff --git a/src/applications/herald/query/HeraldRuleSearchEngine.php b/src/applications/herald/query/HeraldRuleSearchEngine.php index b1639cc28d..7448d8958b 100644 --- a/src/applications/herald/query/HeraldRuleSearchEngine.php +++ b/src/applications/herald/query/HeraldRuleSearchEngine.php @@ -133,7 +133,7 @@ final class HeraldRuleSearchEngine extends PhabricatorApplicationSearchEngine { /** * @param array $rules * @param PhabricatorSavedQuery $query - * @param array $handles + * @param array $handles */ protected function renderResultList( array $rules, diff --git a/src/applications/herald/query/HeraldTranscriptSearchEngine.php b/src/applications/herald/query/HeraldTranscriptSearchEngine.php index 5c4b11ead8..4b020a6adf 100644 --- a/src/applications/herald/query/HeraldTranscriptSearchEngine.php +++ b/src/applications/herald/query/HeraldTranscriptSearchEngine.php @@ -107,7 +107,7 @@ final class HeraldTranscriptSearchEngine /** * @param array $transcripts * @param PhabricatorSavedQuery $query - * @param array $handles + * @param array $handles */ protected function renderResultList( array $transcripts, diff --git a/src/applications/legalpad/query/LegalpadDocumentSearchEngine.php b/src/applications/legalpad/query/LegalpadDocumentSearchEngine.php index cf168451a4..5866c2356c 100644 --- a/src/applications/legalpad/query/LegalpadDocumentSearchEngine.php +++ b/src/applications/legalpad/query/LegalpadDocumentSearchEngine.php @@ -103,11 +103,16 @@ final class LegalpadDocumentSearchEngine return parent::buildSavedQueryFromBuiltin($query_key); } + /** + * @param array $documents + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $documents, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($documents, 'LegalpadDocument'); + assert_instances_of($documents, LegalpadDocument::class); $viewer = $this->requireViewer(); diff --git a/src/applications/legalpad/query/LegalpadDocumentSignatureSearchEngine.php b/src/applications/legalpad/query/LegalpadDocumentSignatureSearchEngine.php index d2c8149349..03fd2281f3 100644 --- a/src/applications/legalpad/query/LegalpadDocumentSignatureSearchEngine.php +++ b/src/applications/legalpad/query/LegalpadDocumentSignatureSearchEngine.php @@ -216,11 +216,16 @@ final class LegalpadDocumentSignatureSearchEngine mpull($signatures, 'getDocumentPHID')); } + /** + * @param array $signatures + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $signatures, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($signatures, 'LegalpadDocumentSignature'); + assert_instances_of($signatures, LegalpadDocumentSignature::class); $viewer = $this->requireViewer(); diff --git a/src/applications/macro/query/PhabricatorMacroSearchEngine.php b/src/applications/macro/query/PhabricatorMacroSearchEngine.php index e61f52b8b8..87559b13b2 100644 --- a/src/applications/macro/query/PhabricatorMacroSearchEngine.php +++ b/src/applications/macro/query/PhabricatorMacroSearchEngine.php @@ -127,12 +127,17 @@ final class PhabricatorMacroSearchEngine return parent::buildSavedQueryFromBuiltin($query_key); } + /** + * @param array $macros + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $macros, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($macros, 'PhabricatorFileImageMacro'); + assert_instances_of($macros, PhabricatorFileImageMacro::class); $viewer = $this->requireViewer(); $handles = $viewer->loadHandles(mpull($macros, 'getAuthorPHID')); diff --git a/src/applications/maniphest/conduit/ManiphestConduitAPIMethod.php b/src/applications/maniphest/conduit/ManiphestConduitAPIMethod.php index 855769472a..df79364383 100644 --- a/src/applications/maniphest/conduit/ManiphestConduitAPIMethod.php +++ b/src/applications/maniphest/conduit/ManiphestConduitAPIMethod.php @@ -217,8 +217,11 @@ abstract class ManiphestConduitAPIMethod extends ConduitAPIMethod { ->executeOne(); } + /** + * @param array $tasks + */ protected function buildTaskInfoDictionaries(array $tasks) { - assert_instances_of($tasks, 'ManiphestTask'); + assert_instances_of($tasks, ManiphestTask::class); if (!$tasks) { return array(); } diff --git a/src/applications/maniphest/controller/ManiphestReportController.php b/src/applications/maniphest/controller/ManiphestReportController.php index 5e4d090f1c..8c5deee625 100644 --- a/src/applications/maniphest/controller/ManiphestReportController.php +++ b/src/applications/maniphest/controller/ManiphestReportController.php @@ -571,11 +571,12 @@ final class ManiphestReportController extends ManiphestController { * Render date of oldest open task per user or per project with a link. * Used on /maniphest/report/user/ and /maniphest/report/project/ URIs. * + * @param array $tasks * @return array HTML link markup and the timespan * (as epoch) since task creation */ private function renderOldest(array $tasks) { - assert_instances_of($tasks, 'ManiphestTask'); + assert_instances_of($tasks, ManiphestTask::class); $oldest = null; foreach ($tasks as $id => $task) { if (($oldest === null) || diff --git a/src/applications/maniphest/view/ManiphestTaskListView.php b/src/applications/maniphest/view/ManiphestTaskListView.php index 19a03ea37f..3581bce144 100644 --- a/src/applications/maniphest/view/ManiphestTaskListView.php +++ b/src/applications/maniphest/view/ManiphestTaskListView.php @@ -152,12 +152,17 @@ final class ManiphestTaskListView extends ManiphestView { return $list; } - // This method should be removed, and all call-sites switch - // to use ManiphestSearchEngine + /** + * Deprecated. + * @param PhabricatorUser $viewer + * @param array $tasks + */ public static function loadTaskHandles( PhabricatorUser $viewer, array $tasks) { - assert_instances_of($tasks, 'ManiphestTask'); + // TODO: This method should be removed, and all call-sites switch + // to use ManiphestSearchEngine + assert_instances_of($tasks, ManiphestTask::class); $phids = array(); foreach ($tasks as $task) { diff --git a/src/applications/maniphest/view/ManiphestTaskResultListView.php b/src/applications/maniphest/view/ManiphestTaskResultListView.php index f21e9cb43e..76a0f4ee1a 100644 --- a/src/applications/maniphest/view/ManiphestTaskResultListView.php +++ b/src/applications/maniphest/view/ManiphestTaskResultListView.php @@ -87,10 +87,15 @@ final class ManiphestTaskResultListView extends ManiphestView { ); } - + /** + * @param array $tasks + * @param string $group + * @param array $handles + * @return array> + */ private function groupTasks(array $tasks, $group, array $handles) { - assert_instances_of($tasks, 'ManiphestTask'); - assert_instances_of($handles, 'PhabricatorObjectHandle'); + assert_instances_of($tasks, ManiphestTask::class); + assert_instances_of($handles, PhabricatorObjectHandle::class); $groups = $this->getTaskGrouping($tasks, $group); diff --git a/src/applications/meta/query/PhabricatorAppSearchEngine.php b/src/applications/meta/query/PhabricatorAppSearchEngine.php index b4d5d9b9c2..354b744658 100644 --- a/src/applications/meta/query/PhabricatorAppSearchEngine.php +++ b/src/applications/meta/query/PhabricatorAppSearchEngine.php @@ -178,11 +178,16 @@ final class PhabricatorAppSearchEngine return parent::buildSavedQueryFromBuiltin($query_key); } + /** + * @param array $all_applications + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $all_applications, PhabricatorSavedQuery $query, - array $handle) { - assert_instances_of($all_applications, 'PhabricatorApplication'); + array $handles) { + assert_instances_of($all_applications, PhabricatorApplication::class); $all_applications = msort($all_applications, 'getName'); diff --git a/src/applications/metamta/engine/PhabricatorMailEmailEngine.php b/src/applications/metamta/engine/PhabricatorMailEmailEngine.php index 872f417cb2..38e1672f72 100644 --- a/src/applications/metamta/engine/PhabricatorMailEmailEngine.php +++ b/src/applications/metamta/engine/PhabricatorMailEmailEngine.php @@ -537,8 +537,12 @@ final class PhabricatorMailEmailEngine return $install_uri->getDomain(); } + /** + * @param array $headers + * @param bool $must_encrypt + */ private function filterHeaders(array $headers, $must_encrypt) { - assert_instances_of($headers, 'PhabricatorMailHeader'); + assert_instances_of($headers, PhabricatorMailHeader::class); if (!$must_encrypt) { return $headers; @@ -582,11 +586,15 @@ final class PhabricatorMailEmailEngine return $headers; } + /** + * @param array $addresses + * @param array $exclude + */ private function getUniqueEmailAddresses( array $addresses, array $exclude = array()) { - assert_instances_of($addresses, 'PhutilEmailAddress'); - assert_instances_of($exclude, 'PhutilEmailAddress'); + assert_instances_of($addresses, PhutilEmailAddress::class); + assert_instances_of($exclude, PhutilEmailAddress::class); $seen = array(); diff --git a/src/applications/metamta/engine/PhabricatorMailMessageEngine.php b/src/applications/metamta/engine/PhabricatorMailMessageEngine.php index c65346bf58..b2090ef367 100644 --- a/src/applications/metamta/engine/PhabricatorMailMessageEngine.php +++ b/src/applications/metamta/engine/PhabricatorMailMessageEngine.php @@ -27,8 +27,11 @@ abstract class PhabricatorMailMessageEngine return $this->mail; } + /** + * @param array $actors + */ final public function setActors(array $actors) { - assert_instances_of($actors, 'PhabricatorMetaMTAActor'); + assert_instances_of($actors, PhabricatorMetaMTAActor::class); $this->actors = $actors; return $this; } diff --git a/src/applications/metamta/message/PhabricatorMailEmailMessage.php b/src/applications/metamta/message/PhabricatorMailEmailMessage.php index c98cdc2e33..e82ebd481d 100644 --- a/src/applications/metamta/message/PhabricatorMailEmailMessage.php +++ b/src/applications/metamta/message/PhabricatorMailEmailMessage.php @@ -37,8 +37,11 @@ final class PhabricatorMailEmailMessage return $this->replyToAddress; } + /** + * @param array $addresses + */ public function setToAddresses(array $addresses) { - assert_instances_of($addresses, 'PhutilEmailAddress'); + assert_instances_of($addresses, PhutilEmailAddress::class); $this->toAddresses = $addresses; return $this; } @@ -47,8 +50,11 @@ final class PhabricatorMailEmailMessage return $this->toAddresses; } + /** + * @param array $addresses + */ public function setCCAddresses(array $addresses) { - assert_instances_of($addresses, 'PhutilEmailAddress'); + assert_instances_of($addresses, PhutilEmailAddress::class); $this->ccAddresses = $addresses; return $this; } @@ -57,8 +63,11 @@ final class PhabricatorMailEmailMessage return $this->ccAddresses; } + /** + * @param array $headers + */ public function setHeaders(array $headers) { - assert_instances_of($headers, 'PhabricatorMailHeader'); + assert_instances_of($headers, PhabricatorMailHeader::class); $this->headers = $headers; return $this; } @@ -67,8 +76,11 @@ final class PhabricatorMailEmailMessage return $this->headers; } + /** + * @param array $attachments + */ public function setAttachments(array $attachments) { - assert_instances_of($attachments, 'PhabricatorMailAttachment'); + assert_instances_of($attachments, PhabricatorMailAttachment::class); $this->attachments = $attachments; return $this; } diff --git a/src/applications/metamta/query/PhabricatorMetaMTAActorQuery.php b/src/applications/metamta/query/PhabricatorMetaMTAActorQuery.php index 62aff57a71..f7d5654147 100644 --- a/src/applications/metamta/query/PhabricatorMetaMTAActorQuery.php +++ b/src/applications/metamta/query/PhabricatorMetaMTAActorQuery.php @@ -45,8 +45,12 @@ final class PhabricatorMetaMTAActorQuery extends PhabricatorQuery { return $actors; } + /** + * @param array $actors + * @param array $phids + */ private function loadUserActors(array $actors, array $phids) { - assert_instances_of($actors, 'PhabricatorMetaMTAActor'); + assert_instances_of($actors, PhabricatorMetaMTAActor::class); $emails = id(new PhabricatorUserEmail())->loadAllWhere( 'userPHID IN (%Ls) AND isPrimary = 1', diff --git a/src/applications/metamta/query/PhabricatorMetaMTAMailSearchEngine.php b/src/applications/metamta/query/PhabricatorMetaMTAMailSearchEngine.php index d3ae165e2a..ddfec31461 100644 --- a/src/applications/metamta/query/PhabricatorMetaMTAMailSearchEngine.php +++ b/src/applications/metamta/query/PhabricatorMetaMTAMailSearchEngine.php @@ -94,12 +94,17 @@ final class PhabricatorMetaMTAMailSearchEngine return array_mergev($phids); } + /** + * @param array $mails + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $mails, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($mails, 'PhabricatorMetaMTAMail'); + assert_instances_of($mails, PhabricatorMetaMTAMail::class); $viewer = $this->requireViewer(); $list = new PHUIObjectItemListView(); diff --git a/src/applications/metamta/storage/PhabricatorMetaMTAMail.php b/src/applications/metamta/storage/PhabricatorMetaMTAMail.php index ca102ae8ac..b45b9e965d 100644 --- a/src/applications/metamta/storage/PhabricatorMetaMTAMail.php +++ b/src/applications/metamta/storage/PhabricatorMetaMTAMail.php @@ -239,8 +239,11 @@ final class PhabricatorMetaMTAMail ->execute(); } + /** + * @param array $attachments + */ public function setAttachments(array $attachments) { - assert_instances_of($attachments, 'PhabricatorMailAttachment'); + assert_instances_of($attachments, PhabricatorMailAttachment::class); $this->setParam('attachments', mpull($attachments, 'toDictionary')); return $this; } @@ -880,8 +883,11 @@ final class PhabricatorMetaMTAMail return array_keys($results); } + /** + * @param array $actors + */ private function filterDeliverableActors(array $actors) { - assert_instances_of($actors, 'PhabricatorMetaMTAActor'); + assert_instances_of($actors, PhabricatorMetaMTAActor::class); $deliverable_actors = array(); foreach ($actors as $phid => $actor) { if ($actor->isDeliverable()) { @@ -1088,8 +1094,11 @@ final class PhabricatorMetaMTAMail return $this->setParam('headers.unfiltered', $headers); } + /** + * @param array $headers + */ private function flattenHeaders(array $headers) { - assert_instances_of($headers, 'PhabricatorMailHeader'); + assert_instances_of($headers, PhabricatorMailHeader::class); $list = array(); foreach ($list as $header) { diff --git a/src/applications/notification/builder/PhabricatorNotificationBuilder.php b/src/applications/notification/builder/PhabricatorNotificationBuilder.php index b9a79be3f3..c93dfe0a59 100644 --- a/src/applications/notification/builder/PhabricatorNotificationBuilder.php +++ b/src/applications/notification/builder/PhabricatorNotificationBuilder.php @@ -7,8 +7,11 @@ final class PhabricatorNotificationBuilder extends Phobject { private $user = null; private $showTimestamps = true; + /** + * @param array $stories + */ public function __construct(array $stories) { - assert_instances_of($stories, 'PhabricatorFeedStory'); + assert_instances_of($stories, PhabricatorFeedStory::class); $this->stories = $stories; } diff --git a/src/applications/notification/query/PhabricatorNotificationSearchEngine.php b/src/applications/notification/query/PhabricatorNotificationSearchEngine.php index 3169a4d972..2df5359348 100644 --- a/src/applications/notification/query/PhabricatorNotificationSearchEngine.php +++ b/src/applications/notification/query/PhabricatorNotificationSearchEngine.php @@ -76,11 +76,16 @@ final class PhabricatorNotificationSearchEngine return parent::buildSavedQueryFromBuiltin($query_key); } + /** + * @param array $notifications + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $notifications, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($notifications, 'PhabricatorFeedStory'); + assert_instances_of($notifications, PhabricatorFeedStory::class); $viewer = $this->requireViewer(); diff --git a/src/applications/nuance/query/NuanceItemSearchEngine.php b/src/applications/nuance/query/NuanceItemSearchEngine.php index 4b65c73394..98f7f2fbb5 100644 --- a/src/applications/nuance/query/NuanceItemSearchEngine.php +++ b/src/applications/nuance/query/NuanceItemSearchEngine.php @@ -50,11 +50,16 @@ final class NuanceItemSearchEngine return parent::buildSavedQueryFromBuiltin($query_key); } + /** + * @param array $items + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $items, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($items, 'NuanceItem'); + assert_instances_of($items, NuanceItem::class); $viewer = $this->requireViewer(); diff --git a/src/applications/nuance/query/NuanceQueueSearchEngine.php b/src/applications/nuance/query/NuanceQueueSearchEngine.php index 7f3188b0c1..3250832ba2 100644 --- a/src/applications/nuance/query/NuanceQueueSearchEngine.php +++ b/src/applications/nuance/query/NuanceQueueSearchEngine.php @@ -49,11 +49,16 @@ final class NuanceQueueSearchEngine return parent::buildSavedQueryFromBuiltin($query_key); } + /** + * @param array $queues + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $queues, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($queues, 'NuanceQueue'); + assert_instances_of($queues, NuanceQueue::class); $viewer = $this->requireViewer(); diff --git a/src/applications/nuance/query/NuanceSourceSearchEngine.php b/src/applications/nuance/query/NuanceSourceSearchEngine.php index 7a1690eedf..9a28befb9e 100644 --- a/src/applications/nuance/query/NuanceSourceSearchEngine.php +++ b/src/applications/nuance/query/NuanceSourceSearchEngine.php @@ -58,11 +58,16 @@ final class NuanceSourceSearchEngine return parent::buildSavedQueryFromBuiltin($query_key); } + /** + * @param array $sources + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $sources, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($sources, 'NuanceSource'); + assert_instances_of($sources, NuanceSource::class); $viewer = $this->requireViewer(); diff --git a/src/applications/oauthserver/query/PhabricatorOAuthServerClientSearchEngine.php b/src/applications/oauthserver/query/PhabricatorOAuthServerClientSearchEngine.php index 064ff34a26..371cffcefe 100644 --- a/src/applications/oauthserver/query/PhabricatorOAuthServerClientSearchEngine.php +++ b/src/applications/oauthserver/query/PhabricatorOAuthServerClientSearchEngine.php @@ -73,11 +73,16 @@ final class PhabricatorOAuthServerClientSearchEngine return parent::buildSavedQueryFromBuiltin($query_key); } + /** + * @param array $clients + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $clients, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($clients, 'PhabricatorOAuthServerClient'); + assert_instances_of($clients, PhabricatorOAuthServerClient::class); $viewer = $this->requireViewer(); diff --git a/src/applications/owners/query/PhabricatorOwnersPackageSearchEngine.php b/src/applications/owners/query/PhabricatorOwnersPackageSearchEngine.php index d0f2790ba7..922fd05041 100644 --- a/src/applications/owners/query/PhabricatorOwnersPackageSearchEngine.php +++ b/src/applications/owners/query/PhabricatorOwnersPackageSearchEngine.php @@ -121,11 +121,16 @@ final class PhabricatorOwnersPackageSearchEngine return parent::buildSavedQueryFromBuiltin($query_key); } + /** + * @param array $packages + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $packages, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($packages, 'PhabricatorOwnersPackage'); + assert_instances_of($packages, PhabricatorOwnersPackage::class); $viewer = $this->requireViewer(); diff --git a/src/applications/owners/storage/PhabricatorOwnersOwner.php b/src/applications/owners/storage/PhabricatorOwnersOwner.php index ddca80b099..ca6142125c 100644 --- a/src/applications/owners/storage/PhabricatorOwnersOwner.php +++ b/src/applications/owners/storage/PhabricatorOwnersOwner.php @@ -24,8 +24,11 @@ final class PhabricatorOwnersOwner extends PhabricatorOwnersDAO { ) + parent::getConfiguration(); } + /** + * @param array $packages + */ public static function loadAllForPackages(array $packages) { - assert_instances_of($packages, 'PhabricatorOwnersPackage'); + assert_instances_of($packages, PhabricatorOwnersPackage::class); if (!$packages) { return array(); } diff --git a/src/applications/owners/storage/PhabricatorOwnersPackage.php b/src/applications/owners/storage/PhabricatorOwnersPackage.php index d8c2720d80..9832255727 100644 --- a/src/applications/owners/storage/PhabricatorOwnersPackage.php +++ b/src/applications/owners/storage/PhabricatorOwnersPackage.php @@ -212,11 +212,16 @@ final class PhabricatorOwnersPackage return self::loadPackagesForPaths($repository, $paths); } + /** + * @param PhabricatorRepository $repository + * @param DifferentialDiff $diff + * @param array $changesets + */ public static function loadAffectedPackagesForChangesets( PhabricatorRepository $repository, DifferentialDiff $diff, array $changesets) { - assert_instances_of($changesets, 'DifferentialChangeset'); + assert_instances_of($changesets, DifferentialChangeset::class); $paths_all = array(); $paths_ungenerated = array(); @@ -518,8 +523,11 @@ final class PhabricatorOwnersPackage return $result; } + /** + * @param array $paths + */ public function attachPaths(array $paths) { - assert_instances_of($paths, 'PhabricatorOwnersPath'); + assert_instances_of($paths, PhabricatorOwnersPath::class); $this->paths = $paths; // Drop this cache if we're attaching new paths. @@ -549,8 +557,11 @@ final class PhabricatorOwnersPackage return $this->pathRepositoryMap[$repository_phid]; } + /** + * @param array $owners + */ public function attachOwners(array $owners) { - assert_instances_of($owners, 'PhabricatorOwnersOwner'); + assert_instances_of($owners, PhabricatorOwnersOwner::class); $this->owners = $owners; return $this; } diff --git a/src/applications/packages/query/PhabricatorPackagesPackageSearchEngine.php b/src/applications/packages/query/PhabricatorPackagesPackageSearchEngine.php index 5c8c465085..e9928d2cea 100644 --- a/src/applications/packages/query/PhabricatorPackagesPackageSearchEngine.php +++ b/src/applications/packages/query/PhabricatorPackagesPackageSearchEngine.php @@ -72,12 +72,17 @@ final class PhabricatorPackagesPackageSearchEngine return parent::buildSavedQueryFromBuiltin($query_key); } + /** + * @param array $packages + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $packages, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($packages, 'PhabricatorPackagesPackage'); + assert_instances_of($packages, PhabricatorPackagesPackage::class); $viewer = $this->requireViewer(); $list = id(new PhabricatorPackagesPackageListView()) diff --git a/src/applications/packages/query/PhabricatorPackagesPublisherSearchEngine.php b/src/applications/packages/query/PhabricatorPackagesPublisherSearchEngine.php index 03e2e968a4..68fb44c70d 100644 --- a/src/applications/packages/query/PhabricatorPackagesPublisherSearchEngine.php +++ b/src/applications/packages/query/PhabricatorPackagesPublisherSearchEngine.php @@ -62,12 +62,17 @@ final class PhabricatorPackagesPublisherSearchEngine return parent::buildSavedQueryFromBuiltin($query_key); } + /** + * @param array $publishers + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $publishers, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($publishers, 'PhabricatorPackagesPublisher'); + assert_instances_of($publishers, PhabricatorPackagesPublisher::class); $viewer = $this->requireViewer(); diff --git a/src/applications/packages/query/PhabricatorPackagesVersionSearchEngine.php b/src/applications/packages/query/PhabricatorPackagesVersionSearchEngine.php index 464b423ee4..6f9007ba41 100644 --- a/src/applications/packages/query/PhabricatorPackagesVersionSearchEngine.php +++ b/src/applications/packages/query/PhabricatorPackagesVersionSearchEngine.php @@ -71,12 +71,17 @@ final class PhabricatorPackagesVersionSearchEngine return parent::buildSavedQueryFromBuiltin($query_key); } + /** + * @param array $versions + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $versions, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($versions, 'PhabricatorPackagesVersion'); + assert_instances_of($versions, PhabricatorPackagesVersion::class); $viewer = $this->requireViewer(); $list = id(new PhabricatorPackagesVersionListView()) diff --git a/src/applications/packages/view/PhabricatorPackagesPackageListView.php b/src/applications/packages/view/PhabricatorPackagesPackageListView.php index 78022bde38..1999a6ee46 100644 --- a/src/applications/packages/view/PhabricatorPackagesPackageListView.php +++ b/src/applications/packages/view/PhabricatorPackagesPackageListView.php @@ -5,8 +5,11 @@ final class PhabricatorPackagesPackageListView private $packages; + /** + * @param array $packages + */ public function setPackages(array $packages) { - assert_instances_of($packages, 'PhabricatorPackagesPackage'); + assert_instances_of($packages, PhabricatorPackagesPackage::class); $this->packages = $packages; return $this; } diff --git a/src/applications/packages/view/PhabricatorPackagesPublisherListView.php b/src/applications/packages/view/PhabricatorPackagesPublisherListView.php index fe7b2b37e4..f434633821 100644 --- a/src/applications/packages/view/PhabricatorPackagesPublisherListView.php +++ b/src/applications/packages/view/PhabricatorPackagesPublisherListView.php @@ -5,8 +5,11 @@ final class PhabricatorPackagesPublisherListView private $publishers; + /** + * @param array $publishers + */ public function setPublishers(array $publishers) { - assert_instances_of($publishers, 'PhabricatorPackagesPublisher'); + assert_instances_of($publishers, PhabricatorPackagesPublisher::class); $this->publishers = $publishers; return $this; } diff --git a/src/applications/packages/view/PhabricatorPackagesVersionListView.php b/src/applications/packages/view/PhabricatorPackagesVersionListView.php index 45840016ee..d73fdb9966 100644 --- a/src/applications/packages/view/PhabricatorPackagesVersionListView.php +++ b/src/applications/packages/view/PhabricatorPackagesVersionListView.php @@ -5,8 +5,11 @@ final class PhabricatorPackagesVersionListView private $versions; + /** + * @param array $versions + */ public function setVersions(array $versions) { - assert_instances_of($versions, 'PhabricatorPackagesVersion'); + assert_instances_of($versions, PhabricatorPackagesVersion::class); $this->versions = $versions; return $this; } diff --git a/src/applications/passphrase/query/PassphraseCredentialSearchEngine.php b/src/applications/passphrase/query/PassphraseCredentialSearchEngine.php index 24cc6609ff..a561055be2 100644 --- a/src/applications/passphrase/query/PassphraseCredentialSearchEngine.php +++ b/src/applications/passphrase/query/PassphraseCredentialSearchEngine.php @@ -69,11 +69,16 @@ final class PassphraseCredentialSearchEngine return parent::buildSavedQueryFromBuiltin($query_key); } + /** + * @param array $credentials + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $credentials, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($credentials, 'PassphraseCredential'); + assert_instances_of($credentials, PassphraseCredential::class); $viewer = $this->requireViewer(); diff --git a/src/applications/passphrase/view/PassphraseCredentialControl.php b/src/applications/passphrase/view/PassphraseCredentialControl.php index 09245157d2..043d1873d6 100644 --- a/src/applications/passphrase/view/PassphraseCredentialControl.php +++ b/src/applications/passphrase/view/PassphraseCredentialControl.php @@ -26,8 +26,11 @@ final class PassphraseCredentialControl extends AphrontFormControl { return $this->credentialType; } + /** + * @param array $options + */ public function setOptions(array $options) { - assert_instances_of($options, 'PassphraseCredential'); + assert_instances_of($options, PassphraseCredential::class); $this->options = $options; return $this; } diff --git a/src/applications/people/management/PhabricatorPeopleManagementWorkflow.php b/src/applications/people/management/PhabricatorPeopleManagementWorkflow.php index d504b8c11b..77c2f01637 100644 --- a/src/applications/people/management/PhabricatorPeopleManagementWorkflow.php +++ b/src/applications/people/management/PhabricatorPeopleManagementWorkflow.php @@ -36,10 +36,14 @@ abstract class PhabricatorPeopleManagementWorkflow return $user; } + /** + * @param PhabricatorUser $user + * @param array $xactions + */ final protected function applyTransactions( PhabricatorUser $user, array $xactions) { - assert_instances_of($xactions, 'PhabricatorUserTransaction'); + assert_instances_of($xactions, PhabricatorUserTransaction::class); $viewer = $this->getViewer(); $application = id(new PhabricatorPeopleApplication())->getPHID(); diff --git a/src/applications/people/query/PhabricatorPeopleLogSearchEngine.php b/src/applications/people/query/PhabricatorPeopleLogSearchEngine.php index fc1819debc..22384b3097 100644 --- a/src/applications/people/query/PhabricatorPeopleLogSearchEngine.php +++ b/src/applications/people/query/PhabricatorPeopleLogSearchEngine.php @@ -124,11 +124,16 @@ final class PhabricatorPeopleLogSearchEngine return parent::buildSavedQueryFromBuiltin($query_key); } + /** + * @param array $logs + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $logs, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($logs, 'PhabricatorUserLog'); + assert_instances_of($logs, PhabricatorUserLog::class); $viewer = $this->requireViewer(); diff --git a/src/applications/people/query/PhabricatorPeopleSearchEngine.php b/src/applications/people/query/PhabricatorPeopleSearchEngine.php index 22b74674ad..27df92e517 100644 --- a/src/applications/people/query/PhabricatorPeopleSearchEngine.php +++ b/src/applications/people/query/PhabricatorPeopleSearchEngine.php @@ -235,12 +235,17 @@ final class PhabricatorPeopleSearchEngine return parent::buildSavedQueryFromBuiltin($query_key); } + /** + * @param array $users + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $users, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($users, 'PhabricatorUser'); + assert_instances_of($users, PhabricatorUser::class); $request = $this->getRequest(); $viewer = $this->requireViewer(); diff --git a/src/applications/people/storage/PhabricatorExternalAccount.php b/src/applications/people/storage/PhabricatorExternalAccount.php index c8c22e40e2..81d5969458 100644 --- a/src/applications/people/storage/PhabricatorExternalAccount.php +++ b/src/applications/people/storage/PhabricatorExternalAccount.php @@ -158,8 +158,13 @@ final class PhabricatorExternalAccount return array_values($raw); } + /** + * @param array $identifiers + */ public function attachAccountIdentifiers(array $identifiers) { - assert_instances_of($identifiers, 'PhabricatorExternalAccountIdentifier'); + assert_instances_of( + $identifiers, + PhabricatorExternalAccountIdentifier::class); $this->accountIdentifiers = mpull($identifiers, null, 'getIdentifierRaw'); return $this; } diff --git a/src/applications/people/view/PhabricatorUserLogView.php b/src/applications/people/view/PhabricatorUserLogView.php index ef4fa6f10c..c4ca973d5b 100644 --- a/src/applications/people/view/PhabricatorUserLogView.php +++ b/src/applications/people/view/PhabricatorUserLogView.php @@ -10,8 +10,11 @@ final class PhabricatorUserLogView extends AphrontView { return $this; } + /** + * @param array $logs + */ public function setLogs(array $logs) { - assert_instances_of($logs, 'PhabricatorUserLog'); + assert_instances_of($logs, PhabricatorUserLog::class); $this->logs = $logs; return $this; } diff --git a/src/applications/phame/query/PhameBlogSearchEngine.php b/src/applications/phame/query/PhameBlogSearchEngine.php index 4b8c287173..9e7ce90cfa 100644 --- a/src/applications/phame/query/PhameBlogSearchEngine.php +++ b/src/applications/phame/query/PhameBlogSearchEngine.php @@ -67,12 +67,18 @@ final class PhameBlogSearchEngine return parent::buildSavedQueryFromBuiltin($query_key); } + + /** + * @param array $blogs + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $blogs, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($blogs, 'PhameBlog'); + assert_instances_of($blogs, PhameBlog::class); $viewer = $this->requireViewer(); $list = new PHUIObjectItemListView(); diff --git a/src/applications/phame/query/PhamePostSearchEngine.php b/src/applications/phame/query/PhamePostSearchEngine.php index 1cff6d1891..a0656b936d 100644 --- a/src/applications/phame/query/PhamePostSearchEngine.php +++ b/src/applications/phame/query/PhamePostSearchEngine.php @@ -86,13 +86,17 @@ final class PhamePostSearchEngine return parent::buildSavedQueryFromBuiltin($query_key); } - + /** + * @param array $posts + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $posts, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($posts, 'PhamePost'); + assert_instances_of($posts, PhamePost::class); $viewer = $this->requireViewer(); $list = new PHUIObjectItemListView(); diff --git a/src/applications/phame/view/PhameBlogListView.php b/src/applications/phame/view/PhameBlogListView.php index 5aa58ee8f9..65bdd8348a 100644 --- a/src/applications/phame/view/PhameBlogListView.php +++ b/src/applications/phame/view/PhameBlogListView.php @@ -4,8 +4,11 @@ final class PhameBlogListView extends AphrontTagView { private $blogs; + /** + * @param array $blogs + */ public function setBlogs($blogs) { - assert_instances_of($blogs, 'PhameBlog'); + assert_instances_of($blogs, PhameBlog::class); $this->blogs = $blogs; return $this; } diff --git a/src/applications/phame/view/PhameDraftListView.php b/src/applications/phame/view/PhameDraftListView.php index 294eeb11bc..ac047813f9 100644 --- a/src/applications/phame/view/PhameDraftListView.php +++ b/src/applications/phame/view/PhameDraftListView.php @@ -5,14 +5,20 @@ final class PhameDraftListView extends AphrontTagView { private $posts; private $blogs; + /** + * @param array $posts + */ public function setPosts($posts) { - assert_instances_of($posts, 'PhamePost'); + assert_instances_of($posts, PhamePost::class); $this->posts = $posts; return $this; } + /** + * @param array $blogs + */ public function setBlogs($blogs) { - assert_instances_of($blogs, 'PhameBlog'); + assert_instances_of($blogs, PhameBlog::class); $this->blogs = $blogs; return $this; } diff --git a/src/applications/phame/view/PhamePostListView.php b/src/applications/phame/view/PhamePostListView.php index 1932b597a1..fe75d56f6b 100644 --- a/src/applications/phame/view/PhamePostListView.php +++ b/src/applications/phame/view/PhamePostListView.php @@ -8,8 +8,11 @@ final class PhamePostListView extends AphrontTagView { private $isExternal; private $isLive; + /** + * @param array $posts + */ public function setPosts($posts) { - assert_instances_of($posts, 'PhamePost'); + assert_instances_of($posts, PhamePost::class); $this->posts = $posts; return $this; } diff --git a/src/applications/pholio/query/PholioMockSearchEngine.php b/src/applications/pholio/query/PholioMockSearchEngine.php index c62731b3e5..ae46316fec 100644 --- a/src/applications/pholio/query/PholioMockSearchEngine.php +++ b/src/applications/pholio/query/PholioMockSearchEngine.php @@ -86,7 +86,7 @@ final class PholioMockSearchEngine extends PhabricatorApplicationSearchEngine { /** * @param array $mocks * @param PhabricatorSavedQuery $query - * @param array $handles + * @param array $handles */ protected function renderResultList( array $mocks, diff --git a/src/applications/phrequent/query/PhrequentSearchEngine.php b/src/applications/phrequent/query/PhrequentSearchEngine.php index 2cf1bb7d4c..6b9ef1e90f 100644 --- a/src/applications/phrequent/query/PhrequentSearchEngine.php +++ b/src/applications/phrequent/query/PhrequentSearchEngine.php @@ -119,11 +119,16 @@ final class PhrequentSearchEngine extends PhabricatorApplicationSearchEngine { )); } + /** + * @param array $usertimes + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $usertimes, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($usertimes, 'PhrequentUserTime'); + assert_instances_of($usertimes, PhrequentUserTime::class); $viewer = $this->requireViewer(); $view = id(new PHUIObjectItemListView()) diff --git a/src/applications/phrequent/storage/PhrequentTimeBlock.php b/src/applications/phrequent/storage/PhrequentTimeBlock.php index 843e149788..402add9f7b 100644 --- a/src/applications/phrequent/storage/PhrequentTimeBlock.php +++ b/src/applications/phrequent/storage/PhrequentTimeBlock.php @@ -4,8 +4,11 @@ final class PhrequentTimeBlock extends Phobject { private $events; + /** + * @param array $events + */ public function __construct(array $events) { - assert_instances_of($events, 'PhrequentUserTime'); + assert_instances_of($events, PhrequentUserTime::class); $this->events = $events; } diff --git a/src/applications/phurl/query/PhabricatorPhurlURLSearchEngine.php b/src/applications/phurl/query/PhabricatorPhurlURLSearchEngine.php index a3a38c8ee9..4f1ebc0700 100644 --- a/src/applications/phurl/query/PhabricatorPhurlURLSearchEngine.php +++ b/src/applications/phurl/query/PhabricatorPhurlURLSearchEngine.php @@ -91,12 +91,17 @@ final class PhabricatorPhurlURLSearchEngine return parent::buildSavedQueryFromBuiltin($query_key); } + /** + * @param array $urls + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $urls, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($urls, 'PhabricatorPhurlURL'); + assert_instances_of($urls, PhabricatorPhurlURL::class); $viewer = $this->requireViewer(); $list = new PHUIObjectItemListView(); $handles = $viewer->loadHandles(mpull($urls, 'getAuthorPHID')); diff --git a/src/applications/policy/filter/PhabricatorPolicyFilter.php b/src/applications/policy/filter/PhabricatorPolicyFilter.php index 2913381be9..e75cff677a 100644 --- a/src/applications/policy/filter/PhabricatorPolicyFilter.php +++ b/src/applications/policy/filter/PhabricatorPolicyFilter.php @@ -155,8 +155,11 @@ final class PhabricatorPolicyFilter extends Phobject { return $this; } + /** + * @param array $objects + */ public function apply(array $objects) { - assert_instances_of($objects, 'PhabricatorPolicyInterface'); + assert_instances_of($objects, PhabricatorPolicyInterface::class); $viewer = $this->viewer; $capabilities = $this->capabilities; diff --git a/src/applications/policy/filter/PhabricatorPolicyFilterSet.php b/src/applications/policy/filter/PhabricatorPolicyFilterSet.php index 1834504dc4..ec3702d847 100644 --- a/src/applications/policy/filter/PhabricatorPolicyFilterSet.php +++ b/src/applications/policy/filter/PhabricatorPolicyFilterSet.php @@ -102,6 +102,11 @@ final class PhabricatorPolicyFilterSet $this->queue = array(); } + /** + * @param PhabricatorUser $viewer + * @param array $handles + * @param array $objects + */ public static function loadHandleViewCapabilities( $viewer, $handles, @@ -111,7 +116,7 @@ final class PhabricatorPolicyFilterSet PhabricatorPolicyCapability::CAN_VIEW, ); - assert_instances_of($objects, 'PhabricatorPolicyInterface'); + assert_instances_of($objects, PhabricatorPolicyInterface::class); if (!$objects) { return; diff --git a/src/applications/ponder/query/PonderQuestionSearchEngine.php b/src/applications/ponder/query/PonderQuestionSearchEngine.php index ab08637124..0896c82bf8 100644 --- a/src/applications/ponder/query/PonderQuestionSearchEngine.php +++ b/src/applications/ponder/query/PonderQuestionSearchEngine.php @@ -109,11 +109,16 @@ final class PonderQuestionSearchEngine return mpull($questions, 'getAuthorPHID'); } + /** + * @param array $questions + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $questions, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($questions, 'PonderQuestion'); + assert_instances_of($questions, PonderQuestion::class); $viewer = $this->requireViewer(); diff --git a/src/applications/ponder/storage/PonderQuestion.php b/src/applications/ponder/storage/PonderQuestion.php index cbdb4170a8..53b3e09061 100644 --- a/src/applications/ponder/storage/PonderQuestion.php +++ b/src/applications/ponder/storage/PonderQuestion.php @@ -114,8 +114,11 @@ final class PonderQuestion extends PonderDAO return '/'.$this->getMonogram(); } + /** + * @param array $answers + */ public function attachAnswers(array $answers) { - assert_instances_of($answers, 'PonderAnswer'); + assert_instances_of($answers, PonderAnswer::class); $this->answers = $answers; return $this; } diff --git a/src/applications/project/chart/PhabricatorProjectActivityChartEngine.php b/src/applications/project/chart/PhabricatorProjectActivityChartEngine.php index 912a177a5c..2869e6b07e 100644 --- a/src/applications/project/chart/PhabricatorProjectActivityChartEngine.php +++ b/src/applications/project/chart/PhabricatorProjectActivityChartEngine.php @@ -5,8 +5,11 @@ final class PhabricatorProjectActivityChartEngine const CHARTENGINEKEY = 'project.activity'; + /** + * @param array $projects + */ public function setProjects(array $projects) { - assert_instances_of($projects, 'PhabricatorProject'); + assert_instances_of($projects, PhabricatorProject::class); $project_phids = mpull($projects, 'getPHID'); return $this->setEngineParameter('projectPHIDs', $project_phids); } diff --git a/src/applications/project/chart/PhabricatorProjectBurndownChartEngine.php b/src/applications/project/chart/PhabricatorProjectBurndownChartEngine.php index ee16e5c8d5..ded27f6658 100644 --- a/src/applications/project/chart/PhabricatorProjectBurndownChartEngine.php +++ b/src/applications/project/chart/PhabricatorProjectBurndownChartEngine.php @@ -9,7 +9,7 @@ final class PhabricatorProjectBurndownChartEngine * @param array $projects */ public function setProjects(array $projects) { - assert_instances_of($projects, 'PhabricatorProject'); + assert_instances_of($projects, PhabricatorProject::class); $project_phids = mpull($projects, 'getPHID'); return $this->setEngineParameter('projectPHIDs', $project_phids); } diff --git a/src/applications/project/conduit/ProjectConduitAPIMethod.php b/src/applications/project/conduit/ProjectConduitAPIMethod.php index f6e40f38a3..e3a569b647 100644 --- a/src/applications/project/conduit/ProjectConduitAPIMethod.php +++ b/src/applications/project/conduit/ProjectConduitAPIMethod.php @@ -11,8 +11,11 @@ abstract class ProjectConduitAPIMethod extends ConduitAPIMethod { return idx($results, $project->getPHID()); } + /** + * @param array $projects + */ protected function buildProjectInfoDictionaries(array $projects) { - assert_instances_of($projects, 'PhabricatorProject'); + assert_instances_of($projects, PhabricatorProject::class); if (!$projects) { return array(); } diff --git a/src/applications/project/controller/PhabricatorProjectBoardManageController.php b/src/applications/project/controller/PhabricatorProjectBoardManageController.php index b2b6dfdf6d..59953abb87 100644 --- a/src/applications/project/controller/PhabricatorProjectBoardManageController.php +++ b/src/applications/project/controller/PhabricatorProjectBoardManageController.php @@ -98,10 +98,14 @@ final class PhabricatorProjectBoardManageController return $curtain; } + /** + * @param PhabricatorProject $board + * @param array $columns + */ private function buildColumnsList( PhabricatorProject $board, array $columns) { - assert_instances_of($columns, 'PhabricatorProjectColumn'); + assert_instances_of($columns, PhabricatorProjectColumn::class); $board_id = $board->getID(); diff --git a/src/applications/project/controller/PhabricatorProjectProfileController.php b/src/applications/project/controller/PhabricatorProjectProfileController.php index 571891ee31..5667089997 100644 --- a/src/applications/project/controller/PhabricatorProjectProfileController.php +++ b/src/applications/project/controller/PhabricatorProjectProfileController.php @@ -182,8 +182,11 @@ final class PhabricatorProjectProfileController return $view; } + /** + * @param array $stories + */ private function renderStories(array $stories) { - assert_instances_of($stories, 'PhabricatorFeedStory'); + assert_instances_of($stories, PhabricatorFeedStory::class); $builder = new PhabricatorFeedBuilder($stories); $builder->setUser($this->getRequest()->getUser()); diff --git a/src/applications/project/order/PhabricatorProjectColumnOrder.php b/src/applications/project/order/PhabricatorProjectColumnOrder.php index f93aa557fa..bf3956c9c1 100644 --- a/src/applications/project/order/PhabricatorProjectColumnOrder.php +++ b/src/applications/project/order/PhabricatorProjectColumnOrder.php @@ -67,7 +67,7 @@ abstract class PhabricatorProjectColumnOrder $result = array(); } - assert_instances_of($result, 'PhabricatorApplicationTransaction'); + assert_instances_of($result, PhabricatorApplicationTransaction::class); return $result; } @@ -108,7 +108,7 @@ abstract class PhabricatorProjectColumnOrder phutil_describe_type($headers))); } - assert_instances_of($headers, 'PhabricatorProjectColumnHeader'); + assert_instances_of($headers, PhabricatorProjectColumnHeader::class); // Add a "0" to the end of each header. This makes them sort above object // cards in the same group. diff --git a/src/applications/project/query/PhabricatorProjectColumnSearchEngine.php b/src/applications/project/query/PhabricatorProjectColumnSearchEngine.php index e7b2e4b8f7..0bed680062 100644 --- a/src/applications/project/query/PhabricatorProjectColumnSearchEngine.php +++ b/src/applications/project/query/PhabricatorProjectColumnSearchEngine.php @@ -65,11 +65,16 @@ final class PhabricatorProjectColumnSearchEngine return parent::buildSavedQueryFromBuiltin($query_key); } + /** + * @param array $projects + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $projects, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($projects, 'PhabricatorProjectColumn'); + assert_instances_of($projects, PhabricatorProjectColumn::class); $viewer = $this->requireViewer(); return null; diff --git a/src/applications/project/query/PhabricatorProjectSearchEngine.php b/src/applications/project/query/PhabricatorProjectSearchEngine.php index 8d18c9eb24..7f09342a04 100644 --- a/src/applications/project/query/PhabricatorProjectSearchEngine.php +++ b/src/applications/project/query/PhabricatorProjectSearchEngine.php @@ -325,11 +325,16 @@ final class PhabricatorProjectSearchEngine return $options; } + /** + * @param array $projects + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $projects, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($projects, 'PhabricatorProject'); + assert_instances_of($projects, PhabricatorProject::class); $viewer = $this->requireViewer(); $list = id(new PhabricatorProjectListView()) diff --git a/src/applications/project/query/PhabricatorProjectTriggerSearchEngine.php b/src/applications/project/query/PhabricatorProjectTriggerSearchEngine.php index 1239dbeade..58d1844191 100644 --- a/src/applications/project/query/PhabricatorProjectTriggerSearchEngine.php +++ b/src/applications/project/query/PhabricatorProjectTriggerSearchEngine.php @@ -69,11 +69,16 @@ final class PhabricatorProjectTriggerSearchEngine return parent::buildSavedQueryFromBuiltin($query_key); } + /** + * @param array $triggers + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $triggers, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($triggers, 'PhabricatorProjectTrigger'); + assert_instances_of($triggers, PhabricatorProjectTrigger::class); $viewer = $this->requireViewer(); $example_phids = array(); diff --git a/src/applications/remarkup/engineextension/PhabricatorRemarkupHyperlinkEngineExtension.php b/src/applications/remarkup/engineextension/PhabricatorRemarkupHyperlinkEngineExtension.php index d3c7a3f624..d6001551af 100644 --- a/src/applications/remarkup/engineextension/PhabricatorRemarkupHyperlinkEngineExtension.php +++ b/src/applications/remarkup/engineextension/PhabricatorRemarkupHyperlinkEngineExtension.php @@ -3,8 +3,11 @@ abstract class PhabricatorRemarkupHyperlinkEngineExtension extends PhutilRemarkupHyperlinkEngineExtension { + /** + * @param array $hyperlinks + */ final protected function getSelfLinks(array $hyperlinks) { - assert_instances_of($hyperlinks, 'PhutilRemarkupHyperlinkRef'); + assert_instances_of($hyperlinks, PhutilRemarkupHyperlinkRef::class); $allowed_protocols = array( 'http' => true, diff --git a/src/applications/search/compiler/PhutilSearchQueryCompiler.php b/src/applications/search/compiler/PhutilSearchQueryCompiler.php index 9bdca5a6b7..65ae625c42 100644 --- a/src/applications/search/compiler/PhutilSearchQueryCompiler.php +++ b/src/applications/search/compiler/PhutilSearchQueryCompiler.php @@ -63,7 +63,7 @@ final class PhutilSearchQueryCompiler * @return string|null */ public function compileQuery(array $tokens) { - assert_instances_of($tokens, 'PhutilSearchQueryToken'); + assert_instances_of($tokens, PhutilSearchQueryToken::class); $result = array(); foreach ($tokens as $token) { @@ -78,7 +78,7 @@ final class PhutilSearchQueryCompiler * @return string|null */ public function compileLiteralQuery(array $tokens) { - assert_instances_of($tokens, 'PhutilSearchQueryToken'); + assert_instances_of($tokens, PhutilSearchQueryToken::class); $result = array(); foreach ($tokens as $token) { @@ -96,7 +96,7 @@ final class PhutilSearchQueryCompiler * @return string|null */ public function compileStemmedQuery(array $tokens) { - assert_instances_of($tokens, 'PhutilSearchQueryToken'); + assert_instances_of($tokens, PhutilSearchQueryToken::class); $result = array(); foreach ($tokens as $token) { diff --git a/src/applications/search/engine/PhabricatorApplicationSearchEngine.php b/src/applications/search/engine/PhabricatorApplicationSearchEngine.php index 2f3d9836ac..0ba6360412 100644 --- a/src/applications/search/engine/PhabricatorApplicationSearchEngine.php +++ b/src/applications/search/engine/PhabricatorApplicationSearchEngine.php @@ -104,7 +104,7 @@ abstract class PhabricatorApplicationSearchEngine extends Phobject { * @param array $navigation_items */ public function setNavigationItems(array $navigation_items) { - assert_instances_of($navigation_items, 'PHUIListItemView'); + assert_instances_of($navigation_items, PHUIListItemView::class); $this->navigationItems = $navigation_items; return $this; } @@ -1704,12 +1704,14 @@ abstract class PhabricatorApplicationSearchEngine extends Phobject { * Load from object and from storage, and updates Custom Fields instances * that are attached to each object. * + * @param array $objects + * @param string $role One of the PhabricatorCustomField::ROLE_ constants * @return array Map of loaded fields * (PHID to PhabricatorCustomFieldList). * @task custom */ protected function loadCustomFields(array $objects, $role) { - assert_instances_of($objects, 'PhabricatorCustomFieldInterface'); + assert_instances_of($objects, PhabricatorCustomFieldInterface::class); $query = new PhabricatorCustomFieldStorageQuery(); $lists = array(); diff --git a/src/applications/search/engine/PhabricatorProfileMenuItemViewList.php b/src/applications/search/engine/PhabricatorProfileMenuItemViewList.php index 8cae5e6676..6d33d7b487 100644 --- a/src/applications/search/engine/PhabricatorProfileMenuItemViewList.php +++ b/src/applications/search/engine/PhabricatorProfileMenuItemViewList.php @@ -169,11 +169,15 @@ final class PhabricatorProfileMenuItemViewList return $navigation; } + /** + * @param array $items + * @param ?PHUIListItemView $selected_item + */ private function getHighlightedItemKey( array $items, ?PHUIListItemView $selected_item = null) { - assert_instances_of($items, 'PHUIListItemView'); + assert_instances_of($items, PHUIListItemView::class); $default_key = null; if ($selected_item) { diff --git a/src/applications/search/menuitem/PhabricatorProfileMenuItem.php b/src/applications/search/menuitem/PhabricatorProfileMenuItem.php index b2204b047f..067c98725b 100644 --- a/src/applications/search/menuitem/PhabricatorProfileMenuItem.php +++ b/src/applications/search/menuitem/PhabricatorProfileMenuItem.php @@ -72,6 +72,10 @@ abstract class PhabricatorProfileMenuItem extends Phobject { public function willGetMenuItemViewList(array $items) {} + /** + * @param PhabricatorProfileMenuItemConfiguration $config + * @param array $list + */ final public function getMenuItemViewList( PhabricatorProfileMenuItemConfiguration $config) { $list = $this->newMenuItemViewList($config); @@ -85,7 +89,7 @@ abstract class PhabricatorProfileMenuItem extends Phobject { phutil_describe_type($list))); } - assert_instances_of($list, 'PhabricatorProfileMenuItemView'); + assert_instances_of($list, PhabricatorProfileMenuItemView::class); foreach ($list as $view) { $view->setMenuItemConfiguration($config); diff --git a/src/applications/search/relationship/PhabricatorObjectRelationshipList.php b/src/applications/search/relationship/PhabricatorObjectRelationshipList.php index 02917bd57d..d12fd5e1d6 100644 --- a/src/applications/search/relationship/PhabricatorObjectRelationshipList.php +++ b/src/applications/search/relationship/PhabricatorObjectRelationshipList.php @@ -32,8 +32,11 @@ final class PhabricatorObjectRelationshipList extends Phobject { return $this->object; } + /** + * @param array $relationships + */ public function setRelationships(array $relationships) { - assert_instances_of($relationships, 'PhabricatorObjectRelationship'); + assert_instances_of($relationships, PhabricatorObjectRelationship::class); $this->relationships = $relationships; return $this; } diff --git a/src/applications/search/view/PhabricatorApplicationSearchResultView.php b/src/applications/search/view/PhabricatorApplicationSearchResultView.php index d80fde4227..6137e7e296 100644 --- a/src/applications/search/view/PhabricatorApplicationSearchResultView.php +++ b/src/applications/search/view/PhabricatorApplicationSearchResultView.php @@ -77,8 +77,11 @@ final class PhabricatorApplicationSearchResultView extends Phobject { return $this; } + /** + * @param array $crumbs + */ public function setCrumbs(array $crumbs) { - assert_instances_of($crumbs, 'PHUICrumbView'); + assert_instances_of($crumbs, PHUICrumbView::class); $this->crumbs = $crumbs; return $this; diff --git a/src/applications/search/view/PhabricatorSearchResultView.php b/src/applications/search/view/PhabricatorSearchResultView.php index ce95fcc6a5..b629ded99c 100644 --- a/src/applications/search/view/PhabricatorSearchResultView.php +++ b/src/applications/search/view/PhabricatorSearchResultView.php @@ -16,7 +16,7 @@ final class PhabricatorSearchResultView extends AphrontView { * @return $this */ public function setTokens(array $tokens) { - assert_instances_of($tokens, 'PhabricatorFulltextToken'); + assert_instances_of($tokens, PhabricatorFulltextToken::class); $this->tokens = $tokens; return $this; } diff --git a/src/applications/settings/query/PhabricatorUserPreferencesQuery.php b/src/applications/settings/query/PhabricatorUserPreferencesQuery.php index c79aa23ba6..a331faff96 100644 --- a/src/applications/settings/query/PhabricatorUserPreferencesQuery.php +++ b/src/applications/settings/query/PhabricatorUserPreferencesQuery.php @@ -34,8 +34,11 @@ final class PhabricatorUserPreferencesQuery return $this; } + /** + * @param array $users + */ public function withUsers(array $users) { - assert_instances_of($users, 'PhabricatorUser'); + assert_instances_of($users, PhabricatorUser::class); $this->users = mpull($users, null, 'getPHID'); $this->withUserPHIDs(array_keys($this->users)); return $this; diff --git a/src/applications/settings/query/PhabricatorUserPreferencesSearchEngine.php b/src/applications/settings/query/PhabricatorUserPreferencesSearchEngine.php index b840d3cfe4..ceca8b1896 100644 --- a/src/applications/settings/query/PhabricatorUserPreferencesSearchEngine.php +++ b/src/applications/settings/query/PhabricatorUserPreferencesSearchEngine.php @@ -50,11 +50,16 @@ final class PhabricatorUserPreferencesSearchEngine return parent::buildSavedQueryFromBuiltin($query_key); } + /** + * @param array $settings + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $settings, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($settings, 'PhabricatorUserPreferences'); + assert_instances_of($settings, PhabricatorUserPreferences::class); $viewer = $this->requireViewer(); diff --git a/src/applications/slowvote/query/PhabricatorSlowvoteQuery.php b/src/applications/slowvote/query/PhabricatorSlowvoteQuery.php index 4cde62eb63..7ddb121d8d 100644 --- a/src/applications/slowvote/query/PhabricatorSlowvoteQuery.php +++ b/src/applications/slowvote/query/PhabricatorSlowvoteQuery.php @@ -60,8 +60,11 @@ final class PhabricatorSlowvoteQuery return new PhabricatorSlowvotePoll(); } + /** + * @param array $polls + */ protected function willFilterPage(array $polls) { - assert_instances_of($polls, 'PhabricatorSlowvotePoll'); + assert_instances_of($polls, PhabricatorSlowvotePoll::class); $ids = mpull($polls, 'getID'); $viewer = $this->getViewer(); diff --git a/src/applications/slowvote/query/PhabricatorSlowvoteSearchEngine.php b/src/applications/slowvote/query/PhabricatorSlowvoteSearchEngine.php index 557f6b815c..79a0247e11 100644 --- a/src/applications/slowvote/query/PhabricatorSlowvoteSearchEngine.php +++ b/src/applications/slowvote/query/PhabricatorSlowvoteSearchEngine.php @@ -106,12 +106,17 @@ final class PhabricatorSlowvoteSearchEngine return mpull($polls, 'getAuthorPHID'); } + /** + * @param array $polls + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $polls, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($polls, 'PhabricatorSlowvotePoll'); + assert_instances_of($polls, PhabricatorSlowvotePoll::class); $viewer = $this->requireViewer(); $list = id(new PHUIObjectItemListView()) diff --git a/src/applications/slowvote/storage/PhabricatorSlowvotePoll.php b/src/applications/slowvote/storage/PhabricatorSlowvotePoll.php index f715efbfdb..7253492141 100644 --- a/src/applications/slowvote/storage/PhabricatorSlowvotePoll.php +++ b/src/applications/slowvote/storage/PhabricatorSlowvotePoll.php @@ -80,8 +80,11 @@ final class PhabricatorSlowvotePoll return $this->assertAttached($this->options); } + /** + * @param array $options + */ public function attachOptions(array $options) { - assert_instances_of($options, 'PhabricatorSlowvoteOption'); + assert_instances_of($options, PhabricatorSlowvoteOption::class); $this->options = $options; return $this; } @@ -90,8 +93,11 @@ final class PhabricatorSlowvotePoll return $this->assertAttached($this->choices); } + /** + * @param array $choices + */ public function attachChoices(array $choices) { - assert_instances_of($choices, 'PhabricatorSlowvoteChoice'); + assert_instances_of($choices, PhabricatorSlowvoteChoice::class); $this->choices = $choices; return $this; } @@ -100,11 +106,15 @@ final class PhabricatorSlowvotePoll return $this->assertAttachedKey($this->viewerChoices, $viewer->getPHID()); } + /** + * @param PhabricatorUser $viewer + * @param array $choices + */ public function attachViewerChoices(PhabricatorUser $viewer, array $choices) { if ($this->viewerChoices === self::ATTACHABLE) { $this->viewerChoices = array(); } - assert_instances_of($choices, 'PhabricatorSlowvoteChoice'); + assert_instances_of($choices, PhabricatorSlowvoteChoice::class); $this->viewerChoices[$viewer->getPHID()] = $choices; return $this; } diff --git a/src/applications/spaces/query/PhabricatorSpacesNamespaceSearchEngine.php b/src/applications/spaces/query/PhabricatorSpacesNamespaceSearchEngine.php index 993920fe0b..9491390877 100644 --- a/src/applications/spaces/query/PhabricatorSpacesNamespaceSearchEngine.php +++ b/src/applications/spaces/query/PhabricatorSpacesNamespaceSearchEngine.php @@ -64,11 +64,16 @@ final class PhabricatorSpacesNamespaceSearchEngine return parent::buildSavedQueryFromBuiltin($query_key); } + /** + * @param array $spaces + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $spaces, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($spaces, 'PhabricatorSpacesNamespace'); + assert_instances_of($spaces, PhabricatorSpacesNamespace::class); $viewer = $this->requireViewer(); diff --git a/src/applications/subscriptions/view/SubscriptionListStringBuilder.php b/src/applications/subscriptions/view/SubscriptionListStringBuilder.php index 7ccc729241..ef6a8623da 100644 --- a/src/applications/subscriptions/view/SubscriptionListStringBuilder.php +++ b/src/applications/subscriptions/view/SubscriptionListStringBuilder.php @@ -5,8 +5,11 @@ final class SubscriptionListStringBuilder extends Phobject { private $handles; private $objectPHID; + /** + * @param array $handles + */ public function setHandles(array $handles) { - assert_instances_of($handles, 'PhabricatorObjectHandle'); + assert_instances_of($handles, PhabricatorObjectHandle::class); $this->handles = $handles; return $this; } diff --git a/src/applications/tokens/conduit/TokenConduitAPIMethod.php b/src/applications/tokens/conduit/TokenConduitAPIMethod.php index fa6810d5d5..f1b94a6e03 100644 --- a/src/applications/tokens/conduit/TokenConduitAPIMethod.php +++ b/src/applications/tokens/conduit/TokenConduitAPIMethod.php @@ -10,8 +10,11 @@ abstract class TokenConduitAPIMethod extends ConduitAPIMethod { return self::METHOD_STATUS_UNSTABLE; } + /** + * @param array $tokens + */ public function buildTokenDicts(array $tokens) { - assert_instances_of($tokens, 'PhabricatorToken'); + assert_instances_of($tokens, PhabricatorToken::class); $list = array(); foreach ($tokens as $token) { @@ -25,8 +28,11 @@ abstract class TokenConduitAPIMethod extends ConduitAPIMethod { return $list; } + /** + * @param array $tokens_given + */ public function buildTokenGivenDicts(array $tokens_given) { - assert_instances_of($tokens_given, 'PhabricatorTokenGiven'); + assert_instances_of($tokens_given, PhabricatorTokenGiven::class); $list = array(); foreach ($tokens_given as $given) { diff --git a/src/applications/transactions/bulk/management/PhabricatorBulkManagementExportWorkflow.php b/src/applications/transactions/bulk/management/PhabricatorBulkManagementExportWorkflow.php index 2dd543d031..c02638061a 100644 --- a/src/applications/transactions/bulk/management/PhabricatorBulkManagementExportWorkflow.php +++ b/src/applications/transactions/bulk/management/PhabricatorBulkManagementExportWorkflow.php @@ -283,11 +283,15 @@ final class PhabricatorBulkManagementExportWorkflow return array($engine, $queries); } + /** + * @param PhabricatorApplicationSearchEngine $engine + * @param array $queries + */ private function newUnionQuery( PhabricatorApplicationSearchEngine $engine, array $queries) { - assert_instances_of($queries, 'PhabricatorSavedQuery'); + assert_instances_of($queries, PhabricatorSavedQuery::class); $engine = clone $engine; diff --git a/src/applications/transactions/draft/PhabricatorDraftEngine.php b/src/applications/transactions/draft/PhabricatorDraftEngine.php index 1e64bfdef4..2ab625957d 100644 --- a/src/applications/transactions/draft/PhabricatorDraftEngine.php +++ b/src/applications/transactions/draft/PhabricatorDraftEngine.php @@ -95,10 +95,14 @@ abstract class PhabricatorDraftEngine $editor->save(); } + /** + * @param PhabricatorUser $viewer + * @param array $objects + */ final public static function attachDrafts( PhabricatorUser $viewer, array $objects) { - assert_instances_of($objects, 'PhabricatorDraftInterface'); + assert_instances_of($objects, PhabricatorDraftInterface::class); $viewer_phid = $viewer->getPHID(); diff --git a/src/applications/transactions/editengine/PhabricatorEditEngine.php b/src/applications/transactions/editengine/PhabricatorEditEngine.php index 94ec15af81..598f0e1024 100644 --- a/src/applications/transactions/editengine/PhabricatorEditEngine.php +++ b/src/applications/transactions/editengine/PhabricatorEditEngine.php @@ -203,7 +203,7 @@ abstract class PhabricatorEditEngine $template_object); // TODO: Validate this in more detail with a more tailored error. - assert_instances_of($extension_fields, 'PhabricatorEditField'); + assert_instances_of($extension_fields, PhabricatorEditField::class); foreach ($extension_fields as $field) { $field @@ -480,7 +480,9 @@ abstract class PhabricatorEditEngine get_class($this))); } - assert_instances_of($configurations, 'PhabricatorEditEngineConfiguration'); + assert_instances_of( + $configurations, + PhabricatorEditEngineConfiguration::class); $has_default = false; foreach ($configurations as $config) { @@ -2491,7 +2493,7 @@ abstract class PhabricatorEditEngine if ($this->pages === null) { $pages = $this->newPages($object); - assert_instances_of($pages, 'PhabricatorEditPage'); + assert_instances_of($pages, PhabricatorEditPage::class); $pages = mpull($pages, null, 'getKey'); $this->pages = $pages; diff --git a/src/applications/transactions/editengine/PhabricatorEditEngineSubtypeMap.php b/src/applications/transactions/editengine/PhabricatorEditEngineSubtypeMap.php index edf2d2045a..b53078950a 100644 --- a/src/applications/transactions/editengine/PhabricatorEditEngineSubtypeMap.php +++ b/src/applications/transactions/editengine/PhabricatorEditEngineSubtypeMap.php @@ -7,8 +7,11 @@ final class PhabricatorEditEngineSubtypeMap private $subtypes; private $datasource; + /** + * @param array $subtypes + */ public function __construct(array $subtypes) { - assert_instances_of($subtypes, 'PhabricatorEditEngineSubtype'); + assert_instances_of($subtypes, PhabricatorEditEngineSubtype::class); $this->subtypes = $subtypes; } diff --git a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php index ebf3155068..46cf482963 100644 --- a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php +++ b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php @@ -1756,6 +1756,10 @@ abstract class PhabricatorApplicationTransactionEditor } } + /** + * @param PhabricatorLiskDAO $object + * @param array $xactions + */ private function validateEditParameters( PhabricatorLiskDAO $object, array $xactions) { @@ -1770,7 +1774,7 @@ abstract class PhabricatorApplicationTransactionEditor $types = array_fill_keys($this->getTransactionTypes(), true); - assert_instances_of($xactions, 'PhabricatorApplicationTransaction'); + assert_instances_of($xactions, PhabricatorApplicationTransaction::class); foreach ($xactions as $xaction) { if ($xaction->getPHID() || $xaction->getID()) { throw new PhabricatorApplicationTransactionStructureException( @@ -1841,10 +1845,14 @@ abstract class PhabricatorApplicationTransactionEditor } } + /** + * @param PhabricatorLiskDAO $object + * @param array $xactions + */ private function applyCapabilityChecks( PhabricatorLiskDAO $object, array $xactions) { - assert_instances_of($xactions, 'PhabricatorApplicationTransaction'); + assert_instances_of($xactions, PhabricatorApplicationTransaction::class); $can_edit = PhabricatorPolicyCapability::CAN_EDIT; @@ -2254,7 +2262,12 @@ abstract class PhabricatorApplicationTransactionEditor return $xactions; } - + /** + * @param PhabricatorLiskDAO $object + * @param array $xactions + * @param array $remarkup_changes + * @return PhabricatorApplicationTransaction + */ private function newFileTransaction( PhabricatorLiskDAO $object, array $xactions, @@ -2262,7 +2275,7 @@ abstract class PhabricatorApplicationTransactionEditor assert_instances_of( $remarkup_changes, - 'PhabricatorTransactionRemarkupChange'); + PhabricatorTransactionRemarkupChange::class); $new_map = array(); @@ -4340,7 +4353,9 @@ abstract class PhabricatorApplicationTransactionEditor } $apply_xactions = $this->didApplyHeraldRules($object, $adapter, $xscript); - assert_instances_of($apply_xactions, 'PhabricatorApplicationTransaction'); + assert_instances_of( + $apply_xactions, + PhabricatorApplicationTransaction::class); $queue_xactions = $adapter->getQueuedTransactions(); @@ -5718,7 +5733,7 @@ abstract class PhabricatorApplicationTransactionEditor assert_instances_of( $extension_errors, - 'PhabricatorApplicationTransactionValidationError'); + PhabricatorApplicationTransactionValidationError::class); $errors[] = $extension_errors; } diff --git a/src/applications/transactions/engine/PhabricatorTimelineEngine.php b/src/applications/transactions/engine/PhabricatorTimelineEngine.php index 8f32d81ff9..ad4de3fb38 100644 --- a/src/applications/transactions/engine/PhabricatorTimelineEngine.php +++ b/src/applications/transactions/engine/PhabricatorTimelineEngine.php @@ -39,8 +39,11 @@ abstract class PhabricatorTimelineEngine return $this->object; } + /** + * @param array $xactions + */ final public function setTransactions(array $xactions) { - assert_instances_of($xactions, 'PhabricatorApplicationTransaction'); + assert_instances_of($xactions, PhabricatorApplicationTransaction::class); $this->xactions = $xactions; return $this; } diff --git a/src/applications/transactions/exception/PhabricatorApplicationTransactionNoEffectException.php b/src/applications/transactions/exception/PhabricatorApplicationTransactionNoEffectException.php index c1bf00c111..35ad6a4004 100644 --- a/src/applications/transactions/exception/PhabricatorApplicationTransactionNoEffectException.php +++ b/src/applications/transactions/exception/PhabricatorApplicationTransactionNoEffectException.php @@ -7,8 +7,15 @@ final class PhabricatorApplicationTransactionNoEffectException private $anyEffect; private $hasComment; + /** + * @param array $transactions + * @param bool $any_effect + * @param bool $has_comment + */ public function __construct(array $transactions, $any_effect, $has_comment) { - assert_instances_of($transactions, 'PhabricatorApplicationTransaction'); + assert_instances_of( + $transactions, + PhabricatorApplicationTransaction::class); $this->transactions = $transactions; $this->anyEffect = $any_effect; diff --git a/src/applications/transactions/exception/PhabricatorApplicationTransactionValidationException.php b/src/applications/transactions/exception/PhabricatorApplicationTransactionValidationException.php index 2ed1f54feb..e6baac1d1e 100644 --- a/src/applications/transactions/exception/PhabricatorApplicationTransactionValidationException.php +++ b/src/applications/transactions/exception/PhabricatorApplicationTransactionValidationException.php @@ -5,10 +5,13 @@ final class PhabricatorApplicationTransactionValidationException private $errors; + /** + * @param array $errors + */ public function __construct(array $errors) { assert_instances_of( $errors, - 'PhabricatorApplicationTransactionValidationError'); + PhabricatorApplicationTransactionValidationError::class); $this->errors = $errors; diff --git a/src/applications/transactions/query/PhabricatorEditEngineConfigurationSearchEngine.php b/src/applications/transactions/query/PhabricatorEditEngineConfigurationSearchEngine.php index c74ba38713..ee3a5da3e6 100644 --- a/src/applications/transactions/query/PhabricatorEditEngineConfigurationSearchEngine.php +++ b/src/applications/transactions/query/PhabricatorEditEngineConfigurationSearchEngine.php @@ -100,11 +100,16 @@ final class PhabricatorEditEngineConfigurationSearchEngine return parent::buildSavedQueryFromBuiltin($query_key); } + /** + * @param array $configs + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $configs, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($configs, 'PhabricatorEditEngineConfiguration'); + assert_instances_of($configs, PhabricatorEditEngineConfiguration::class); $viewer = $this->requireViewer(); $engine_key = $this->getEngineKey(); diff --git a/src/applications/transactions/query/PhabricatorEditEngineSearchEngine.php b/src/applications/transactions/query/PhabricatorEditEngineSearchEngine.php index 822548f860..dcb512fa7a 100644 --- a/src/applications/transactions/query/PhabricatorEditEngineSearchEngine.php +++ b/src/applications/transactions/query/PhabricatorEditEngineSearchEngine.php @@ -56,11 +56,16 @@ final class PhabricatorEditEngineSearchEngine return parent::buildSavedQueryFromBuiltin($query_key); } + /** + * @param array $engines + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $engines, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($engines, 'PhabricatorEditEngine'); + assert_instances_of($engines, PhabricatorEditEngine::class); $viewer = $this->requireViewer(); $list = id(new PHUIObjectItemListView()) diff --git a/src/applications/transactions/response/PhabricatorApplicationTransactionResponse.php b/src/applications/transactions/response/PhabricatorApplicationTransactionResponse.php index 4947d6868f..92ff015ca2 100644 --- a/src/applications/transactions/response/PhabricatorApplicationTransactionResponse.php +++ b/src/applications/transactions/response/PhabricatorApplicationTransactionResponse.php @@ -14,8 +14,13 @@ final class PhabricatorApplicationTransactionResponse return new AphrontAjaxResponse(); } + /** + * @param array $transactions + */ public function setTransactions($transactions) { - assert_instances_of($transactions, 'PhabricatorApplicationTransaction'); + assert_instances_of( + $transactions, + PhabricatorApplicationTransaction::class); $this->transactions = $transactions; return $this; diff --git a/src/applications/transactions/storage/PhabricatorApplicationTransaction.php b/src/applications/transactions/storage/PhabricatorApplicationTransaction.php index 6bc92e0c3b..dbaf2064b7 100644 --- a/src/applications/transactions/storage/PhabricatorApplicationTransaction.php +++ b/src/applications/transactions/storage/PhabricatorApplicationTransaction.php @@ -217,7 +217,7 @@ abstract class PhabricatorApplicationTransaction public function getRemarkupChanges() { $changes = $this->newRemarkupChanges(); - assert_instances_of($changes, 'PhabricatorTransactionRemarkupChange'); + assert_instances_of($changes, PhabricatorTransactionRemarkupChange::class); // Convert older-style remarkup blocks into newer-style remarkup changes. // This builds changes that do not have the correct "old value", so rules @@ -1674,6 +1674,9 @@ abstract class PhabricatorApplicationTransaction ->setNewText($new); } + /** + * @param array $group + */ public function attachTransactionGroup(array $group) { assert_instances_of($group, self::class); $this->transactionGroup = $group; diff --git a/src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php b/src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php index 33639ef18b..9cb3680c55 100644 --- a/src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php +++ b/src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php @@ -127,8 +127,13 @@ final class PhabricatorApplicationTransactionCommentView return $this->infoView; } + /** + * @param array $comment_actions + */ public function setCommentActions(array $comment_actions) { - assert_instances_of($comment_actions, 'PhabricatorEditEngineCommentAction'); + assert_instances_of( + $comment_actions, + PhabricatorEditEngineCommentAction::class); $this->commentActions = $comment_actions; return $this; } @@ -137,8 +142,13 @@ final class PhabricatorApplicationTransactionCommentView return $this->commentActions; } + /** + * @param array $groups + */ public function setCommentActionGroups(array $groups) { - assert_instances_of($groups, 'PhabricatorEditEngineCommentActionGroup'); + assert_instances_of( + $groups, + PhabricatorEditEngineCommentActionGroup::class); $this->commentActionGroups = $groups; return $this; } diff --git a/src/applications/transactions/view/PhabricatorApplicationTransactionView.php b/src/applications/transactions/view/PhabricatorApplicationTransactionView.php index 180ba071a9..d591f9e38c 100644 --- a/src/applications/transactions/view/PhabricatorApplicationTransactionView.php +++ b/src/applications/transactions/view/PhabricatorApplicationTransactionView.php @@ -84,8 +84,12 @@ class PhabricatorApplicationTransactionView extends AphrontView { return $this; } + /** + * @param array $transactions + */ public function setTransactions(array $transactions) { - assert_instances_of($transactions, 'PhabricatorApplicationTransaction'); + assert_instances_of($transactions, + PhabricatorApplicationTransaction::class); $this->transactions = $transactions; return $this; } diff --git a/src/applications/xhprof/query/PhabricatorXHProfSampleSearchEngine.php b/src/applications/xhprof/query/PhabricatorXHProfSampleSearchEngine.php index f0a5273f3e..4ef5dd53f5 100644 --- a/src/applications/xhprof/query/PhabricatorXHProfSampleSearchEngine.php +++ b/src/applications/xhprof/query/PhabricatorXHProfSampleSearchEngine.php @@ -49,11 +49,16 @@ final class PhabricatorXHProfSampleSearchEngine return parent::buildSavedQueryFromBuiltin($query_key); } + /** + * @param array $samples + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $samples, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($samples, 'PhabricatorXHProfSample'); + assert_instances_of($samples, PhabricatorXHProfSample::class); $viewer = $this->requireViewer(); diff --git a/src/infrastructure/cache/PhutilKeyValueCacheStack.php b/src/infrastructure/cache/PhutilKeyValueCacheStack.php index 9c626339b7..5ff9c72c0b 100644 --- a/src/infrastructure/cache/PhutilKeyValueCacheStack.php +++ b/src/infrastructure/cache/PhutilKeyValueCacheStack.php @@ -38,13 +38,13 @@ final class PhutilKeyValueCacheStack extends PhutilKeyValueCache { /** * Set the caches which comprise this stack. * - * @param list $caches Ordered list of key-value + * @param array $caches Ordered list of key-value * caches. * @return $this * @task config */ public function setCaches(array $caches) { - assert_instances_of($caches, 'PhutilKeyValueCache'); + assert_instances_of($caches, parent::class); $this->cachesForward = $caches; $this->cachesBackward = array_reverse($caches); diff --git a/src/infrastructure/customfield/field/PhabricatorCustomFieldList.php b/src/infrastructure/customfield/field/PhabricatorCustomFieldList.php index ca474ffd8b..654ee6312c 100644 --- a/src/infrastructure/customfield/field/PhabricatorCustomFieldList.php +++ b/src/infrastructure/customfield/field/PhabricatorCustomFieldList.php @@ -12,8 +12,11 @@ final class PhabricatorCustomFieldList extends Phobject { private $fields; private $viewer; + /** + * @param array $fields + */ public function __construct(array $fields) { - assert_instances_of($fields, 'PhabricatorCustomField'); + assert_instances_of($fields, PhabricatorCustomField::class); $this->fields = $fields; } diff --git a/src/infrastructure/customfield/query/PhabricatorCustomFieldStorageQuery.php b/src/infrastructure/customfield/query/PhabricatorCustomFieldStorageQuery.php index 9188117dcc..117226eeb5 100644 --- a/src/infrastructure/customfield/query/PhabricatorCustomFieldStorageQuery.php +++ b/src/infrastructure/customfield/query/PhabricatorCustomFieldStorageQuery.php @@ -12,8 +12,11 @@ final class PhabricatorCustomFieldStorageQuery extends Phobject { private $fieldMap = array(); private $storageSources = array(); + /** + * @param array $fields + */ public function addFields(array $fields) { - assert_instances_of($fields, 'PhabricatorCustomField'); + assert_instances_of($fields, PhabricatorCustomField::class); foreach ($fields as $field) { $this->addField($field); diff --git a/src/infrastructure/daemon/workers/query/PhabricatorWorkerBulkJobSearchEngine.php b/src/infrastructure/daemon/workers/query/PhabricatorWorkerBulkJobSearchEngine.php index cda4176f29..3b7d05897f 100644 --- a/src/infrastructure/daemon/workers/query/PhabricatorWorkerBulkJobSearchEngine.php +++ b/src/infrastructure/daemon/workers/query/PhabricatorWorkerBulkJobSearchEngine.php @@ -71,11 +71,16 @@ final class PhabricatorWorkerBulkJobSearchEngine return parent::buildSavedQueryFromBuiltin($query_key); } + /** + * @param array $jobs + * @param PhabricatorSavedQuery $query + * @param array $handles + */ protected function renderResultList( array $jobs, PhabricatorSavedQuery $query, array $handles) { - assert_instances_of($jobs, 'PhabricatorWorkerBulkJob'); + assert_instances_of($jobs, PhabricatorWorkerBulkJob::class); $viewer = $this->requireViewer(); diff --git a/src/infrastructure/diff/engine/PhabricatorInlineCommentAdjustmentEngine.php b/src/infrastructure/diff/engine/PhabricatorInlineCommentAdjustmentEngine.php index 0589cc0234..aa4e17fbd7 100644 --- a/src/infrastructure/diff/engine/PhabricatorInlineCommentAdjustmentEngine.php +++ b/src/infrastructure/diff/engine/PhabricatorInlineCommentAdjustmentEngine.php @@ -18,8 +18,11 @@ final class PhabricatorInlineCommentAdjustmentEngine return $this->viewer; } + /** + * @param array $inlines + */ public function setInlines(array $inlines) { - assert_instances_of($inlines, 'DifferentialInlineComment'); + assert_instances_of($inlines, DifferentialInlineComment::class); $this->inlines = $inlines; return $this; } @@ -28,8 +31,11 @@ final class PhabricatorInlineCommentAdjustmentEngine return $this->inlines; } + /** + * @param array $old_changesets + */ public function setOldChangesets(array $old_changesets) { - assert_instances_of($old_changesets, 'DifferentialChangeset'); + assert_instances_of($old_changesets, DifferentialChangeset::class); $this->oldChangesets = $old_changesets; return $this; } @@ -38,8 +44,11 @@ final class PhabricatorInlineCommentAdjustmentEngine return $this->oldChangesets; } + /** + * @param array $new_changesets + */ public function setNewChangesets(array $new_changesets) { - assert_instances_of($new_changesets, 'DifferentialChangeset'); + assert_instances_of($new_changesets, DifferentialChangeset::class); $this->newChangesets = $new_changesets; return $this; } diff --git a/src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php b/src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php index 3ff87c11ab..ed98bf3bf1 100644 --- a/src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php +++ b/src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php @@ -15,8 +15,11 @@ final class PHUIDiffInlineCommentDetailView return $this->getInlineComment()->isHidden(); } + /** + * @param array $handles + */ public function setHandles(array $handles) { - assert_instances_of($handles, 'PhabricatorObjectHandle'); + assert_instances_of($handles, PhabricatorObjectHandle::class); $this->handles = $handles; return $this; } diff --git a/src/infrastructure/diff/view/PHUIDiffInlineCommentPreviewListView.php b/src/infrastructure/diff/view/PHUIDiffInlineCommentPreviewListView.php index 9507004520..05cad40539 100644 --- a/src/infrastructure/diff/view/PHUIDiffInlineCommentPreviewListView.php +++ b/src/infrastructure/diff/view/PHUIDiffInlineCommentPreviewListView.php @@ -6,8 +6,12 @@ final class PHUIDiffInlineCommentPreviewListView private $inlineComments = array(); private $ownerPHID; + /** + * @param array $comments + */ public function setInlineComments(array $comments) { - assert_instances_of($comments, 'PhabricatorApplicationTransactionComment'); + assert_instances_of($comments, + PhabricatorApplicationTransactionComment::class); $this->inlineComments = $comments; return $this; } diff --git a/src/infrastructure/diff/view/PHUIDiffTableOfContentsItemView.php b/src/infrastructure/diff/view/PHUIDiffTableOfContentsItemView.php index 752d895952..95e2170e17 100644 --- a/src/infrastructure/diff/view/PHUIDiffTableOfContentsItemView.php +++ b/src/infrastructure/diff/view/PHUIDiffTableOfContentsItemView.php @@ -69,8 +69,11 @@ final class PHUIDiffTableOfContentsItemView extends AphrontView { return $this->context; } + /** + * @param array $packages + */ public function setPackages(array $packages) { - assert_instances_of($packages, 'PhabricatorOwnersPackage'); + assert_instances_of($packages, PhabricatorOwnersPackage::class); $this->packages = mpull($packages, null, 'getPHID'); return $this; } diff --git a/src/infrastructure/diff/view/PHUIDiffTableOfContentsListView.php b/src/infrastructure/diff/view/PHUIDiffTableOfContentsListView.php index d859bc42d7..79fe918699 100644 --- a/src/infrastructure/diff/view/PHUIDiffTableOfContentsListView.php +++ b/src/infrastructure/diff/view/PHUIDiffTableOfContentsListView.php @@ -16,8 +16,11 @@ final class PHUIDiffTableOfContentsListView extends AphrontView { return $this; } + /** + * @param array $authority_packages + */ public function setAuthorityPackages(array $authority_packages) { - assert_instances_of($authority_packages, 'PhabricatorOwnersPackage'); + assert_instances_of($authority_packages, PhabricatorOwnersPackage::class); $this->authorityPackages = $authority_packages; return $this; } diff --git a/src/infrastructure/markup/blockrule/PhutilRemarkupBlockRule.php b/src/infrastructure/markup/blockrule/PhutilRemarkupBlockRule.php index ac3a308d06..849ff3b992 100644 --- a/src/infrastructure/markup/blockrule/PhutilRemarkupBlockRule.php +++ b/src/infrastructure/markup/blockrule/PhutilRemarkupBlockRule.php @@ -61,8 +61,11 @@ abstract class PhutilRemarkupBlockRule extends Phobject { return $this->engine; } + /** + * @param array $rules + */ public function setMarkupRules(array $rules) { - assert_instances_of($rules, 'PhutilRemarkupRule'); + assert_instances_of($rules, PhutilRemarkupRule::class); $this->rules = $rules; $this->updateRules(); return $this; diff --git a/src/infrastructure/markup/remarkup/PhutilRemarkupEngine.php b/src/infrastructure/markup/remarkup/PhutilRemarkupEngine.php index bedbf0bab7..9d0a1c7324 100644 --- a/src/infrastructure/markup/remarkup/PhutilRemarkupEngine.php +++ b/src/infrastructure/markup/remarkup/PhutilRemarkupEngine.php @@ -50,8 +50,11 @@ final class PhutilRemarkupEngine extends PhutilMarkupEngine { return $this->setConfig('runtime.quote.depth', $depth); } + /** + * @param array $rules + */ public function setBlockRules(array $rules) { - assert_instances_of($rules, 'PhutilRemarkupBlockRule'); + assert_instances_of($rules, PhutilRemarkupBlockRule::class); $rules = msortv($rules, 'getPriorityVector'); diff --git a/src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php b/src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php index 93ebaeae40..7d584c029e 100644 --- a/src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php +++ b/src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php @@ -2620,11 +2620,13 @@ abstract class PhabricatorCursorPagedPolicyAwareQuery /** + * @param int $edge_type An edge type's EDGECONST constant + * @param array $constraints * @return $this * @task edgelogic */ public function withEdgeLogicConstraints($edge_type, array $constraints) { - assert_instances_of($constraints, 'PhabricatorQueryConstraint'); + assert_instances_of($constraints, PhabricatorQueryConstraint::class); $constraints = mgroup($constraints, 'getOperator'); foreach ($constraints as $operator => $list) { diff --git a/src/infrastructure/query/policy/PhabricatorPolicyAwareQuery.php b/src/infrastructure/query/policy/PhabricatorPolicyAwareQuery.php index 656a4903bc..09c4532fbe 100644 --- a/src/infrastructure/query/policy/PhabricatorPolicyAwareQuery.php +++ b/src/infrastructure/query/policy/PhabricatorPolicyAwareQuery.php @@ -487,7 +487,7 @@ abstract class PhabricatorPolicyAwareQuery extends PhabricatorOffsetPagedQuery { return $this; } - assert_instances_of($objects, 'PhabricatorPolicyInterface'); + assert_instances_of($objects, PhabricatorPolicyInterface::class); $viewer_fragment = $this->getViewer()->getCacheFragment(); diff --git a/src/infrastructure/storage/management/PhabricatorStorageManagementAPI.php b/src/infrastructure/storage/management/PhabricatorStorageManagementAPI.php index abd84a2c4a..bb09ed4a1d 100644 --- a/src/infrastructure/storage/management/PhabricatorStorageManagementAPI.php +++ b/src/infrastructure/storage/management/PhabricatorStorageManagementAPI.php @@ -104,8 +104,12 @@ final class PhabricatorStorageManagementAPI extends Phobject { return $this->getRef()->getDisplayName(); } + /** + * @param array $patches + * @param bool $only_living + */ public function getDatabaseList(array $patches, $only_living = false) { - assert_instances_of($patches, 'PhabricatorStoragePatch'); + assert_instances_of($patches, PhabricatorStoragePatch::class); $list = array(); @@ -194,8 +198,11 @@ final class PhabricatorStorageManagementAPI extends Phobject { implode(', ', $cols)); } + /** + * @param array $patches + */ public function getLegacyPatches(array $patches) { - assert_instances_of($patches, 'PhabricatorStoragePatch'); + assert_instances_of($patches, PhabricatorStoragePatch::class); try { $row = queryfx_one( diff --git a/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php b/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php index 38a7b7788c..6a90c20730 100644 --- a/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php +++ b/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php @@ -77,8 +77,11 @@ abstract class PhabricatorStorageManagementWorkflow return $this->patches; } + /** + * @param array $patches + */ public function setPatches(array $patches) { - assert_instances_of($patches, 'PhabricatorStoragePatch'); + assert_instances_of($patches, PhabricatorStoragePatch::class); $this->patches = $patches; return $this; } diff --git a/src/view/control/AphrontTokenizerTemplateView.php b/src/view/control/AphrontTokenizerTemplateView.php index ebc9c4d3fb..48717d03b9 100644 --- a/src/view/control/AphrontTokenizerTemplateView.php +++ b/src/view/control/AphrontTokenizerTemplateView.php @@ -18,8 +18,11 @@ final class AphrontTokenizerTemplateView extends AphrontView { return $this; } + /** + * @param array $value + */ public function setValue(array $value) { - assert_instances_of($value, 'PhabricatorTypeaheadTokenView'); + assert_instances_of($value, PhabricatorTypeaheadTokenView::class); $this->value = $value; return $this; } diff --git a/src/view/control/PhabricatorObjectSelectorDialog.php b/src/view/control/PhabricatorObjectSelectorDialog.php index 3455cbc8bd..0e003e7571 100644 --- a/src/view/control/PhabricatorObjectSelectorDialog.php +++ b/src/view/control/PhabricatorObjectSelectorDialog.php @@ -38,8 +38,11 @@ final class PhabricatorObjectSelectorDialog extends Phobject { return $this; } + /** + * @param array $handles + */ public function setHandles(array $handles) { - assert_instances_of($handles, 'PhabricatorObjectHandle'); + assert_instances_of($handles, PhabricatorObjectHandle::class); $this->handles = $handles; return $this; } diff --git a/src/view/form/control/AphrontFormPolicyControl.php b/src/view/form/control/AphrontFormPolicyControl.php index c5e1ed2d29..b07c80834a 100644 --- a/src/view/form/control/AphrontFormPolicyControl.php +++ b/src/view/form/control/AphrontFormPolicyControl.php @@ -14,8 +14,11 @@ final class AphrontFormPolicyControl extends AphrontFormControl { return $this; } + /** + * @param array $policies + */ public function setPolicies(array $policies) { - assert_instances_of($policies, 'PhabricatorPolicy'); + assert_instances_of($policies, PhabricatorPolicy::class); $this->policies = $policies; return $this; } diff --git a/src/view/phui/PHUITimelineView.php b/src/view/phui/PHUITimelineView.php index 7873f73653..8504c2c69c 100644 --- a/src/view/phui/PHUITimelineView.php +++ b/src/view/phui/PHUITimelineView.php @@ -233,8 +233,11 @@ final class PHUITimelineView extends AphrontView { ''); } + /** + * @param array $events + */ private function prepareBadgeData(array $events) { - assert_instances_of($events, 'PHUITimelineEventView'); + assert_instances_of($events, PHUITimelineEventView::class); $viewer = $this->getUser(); $can_use_badges = PhabricatorApplication::isClassInstalledForViewer(