From 243271b9db9f1245c55db1a0ee1fbeb0d925af52 Mon Sep 17 00:00:00 2001
From: Andre Klapper <a9016009@gmx.de>
Date: Sat, 19 Jul 2025 14:26:24 +0200
Subject: [PATCH] Burndown the Burnup Rate (and vice versa)

Summary:
Those two things are in the same one chart. Thus use consistent naming.

Closes T16176

Test Plan:
* Go to http://phorge.localhost/maniphest/report/burn/ and look at the sidebar and the title of the chart
* Enable the "Facts" application at http://phorge.localhost/applications/view/PhabricatorFactApplication/, go to http://phorge.localhost/project/reports/1/, and look at the title of the chart

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T16176

Differential Revision: https://we.phorge.it/D26202
---
 .../controller/ManiphestReportController.php         | 12 ++++++------
 .../PhabricatorProjectReportsController.php          |  3 ++-
 2 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/src/applications/maniphest/controller/ManiphestReportController.php b/src/applications/maniphest/controller/ManiphestReportController.php
index 765bca71e0..4759af3593 100644
--- a/src/applications/maniphest/controller/ManiphestReportController.php
+++ b/src/applications/maniphest/controller/ManiphestReportController.php
@@ -38,8 +38,8 @@ final class ManiphestReportController extends ManiphestController {
 
     $class = PhabricatorFactApplication::class;
     if (PhabricatorApplication::isClassInstalledForViewer($class, $viewer)) {
-      $nav->addLabel(pht('Burnup'));
-      $nav->addFilter('burn', pht('Burnup Rate'));
+      $nav->addLabel(pht('Burnup / Burndown'));
+      $nav->addFilter('burn', pht('Burnup / Burndown Rate'));
     }
 
     $this->view = $nav->selectFilter($this->view, 'user');
@@ -72,10 +72,10 @@ final class ManiphestReportController extends ManiphestController {
   }
 
   /**
-   * Render the "Burnup Rate" on /maniphest/report/burn/.
+   * Render the 'Burnup / Burndown Rate' on /maniphest/report/burn/.
    *
-   * Ironically this is not called for the "Burndown" on /project/reports/$id/
-   * as that's handled by PhabricatorProjectReportsController instead.
+   * The same thing on /project/reports/$id/ is handled by
+   * PhabricatorProjectReportsController instead.
    *
    * @return array<AphrontListFilterView, PHUIObjectBoxView>
    */
@@ -113,7 +113,7 @@ final class ManiphestReportController extends ManiphestController {
       ->setProjects($projects)
       ->buildChartPanel();
 
-    $panel->setName(pht('Burnup Rate'));
+    $panel->setName(pht('Burnup / Burndown Rate'));
 
     $chart_view = id(new PhabricatorDashboardPanelRenderingEngine())
       ->setViewer($viewer)
diff --git a/src/applications/project/controller/PhabricatorProjectReportsController.php b/src/applications/project/controller/PhabricatorProjectReportsController.php
index 36335f1fd9..afc1b4cd07 100644
--- a/src/applications/project/controller/PhabricatorProjectReportsController.php
+++ b/src/applications/project/controller/PhabricatorProjectReportsController.php
@@ -36,7 +36,8 @@ final class PhabricatorProjectReportsController
       ->setProjects(array($project))
       ->buildChartPanel();
 
-    $chart_panel->setName(pht('%s: Burndown', $project->getName()));
+    $chart_panel->setName(pht('%s: Burnup / Burndown Rate',
+      $project->getName()));
 
     $chart_view = id(new PhabricatorDashboardPanelRenderingEngine())
       ->setViewer($viewer)
-- 
2.51.2