From 22b97a4b57a47521a10b569c0bbcf4ae3095516f Mon Sep 17 00:00:00 2001 From: Andre Klapper Date: Sun, 14 Sep 2025 17:42:23 +0200 Subject: [PATCH] Replace some manual class name strings with ::class keyword Summary: Replace classname strings in misc places with the corresponding `::class` keyword. This will enable static code analysis to throw "Class not found" if such a class did not exist. `::class` is available since PHP 5.5: https://www.php.net/manual/en/language.oop5.basic.php#language.oop5.basic.class.class `::class` returns the fully qualified classname including namespace, however we do not use PHP namespaces except in imported external libraries. Refs T15158 Test Plan: Browse random Phorge pages? Reviewers: O1 Blessed Committers, mainframe98 Reviewed By: O1 Blessed Committers, mainframe98 Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Maniphest Tasks: T15158 Differential Revision: https://we.phorge.it/D26351 --- scripts/daemon/exec/exec_daemon.php | 2 +- .../handler/PhabricatorPolicyRequestExceptionHandler.php | 2 +- src/aphront/site/PhabricatorShortSite.php | 3 ++- .../aphlict/query/AphlictDropdownDataQuery.php | 4 ++-- .../audit/application/PhabricatorAuditApplication.php | 2 +- src/applications/audit/conduit/AuditConduitAPIMethod.php | 2 +- .../auth/conduit/PhabricatorAuthConduitAPIMethod.php | 3 ++- .../auth/provider/PhabricatorAuthProvider.php | 6 ++++-- .../base/controller/PhabricatorController.php | 2 +- .../__tests__/PhabricatorAccessControlTestCase.php | 3 ++- .../method/ConduitGetCapabilitiesConduitAPIMethod.php | 2 +- .../conpherence/conduit/ConpherenceConduitAPIMethod.php | 2 +- .../differential/conduit/DifferentialConduitAPIMethod.php | 2 +- .../differential/controller/DifferentialController.php | 2 +- .../relationships/DifferentialRevisionRelationship.php | 2 +- .../diffusion/conduit/DiffusionConduitAPIMethod.php | 2 +- .../diffusion/controller/DiffusionBrowseController.php | 2 +- .../diffusion/controller/DiffusionCommitController.php | 2 +- .../relationships/DiffusionCommitRelationship.php | 2 +- src/applications/diffusion/ssh/DiffusionSSHWorkflow.php | 2 +- .../diffusion/view/DiffusionCommitGraphView.php | 4 ++-- src/applications/diffusion/view/DiffusionView.php | 2 +- .../DrydockAlmanacServiceHostBlueprintImplementation.php | 2 +- .../PhabricatorFavoritesMainMenuBarExtension.php | 2 +- src/applications/feed/PhabricatorFeedStoryPublisher.php | 2 +- src/applications/feed/conduit/FeedConduitAPIMethod.php | 3 ++- src/applications/files/conduit/FileConduitAPIMethod.php | 3 ++- src/applications/flag/conduit/FlagConduitAPIMethod.php | 3 ++- .../harbormaster/conduit/HarbormasterConduitAPIMethod.php | 2 +- .../harbormaster/storage/HarbormasterBuildable.php | 2 +- src/applications/home/view/PHUIHomeView.php | 6 +++--- src/applications/macro/conduit/MacroConduitAPIMethod.php | 3 ++- .../macro/storage/PhabricatorFileImageMacro.php | 2 +- .../maniphest/conduit/ManiphestConduitAPIMethod.php | 2 +- .../maniphest/controller/ManiphestReportController.php | 2 +- .../maniphest/relationship/ManiphestTaskRelationship.php | 2 +- .../nuance/conduit/NuanceConduitAPIMethod.php | 3 ++- .../PhabricatorOAuthServerAuthorizationsSettingsPanel.php | 2 +- .../owners/conduit/OwnersConduitAPIMethod.php | 3 ++- .../passphrase/conduit/PassphraseConduitAPIMethod.php | 2 +- src/applications/paste/conduit/PasteConduitAPIMethod.php | 3 ++- src/applications/people/conduit/UserConduitAPIMethod.php | 3 ++- .../PhabricatorPeopleProfileBadgesController.php | 2 +- .../PhabricatorPeopleProfileCommitsController.php | 2 +- .../PhabricatorPeopleProfileRevisionsController.php | 2 +- .../PhabricatorPeopleProfileTasksAssignedController.php | 2 +- .../PhabricatorPeopleProfileTasksAuthoredController.php | 2 +- .../controller/PhabricatorPeopleProfileViewController.php | 2 +- .../people/engine/PhabricatorPeopleProfileMenuEngine.php | 8 ++++---- src/applications/people/view/PhabricatorUserCardView.php | 2 +- src/applications/phame/site/PhameBlogSite.php | 3 ++- .../pholio/relationships/PholioMockRelationship.php | 2 +- .../phortune/provider/PhortunePaymentProvider.php | 3 ++- .../phrequent/conduit/PhrequentConduitAPIMethod.php | 2 +- .../phriction/conduit/PhrictionConduitAPIMethod.php | 2 +- src/applications/ponder/storage/PonderAnswer.php | 2 +- src/applications/ponder/storage/PonderQuestion.php | 2 +- .../project/conduit/ProjectConduitAPIMethod.php | 3 ++- .../controller/PhabricatorProjectBoardViewController.php | 3 ++- .../PhabricatorProjectColumnBulkMoveController.php | 3 ++- .../menuitem/PhabricatorProjectPointsProfileMenuItem.php | 2 +- .../menuitem/PhabricatorProjectReportsProfileMenuItem.php | 4 ++-- .../PhabricatorProjectWorkboardProfileMenuItem.php | 2 +- .../repository/conduit/RepositoryConduitAPIMethod.php | 2 +- .../daemon/PhabricatorRepositoryPullLocalDaemonModule.php | 2 +- .../repository/storage/PhabricatorRepositoryIdentity.php | 2 +- .../controller/PhabricatorApplicationSearchController.php | 2 +- .../DifferentialRevisionRelationshipSource.php | 2 +- .../relationship/DiffusionCommitRelationshipSource.php | 2 +- .../relationship/ManiphestTaskRelationshipSource.php | 2 +- .../search/relationship/PholioMockRelationshipSource.php | 2 +- .../PhabricatorConpherenceNotificationsSetting.php | 2 +- .../setting/PhabricatorConpherenceSoundSetting.php | 2 +- .../slowvote/conduit/SlowvoteConduitAPIMethod.php | 2 +- src/applications/tokens/conduit/TokenConduitAPIMethod.php | 3 ++- .../view/PhabricatorApplicationTransactionCommentView.php | 2 +- .../daemon/workers/PhabricatorTaskmasterDaemonModule.php | 2 +- .../daemon/workers/PhabricatorTriggerDaemon.php | 2 +- .../workers/query/PhabricatorWorkerTriggerQuery.php | 4 ++-- .../daemon/workers/storage/PhabricatorWorkerTask.php | 2 +- .../export/engine/PhabricatorExportEngineBulkJobType.php | 4 +++- src/view/form/control/PhabricatorRemarkupControl.php | 2 +- src/view/page/PhabricatorStandardPageView.php | 2 +- src/view/page/menu/PhabricatorMainMenuView.php | 4 ++-- src/view/phui/PHUITimelineView.php | 2 +- 85 files changed, 117 insertions(+), 96 deletions(-) diff --git a/scripts/daemon/exec/exec_daemon.php b/scripts/daemon/exec/exec_daemon.php index af53131612..3f10045a85 100755 --- a/scripts/daemon/exec/exec_daemon.php +++ b/scripts/daemon/exec/exec_daemon.php @@ -99,7 +99,7 @@ if (!$daemon) { pht( 'No class "%s" exists in any known library.', $daemon)); - } else if (!is_subclass_of($daemon, 'PhutilDaemon')) { + } else if (!is_subclass_of($daemon, PhutilDaemon::class)) { throw new PhutilArgumentUsageException( pht( 'Class "%s" is not a subclass of "%s".', diff --git a/src/aphront/handler/PhabricatorPolicyRequestExceptionHandler.php b/src/aphront/handler/PhabricatorPolicyRequestExceptionHandler.php index 0900b4abbe..50c83abd34 100644 --- a/src/aphront/handler/PhabricatorPolicyRequestExceptionHandler.php +++ b/src/aphront/handler/PhabricatorPolicyRequestExceptionHandler.php @@ -37,7 +37,7 @@ final class PhabricatorPolicyRequestExceptionHandler // // Possibly we should add a header here like "you need to login to see // the thing you are trying to look at". - $auth_app_class = 'PhabricatorAuthApplication'; + $auth_app_class = PhabricatorAuthApplication::class; $auth_app = PhabricatorApplication::getByClass($auth_app_class); return id(new PhabricatorAuthStartController()) diff --git a/src/aphront/site/PhabricatorShortSite.php b/src/aphront/site/PhabricatorShortSite.php index 05cf2c3584..01151f49c1 100644 --- a/src/aphront/site/PhabricatorShortSite.php +++ b/src/aphront/site/PhabricatorShortSite.php @@ -32,7 +32,8 @@ final class PhabricatorShortSite extends PhabricatorSite { } public function getRoutingMaps() { - $app = PhabricatorApplication::getByClass('PhabricatorPhurlApplication'); + $app = PhabricatorApplication::getByClass( + PhabricatorPhurlApplication::class); $maps = array(); $maps[] = $this->newRoutingMap() diff --git a/src/applications/aphlict/query/AphlictDropdownDataQuery.php b/src/applications/aphlict/query/AphlictDropdownDataQuery.php index 7a15ec7f64..c3ed5ee7d7 100644 --- a/src/applications/aphlict/query/AphlictDropdownDataQuery.php +++ b/src/applications/aphlict/query/AphlictDropdownDataQuery.php @@ -42,7 +42,7 @@ final class AphlictDropdownDataQuery extends Phobject { public function execute() { $viewer = $this->getViewer(); - $conpherence_app = 'PhabricatorConpherenceApplication'; + $conpherence_app = PhabricatorConpherenceApplication::class; $is_c_installed = PhabricatorApplication::isClassInstalledForViewer( $conpherence_app, $viewer); @@ -63,7 +63,7 @@ final class AphlictDropdownDataQuery extends Phobject { ); $this->setConpherenceData($conpherence_data); - $notification_app = 'PhabricatorNotificationsApplication'; + $notification_app = PhabricatorNotificationsApplication::class; $is_n_installed = PhabricatorApplication::isClassInstalledForViewer( $notification_app, $viewer); diff --git a/src/applications/audit/application/PhabricatorAuditApplication.php b/src/applications/audit/application/PhabricatorAuditApplication.php index ee5cbe7781..f2d29543a6 100644 --- a/src/applications/audit/application/PhabricatorAuditApplication.php +++ b/src/applications/audit/application/PhabricatorAuditApplication.php @@ -24,7 +24,7 @@ final class PhabricatorAuditApplication extends PhabricatorApplication { public function isPinnedByDefault(PhabricatorUser $viewer) { return parent::isClassInstalledForViewer( - 'PhabricatorDiffusionApplication', + PhabricatorDiffusionApplication::class, $viewer); } diff --git a/src/applications/audit/conduit/AuditConduitAPIMethod.php b/src/applications/audit/conduit/AuditConduitAPIMethod.php index 4dc9eb103e..8525305894 100644 --- a/src/applications/audit/conduit/AuditConduitAPIMethod.php +++ b/src/applications/audit/conduit/AuditConduitAPIMethod.php @@ -4,7 +4,7 @@ abstract class AuditConduitAPIMethod extends ConduitAPIMethod { final public function getApplication() { return PhabricatorApplication::getByClass( - 'PhabricatorAuditApplication'); + PhabricatorAuditApplication::class); } } diff --git a/src/applications/auth/conduit/PhabricatorAuthConduitAPIMethod.php b/src/applications/auth/conduit/PhabricatorAuthConduitAPIMethod.php index 34bedec0bc..86b3f7634e 100644 --- a/src/applications/auth/conduit/PhabricatorAuthConduitAPIMethod.php +++ b/src/applications/auth/conduit/PhabricatorAuthConduitAPIMethod.php @@ -3,7 +3,8 @@ abstract class PhabricatorAuthConduitAPIMethod extends ConduitAPIMethod { final public function getApplication() { - return PhabricatorApplication::getByClass('PhabricatorAuthApplication'); + return PhabricatorApplication::getByClass( + PhabricatorAuthApplication::class); } public function getMethodStatus() { diff --git a/src/applications/auth/provider/PhabricatorAuthProvider.php b/src/applications/auth/provider/PhabricatorAuthProvider.php index 110b46717e..be103f030e 100644 --- a/src/applications/auth/provider/PhabricatorAuthProvider.php +++ b/src/applications/auth/provider/PhabricatorAuthProvider.php @@ -335,7 +335,8 @@ abstract class PhabricatorAuthProvider extends Phobject { } public function getLoginURI() { - $app = PhabricatorApplication::getByClass('PhabricatorAuthApplication'); + $app = PhabricatorApplication::getByClass( + PhabricatorAuthApplication::class); return $app->getApplicationURI('/login/'.$this->getProviderKey().'/'); } @@ -344,7 +345,8 @@ abstract class PhabricatorAuthProvider extends Phobject { } public function getStartURI() { - $app = PhabricatorApplication::getByClass('PhabricatorAuthApplication'); + $app = PhabricatorApplication::getByClass( + PhabricatorAuthApplication::class); $uri = $app->getApplicationURI('/start/'); return $uri; } diff --git a/src/applications/base/controller/PhabricatorController.php b/src/applications/base/controller/PhabricatorController.php index b506faea31..1ad43b8bef 100644 --- a/src/applications/base/controller/PhabricatorController.php +++ b/src/applications/base/controller/PhabricatorController.php @@ -590,7 +590,7 @@ abstract class PhabricatorController extends AphrontController { $must_sign_docs = array(); $sign_docs = array(); - $legalpad_class = 'PhabricatorLegalpadApplication'; + $legalpad_class = PhabricatorLegalpadApplication::class; $legalpad_installed = PhabricatorApplication::isClassInstalledForViewer( $legalpad_class, $viewer); diff --git a/src/applications/base/controller/__tests__/PhabricatorAccessControlTestCase.php b/src/applications/base/controller/__tests__/PhabricatorAccessControlTestCase.php index 7d763d6e64..9f42277dfa 100644 --- a/src/applications/base/controller/__tests__/PhabricatorAccessControlTestCase.php +++ b/src/applications/base/controller/__tests__/PhabricatorAccessControlTestCase.php @@ -200,7 +200,8 @@ final class PhabricatorAccessControlTestCase extends PhabricatorTestCase { $env->overrideEnvConfig('policy.allow-public', false); - $app = PhabricatorApplication::getByClass('PhabricatorTestApplication'); + $app = PhabricatorApplication::getByClass( + PhabricatorTestApplication::class); $app->reset(); $app->setPolicy( PhabricatorPolicyCapability::CAN_VIEW, diff --git a/src/applications/conduit/method/ConduitGetCapabilitiesConduitAPIMethod.php b/src/applications/conduit/method/ConduitGetCapabilitiesConduitAPIMethod.php index 2cb84b1f83..2f549dbd73 100644 --- a/src/applications/conduit/method/ConduitGetCapabilitiesConduitAPIMethod.php +++ b/src/applications/conduit/method/ConduitGetCapabilitiesConduitAPIMethod.php @@ -36,7 +36,7 @@ final class ConduitGetCapabilitiesConduitAPIMethod extends ConduitAPIMethod { 'sessionless', ); - $oauth_app = 'PhabricatorOAuthServerApplication'; + $oauth_app = PhabricatorOAuthServerApplication::class; if (PhabricatorApplication::isClassInstalled($oauth_app)) { $authentication[] = 'oauth'; } diff --git a/src/applications/conpherence/conduit/ConpherenceConduitAPIMethod.php b/src/applications/conpherence/conduit/ConpherenceConduitAPIMethod.php index 49443597ba..418f97296e 100644 --- a/src/applications/conpherence/conduit/ConpherenceConduitAPIMethod.php +++ b/src/applications/conpherence/conduit/ConpherenceConduitAPIMethod.php @@ -4,7 +4,7 @@ abstract class ConpherenceConduitAPIMethod extends ConduitAPIMethod { final public function getApplication() { return PhabricatorApplication::getByClass( - 'PhabricatorConpherenceApplication'); + PhabricatorConpherenceApplication::class); } final protected function getConpherenceURI(ConpherenceThread $conpherence) { diff --git a/src/applications/differential/conduit/DifferentialConduitAPIMethod.php b/src/applications/differential/conduit/DifferentialConduitAPIMethod.php index 3c4210daf2..f46186b2f8 100644 --- a/src/applications/differential/conduit/DifferentialConduitAPIMethod.php +++ b/src/applications/differential/conduit/DifferentialConduitAPIMethod.php @@ -4,7 +4,7 @@ abstract class DifferentialConduitAPIMethod extends ConduitAPIMethod { final public function getApplication() { return PhabricatorApplication::getByClass( - 'PhabricatorDifferentialApplication'); + PhabricatorDifferentialApplication::class); } protected function buildDiffInfoDictionary(DifferentialDiff $diff) { diff --git a/src/applications/differential/controller/DifferentialController.php b/src/applications/differential/controller/DifferentialController.php index dd3ab85910..352895b81c 100644 --- a/src/applications/differential/controller/DifferentialController.php +++ b/src/applications/differential/controller/DifferentialController.php @@ -42,7 +42,7 @@ abstract class DifferentialController extends PhabricatorController { $viewer = $this->getViewer(); $have_owners = PhabricatorApplication::isClassInstalledForViewer( - 'PhabricatorOwnersApplication', + PhabricatorOwnersApplication::class, $viewer); if (!$have_owners) { return; diff --git a/src/applications/differential/relationships/DifferentialRevisionRelationship.php b/src/applications/differential/relationships/DifferentialRevisionRelationship.php index 74004502eb..7230ad8435 100644 --- a/src/applications/differential/relationships/DifferentialRevisionRelationship.php +++ b/src/applications/differential/relationships/DifferentialRevisionRelationship.php @@ -7,7 +7,7 @@ abstract class DifferentialRevisionRelationship $viewer = $this->getViewer(); $has_app = PhabricatorApplication::isClassInstalledForViewer( - 'PhabricatorDifferentialApplication', + PhabricatorDifferentialApplication::class, $viewer); if (!$has_app) { return false; diff --git a/src/applications/diffusion/conduit/DiffusionConduitAPIMethod.php b/src/applications/diffusion/conduit/DiffusionConduitAPIMethod.php index 1d9c442fa2..0619b25645 100644 --- a/src/applications/diffusion/conduit/DiffusionConduitAPIMethod.php +++ b/src/applications/diffusion/conduit/DiffusionConduitAPIMethod.php @@ -4,7 +4,7 @@ abstract class DiffusionConduitAPIMethod extends ConduitAPIMethod { final public function getApplication() { return PhabricatorApplication::getByClass( - 'PhabricatorDiffusionApplication'); + PhabricatorDiffusionApplication::class); } } diff --git a/src/applications/diffusion/controller/DiffusionBrowseController.php b/src/applications/diffusion/controller/DiffusionBrowseController.php index 8cc0ae31c3..fd0b3bf930 100644 --- a/src/applications/diffusion/controller/DiffusionBrowseController.php +++ b/src/applications/diffusion/controller/DiffusionBrowseController.php @@ -503,7 +503,7 @@ final class DiffusionBrowseController extends DiffusionController { $viewer = $this->getViewer(); $have_owners = PhabricatorApplication::isClassInstalledForViewer( - 'PhabricatorOwnersApplication', + PhabricatorOwnersApplication::class, $viewer); if (!$have_owners) { return null; diff --git a/src/applications/diffusion/controller/DiffusionCommitController.php b/src/applications/diffusion/controller/DiffusionCommitController.php index 143fd125cc..26493689c4 100644 --- a/src/applications/diffusion/controller/DiffusionCommitController.php +++ b/src/applications/diffusion/controller/DiffusionCommitController.php @@ -980,7 +980,7 @@ final class DiffusionCommitController extends DiffusionController { ->setDiffusionRequest($drequest); $have_owners = PhabricatorApplication::isClassInstalledForViewer( - 'PhabricatorOwnersApplication', + PhabricatorOwnersApplication::class, $viewer); if (!$changesets) { diff --git a/src/applications/diffusion/relationships/DiffusionCommitRelationship.php b/src/applications/diffusion/relationships/DiffusionCommitRelationship.php index 596350f362..ee4579577f 100644 --- a/src/applications/diffusion/relationships/DiffusionCommitRelationship.php +++ b/src/applications/diffusion/relationships/DiffusionCommitRelationship.php @@ -7,7 +7,7 @@ abstract class DiffusionCommitRelationship $viewer = $this->getViewer(); $has_app = PhabricatorApplication::isClassInstalledForViewer( - 'PhabricatorDiffusionApplication', + PhabricatorDiffusionApplication::class, $viewer); if (!$has_app) { return false; diff --git a/src/applications/diffusion/ssh/DiffusionSSHWorkflow.php b/src/applications/diffusion/ssh/DiffusionSSHWorkflow.php index 0645e76356..536fa5ae7b 100644 --- a/src/applications/diffusion/ssh/DiffusionSSHWorkflow.php +++ b/src/applications/diffusion/ssh/DiffusionSSHWorkflow.php @@ -166,7 +166,7 @@ abstract class DiffusionSSHWorkflow extends PhabricatorSSHWorkflow { $viewer = $this->getSSHUser(); $have_diffusion = PhabricatorApplication::isClassInstalledForViewer( - 'PhabricatorDiffusionApplication', + PhabricatorDiffusionApplication::class, $viewer); if (!$have_diffusion) { throw new Exception( diff --git a/src/applications/diffusion/view/DiffusionCommitGraphView.php b/src/applications/diffusion/view/DiffusionCommitGraphView.php index 9f4c615071..acfcfc0d82 100644 --- a/src/applications/diffusion/view/DiffusionCommitGraphView.php +++ b/src/applications/diffusion/view/DiffusionCommitGraphView.php @@ -337,7 +337,7 @@ final class DiffusionCommitGraphView $viewer = $this->getViewer(); $show_builds = PhabricatorApplication::isClassInstalledForViewer( - 'PhabricatorHarbormasterApplication', + PhabricatorHarbormasterApplication::class, $this->getUser()); return $show_builds; @@ -347,7 +347,7 @@ final class DiffusionCommitGraphView $viewer = $this->getViewer(); $show_revisions = PhabricatorApplication::isClassInstalledForViewer( - 'PhabricatorDifferentialApplication', + PhabricatorDifferentialApplication::class, $viewer); return $show_revisions; diff --git a/src/applications/diffusion/view/DiffusionView.php b/src/applications/diffusion/view/DiffusionView.php index 3503c60ce5..261cc07deb 100644 --- a/src/applications/diffusion/view/DiffusionView.php +++ b/src/applications/diffusion/view/DiffusionView.php @@ -233,7 +233,7 @@ abstract class DiffusionView extends AphrontView { $viewer = $this->getUser(); - $harbormaster_app = 'PhabricatorHarbormasterApplication'; + $harbormaster_app = PhabricatorHarbormasterApplication::class; $have_harbormaster = PhabricatorApplication::isClassInstalledForViewer( $harbormaster_app, $viewer); diff --git a/src/applications/drydock/blueprint/DrydockAlmanacServiceHostBlueprintImplementation.php b/src/applications/drydock/blueprint/DrydockAlmanacServiceHostBlueprintImplementation.php index 683e9f9682..95c4229c96 100644 --- a/src/applications/drydock/blueprint/DrydockAlmanacServiceHostBlueprintImplementation.php +++ b/src/applications/drydock/blueprint/DrydockAlmanacServiceHostBlueprintImplementation.php @@ -7,7 +7,7 @@ final class DrydockAlmanacServiceHostBlueprintImplementation private $freeBindings; public function isEnabled() { - $almanac_app = 'PhabricatorAlmanacApplication'; + $almanac_app = PhabricatorAlmanacApplication::class; return PhabricatorApplication::isClassInstalled($almanac_app); } diff --git a/src/applications/favorites/engineextension/PhabricatorFavoritesMainMenuBarExtension.php b/src/applications/favorites/engineextension/PhabricatorFavoritesMainMenuBarExtension.php index 2af35f1f79..76906e4d2f 100644 --- a/src/applications/favorites/engineextension/PhabricatorFavoritesMainMenuBarExtension.php +++ b/src/applications/favorites/engineextension/PhabricatorFavoritesMainMenuBarExtension.php @@ -7,7 +7,7 @@ final class PhabricatorFavoritesMainMenuBarExtension public function isExtensionEnabledForViewer(PhabricatorUser $viewer) { return PhabricatorApplication::isClassInstalledForViewer( - 'PhabricatorFavoritesApplication', + PhabricatorFavoritesApplication::class, $viewer); } diff --git a/src/applications/feed/PhabricatorFeedStoryPublisher.php b/src/applications/feed/PhabricatorFeedStoryPublisher.php index f3e44eb717..823aec943b 100644 --- a/src/applications/feed/PhabricatorFeedStoryPublisher.php +++ b/src/applications/feed/PhabricatorFeedStoryPublisher.php @@ -99,7 +99,7 @@ final class PhabricatorFeedStoryPublisher extends Phobject { $class)); } - if (!is_subclass_of($class, 'PhabricatorFeedStory')) { + if (!is_subclass_of($class, PhabricatorFeedStory::class)) { throw new Exception( pht( "Story type must be a valid class name and must subclass %s. ". diff --git a/src/applications/feed/conduit/FeedConduitAPIMethod.php b/src/applications/feed/conduit/FeedConduitAPIMethod.php index a11841d077..e032d105f1 100644 --- a/src/applications/feed/conduit/FeedConduitAPIMethod.php +++ b/src/applications/feed/conduit/FeedConduitAPIMethod.php @@ -3,7 +3,8 @@ abstract class FeedConduitAPIMethod extends ConduitAPIMethod { final public function getApplication() { - return PhabricatorApplication::getByClass('PhabricatorFeedApplication'); + return PhabricatorApplication::getByClass( + PhabricatorFeedApplication::class); } } diff --git a/src/applications/files/conduit/FileConduitAPIMethod.php b/src/applications/files/conduit/FileConduitAPIMethod.php index 420ed65bfb..15342e3b8e 100644 --- a/src/applications/files/conduit/FileConduitAPIMethod.php +++ b/src/applications/files/conduit/FileConduitAPIMethod.php @@ -3,7 +3,8 @@ abstract class FileConduitAPIMethod extends ConduitAPIMethod { final public function getApplication() { - return PhabricatorApplication::getByClass('PhabricatorFilesApplication'); + return PhabricatorApplication::getByClass( + PhabricatorFilesApplication::class); } protected function loadFileByPHID(PhabricatorUser $viewer, $file_phid) { diff --git a/src/applications/flag/conduit/FlagConduitAPIMethod.php b/src/applications/flag/conduit/FlagConduitAPIMethod.php index d3eab561ed..33a19cd8a8 100644 --- a/src/applications/flag/conduit/FlagConduitAPIMethod.php +++ b/src/applications/flag/conduit/FlagConduitAPIMethod.php @@ -3,7 +3,8 @@ abstract class FlagConduitAPIMethod extends ConduitAPIMethod { final public function getApplication() { - return PhabricatorApplication::getByClass('PhabricatorFlagsApplication'); + return PhabricatorApplication::getByClass( + PhabricatorFlagsApplication::class); } protected function attachHandleToFlag($flag, PhabricatorUser $user) { diff --git a/src/applications/harbormaster/conduit/HarbormasterConduitAPIMethod.php b/src/applications/harbormaster/conduit/HarbormasterConduitAPIMethod.php index 6f5b453ed7..27e4a86174 100644 --- a/src/applications/harbormaster/conduit/HarbormasterConduitAPIMethod.php +++ b/src/applications/harbormaster/conduit/HarbormasterConduitAPIMethod.php @@ -4,7 +4,7 @@ abstract class HarbormasterConduitAPIMethod extends ConduitAPIMethod { final public function getApplication() { return PhabricatorApplication::getByClass( - 'PhabricatorHarbormasterApplication'); + PhabricatorHarbormasterApplication::class); } protected function returnArtifactList(array $artifacts) { diff --git a/src/applications/harbormaster/storage/HarbormasterBuildable.php b/src/applications/harbormaster/storage/HarbormasterBuildable.php index d57b60f15b..7ad673cfef 100644 --- a/src/applications/harbormaster/storage/HarbormasterBuildable.php +++ b/src/applications/harbormaster/storage/HarbormasterBuildable.php @@ -80,7 +80,7 @@ final class HarbormasterBuildable // Skip all of this logic if the Harbormaster application // isn't currently installed. - $harbormaster_app = 'PhabricatorHarbormasterApplication'; + $harbormaster_app = PhabricatorHarbormasterApplication::class; if (!PhabricatorApplication::isClassInstalled($harbormaster_app)) { return; } diff --git a/src/applications/home/view/PHUIHomeView.php b/src/applications/home/view/PHUIHomeView.php index 45750f5a93..d7eb9f37bf 100644 --- a/src/applications/home/view/PHUIHomeView.php +++ b/src/applications/home/view/PHUIHomeView.php @@ -16,15 +16,15 @@ final class PHUIHomeView $viewer = $this->getViewer(); $has_maniphest = PhabricatorApplication::isClassInstalledForViewer( - 'PhabricatorManiphestApplication', + PhabricatorManiphestApplication::class, $viewer); $has_diffusion = PhabricatorApplication::isClassInstalledForViewer( - 'PhabricatorDiffusionApplication', + PhabricatorDiffusionApplication::class, $viewer); $has_differential = PhabricatorApplication::isClassInstalledForViewer( - 'PhabricatorDifferentialApplication', + PhabricatorDifferentialApplication::class, $viewer); $revision_panel = null; diff --git a/src/applications/macro/conduit/MacroConduitAPIMethod.php b/src/applications/macro/conduit/MacroConduitAPIMethod.php index 7b335c5da8..afaed1465c 100644 --- a/src/applications/macro/conduit/MacroConduitAPIMethod.php +++ b/src/applications/macro/conduit/MacroConduitAPIMethod.php @@ -3,7 +3,8 @@ abstract class MacroConduitAPIMethod extends ConduitAPIMethod { final public function getApplication() { - return PhabricatorApplication::getByClass('PhabricatorMacroApplication'); + return PhabricatorApplication::getByClass( + PhabricatorMacroApplication::class); } } diff --git a/src/applications/macro/storage/PhabricatorFileImageMacro.php b/src/applications/macro/storage/PhabricatorFileImageMacro.php index b03a84efe2..14c06948fe 100644 --- a/src/applications/macro/storage/PhabricatorFileImageMacro.php +++ b/src/applications/macro/storage/PhabricatorFileImageMacro.php @@ -137,7 +137,7 @@ final class PhabricatorFileImageMacro extends PhabricatorFileDAO return PhabricatorPolicies::getMostOpenPolicy(); case PhabricatorPolicyCapability::CAN_EDIT: $app = PhabricatorApplication::getByClass( - 'PhabricatorMacroApplication'); + PhabricatorMacroApplication::class); return $app->getPolicy(PhabricatorMacroManageCapability::CAPABILITY); } } diff --git a/src/applications/maniphest/conduit/ManiphestConduitAPIMethod.php b/src/applications/maniphest/conduit/ManiphestConduitAPIMethod.php index df79364383..2530c539b9 100644 --- a/src/applications/maniphest/conduit/ManiphestConduitAPIMethod.php +++ b/src/applications/maniphest/conduit/ManiphestConduitAPIMethod.php @@ -4,7 +4,7 @@ abstract class ManiphestConduitAPIMethod extends ConduitAPIMethod { final public function getApplication() { return PhabricatorApplication::getByClass( - 'PhabricatorManiphestApplication'); + PhabricatorManiphestApplication::class); } protected function defineErrorTypes() { diff --git a/src/applications/maniphest/controller/ManiphestReportController.php b/src/applications/maniphest/controller/ManiphestReportController.php index 8c5deee625..765bca71e0 100644 --- a/src/applications/maniphest/controller/ManiphestReportController.php +++ b/src/applications/maniphest/controller/ManiphestReportController.php @@ -36,7 +36,7 @@ final class ManiphestReportController extends ManiphestController { $nav->addFilter('user', pht('By User')); $nav->addFilter('project', pht('By Project')); - $class = 'PhabricatorFactApplication'; + $class = PhabricatorFactApplication::class; if (PhabricatorApplication::isClassInstalledForViewer($class, $viewer)) { $nav->addLabel(pht('Burnup')); $nav->addFilter('burn', pht('Burnup Rate')); diff --git a/src/applications/maniphest/relationship/ManiphestTaskRelationship.php b/src/applications/maniphest/relationship/ManiphestTaskRelationship.php index a7d3e6f11c..ff598d7be6 100644 --- a/src/applications/maniphest/relationship/ManiphestTaskRelationship.php +++ b/src/applications/maniphest/relationship/ManiphestTaskRelationship.php @@ -7,7 +7,7 @@ abstract class ManiphestTaskRelationship $viewer = $this->getViewer(); $has_app = PhabricatorApplication::isClassInstalledForViewer( - 'PhabricatorManiphestApplication', + PhabricatorManiphestApplication::class, $viewer); if (!$has_app) { return false; diff --git a/src/applications/nuance/conduit/NuanceConduitAPIMethod.php b/src/applications/nuance/conduit/NuanceConduitAPIMethod.php index 9634cb6b9b..3582095578 100644 --- a/src/applications/nuance/conduit/NuanceConduitAPIMethod.php +++ b/src/applications/nuance/conduit/NuanceConduitAPIMethod.php @@ -3,7 +3,8 @@ abstract class NuanceConduitAPIMethod extends ConduitAPIMethod { final public function getApplication() { - return PhabricatorApplication::getByClass('PhabricatorNuanceApplication'); + return PhabricatorApplication::getByClass( + PhabricatorNuanceApplication::class); } public function getMethodStatus() { diff --git a/src/applications/oauthserver/panel/PhabricatorOAuthServerAuthorizationsSettingsPanel.php b/src/applications/oauthserver/panel/PhabricatorOAuthServerAuthorizationsSettingsPanel.php index 21fb891330..8f74460ec7 100644 --- a/src/applications/oauthserver/panel/PhabricatorOAuthServerAuthorizationsSettingsPanel.php +++ b/src/applications/oauthserver/panel/PhabricatorOAuthServerAuthorizationsSettingsPanel.php @@ -30,7 +30,7 @@ final class PhabricatorOAuthServerAuthorizationsSettingsPanel // TODO: It would be nice to simply disable this panel, but we can't do // viewer-based checks for enabled panels right now. - $app_class = 'PhabricatorOAuthServerApplication'; + $app_class = PhabricatorOAuthServerApplication::class; $installed = PhabricatorApplication::isClassInstalledForViewer( $app_class, $viewer); diff --git a/src/applications/owners/conduit/OwnersConduitAPIMethod.php b/src/applications/owners/conduit/OwnersConduitAPIMethod.php index 3e2a199161..a36701deeb 100644 --- a/src/applications/owners/conduit/OwnersConduitAPIMethod.php +++ b/src/applications/owners/conduit/OwnersConduitAPIMethod.php @@ -3,7 +3,8 @@ abstract class OwnersConduitAPIMethod extends ConduitAPIMethod { final public function getApplication() { - return PhabricatorApplication::getByClass('PhabricatorOwnersApplication'); + return PhabricatorApplication::getByClass( + PhabricatorOwnersApplication::class); } } diff --git a/src/applications/passphrase/conduit/PassphraseConduitAPIMethod.php b/src/applications/passphrase/conduit/PassphraseConduitAPIMethod.php index 7b5ed82460..7eae6264e8 100644 --- a/src/applications/passphrase/conduit/PassphraseConduitAPIMethod.php +++ b/src/applications/passphrase/conduit/PassphraseConduitAPIMethod.php @@ -4,7 +4,7 @@ abstract class PassphraseConduitAPIMethod extends ConduitAPIMethod { final public function getApplication() { return PhabricatorApplication::getByClass( - 'PhabricatorPassphraseApplication'); + PhabricatorPassphraseApplication::class); } } diff --git a/src/applications/paste/conduit/PasteConduitAPIMethod.php b/src/applications/paste/conduit/PasteConduitAPIMethod.php index 71178192a6..692e339c37 100644 --- a/src/applications/paste/conduit/PasteConduitAPIMethod.php +++ b/src/applications/paste/conduit/PasteConduitAPIMethod.php @@ -3,7 +3,8 @@ abstract class PasteConduitAPIMethod extends ConduitAPIMethod { final public function getApplication() { - return PhabricatorApplication::getByClass('PhabricatorPasteApplication'); + return PhabricatorApplication::getByClass( + PhabricatorPasteApplication::class); } protected function buildPasteInfoDictionary(PhabricatorPaste $paste) { diff --git a/src/applications/people/conduit/UserConduitAPIMethod.php b/src/applications/people/conduit/UserConduitAPIMethod.php index 427e7f71e5..a576300f29 100644 --- a/src/applications/people/conduit/UserConduitAPIMethod.php +++ b/src/applications/people/conduit/UserConduitAPIMethod.php @@ -3,7 +3,8 @@ abstract class UserConduitAPIMethod extends ConduitAPIMethod { final public function getApplication() { - return PhabricatorApplication::getByClass('PhabricatorPeopleApplication'); + return PhabricatorApplication::getByClass( + PhabricatorPeopleApplication::class); } protected function buildUserInformationDictionary( diff --git a/src/applications/people/controller/PhabricatorPeopleProfileBadgesController.php b/src/applications/people/controller/PhabricatorPeopleProfileBadgesController.php index 3e44a73c73..6e5af75e77 100644 --- a/src/applications/people/controller/PhabricatorPeopleProfileBadgesController.php +++ b/src/applications/people/controller/PhabricatorPeopleProfileBadgesController.php @@ -16,7 +16,7 @@ final class PhabricatorPeopleProfileBadgesController return new Aphront404Response(); } - $class = 'PhabricatorBadgesApplication'; + $class = PhabricatorBadgesApplication::class; if (!PhabricatorApplication::isClassInstalledForViewer($class, $viewer)) { return new Aphront404Response(); } diff --git a/src/applications/people/controller/PhabricatorPeopleProfileCommitsController.php b/src/applications/people/controller/PhabricatorPeopleProfileCommitsController.php index 8f85fef8ec..fe3f929b70 100644 --- a/src/applications/people/controller/PhabricatorPeopleProfileCommitsController.php +++ b/src/applications/people/controller/PhabricatorPeopleProfileCommitsController.php @@ -18,7 +18,7 @@ final class PhabricatorPeopleProfileCommitsController return new Aphront404Response(); } - $class = 'PhabricatorDiffusionApplication'; + $class = PhabricatorDiffusionApplication::class; if (!PhabricatorApplication::isClassInstalledForViewer($class, $viewer)) { return new Aphront404Response(); } diff --git a/src/applications/people/controller/PhabricatorPeopleProfileRevisionsController.php b/src/applications/people/controller/PhabricatorPeopleProfileRevisionsController.php index 0c7b6f6a1f..77196f414a 100644 --- a/src/applications/people/controller/PhabricatorPeopleProfileRevisionsController.php +++ b/src/applications/people/controller/PhabricatorPeopleProfileRevisionsController.php @@ -18,7 +18,7 @@ final class PhabricatorPeopleProfileRevisionsController return new Aphront404Response(); } - $class = 'PhabricatorDifferentialApplication'; + $class = PhabricatorDifferentialApplication::class; if (!PhabricatorApplication::isClassInstalledForViewer($class, $viewer)) { return new Aphront404Response(); } diff --git a/src/applications/people/controller/PhabricatorPeopleProfileTasksAssignedController.php b/src/applications/people/controller/PhabricatorPeopleProfileTasksAssignedController.php index 1cf4b6003c..aa76948476 100644 --- a/src/applications/people/controller/PhabricatorPeopleProfileTasksAssignedController.php +++ b/src/applications/people/controller/PhabricatorPeopleProfileTasksAssignedController.php @@ -18,7 +18,7 @@ final class PhabricatorPeopleProfileTasksAssignedController return new Aphront404Response(); } - $class = 'PhabricatorManiphestApplication'; + $class = PhabricatorManiphestApplication::class; if (!PhabricatorApplication::isClassInstalledForViewer($class, $viewer)) { return new Aphront404Response(); } diff --git a/src/applications/people/controller/PhabricatorPeopleProfileTasksAuthoredController.php b/src/applications/people/controller/PhabricatorPeopleProfileTasksAuthoredController.php index 71d394a595..d8d654c070 100644 --- a/src/applications/people/controller/PhabricatorPeopleProfileTasksAuthoredController.php +++ b/src/applications/people/controller/PhabricatorPeopleProfileTasksAuthoredController.php @@ -18,7 +18,7 @@ final class PhabricatorPeopleProfileTasksAuthoredController return new Aphront404Response(); } - $class = 'PhabricatorManiphestApplication'; + $class = PhabricatorManiphestApplication::class; if (!PhabricatorApplication::isClassInstalledForViewer($class, $viewer)) { return new Aphront404Response(); } diff --git a/src/applications/people/controller/PhabricatorPeopleProfileViewController.php b/src/applications/people/controller/PhabricatorPeopleProfileViewController.php index dbb8773ed6..3b5c664c5d 100644 --- a/src/applications/people/controller/PhabricatorPeopleProfileViewController.php +++ b/src/applications/people/controller/PhabricatorPeopleProfileViewController.php @@ -177,7 +177,7 @@ final class PhabricatorPeopleProfileViewController */ private function buildCalendarDayView(PhabricatorUser $user) { $viewer = $this->getViewer(); - $class = 'PhabricatorCalendarApplication'; + $class = PhabricatorCalendarApplication::class; if (!PhabricatorApplication::isClassInstalledForViewer($class, $viewer)) { return null; diff --git a/src/applications/people/engine/PhabricatorPeopleProfileMenuEngine.php b/src/applications/people/engine/PhabricatorPeopleProfileMenuEngine.php index 62dbfc0833..24ca0bf66c 100644 --- a/src/applications/people/engine/PhabricatorPeopleProfileMenuEngine.php +++ b/src/applications/people/engine/PhabricatorPeopleProfileMenuEngine.php @@ -37,7 +37,7 @@ final class PhabricatorPeopleProfileMenuEngine ->setMenuItemKey(PhabricatorPeopleDetailsProfileMenuItem::MENUITEMKEY); $have_maniphest = PhabricatorApplication::isClassInstalledForViewer( - 'PhabricatorManiphestApplication', + PhabricatorManiphestApplication::class, $viewer); if ($have_maniphest) { $items[] = $this->newItem() @@ -51,7 +51,7 @@ final class PhabricatorPeopleProfileMenuEngine } $have_differential = PhabricatorApplication::isClassInstalledForViewer( - 'PhabricatorDifferentialApplication', + PhabricatorDifferentialApplication::class, $viewer); if ($have_differential) { $items[] = $this->newItem() @@ -61,7 +61,7 @@ final class PhabricatorPeopleProfileMenuEngine } $have_diffusion = PhabricatorApplication::isClassInstalledForViewer( - 'PhabricatorDiffusionApplication', + PhabricatorDiffusionApplication::class, $viewer); if ($have_diffusion) { $items[] = $this->newItem() @@ -70,7 +70,7 @@ final class PhabricatorPeopleProfileMenuEngine } $have_badges = PhabricatorApplication::isClassInstalledForViewer( - 'PhabricatorBadgesApplication', + PhabricatorBadgesApplication::class, $viewer); if ($have_badges) { $items[] = $this->newItem() diff --git a/src/applications/people/view/PhabricatorUserCardView.php b/src/applications/people/view/PhabricatorUserCardView.php index 83cf3c78f6..e0b0f2554e 100644 --- a/src/applications/people/view/PhabricatorUserCardView.php +++ b/src/applications/people/view/PhabricatorUserCardView.php @@ -106,7 +106,7 @@ final class PhabricatorUserCardView extends AphrontTagView { phabricator_date($user->getDateCreated(), $viewer)); $has_calendar = PhabricatorApplication::isClassInstalledForViewer( - 'PhabricatorCalendarApplication', + PhabricatorCalendarApplication::class, $viewer); if ($has_calendar) { if (!$user->getIsDisabled()) { diff --git a/src/applications/phame/site/PhameBlogSite.php b/src/applications/phame/site/PhameBlogSite.php index f45aca0266..cccd660022 100644 --- a/src/applications/phame/site/PhameBlogSite.php +++ b/src/applications/phame/site/PhameBlogSite.php @@ -65,7 +65,8 @@ final class PhameBlogSite extends PhameSite { } public function getRoutingMaps() { - $app = PhabricatorApplication::getByClass('PhabricatorPhameApplication'); + $app = PhabricatorApplication::getByClass( + PhabricatorPhameApplication::class); $maps = array(); $maps[] = $this->newRoutingMap() diff --git a/src/applications/pholio/relationships/PholioMockRelationship.php b/src/applications/pholio/relationships/PholioMockRelationship.php index 0d34f2108b..283ebc6956 100644 --- a/src/applications/pholio/relationships/PholioMockRelationship.php +++ b/src/applications/pholio/relationships/PholioMockRelationship.php @@ -7,7 +7,7 @@ abstract class PholioMockRelationship $viewer = $this->getViewer(); $has_app = PhabricatorApplication::isClassInstalledForViewer( - 'PhabricatorPholioApplication', + PhabricatorPholioApplication::class, $viewer); if (!$has_app) { return false; diff --git a/src/applications/phortune/provider/PhortunePaymentProvider.php b/src/applications/phortune/provider/PhortunePaymentProvider.php index eb6d2ff2e3..e06379b462 100644 --- a/src/applications/phortune/provider/PhortunePaymentProvider.php +++ b/src/applications/phortune/provider/PhortunePaymentProvider.php @@ -270,7 +270,8 @@ abstract class PhortunePaymentProvider extends Phobject { $local = false) { $id = $this->getProviderConfig()->getID(); - $app = PhabricatorApplication::getByClass('PhabricatorPhortuneApplication'); + $app = PhabricatorApplication::getByClass( + PhabricatorPhortuneApplication::class); $path = $app->getBaseURI().'provider/'.$id.'/'.$action.'/'; $uri = new PhutilURI($path, $params); diff --git a/src/applications/phrequent/conduit/PhrequentConduitAPIMethod.php b/src/applications/phrequent/conduit/PhrequentConduitAPIMethod.php index 88b23937f8..07540a19cb 100644 --- a/src/applications/phrequent/conduit/PhrequentConduitAPIMethod.php +++ b/src/applications/phrequent/conduit/PhrequentConduitAPIMethod.php @@ -4,7 +4,7 @@ abstract class PhrequentConduitAPIMethod extends ConduitAPIMethod { final public function getApplication() { return PhabricatorApplication::getByClass( - 'PhabricatorPhrequentApplication'); + PhabricatorPhrequentApplication::class); } } diff --git a/src/applications/phriction/conduit/PhrictionConduitAPIMethod.php b/src/applications/phriction/conduit/PhrictionConduitAPIMethod.php index 065492dd82..27a9918df6 100644 --- a/src/applications/phriction/conduit/PhrictionConduitAPIMethod.php +++ b/src/applications/phriction/conduit/PhrictionConduitAPIMethod.php @@ -4,7 +4,7 @@ abstract class PhrictionConduitAPIMethod extends ConduitAPIMethod { final public function getApplication() { return PhabricatorApplication::getByClass( - 'PhabricatorPhrictionApplication'); + PhabricatorPhrictionApplication::class); } final protected function buildDocumentInfoDictionary(PhrictionDocument $doc) { diff --git a/src/applications/ponder/storage/PonderAnswer.php b/src/applications/ponder/storage/PonderAnswer.php index af9b423287..ce65ec8d3a 100644 --- a/src/applications/ponder/storage/PonderAnswer.php +++ b/src/applications/ponder/storage/PonderAnswer.php @@ -165,7 +165,7 @@ final class PonderAnswer extends PonderDAO return $this->getQuestion()->getPolicy($capability); case PhabricatorPolicyCapability::CAN_EDIT: $app = PhabricatorApplication::getByClass( - 'PhabricatorPonderApplication'); + PhabricatorPonderApplication::class); return $app->getPolicy(PonderModerateCapability::CAPABILITY); } } diff --git a/src/applications/ponder/storage/PonderQuestion.php b/src/applications/ponder/storage/PonderQuestion.php index 53b3e09061..a22308b9ed 100644 --- a/src/applications/ponder/storage/PonderQuestion.php +++ b/src/applications/ponder/storage/PonderQuestion.php @@ -216,7 +216,7 @@ final class PonderQuestion extends PonderDAO return $this->getViewPolicy(); case PhabricatorPolicyCapability::CAN_EDIT: $app = PhabricatorApplication::getByClass( - 'PhabricatorPonderApplication'); + PhabricatorPonderApplication::class); return $app->getPolicy(PonderModerateCapability::CAPABILITY); } } diff --git a/src/applications/project/conduit/ProjectConduitAPIMethod.php b/src/applications/project/conduit/ProjectConduitAPIMethod.php index e3a569b647..9c6095ea91 100644 --- a/src/applications/project/conduit/ProjectConduitAPIMethod.php +++ b/src/applications/project/conduit/ProjectConduitAPIMethod.php @@ -3,7 +3,8 @@ abstract class ProjectConduitAPIMethod extends ConduitAPIMethod { final public function getApplication() { - return PhabricatorApplication::getByClass('PhabricatorProjectApplication'); + return PhabricatorApplication::getByClass( + PhabricatorProjectApplication::class); } protected function buildProjectInfoDictionary(PhabricatorProject $project) { diff --git a/src/applications/project/controller/PhabricatorProjectBoardViewController.php b/src/applications/project/controller/PhabricatorProjectBoardViewController.php index ad40e7520d..4b35af8d37 100644 --- a/src/applications/project/controller/PhabricatorProjectBoardViewController.php +++ b/src/applications/project/controller/PhabricatorProjectBoardViewController.php @@ -756,7 +756,8 @@ final class PhabricatorProjectBoardViewController $can_bulk_edit = PhabricatorPolicyFilter::hasCapability( $viewer, - PhabricatorApplication::getByClass('PhabricatorManiphestApplication'), + PhabricatorApplication::getByClass( + PhabricatorManiphestApplication::class), ManiphestBulkEditCapability::CAPABILITY); $column_move_uri = urisprintf('bulkmove/%d/column/', $column->getID()); diff --git a/src/applications/project/controller/PhabricatorProjectColumnBulkMoveController.php b/src/applications/project/controller/PhabricatorProjectColumnBulkMoveController.php index 4e6a363ea6..e0854230d7 100644 --- a/src/applications/project/controller/PhabricatorProjectColumnBulkMoveController.php +++ b/src/applications/project/controller/PhabricatorProjectColumnBulkMoveController.php @@ -42,7 +42,8 @@ final class PhabricatorProjectColumnBulkMoveController $can_bulk_edit = PhabricatorPolicyFilter::hasCapability( $viewer, - PhabricatorApplication::getByClass('PhabricatorManiphestApplication'), + PhabricatorApplication::getByClass( + PhabricatorManiphestApplication::class), ManiphestBulkEditCapability::CAPABILITY); if (!$can_bulk_edit) { diff --git a/src/applications/project/menuitem/PhabricatorProjectPointsProfileMenuItem.php b/src/applications/project/menuitem/PhabricatorProjectPointsProfileMenuItem.php index 20c8d2985b..6adb11b311 100644 --- a/src/applications/project/menuitem/PhabricatorProjectPointsProfileMenuItem.php +++ b/src/applications/project/menuitem/PhabricatorProjectPointsProfileMenuItem.php @@ -27,7 +27,7 @@ final class PhabricatorProjectPointsProfileMenuItem } // Points are only available if Maniphest is installed. - $class = 'PhabricatorManiphestApplication'; + $class = PhabricatorManiphestApplication::class; if (!PhabricatorApplication::isClassInstalledForViewer($class, $viewer)) { return false; } diff --git a/src/applications/project/menuitem/PhabricatorProjectReportsProfileMenuItem.php b/src/applications/project/menuitem/PhabricatorProjectReportsProfileMenuItem.php index 3b0acdf375..8da9739687 100644 --- a/src/applications/project/menuitem/PhabricatorProjectReportsProfileMenuItem.php +++ b/src/applications/project/menuitem/PhabricatorProjectReportsProfileMenuItem.php @@ -29,12 +29,12 @@ final class PhabricatorProjectReportsProfileMenuItem return false; } - $class = 'PhabricatorManiphestApplication'; + $class = PhabricatorManiphestApplication::class; if (!PhabricatorApplication::isClassInstalledForViewer($class, $viewer)) { return false; } - $class = 'PhabricatorFactApplication'; + $class = PhabricatorFactApplication::class; if (!PhabricatorApplication::isClassInstalledForViewer($class, $viewer)) { return false; } diff --git a/src/applications/project/menuitem/PhabricatorProjectWorkboardProfileMenuItem.php b/src/applications/project/menuitem/PhabricatorProjectWorkboardProfileMenuItem.php index 2f0fbb284b..e74ce3c825 100644 --- a/src/applications/project/menuitem/PhabricatorProjectWorkboardProfileMenuItem.php +++ b/src/applications/project/menuitem/PhabricatorProjectWorkboardProfileMenuItem.php @@ -26,7 +26,7 @@ final class PhabricatorProjectWorkboardProfileMenuItem $viewer = $this->getViewer(); // Workboards are only available if Maniphest is installed. - $class = 'PhabricatorManiphestApplication'; + $class = PhabricatorManiphestApplication::class; if (!PhabricatorApplication::isClassInstalledForViewer($class, $viewer)) { return false; } diff --git a/src/applications/repository/conduit/RepositoryConduitAPIMethod.php b/src/applications/repository/conduit/RepositoryConduitAPIMethod.php index 4e3a0b8360..7a7ffcfef5 100644 --- a/src/applications/repository/conduit/RepositoryConduitAPIMethod.php +++ b/src/applications/repository/conduit/RepositoryConduitAPIMethod.php @@ -4,7 +4,7 @@ abstract class RepositoryConduitAPIMethod extends ConduitAPIMethod { final public function getApplication() { return PhabricatorApplication::getByClass( - 'PhabricatorDiffusionApplication'); + PhabricatorDiffusionApplication::class); } } diff --git a/src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemonModule.php b/src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemonModule.php index 45dc49d9af..456bef99ae 100644 --- a/src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemonModule.php +++ b/src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemonModule.php @@ -7,7 +7,7 @@ final class PhabricatorRepositoryPullLocalDaemonModule public function shouldWakePool(PhutilDaemonPool $pool) { $class = $pool->getPoolDaemonClass(); - if ($class != 'PhabricatorRepositoryPullLocalDaemon') { + if ($class != PhabricatorRepositoryPullLocalDaemon::class) { return false; } diff --git a/src/applications/repository/storage/PhabricatorRepositoryIdentity.php b/src/applications/repository/storage/PhabricatorRepositoryIdentity.php index df19f302f6..ed73866eff 100644 --- a/src/applications/repository/storage/PhabricatorRepositoryIdentity.php +++ b/src/applications/repository/storage/PhabricatorRepositoryIdentity.php @@ -143,7 +143,7 @@ final class PhabricatorRepositoryIdentity public function getPolicy($capability) { $app = PhabricatorApplication::getByClass( - 'PhabricatorDiffusionApplication'); + PhabricatorDiffusionApplication::class); return $app->getPolicy( PhabricatorRepositoryIdentityEditViewCapability::CAPABILITY); } diff --git a/src/applications/search/controller/PhabricatorApplicationSearchController.php b/src/applications/search/controller/PhabricatorApplicationSearchController.php index 82691f2e4d..6b8d7aff37 100644 --- a/src/applications/search/controller/PhabricatorApplicationSearchController.php +++ b/src/applications/search/controller/PhabricatorApplicationSearchController.php @@ -916,7 +916,7 @@ final class PhabricatorApplicationSearchController $can_use = $engine->canUseInPanelContext(); $is_installed = PhabricatorApplication::isClassInstalledForViewer( - 'PhabricatorDashboardApplication', + PhabricatorDashboardApplication::class, $viewer); if ($can_use && $is_installed) { diff --git a/src/applications/search/relationship/DifferentialRevisionRelationshipSource.php b/src/applications/search/relationship/DifferentialRevisionRelationshipSource.php index 3a5b274880..f776af7fbb 100644 --- a/src/applications/search/relationship/DifferentialRevisionRelationshipSource.php +++ b/src/applications/search/relationship/DifferentialRevisionRelationshipSource.php @@ -7,7 +7,7 @@ final class DifferentialRevisionRelationshipSource $viewer = $this->getViewer(); return PhabricatorApplication::isClassInstalledForViewer( - 'PhabricatorDifferentialApplication', + PhabricatorDifferentialApplication::class, $viewer); } diff --git a/src/applications/search/relationship/DiffusionCommitRelationshipSource.php b/src/applications/search/relationship/DiffusionCommitRelationshipSource.php index 25c799caf4..e5ff375640 100644 --- a/src/applications/search/relationship/DiffusionCommitRelationshipSource.php +++ b/src/applications/search/relationship/DiffusionCommitRelationshipSource.php @@ -7,7 +7,7 @@ final class DiffusionCommitRelationshipSource $viewer = $this->getViewer(); return PhabricatorApplication::isClassInstalledForViewer( - 'PhabricatorDiffusionApplication', + PhabricatorDiffusionApplication::class, $viewer); } diff --git a/src/applications/search/relationship/ManiphestTaskRelationshipSource.php b/src/applications/search/relationship/ManiphestTaskRelationshipSource.php index e510f73a97..5838356819 100644 --- a/src/applications/search/relationship/ManiphestTaskRelationshipSource.php +++ b/src/applications/search/relationship/ManiphestTaskRelationshipSource.php @@ -7,7 +7,7 @@ final class ManiphestTaskRelationshipSource $viewer = $this->getViewer(); return PhabricatorApplication::isClassInstalledForViewer( - 'PhabricatorManiphestApplication', + PhabricatorManiphestApplication::class, $viewer); } diff --git a/src/applications/search/relationship/PholioMockRelationshipSource.php b/src/applications/search/relationship/PholioMockRelationshipSource.php index b21fd6624b..8187e7e6b5 100644 --- a/src/applications/search/relationship/PholioMockRelationshipSource.php +++ b/src/applications/search/relationship/PholioMockRelationshipSource.php @@ -7,7 +7,7 @@ final class PholioMockRelationshipSource $viewer = $this->getViewer(); return PhabricatorApplication::isClassInstalledForViewer( - 'PhabricatorPholioApplication', + PhabricatorPholioApplication::class, $viewer); } diff --git a/src/applications/settings/setting/PhabricatorConpherenceNotificationsSetting.php b/src/applications/settings/setting/PhabricatorConpherenceNotificationsSetting.php index cb792e0180..729767418a 100644 --- a/src/applications/settings/setting/PhabricatorConpherenceNotificationsSetting.php +++ b/src/applications/settings/setting/PhabricatorConpherenceNotificationsSetting.php @@ -23,7 +23,7 @@ final class PhabricatorConpherenceNotificationsSetting protected function isEnabledForViewer(PhabricatorUser $viewer) { return PhabricatorApplication::isClassInstalledForViewer( - 'PhabricatorConpherenceApplication', + PhabricatorConpherenceApplication::class, $viewer); } diff --git a/src/applications/settings/setting/PhabricatorConpherenceSoundSetting.php b/src/applications/settings/setting/PhabricatorConpherenceSoundSetting.php index e5ec008f77..0edfbd6644 100644 --- a/src/applications/settings/setting/PhabricatorConpherenceSoundSetting.php +++ b/src/applications/settings/setting/PhabricatorConpherenceSoundSetting.php @@ -24,7 +24,7 @@ final class PhabricatorConpherenceSoundSetting protected function isEnabledForViewer(PhabricatorUser $viewer) { return PhabricatorApplication::isClassInstalledForViewer( - 'PhabricatorConpherenceApplication', + PhabricatorConpherenceApplication::class, $viewer); } diff --git a/src/applications/slowvote/conduit/SlowvoteConduitAPIMethod.php b/src/applications/slowvote/conduit/SlowvoteConduitAPIMethod.php index c5971b3420..92a55d0cef 100644 --- a/src/applications/slowvote/conduit/SlowvoteConduitAPIMethod.php +++ b/src/applications/slowvote/conduit/SlowvoteConduitAPIMethod.php @@ -4,7 +4,7 @@ abstract class SlowvoteConduitAPIMethod extends ConduitAPIMethod { final public function getApplication() { return PhabricatorApplication::getByClass( - 'PhabricatorSlowvoteApplication'); + PhabricatorSlowvoteApplication::class); } } diff --git a/src/applications/tokens/conduit/TokenConduitAPIMethod.php b/src/applications/tokens/conduit/TokenConduitAPIMethod.php index f1b94a6e03..bf218d0797 100644 --- a/src/applications/tokens/conduit/TokenConduitAPIMethod.php +++ b/src/applications/tokens/conduit/TokenConduitAPIMethod.php @@ -3,7 +3,8 @@ abstract class TokenConduitAPIMethod extends ConduitAPIMethod { final public function getApplication() { - return PhabricatorApplication::getByClass('PhabricatorTokensApplication'); + return PhabricatorApplication::getByClass( + PhabricatorTokensApplication::class); } public function getMethodStatus() { diff --git a/src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php b/src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php index 9cb3680c55..d552582ec9 100644 --- a/src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php +++ b/src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php @@ -630,7 +630,7 @@ final class PhabricatorApplicationTransactionCommentView private function renderBadgeView() { $user = $this->getUser(); $can_use_badges = PhabricatorApplication::isClassInstalledForViewer( - 'PhabricatorBadgesApplication', + PhabricatorBadgesApplication::class, $user); if (!$can_use_badges) { return null; diff --git a/src/infrastructure/daemon/workers/PhabricatorTaskmasterDaemonModule.php b/src/infrastructure/daemon/workers/PhabricatorTaskmasterDaemonModule.php index ddd0e082bb..6ad8446cd0 100644 --- a/src/infrastructure/daemon/workers/PhabricatorTaskmasterDaemonModule.php +++ b/src/infrastructure/daemon/workers/PhabricatorTaskmasterDaemonModule.php @@ -6,7 +6,7 @@ final class PhabricatorTaskmasterDaemonModule public function shouldWakePool(PhutilDaemonPool $pool) { $class = $pool->getPoolDaemonClass(); - if ($class != 'PhabricatorTaskmasterDaemon') { + if ($class != PhabricatorTaskmasterDaemon::class) { return false; } diff --git a/src/infrastructure/daemon/workers/PhabricatorTriggerDaemon.php b/src/infrastructure/daemon/workers/PhabricatorTriggerDaemon.php index fd2c80e091..4cf6a69048 100644 --- a/src/infrastructure/daemon/workers/PhabricatorTriggerDaemon.php +++ b/src/infrastructure/daemon/workers/PhabricatorTriggerDaemon.php @@ -415,7 +415,7 @@ final class PhabricatorTriggerDaemon private function updateNuanceImportCursors() { - $nuance_app = 'PhabricatorNuanceApplication'; + $nuance_app = PhabricatorNuanceApplication::class; if (!PhabricatorApplication::isClassInstalled($nuance_app)) { return false; } diff --git a/src/infrastructure/daemon/workers/query/PhabricatorWorkerTriggerQuery.php b/src/infrastructure/daemon/workers/query/PhabricatorWorkerTriggerQuery.php index ac9a6b1509..f1e66536eb 100644 --- a/src/infrastructure/daemon/workers/query/PhabricatorWorkerTriggerQuery.php +++ b/src/infrastructure/daemon/workers/query/PhabricatorWorkerTriggerQuery.php @@ -109,7 +109,7 @@ final class PhabricatorWorkerTriggerQuery foreach ($triggers as $key => $trigger) { $clock_class = $trigger->getClockClass(); - if (!is_subclass_of($clock_class, 'PhabricatorTriggerClock')) { + if (!is_subclass_of($clock_class, PhabricatorTriggerClock::class)) { unset($triggers[$key]); continue; } @@ -128,7 +128,7 @@ final class PhabricatorWorkerTriggerQuery foreach ($triggers as $key => $trigger) { $action_class = $trigger->getActionClass(); - if (!is_subclass_of($action_class, 'PhabricatorTriggerAction')) { + if (!is_subclass_of($action_class, PhabricatorTriggerAction::class)) { unset($triggers[$key]); continue; } diff --git a/src/infrastructure/daemon/workers/storage/PhabricatorWorkerTask.php b/src/infrastructure/daemon/workers/storage/PhabricatorWorkerTask.php index 480a9d8614..589bd8f42d 100644 --- a/src/infrastructure/daemon/workers/storage/PhabricatorWorkerTask.php +++ b/src/infrastructure/daemon/workers/storage/PhabricatorWorkerTask.php @@ -76,7 +76,7 @@ abstract class PhabricatorWorkerTask extends PhabricatorWorkerDAO { $class)); } - if (!is_subclass_of($class, 'PhabricatorWorker')) { + if (!is_subclass_of($class, PhabricatorWorker::class)) { throw new PhabricatorWorkerPermanentFailureException( pht( "Task class '%s' does not extend %s.", diff --git a/src/infrastructure/export/engine/PhabricatorExportEngineBulkJobType.php b/src/infrastructure/export/engine/PhabricatorExportEngineBulkJobType.php index cf54bc7995..3e2aab8f53 100644 --- a/src/infrastructure/export/engine/PhabricatorExportEngineBulkJobType.php +++ b/src/infrastructure/export/engine/PhabricatorExportEngineBulkJobType.php @@ -52,7 +52,9 @@ final class PhabricatorExportEngineBulkJobType PhabricatorWorkerBulkTask $task) { $engine_class = $job->getParameter('engineClass'); - if (!is_subclass_of($engine_class, 'PhabricatorApplicationSearchEngine')) { + if (!is_subclass_of( + $engine_class, + PhabricatorApplicationSearchEngine::class)) { throw new Exception( pht( 'Unknown search engine class "%s".', diff --git a/src/view/form/control/PhabricatorRemarkupControl.php b/src/view/form/control/PhabricatorRemarkupControl.php index 4d25651ce8..36fc5dee14 100644 --- a/src/view/form/control/PhabricatorRemarkupControl.php +++ b/src/view/form/control/PhabricatorRemarkupControl.php @@ -249,7 +249,7 @@ final class PhabricatorRemarkupControl if ($can_use_macros) { $can_use_macros = PhabricatorApplication::isClassInstalledForViewer( - 'PhabricatorMacroApplication', + PhabricatorMacroApplication::class, $viewer); } diff --git a/src/view/page/PhabricatorStandardPageView.php b/src/view/page/PhabricatorStandardPageView.php index 0ca29636c2..1ccb027c55 100644 --- a/src/view/page/PhabricatorStandardPageView.php +++ b/src/view/page/PhabricatorStandardPageView.php @@ -93,7 +93,7 @@ final class PhabricatorStandardPageView extends PhabricatorBarePageView } $conpherence_installed = PhabricatorApplication::isClassInstalledForViewer( - 'PhabricatorConpherenceApplication', + PhabricatorConpherenceApplication::class, $viewer); if (!$conpherence_installed) { return false; diff --git a/src/view/page/menu/PhabricatorMainMenuView.php b/src/view/page/menu/PhabricatorMainMenuView.php index 28ef0eed7b..c74da499f9 100644 --- a/src/view/page/menu/PhabricatorMainMenuView.php +++ b/src/view/page/menu/PhabricatorMainMenuView.php @@ -354,7 +354,7 @@ final class PhabricatorMainMenuView extends AphrontView { $message_tag = ''; $message_notification_dropdown = ''; - $conpherence_app = 'PhabricatorConpherenceApplication'; + $conpherence_app = PhabricatorConpherenceApplication::class; $conpherence_data = $dropdown_data[$conpherence_app]; if ($conpherence_data['isInstalled']) { $message_id = celerity_generate_unique_node_id(); @@ -436,7 +436,7 @@ final class PhabricatorMainMenuView extends AphrontView { $bubble_tag = ''; $notification_dropdown = ''; - $notification_app = 'PhabricatorNotificationsApplication'; + $notification_app = PhabricatorNotificationsApplication::class; $notification_data = $dropdown_data[$notification_app]; if ($notification_data['isInstalled']) { $count_id = celerity_generate_unique_node_id(); diff --git a/src/view/phui/PHUITimelineView.php b/src/view/phui/PHUITimelineView.php index 8504c2c69c..cfd59b69cd 100644 --- a/src/view/phui/PHUITimelineView.php +++ b/src/view/phui/PHUITimelineView.php @@ -241,7 +241,7 @@ final class PHUITimelineView extends AphrontView { $viewer = $this->getUser(); $can_use_badges = PhabricatorApplication::isClassInstalledForViewer( - 'PhabricatorBadgesApplication', + PhabricatorBadgesApplication::class, $viewer); if (!$can_use_badges) { return; -- 2.51.2