From 21a259742179da0dfd091d1a6ee120d0056623b2 Mon Sep 17 00:00:00 2001 From: Joshua Spence Date: Tue, 24 Jun 2014 04:23:07 +1000 Subject: [PATCH] Complain if a Conduit Client doesn't send a host key. Summary: There is a TODO here that is a few years old... the Conduit Protocol is now at version 7. Test Plan: One less TODO in the codebase. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9694 --- src/applications/conduit/method/ConduitAPIMethod.php | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/src/applications/conduit/method/ConduitAPIMethod.php b/src/applications/conduit/method/ConduitAPIMethod.php index 764f8f5737..f8a9ec0a9d 100644 --- a/src/applications/conduit/method/ConduitAPIMethod.php +++ b/src/applications/conduit/method/ConduitAPIMethod.php @@ -137,16 +137,6 @@ abstract class ConduitAPIMethod } protected function validateHost($host) { - if (!$host) { - // If the client doesn't send a host key, don't complain. We should in - // the future, but this change isn't severe enough to bump the protocol - // version. - - // TODO: Remove this once the protocol version gets bumped past 2 (i.e., - // require the host key be present and valid). - return; - } - // NOTE: Compare domains only so we aren't sensitive to port specification // or omission. -- 2.54.0