From 21262d1c22fcffa44efd9e8bd2b1838050265056 Mon Sep 17 00:00:00 2001
From: Andre Klapper <a9016009@gmx.de>
Date: Fri, 26 Sep 2025 16:11:17 +0200
Subject: [PATCH] Replace some manual class name strings with ::class keyword

Summary:
Replace classname strings in `getBaseTransactionClass()` return value with the corresponding `::class` keyword.
This will enable static code analysis to throw "Class not found" if such a class did not exist.

`::class` is available since PHP 5.5: https://www.php.net/manual/en/language.oop5.basic.php#language.oop5.basic.class.class
`::class` returns the fully qualified classname including namespace, however we do not use PHP namespaces except in imported external libraries.

See similar previous patches.

Refs T15158

Test Plan: Browse random Phorge pages?

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15158

Differential Revision: https://we.phorge.it/D26380
---
 src/applications/almanac/storage/AlmanacBindingTransaction.php  | 2 +-
 src/applications/almanac/storage/AlmanacDeviceTransaction.php   | 2 +-
 .../almanac/storage/AlmanacInterfaceTransaction.php             | 2 +-
 .../almanac/storage/AlmanacNamespaceTransaction.php             | 2 +-
 src/applications/almanac/storage/AlmanacNetworkTransaction.php  | 2 +-
 src/applications/almanac/storage/AlmanacServiceTransaction.php  | 2 +-
 src/applications/audit/storage/PhabricatorAuditTransaction.php  | 2 +-
 .../auth/storage/PhabricatorAuthContactNumberTransaction.php    | 2 +-
 .../auth/storage/PhabricatorAuthFactorProviderTransaction.php   | 2 +-
 .../auth/storage/PhabricatorAuthMessageTransaction.php          | 2 +-
 .../auth/storage/PhabricatorAuthPasswordTransaction.php         | 2 +-
 .../badges/storage/PhabricatorBadgesTransaction.php             | 2 +-
 .../calendar/storage/PhabricatorCalendarEventTransaction.php    | 2 +-
 .../calendar/storage/PhabricatorCalendarExportTransaction.php   | 2 +-
 .../calendar/storage/PhabricatorCalendarImportTransaction.php   | 2 +-
 src/applications/conpherence/storage/ConpherenceTransaction.php | 2 +-
 .../countdown/storage/PhabricatorCountdownTransaction.php       | 2 +-
 .../dashboard/storage/PhabricatorDashboardPanelTransaction.php  | 2 +-
 .../dashboard/storage/PhabricatorDashboardPortalTransaction.php | 2 +-
 .../dashboard/storage/PhabricatorDashboardTransaction.php       | 2 +-
 .../differential/storage/DifferentialTransaction.php            | 2 +-
 .../drydock/storage/DrydockBlueprintTransaction.php             | 2 +-
 src/applications/files/storage/PhabricatorFileTransaction.php   | 2 +-
 .../harbormaster/storage/HarbormasterBuildTransaction.php       | 2 +-
 .../harbormaster/storage/HarbormasterBuildableTransaction.php   | 2 +-
 .../storage/configuration/HarbormasterBuildPlanTransaction.php  | 2 +-
 src/applications/herald/storage/HeraldRuleTransaction.php       | 2 +-
 src/applications/herald/storage/HeraldWebhookTransaction.php    | 2 +-
 src/applications/legalpad/storage/LegalpadTransaction.php       | 2 +-
 src/applications/macro/storage/PhabricatorMacroTransaction.php  | 2 +-
 src/applications/maniphest/storage/ManiphestTransaction.php     | 2 +-
 .../storage/PhabricatorApplicationApplicationTransaction.php    | 2 +-
 src/applications/nuance/storage/NuanceItemTransaction.php       | 2 +-
 src/applications/nuance/storage/NuanceQueueTransaction.php      | 2 +-
 src/applications/nuance/storage/NuanceSourceTransaction.php     | 2 +-
 .../owners/storage/PhabricatorOwnersPackageTransaction.php      | 2 +-
 .../packages/storage/PhabricatorPackagesPackageTransaction.php  | 2 +-
 .../storage/PhabricatorPackagesPublisherTransaction.php         | 2 +-
 .../packages/storage/PhabricatorPackagesVersionTransaction.php  | 2 +-
 .../passphrase/storage/PassphraseCredentialTransaction.php      | 2 +-
 src/applications/paste/storage/PhabricatorPasteTransaction.php  | 2 +-
 src/applications/people/storage/PhabricatorUserTransaction.php  | 2 +-
 src/applications/phame/storage/PhameBlogTransaction.php         | 2 +-
 src/applications/phame/storage/PhamePostTransaction.php         | 2 +-
 src/applications/pholio/storage/PholioTransaction.php           | 2 +-
 src/applications/phriction/storage/PhrictionTransaction.php     | 2 +-
 .../phurl/storage/PhabricatorPhurlURLTransaction.php            | 2 +-
 src/applications/ponder/storage/PonderAnswerTransaction.php     | 2 +-
 src/applications/ponder/storage/PonderQuestionTransaction.php   | 2 +-
 .../project/storage/PhabricatorProjectColumnTransaction.php     | 2 +-
 .../project/storage/PhabricatorProjectTransaction.php           | 2 +-
 .../project/storage/PhabricatorProjectTriggerTransaction.php    | 2 +-
 .../storage/PhabricatorRepositoryIdentityTransaction.php        | 2 +-
 .../repository/storage/PhabricatorRepositoryTransaction.php     | 2 +-
 .../slowvote/storage/PhabricatorSlowvoteTransaction.php         | 2 +-
 .../spaces/storage/PhabricatorSpacesNamespaceTransaction.php    | 2 +-
 .../storage/PhabricatorEditEngineConfigurationTransaction.php   | 2 +-
 57 files changed, 57 insertions(+), 57 deletions(-)

diff --git a/src/applications/almanac/storage/AlmanacBindingTransaction.php b/src/applications/almanac/storage/AlmanacBindingTransaction.php
index d17eb59000..9948c1b9f2 100644
--- a/src/applications/almanac/storage/AlmanacBindingTransaction.php
+++ b/src/applications/almanac/storage/AlmanacBindingTransaction.php
@@ -8,7 +8,7 @@ final class AlmanacBindingTransaction
   }
 
   public function getBaseTransactionClass() {
-    return 'AlmanacBindingTransactionType';
+    return AlmanacBindingTransactionType::class;
   }
 
 }
diff --git a/src/applications/almanac/storage/AlmanacDeviceTransaction.php b/src/applications/almanac/storage/AlmanacDeviceTransaction.php
index 2b921525ac..9f986a4994 100644
--- a/src/applications/almanac/storage/AlmanacDeviceTransaction.php
+++ b/src/applications/almanac/storage/AlmanacDeviceTransaction.php
@@ -8,7 +8,7 @@ final class AlmanacDeviceTransaction
   }
 
   public function getBaseTransactionClass() {
-    return 'AlmanacDeviceTransactionType';
+    return AlmanacDeviceTransactionType::class;
   }
 
 }
diff --git a/src/applications/almanac/storage/AlmanacInterfaceTransaction.php b/src/applications/almanac/storage/AlmanacInterfaceTransaction.php
index 02263f13c2..e427b67c45 100644
--- a/src/applications/almanac/storage/AlmanacInterfaceTransaction.php
+++ b/src/applications/almanac/storage/AlmanacInterfaceTransaction.php
@@ -8,7 +8,7 @@ final class AlmanacInterfaceTransaction
   }
 
   public function getBaseTransactionClass() {
-    return 'AlmanacInterfaceTransactionType';
+    return AlmanacInterfaceTransactionType::class;
   }
 
 }
diff --git a/src/applications/almanac/storage/AlmanacNamespaceTransaction.php b/src/applications/almanac/storage/AlmanacNamespaceTransaction.php
index 7b859832b8..b45d3f50d7 100644
--- a/src/applications/almanac/storage/AlmanacNamespaceTransaction.php
+++ b/src/applications/almanac/storage/AlmanacNamespaceTransaction.php
@@ -8,7 +8,7 @@ final class AlmanacNamespaceTransaction
   }
 
   public function getBaseTransactionClass() {
-    return 'AlmanacNamespaceTransactionType';
+    return AlmanacNamespaceTransactionType::class;
   }
 
 }
diff --git a/src/applications/almanac/storage/AlmanacNetworkTransaction.php b/src/applications/almanac/storage/AlmanacNetworkTransaction.php
index e487ffda3d..6be33ca156 100644
--- a/src/applications/almanac/storage/AlmanacNetworkTransaction.php
+++ b/src/applications/almanac/storage/AlmanacNetworkTransaction.php
@@ -8,7 +8,7 @@ final class AlmanacNetworkTransaction
   }
 
   public function getBaseTransactionClass() {
-    return 'AlmanacNetworkTransactionType';
+    return AlmanacNetworkTransactionType::class;
   }
 
 }
diff --git a/src/applications/almanac/storage/AlmanacServiceTransaction.php b/src/applications/almanac/storage/AlmanacServiceTransaction.php
index 62b4137e7b..d236b3b2a6 100644
--- a/src/applications/almanac/storage/AlmanacServiceTransaction.php
+++ b/src/applications/almanac/storage/AlmanacServiceTransaction.php
@@ -8,7 +8,7 @@ final class AlmanacServiceTransaction
   }
 
   public function getBaseTransactionClass() {
-    return 'AlmanacServiceTransactionType';
+    return AlmanacServiceTransactionType::class;
   }
 
 }
diff --git a/src/applications/audit/storage/PhabricatorAuditTransaction.php b/src/applications/audit/storage/PhabricatorAuditTransaction.php
index ed335a0bff..69c7a3b045 100644
--- a/src/applications/audit/storage/PhabricatorAuditTransaction.php
+++ b/src/applications/audit/storage/PhabricatorAuditTransaction.php
@@ -21,7 +21,7 @@ final class PhabricatorAuditTransaction
   }
 
   public function getBaseTransactionClass() {
-    return 'DiffusionCommitTransactionType';
+    return DiffusionCommitTransactionType::class;
   }
 
   public function getApplicationTransactionType() {
diff --git a/src/applications/auth/storage/PhabricatorAuthContactNumberTransaction.php b/src/applications/auth/storage/PhabricatorAuthContactNumberTransaction.php
index d6faccf497..1d9d854aa2 100644
--- a/src/applications/auth/storage/PhabricatorAuthContactNumberTransaction.php
+++ b/src/applications/auth/storage/PhabricatorAuthContactNumberTransaction.php
@@ -12,7 +12,7 @@ final class PhabricatorAuthContactNumberTransaction
   }
 
   public function getBaseTransactionClass() {
-    return 'PhabricatorAuthContactNumberTransactionType';
+    return PhabricatorAuthContactNumberTransactionType::class;
   }
 
 }
diff --git a/src/applications/auth/storage/PhabricatorAuthFactorProviderTransaction.php b/src/applications/auth/storage/PhabricatorAuthFactorProviderTransaction.php
index 0b7b7fc6a7..95c2540bab 100644
--- a/src/applications/auth/storage/PhabricatorAuthFactorProviderTransaction.php
+++ b/src/applications/auth/storage/PhabricatorAuthFactorProviderTransaction.php
@@ -12,7 +12,7 @@ final class PhabricatorAuthFactorProviderTransaction
   }
 
   public function getBaseTransactionClass() {
-    return 'PhabricatorAuthFactorProviderTransactionType';
+    return PhabricatorAuthFactorProviderTransactionType::class;
   }
 
 }
diff --git a/src/applications/auth/storage/PhabricatorAuthMessageTransaction.php b/src/applications/auth/storage/PhabricatorAuthMessageTransaction.php
index 407a9735c6..7448000aa3 100644
--- a/src/applications/auth/storage/PhabricatorAuthMessageTransaction.php
+++ b/src/applications/auth/storage/PhabricatorAuthMessageTransaction.php
@@ -12,7 +12,7 @@ final class PhabricatorAuthMessageTransaction
   }
 
   public function getBaseTransactionClass() {
-    return 'PhabricatorAuthMessageTransactionType';
+    return PhabricatorAuthMessageTransactionType::class;
   }
 
 }
diff --git a/src/applications/auth/storage/PhabricatorAuthPasswordTransaction.php b/src/applications/auth/storage/PhabricatorAuthPasswordTransaction.php
index a8cb6d10a3..5eca63569a 100644
--- a/src/applications/auth/storage/PhabricatorAuthPasswordTransaction.php
+++ b/src/applications/auth/storage/PhabricatorAuthPasswordTransaction.php
@@ -12,6 +12,6 @@ final class PhabricatorAuthPasswordTransaction
   }
 
   public function getBaseTransactionClass() {
-    return 'PhabricatorAuthPasswordTransactionType';
+    return PhabricatorAuthPasswordTransactionType::class;
   }
 }
diff --git a/src/applications/badges/storage/PhabricatorBadgesTransaction.php b/src/applications/badges/storage/PhabricatorBadgesTransaction.php
index 75d8f7fd59..6008afa9cf 100644
--- a/src/applications/badges/storage/PhabricatorBadgesTransaction.php
+++ b/src/applications/badges/storage/PhabricatorBadgesTransaction.php
@@ -20,7 +20,7 @@ final class PhabricatorBadgesTransaction
   }
 
   public function getBaseTransactionClass() {
-    return 'PhabricatorBadgesBadgeTransactionType';
+    return PhabricatorBadgesBadgeTransactionType::class;
   }
 
   public function getMailTags() {
diff --git a/src/applications/calendar/storage/PhabricatorCalendarEventTransaction.php b/src/applications/calendar/storage/PhabricatorCalendarEventTransaction.php
index cd4d788c1a..0ea6033893 100644
--- a/src/applications/calendar/storage/PhabricatorCalendarEventTransaction.php
+++ b/src/applications/calendar/storage/PhabricatorCalendarEventTransaction.php
@@ -20,7 +20,7 @@ final class PhabricatorCalendarEventTransaction
   }
 
   public function getBaseTransactionClass() {
-    return 'PhabricatorCalendarEventTransactionType';
+    return PhabricatorCalendarEventTransactionType::class;
   }
 
   public function getMailTags() {
diff --git a/src/applications/calendar/storage/PhabricatorCalendarExportTransaction.php b/src/applications/calendar/storage/PhabricatorCalendarExportTransaction.php
index 1bd24ef188..3d316c6144 100644
--- a/src/applications/calendar/storage/PhabricatorCalendarExportTransaction.php
+++ b/src/applications/calendar/storage/PhabricatorCalendarExportTransaction.php
@@ -12,7 +12,7 @@ final class PhabricatorCalendarExportTransaction
   }
 
   public function getBaseTransactionClass() {
-    return 'PhabricatorCalendarExportTransactionType';
+    return PhabricatorCalendarExportTransactionType::class;
   }
 
 }
diff --git a/src/applications/calendar/storage/PhabricatorCalendarImportTransaction.php b/src/applications/calendar/storage/PhabricatorCalendarImportTransaction.php
index 2102e94576..c35c631532 100644
--- a/src/applications/calendar/storage/PhabricatorCalendarImportTransaction.php
+++ b/src/applications/calendar/storage/PhabricatorCalendarImportTransaction.php
@@ -12,7 +12,7 @@ final class PhabricatorCalendarImportTransaction
   }
 
   public function getBaseTransactionClass() {
-    return 'PhabricatorCalendarImportTransactionType';
+    return PhabricatorCalendarImportTransactionType::class;
   }
 
 }
diff --git a/src/applications/conpherence/storage/ConpherenceTransaction.php b/src/applications/conpherence/storage/ConpherenceTransaction.php
index f23882d69b..2a0a727fa4 100644
--- a/src/applications/conpherence/storage/ConpherenceTransaction.php
+++ b/src/applications/conpherence/storage/ConpherenceTransaction.php
@@ -16,7 +16,7 @@ final class ConpherenceTransaction
   }
 
   public function getBaseTransactionClass() {
-    return 'ConpherenceThreadTransactionType';
+    return ConpherenceThreadTransactionType::class;
   }
 
 }
diff --git a/src/applications/countdown/storage/PhabricatorCountdownTransaction.php b/src/applications/countdown/storage/PhabricatorCountdownTransaction.php
index 78e0a54ced..37ef553864 100644
--- a/src/applications/countdown/storage/PhabricatorCountdownTransaction.php
+++ b/src/applications/countdown/storage/PhabricatorCountdownTransaction.php
@@ -20,7 +20,7 @@ final class PhabricatorCountdownTransaction
   }
 
   public function getBaseTransactionClass() {
-    return 'PhabricatorCountdownTransactionType';
+    return PhabricatorCountdownTransactionType::class;
   }
 
   public function getMailTags() {
diff --git a/src/applications/dashboard/storage/PhabricatorDashboardPanelTransaction.php b/src/applications/dashboard/storage/PhabricatorDashboardPanelTransaction.php
index 3fbbec1dd4..02bc484bf7 100644
--- a/src/applications/dashboard/storage/PhabricatorDashboardPanelTransaction.php
+++ b/src/applications/dashboard/storage/PhabricatorDashboardPanelTransaction.php
@@ -12,7 +12,7 @@ final class PhabricatorDashboardPanelTransaction
   }
 
   public function getBaseTransactionClass() {
-    return 'PhabricatorDashboardPanelTransactionType';
+    return PhabricatorDashboardPanelTransactionType::class;
   }
 
 }
diff --git a/src/applications/dashboard/storage/PhabricatorDashboardPortalTransaction.php b/src/applications/dashboard/storage/PhabricatorDashboardPortalTransaction.php
index 7861394b98..b3b213cf97 100644
--- a/src/applications/dashboard/storage/PhabricatorDashboardPortalTransaction.php
+++ b/src/applications/dashboard/storage/PhabricatorDashboardPortalTransaction.php
@@ -12,7 +12,7 @@ final class PhabricatorDashboardPortalTransaction
   }
 
   public function getBaseTransactionClass() {
-    return 'PhabricatorDashboardPortalTransactionType';
+    return PhabricatorDashboardPortalTransactionType::class;
   }
 
 }
diff --git a/src/applications/dashboard/storage/PhabricatorDashboardTransaction.php b/src/applications/dashboard/storage/PhabricatorDashboardTransaction.php
index 8b2c5c69f6..74dc4e372f 100644
--- a/src/applications/dashboard/storage/PhabricatorDashboardTransaction.php
+++ b/src/applications/dashboard/storage/PhabricatorDashboardTransaction.php
@@ -12,7 +12,7 @@ final class PhabricatorDashboardTransaction
   }
 
   public function getBaseTransactionClass() {
-    return 'PhabricatorDashboardTransactionType';
+    return PhabricatorDashboardTransactionType::class;
   }
 
 }
diff --git a/src/applications/differential/storage/DifferentialTransaction.php b/src/applications/differential/storage/DifferentialTransaction.php
index 54ece849d0..f91dfe7cfc 100644
--- a/src/applications/differential/storage/DifferentialTransaction.php
+++ b/src/applications/differential/storage/DifferentialTransaction.php
@@ -17,7 +17,7 @@ final class DifferentialTransaction
   const MAILTAG_OTHER          = 'differential-other';
 
   public function getBaseTransactionClass() {
-    return 'DifferentialRevisionTransactionType';
+    return DifferentialRevisionTransactionType::class;
   }
 
   protected function newFallbackModularTransactionType() {
diff --git a/src/applications/drydock/storage/DrydockBlueprintTransaction.php b/src/applications/drydock/storage/DrydockBlueprintTransaction.php
index 68eebe8c1d..5787fd5b9d 100644
--- a/src/applications/drydock/storage/DrydockBlueprintTransaction.php
+++ b/src/applications/drydock/storage/DrydockBlueprintTransaction.php
@@ -15,7 +15,7 @@ final class DrydockBlueprintTransaction
   }
 
   public function getBaseTransactionClass() {
-    return 'DrydockBlueprintTransactionType';
+    return DrydockBlueprintTransactionType::class;
   }
 
 }
diff --git a/src/applications/files/storage/PhabricatorFileTransaction.php b/src/applications/files/storage/PhabricatorFileTransaction.php
index 3c72be6fd7..9841a257e1 100644
--- a/src/applications/files/storage/PhabricatorFileTransaction.php
+++ b/src/applications/files/storage/PhabricatorFileTransaction.php
@@ -16,7 +16,7 @@ final class PhabricatorFileTransaction
   }
 
   public function getBaseTransactionClass() {
-    return 'PhabricatorFileTransactionType';
+    return PhabricatorFileTransactionType::class;
   }
 
 }
diff --git a/src/applications/harbormaster/storage/HarbormasterBuildTransaction.php b/src/applications/harbormaster/storage/HarbormasterBuildTransaction.php
index f095bd90d4..e9b3e2f43a 100644
--- a/src/applications/harbormaster/storage/HarbormasterBuildTransaction.php
+++ b/src/applications/harbormaster/storage/HarbormasterBuildTransaction.php
@@ -12,7 +12,7 @@ final class HarbormasterBuildTransaction
   }
 
   public function getBaseTransactionClass() {
-    return 'HarbormasterBuildTransactionType';
+    return HarbormasterBuildTransactionType::class;
   }
 
 }
diff --git a/src/applications/harbormaster/storage/HarbormasterBuildableTransaction.php b/src/applications/harbormaster/storage/HarbormasterBuildableTransaction.php
index e3b937df1e..5057813d24 100644
--- a/src/applications/harbormaster/storage/HarbormasterBuildableTransaction.php
+++ b/src/applications/harbormaster/storage/HarbormasterBuildableTransaction.php
@@ -12,7 +12,7 @@ final class HarbormasterBuildableTransaction
   }
 
   public function getBaseTransactionClass() {
-    return 'HarbormasterBuildableTransactionType';
+    return HarbormasterBuildableTransactionType::class;
   }
 
 }
diff --git a/src/applications/harbormaster/storage/configuration/HarbormasterBuildPlanTransaction.php b/src/applications/harbormaster/storage/configuration/HarbormasterBuildPlanTransaction.php
index 6cd286343a..f6bdee4b52 100644
--- a/src/applications/harbormaster/storage/configuration/HarbormasterBuildPlanTransaction.php
+++ b/src/applications/harbormaster/storage/configuration/HarbormasterBuildPlanTransaction.php
@@ -12,7 +12,7 @@ final class HarbormasterBuildPlanTransaction
   }
 
   public function getBaseTransactionClass() {
-    return 'HarbormasterBuildPlanTransactionType';
+    return HarbormasterBuildPlanTransactionType::class;
   }
 
 }
diff --git a/src/applications/herald/storage/HeraldRuleTransaction.php b/src/applications/herald/storage/HeraldRuleTransaction.php
index 7fa7667ec7..98f05f6b38 100644
--- a/src/applications/herald/storage/HeraldRuleTransaction.php
+++ b/src/applications/herald/storage/HeraldRuleTransaction.php
@@ -14,7 +14,7 @@ final class HeraldRuleTransaction
   }
 
   public function getBaseTransactionClass() {
-    return 'HeraldRuleTransactionType';
+    return HeraldRuleTransactionType::class;
   }
 
 }
diff --git a/src/applications/herald/storage/HeraldWebhookTransaction.php b/src/applications/herald/storage/HeraldWebhookTransaction.php
index 4f924cd4bb..4ea8ed33b3 100644
--- a/src/applications/herald/storage/HeraldWebhookTransaction.php
+++ b/src/applications/herald/storage/HeraldWebhookTransaction.php
@@ -12,7 +12,7 @@ final class HeraldWebhookTransaction
   }
 
   public function getBaseTransactionClass() {
-    return 'HeraldWebhookTransactionType';
+    return HeraldWebhookTransactionType::class;
   }
 
 }
diff --git a/src/applications/legalpad/storage/LegalpadTransaction.php b/src/applications/legalpad/storage/LegalpadTransaction.php
index dc4bbfe942..3dc3355fde 100644
--- a/src/applications/legalpad/storage/LegalpadTransaction.php
+++ b/src/applications/legalpad/storage/LegalpadTransaction.php
@@ -15,7 +15,7 @@ final class LegalpadTransaction extends PhabricatorModularTransaction {
   }
 
   public function getBaseTransactionClass() {
-    return 'LegalpadDocumentTransactionType';
+    return LegalpadDocumentTransactionType::class;
   }
 
 }
diff --git a/src/applications/macro/storage/PhabricatorMacroTransaction.php b/src/applications/macro/storage/PhabricatorMacroTransaction.php
index 3a15b4c15d..1344bd6027 100644
--- a/src/applications/macro/storage/PhabricatorMacroTransaction.php
+++ b/src/applications/macro/storage/PhabricatorMacroTransaction.php
@@ -20,7 +20,7 @@ final class PhabricatorMacroTransaction
   }
 
   public function getBaseTransactionClass() {
-    return 'PhabricatorMacroTransactionType';
+    return PhabricatorMacroTransactionType::class;
   }
 
 
diff --git a/src/applications/maniphest/storage/ManiphestTransaction.php b/src/applications/maniphest/storage/ManiphestTransaction.php
index 54a1e47f6c..efcf2d77a6 100644
--- a/src/applications/maniphest/storage/ManiphestTransaction.php
+++ b/src/applications/maniphest/storage/ManiphestTransaction.php
@@ -27,7 +27,7 @@ final class ManiphestTransaction
   }
 
   public function getBaseTransactionClass() {
-    return 'ManiphestTaskTransactionType';
+    return ManiphestTaskTransactionType::class;
   }
 
   public function shouldGenerateOldValue() {
diff --git a/src/applications/meta/storage/PhabricatorApplicationApplicationTransaction.php b/src/applications/meta/storage/PhabricatorApplicationApplicationTransaction.php
index 8fbe20e0fa..f4f4765c05 100644
--- a/src/applications/meta/storage/PhabricatorApplicationApplicationTransaction.php
+++ b/src/applications/meta/storage/PhabricatorApplicationApplicationTransaction.php
@@ -12,7 +12,7 @@ final class PhabricatorApplicationApplicationTransaction
   }
 
   public function getBaseTransactionClass() {
-    return 'PhabricatorApplicationTransactionType';
+    return PhabricatorApplicationTransactionType::class;
   }
 
 }
diff --git a/src/applications/nuance/storage/NuanceItemTransaction.php b/src/applications/nuance/storage/NuanceItemTransaction.php
index 5579183a66..abc70c748f 100644
--- a/src/applications/nuance/storage/NuanceItemTransaction.php
+++ b/src/applications/nuance/storage/NuanceItemTransaction.php
@@ -14,7 +14,7 @@ final class NuanceItemTransaction
   }
 
   public function getBaseTransactionClass() {
-    return 'NuanceItemTransactionType';
+    return NuanceItemTransactionType::class;
   }
 
 }
diff --git a/src/applications/nuance/storage/NuanceQueueTransaction.php b/src/applications/nuance/storage/NuanceQueueTransaction.php
index 1561db80e5..e5cb297653 100644
--- a/src/applications/nuance/storage/NuanceQueueTransaction.php
+++ b/src/applications/nuance/storage/NuanceQueueTransaction.php
@@ -11,7 +11,7 @@ final class NuanceQueueTransaction extends NuanceTransaction {
   }
 
   public function getBaseTransactionClass() {
-    return 'NuanceQueueTransactionType';
+    return NuanceQueueTransactionType::class;
   }
 
 }
diff --git a/src/applications/nuance/storage/NuanceSourceTransaction.php b/src/applications/nuance/storage/NuanceSourceTransaction.php
index 0e264876dd..eef2191366 100644
--- a/src/applications/nuance/storage/NuanceSourceTransaction.php
+++ b/src/applications/nuance/storage/NuanceSourceTransaction.php
@@ -12,7 +12,7 @@ final class NuanceSourceTransaction
   }
 
   public function getBaseTransactionClass() {
-    return 'NuanceSourceTransactionType';
+    return NuanceSourceTransactionType::class;
   }
 
 }
diff --git a/src/applications/owners/storage/PhabricatorOwnersPackageTransaction.php b/src/applications/owners/storage/PhabricatorOwnersPackageTransaction.php
index 66e15b634a..3cc141672c 100644
--- a/src/applications/owners/storage/PhabricatorOwnersPackageTransaction.php
+++ b/src/applications/owners/storage/PhabricatorOwnersPackageTransaction.php
@@ -12,7 +12,7 @@ final class PhabricatorOwnersPackageTransaction
   }
 
   public function getBaseTransactionClass() {
-    return 'PhabricatorOwnersPackageTransactionType';
+    return PhabricatorOwnersPackageTransactionType::class;
   }
 
 }
diff --git a/src/applications/packages/storage/PhabricatorPackagesPackageTransaction.php b/src/applications/packages/storage/PhabricatorPackagesPackageTransaction.php
index 29a6b74051..27afd73477 100644
--- a/src/applications/packages/storage/PhabricatorPackagesPackageTransaction.php
+++ b/src/applications/packages/storage/PhabricatorPackagesPackageTransaction.php
@@ -12,7 +12,7 @@ final class PhabricatorPackagesPackageTransaction
   }
 
   public function getBaseTransactionClass() {
-    return 'PhabricatorPackagesPackageTransactionType';
+    return PhabricatorPackagesPackageTransactionType::class;
   }
 
 }
diff --git a/src/applications/packages/storage/PhabricatorPackagesPublisherTransaction.php b/src/applications/packages/storage/PhabricatorPackagesPublisherTransaction.php
index 4aa0892ea5..2ab346fbf2 100644
--- a/src/applications/packages/storage/PhabricatorPackagesPublisherTransaction.php
+++ b/src/applications/packages/storage/PhabricatorPackagesPublisherTransaction.php
@@ -12,7 +12,7 @@ final class PhabricatorPackagesPublisherTransaction
   }
 
   public function getBaseTransactionClass() {
-    return 'PhabricatorPackagesPublisherTransactionType';
+    return PhabricatorPackagesPublisherTransactionType::class;
   }
 
 }
diff --git a/src/applications/packages/storage/PhabricatorPackagesVersionTransaction.php b/src/applications/packages/storage/PhabricatorPackagesVersionTransaction.php
index 9ae1622d70..6c670b20f9 100644
--- a/src/applications/packages/storage/PhabricatorPackagesVersionTransaction.php
+++ b/src/applications/packages/storage/PhabricatorPackagesVersionTransaction.php
@@ -12,7 +12,7 @@ final class PhabricatorPackagesVersionTransaction
   }
 
   public function getBaseTransactionClass() {
-    return 'PhabricatorPackagesVersionTransactionType';
+    return PhabricatorPackagesVersionTransactionType::class;
   }
 
 }
diff --git a/src/applications/passphrase/storage/PassphraseCredentialTransaction.php b/src/applications/passphrase/storage/PassphraseCredentialTransaction.php
index bbc3b09668..13f5707bdc 100644
--- a/src/applications/passphrase/storage/PassphraseCredentialTransaction.php
+++ b/src/applications/passphrase/storage/PassphraseCredentialTransaction.php
@@ -12,7 +12,7 @@ final class PassphraseCredentialTransaction
   }
 
   public function getBaseTransactionClass() {
-    return 'PassphraseCredentialTransactionType';
+    return PassphraseCredentialTransactionType::class;
   }
 
 }
diff --git a/src/applications/paste/storage/PhabricatorPasteTransaction.php b/src/applications/paste/storage/PhabricatorPasteTransaction.php
index 18bf984259..5b79835c04 100644
--- a/src/applications/paste/storage/PhabricatorPasteTransaction.php
+++ b/src/applications/paste/storage/PhabricatorPasteTransaction.php
@@ -20,7 +20,7 @@ final class PhabricatorPasteTransaction
   }
 
   public function getBaseTransactionClass() {
-    return 'PhabricatorPasteTransactionType';
+    return PhabricatorPasteTransactionType::class;
   }
 
   public function getMailTags() {
diff --git a/src/applications/people/storage/PhabricatorUserTransaction.php b/src/applications/people/storage/PhabricatorUserTransaction.php
index 81ca52a132..758ad215b0 100644
--- a/src/applications/people/storage/PhabricatorUserTransaction.php
+++ b/src/applications/people/storage/PhabricatorUserTransaction.php
@@ -12,7 +12,7 @@ final class PhabricatorUserTransaction
   }
 
   public function getBaseTransactionClass() {
-    return 'PhabricatorUserTransactionType';
+    return PhabricatorUserTransactionType::class;
   }
 
 }
diff --git a/src/applications/phame/storage/PhameBlogTransaction.php b/src/applications/phame/storage/PhameBlogTransaction.php
index c605510d7d..98290cf32d 100644
--- a/src/applications/phame/storage/PhameBlogTransaction.php
+++ b/src/applications/phame/storage/PhameBlogTransaction.php
@@ -16,7 +16,7 @@ final class PhameBlogTransaction
   }
 
   public function getBaseTransactionClass() {
-    return 'PhameBlogTransactionType';
+    return PhameBlogTransactionType::class;
   }
 
   public function getMailTags() {
diff --git a/src/applications/phame/storage/PhamePostTransaction.php b/src/applications/phame/storage/PhamePostTransaction.php
index 6adc640b67..17084b4a0c 100644
--- a/src/applications/phame/storage/PhamePostTransaction.php
+++ b/src/applications/phame/storage/PhamePostTransaction.php
@@ -17,7 +17,7 @@ final class PhamePostTransaction
   }
 
   public function getBaseTransactionClass() {
-    return 'PhamePostTransactionType';
+    return PhamePostTransactionType::class;
   }
 
   public function getApplicationTransactionCommentObject() {
diff --git a/src/applications/pholio/storage/PholioTransaction.php b/src/applications/pholio/storage/PholioTransaction.php
index e4656dc7f6..96ca3ba43b 100644
--- a/src/applications/pholio/storage/PholioTransaction.php
+++ b/src/applications/pholio/storage/PholioTransaction.php
@@ -12,7 +12,7 @@ final class PholioTransaction extends PhabricatorModularTransaction {
   }
 
   public function getBaseTransactionClass() {
-    return 'PholioTransactionType';
+    return PholioTransactionType::class;
   }
 
   public function getApplicationTransactionType() {
diff --git a/src/applications/phriction/storage/PhrictionTransaction.php b/src/applications/phriction/storage/PhrictionTransaction.php
index 860a86be35..7d60325ce6 100644
--- a/src/applications/phriction/storage/PhrictionTransaction.php
+++ b/src/applications/phriction/storage/PhrictionTransaction.php
@@ -22,7 +22,7 @@ final class PhrictionTransaction
   }
 
   public function getBaseTransactionClass() {
-    return 'PhrictionDocumentTransactionType';
+    return PhrictionDocumentTransactionType::class;
   }
 
   public function getRequiredHandlePHIDs() {
diff --git a/src/applications/phurl/storage/PhabricatorPhurlURLTransaction.php b/src/applications/phurl/storage/PhabricatorPhurlURLTransaction.php
index cc2f2a8672..47c4d14480 100644
--- a/src/applications/phurl/storage/PhabricatorPhurlURLTransaction.php
+++ b/src/applications/phurl/storage/PhabricatorPhurlURLTransaction.php
@@ -18,7 +18,7 @@ final class PhabricatorPhurlURLTransaction
   }
 
   public function getBaseTransactionClass() {
-    return 'PhabricatorPhurlURLTransactionType';
+    return PhabricatorPhurlURLTransactionType::class;
   }
 
   public function getRequiredHandlePHIDs() {
diff --git a/src/applications/ponder/storage/PonderAnswerTransaction.php b/src/applications/ponder/storage/PonderAnswerTransaction.php
index efbe020106..1f526a7fde 100644
--- a/src/applications/ponder/storage/PonderAnswerTransaction.php
+++ b/src/applications/ponder/storage/PonderAnswerTransaction.php
@@ -20,7 +20,7 @@ final class PonderAnswerTransaction
   }
 
   public function getBaseTransactionClass() {
-    return 'PonderAnswerTransactionType';
+    return PonderAnswerTransactionType::class;
   }
 
   public function getMailTags() {
diff --git a/src/applications/ponder/storage/PonderQuestionTransaction.php b/src/applications/ponder/storage/PonderQuestionTransaction.php
index 73a0899ca8..c698be81f5 100644
--- a/src/applications/ponder/storage/PonderQuestionTransaction.php
+++ b/src/applications/ponder/storage/PonderQuestionTransaction.php
@@ -25,7 +25,7 @@ final class PonderQuestionTransaction
   }
 
   public function getBaseTransactionClass() {
-    return 'PonderQuestionTransactionType';
+    return PonderQuestionTransactionType::class;
   }
 
   public function getMailTags() {
diff --git a/src/applications/project/storage/PhabricatorProjectColumnTransaction.php b/src/applications/project/storage/PhabricatorProjectColumnTransaction.php
index 35a7461ca2..8470c52096 100644
--- a/src/applications/project/storage/PhabricatorProjectColumnTransaction.php
+++ b/src/applications/project/storage/PhabricatorProjectColumnTransaction.php
@@ -12,7 +12,7 @@ final class PhabricatorProjectColumnTransaction
   }
 
   public function getBaseTransactionClass() {
-    return 'PhabricatorProjectColumnTransactionType';
+    return PhabricatorProjectColumnTransactionType::class;
   }
 
 }
diff --git a/src/applications/project/storage/PhabricatorProjectTransaction.php b/src/applications/project/storage/PhabricatorProjectTransaction.php
index 158c2480c0..aef980a300 100644
--- a/src/applications/project/storage/PhabricatorProjectTransaction.php
+++ b/src/applications/project/storage/PhabricatorProjectTransaction.php
@@ -20,7 +20,7 @@ final class PhabricatorProjectTransaction
   }
 
   public function getBaseTransactionClass() {
-    return 'PhabricatorProjectTransactionType';
+    return PhabricatorProjectTransactionType::class;
   }
 
   public function getRequiredHandlePHIDs() {
diff --git a/src/applications/project/storage/PhabricatorProjectTriggerTransaction.php b/src/applications/project/storage/PhabricatorProjectTriggerTransaction.php
index fb94bdc364..069f768980 100644
--- a/src/applications/project/storage/PhabricatorProjectTriggerTransaction.php
+++ b/src/applications/project/storage/PhabricatorProjectTriggerTransaction.php
@@ -12,7 +12,7 @@ final class PhabricatorProjectTriggerTransaction
   }
 
   public function getBaseTransactionClass() {
-    return 'PhabricatorProjectTriggerTransactionType';
+    return PhabricatorProjectTriggerTransactionType::class;
   }
 
 }
diff --git a/src/applications/repository/storage/PhabricatorRepositoryIdentityTransaction.php b/src/applications/repository/storage/PhabricatorRepositoryIdentityTransaction.php
index 5f25346b64..feb96ac3c5 100644
--- a/src/applications/repository/storage/PhabricatorRepositoryIdentityTransaction.php
+++ b/src/applications/repository/storage/PhabricatorRepositoryIdentityTransaction.php
@@ -8,7 +8,7 @@ final class PhabricatorRepositoryIdentityTransaction
   }
 
   public function getBaseTransactionClass() {
-    return 'PhabricatorRepositoryIdentityTransactionType';
+    return PhabricatorRepositoryIdentityTransactionType::class;
   }
 
   public function getApplicationName() {
diff --git a/src/applications/repository/storage/PhabricatorRepositoryTransaction.php b/src/applications/repository/storage/PhabricatorRepositoryTransaction.php
index 8729e462a3..fba2423d7f 100644
--- a/src/applications/repository/storage/PhabricatorRepositoryTransaction.php
+++ b/src/applications/repository/storage/PhabricatorRepositoryTransaction.php
@@ -12,7 +12,7 @@ final class PhabricatorRepositoryTransaction
   }
 
   public function getBaseTransactionClass() {
-    return 'PhabricatorRepositoryTransactionType';
+    return PhabricatorRepositoryTransactionType::class;
   }
 
 }
diff --git a/src/applications/slowvote/storage/PhabricatorSlowvoteTransaction.php b/src/applications/slowvote/storage/PhabricatorSlowvoteTransaction.php
index ef86a95760..7f75af5842 100644
--- a/src/applications/slowvote/storage/PhabricatorSlowvoteTransaction.php
+++ b/src/applications/slowvote/storage/PhabricatorSlowvoteTransaction.php
@@ -20,7 +20,7 @@ final class PhabricatorSlowvoteTransaction
   }
 
   public function getBaseTransactionClass() {
-    return 'PhabricatorSlowvoteTransactionType';
+    return PhabricatorSlowvoteTransactionType::class;
   }
 
   public function getMailTags() {
diff --git a/src/applications/spaces/storage/PhabricatorSpacesNamespaceTransaction.php b/src/applications/spaces/storage/PhabricatorSpacesNamespaceTransaction.php
index bac0ea636f..cbbafd32a4 100644
--- a/src/applications/spaces/storage/PhabricatorSpacesNamespaceTransaction.php
+++ b/src/applications/spaces/storage/PhabricatorSpacesNamespaceTransaction.php
@@ -12,7 +12,7 @@ final class PhabricatorSpacesNamespaceTransaction
   }
 
   public function getBaseTransactionClass() {
-    return 'PhabricatorSpacesNamespaceTransactionType';
+    return PhabricatorSpacesNamespaceTransactionType::class;
   }
 
 }
diff --git a/src/applications/transactions/storage/PhabricatorEditEngineConfigurationTransaction.php b/src/applications/transactions/storage/PhabricatorEditEngineConfigurationTransaction.php
index a9dca32e3d..7a022ce4a6 100644
--- a/src/applications/transactions/storage/PhabricatorEditEngineConfigurationTransaction.php
+++ b/src/applications/transactions/storage/PhabricatorEditEngineConfigurationTransaction.php
@@ -12,7 +12,7 @@ final class PhabricatorEditEngineConfigurationTransaction
   }
 
   public function getBaseTransactionClass() {
-    return 'PhabricatorEditEngineTransactionType';
+    return PhabricatorEditEngineTransactionType::class;
   }
 
 }
-- 
2.51.2