From 1f70ea9b49512b6d65f60181d92d4760e05e2eb7 Mon Sep 17 00:00:00 2001 From: Andre Klapper Date: Tue, 29 Jul 2025 15:38:02 +0000 Subject: [PATCH] a11y: Improve HTML table in PHUIFormationView Summary: Ideally this would not be a "layout table" at all but for now, improve accessibility by * marking the table in `PHUIFormationView` as a non-data table via `role="presentation"` so most screenreader software will not output the table skeleton parts; see https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Reference/Roles/presentation_role * explicitly setting `aria-hidden="true"` on the `PHUIFormationResizerView` visual slider to completely hide it from screenreader software. Closes T16195 Test Plan: Go to http://phorge.localhost/D1, inspect the HTML table parameters. Or try some screenreader software on it and realize a small improvement. Reviewers: O1 Blessed Committers, valerio.bozzolan Reviewed By: O1 Blessed Committers, valerio.bozzolan Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Maniphest Tasks: T16195 Differential Revision: https://we.phorge.it/D26221 --- src/view/formation/PHUIFormationResizerView.php | 1 + src/view/formation/PHUIFormationView.php | 1 + 2 file(s) changed, 2 insertion(s)(+), 0 deletion(s)(-) diff --git a/src/view/formation/PHUIFormationResizerView.php b/src/view/formation/PHUIFormationResizerView.php --- a/src/view/formation/PHUIFormationResizerView.php +++ b/src/view/formation/PHUIFormationResizerView.php @@ -29,6 +29,7 @@ 'div', array( 'id' => $this->getID(), + 'aria-hidden' => 'true', 'class' => 'phui-formation-resizer', 'style' => $style, )); diff --git a/src/view/formation/PHUIFormationView.php b/src/view/formation/PHUIFormationView.php --- a/src/view/formation/PHUIFormationView.php +++ b/src/view/formation/PHUIFormationView.php @@ -80,6 +80,7 @@ array( 'id' => $this->getID(), 'class' => 'phui-formation-view', + 'role' => 'presentation', 'sigil' => 'phuix-formation-view', 'meta' => array( 'items' => $phuix_items, -- tangled.sh