From 187ed0e9406f4c3157c24ff4490d70c03bb2b516 Mon Sep 17 00:00:00 2001
From: Andre Klapper <a9016009@gmx.de>
Date: Fri, 2 Jan 2026 22:56:44 +0100
Subject: [PATCH] Ponder: Do not offer/default to current status in Change
 Question Status

Summary:
The user intention is to change the question status, so listing and defaulting to the current status makes no sense. Remove the current status from the list of available options.

Also, the sidebar entry names "Close Question" and "Reopen Question" are misleading as the resulting dialog allows changing the question status from Closed from Closed. Replace that with a generic "Change Question Status" menu entry.

Closes T16443

Test Plan: Go to a Ponder Question, look at the second option in the sidebar menu, select it, look at the available list options, change the question status.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T16443

Differential Revision: https://we.phorge.it/D26645
---
 .../ponder/controller/PonderQuestionStatusController.php | 6 ++++--
 .../ponder/controller/PonderQuestionViewController.php   | 9 ++-------
 2 files changed, 6 insertions(+), 9 deletions(-)

diff --git a/src/applications/ponder/controller/PonderQuestionStatusController.php b/src/applications/ponder/controller/PonderQuestionStatusController.php
index ab791b740f..da1cdfd76e 100644
--- a/src/applications/ponder/controller/PonderQuestionStatusController.php
+++ b/src/applications/ponder/controller/PonderQuestionStatusController.php
@@ -42,11 +42,13 @@ final class PonderQuestionStatusController
 
     $radio = id(new AphrontFormRadioButtonControl())
       ->setLabel(pht('Status'))
-      ->setName('status')
-      ->setValue($v_status);
+      ->setName('status');
 
     foreach (PonderQuestionStatus::getQuestionStatusMap() as $value => $name) {
       $description = PonderQuestionStatus::getQuestionStatusDescription($value);
+      if ($value === $v_status) {
+        continue;
+      }
       $radio->addButton($value, $name, $description);
     }
 
diff --git a/src/applications/ponder/controller/PonderQuestionViewController.php b/src/applications/ponder/controller/PonderQuestionViewController.php
index 63fe4e3539..446587facf 100644
--- a/src/applications/ponder/controller/PonderQuestionViewController.php
+++ b/src/applications/ponder/controller/PonderQuestionViewController.php
@@ -144,13 +144,8 @@ final class PonderQuestionViewController extends PonderController {
 
     $curtain = $this->newCurtainView($question);
 
-    if ($question->getStatus() == PonderQuestionStatus::STATUS_OPEN) {
-      $name = pht('Close Question');
-      $icon = 'fa-check-square-o';
-    } else {
-      $name = pht('Reopen Question');
-      $icon = 'fa-square-o';
-    }
+    $name = pht('Change Question Status');
+    $icon = 'fa-square-o';
 
     $curtain->addAction(
       id(new PhabricatorActionView())
-- 
2.51.2