From 15f483c41aa19a4d91e7eb0c96f6e29b88bdd7a8 Mon Sep 17 00:00:00 2001
From: Andre Klapper <a9016009@gmx.de>
Date: Sun, 4 Jan 2026 23:38:31 +0100
Subject: [PATCH] PHP 8.5: Avoid null array keys in
 PhabricatorEditEngineConfigurationQuery::loadPage()

Summary:
Setting null as an array key is deprecated since PHP 8.5 per https://www.php.net/releases/8.5/en.php: "Using null as an array offset or when calling array_key_exists() is now deprecated. Use an empty string instead."

`PhabricatorEditEngineConfiguration::getID()` can return null when it is a builtin configuration, see e.g. existing null handling in `PhabricatorEditEngineConfiguration::getIdentifier()`.
I didn't investigate the `getPHID()` spiel though.

```
ERROR 8192: Using null as an array offset is deprecated, use an empty string instead at [/var/www/html/phorge/phorge/src/applications/transactions/query/PhabricatorEditEngineConfigurationQuery.php:134]
ERROR 8192: Using null as an array offset is deprecated, use an empty string instead at [/var/www/html/phorge/phorge/src/applications/transactions/query/PhabricatorEditEngineConfigurationQuery.php:143]
```

Closes T16438

Test Plan:
* On PHP 8.5, go to http://phorge.localhost/transactions/editengine/maniphest.task/view/1/ and select "Edit Form Configuration"
* On PHP 8.5, go to http://phorge.localhost/transactions/editengine/transactions.editengine.config/view/2/ and do something to reload that page (for example: select "Change Field Order", then reorder some fields, and click "Save Changes")

Reviewers: O1 Blessed Committers, mainframe98

Reviewed By: O1 Blessed Committers, mainframe98

Subscribers: mainframe98, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T16438

Differential Revision: https://we.phorge.it/D26657
---
 .../query/PhabricatorEditEngineConfigurationQuery.php         | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/applications/transactions/query/PhabricatorEditEngineConfigurationQuery.php b/src/applications/transactions/query/PhabricatorEditEngineConfigurationQuery.php
index b33a448105..0103aed164 100644
--- a/src/applications/transactions/query/PhabricatorEditEngineConfigurationQuery.php
+++ b/src/applications/transactions/query/PhabricatorEditEngineConfigurationQuery.php
@@ -131,7 +131,7 @@ final class PhabricatorEditEngineConfigurationQuery
     if ($this->ids !== null) {
       $ids = array_fuse($this->ids);
       foreach ($page as $key => $config) {
-        if (empty($ids[$config->getID()])) {
+        if (!$config->getID() || empty($ids[$config->getID()])) {
           unset($page[$key]);
         }
       }
@@ -140,7 +140,7 @@ final class PhabricatorEditEngineConfigurationQuery
     if ($this->phids !== null) {
       $phids = array_fuse($this->phids);
       foreach ($page as $key => $config) {
-        if (empty($phids[$config->getPHID()])) {
+        if (!$config->getPHID() || empty($phids[$config->getPHID()])) {
           unset($page[$key]);
         }
       }
-- 
2.51.2