From 13950b630c122ba6404aeb4d166d4bdd19cb7292 Mon Sep 17 00:00:00 2001 From: Pppery Date: Tue, 6 Jan 2026 11:07:46 -0500 Subject: [PATCH] Fix PhutilRemarkupEngineTestCase when run alone Summary: (Technical explanation: the `PhabricatorTestCase` class includes extra code to setup the Phabricator config system. Originally remarkup was part of the libphutil repo and didn't depend on any Phab stuff. Phorge broke this rule that had no reason to exist anymore T15161, but didn't update the test, resulting in this extremely silly edge case ...) Fixes T15973 (and sorry @valerio.bozzolan for stealing a ticket from you for the third time in the last few days) Test Plan: Run `arc unit src/infrastructure/markup/__tests__/PhutilRemarkupEngineTestCase.php` Reviewers: O1 Blessed Committers, aklapper, valerio.bozzolan Reviewed By: O1 Blessed Committers, aklapper, valerio.bozzolan Subscribers: aklapper, tobiaswiese, Matthew, valerio.bozzolan, Cigaryno Maniphest Tasks: T15973 Differential Revision: https://we.phorge.it/D26662 --- src/__phutil_library_map__.php | 2 +- .../markup/__tests__/PhutilRemarkupEngineTestCase.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php index 126a3fd402..05f57dcdc9 100644 --- a/src/__phutil_library_map__.php +++ b/src/__phutil_library_map__.php @@ -12700,7 +12700,7 @@ phutil_register_library_map(array( 'PhutilRemarkupDelRule' => 'PhutilRemarkupRule', 'PhutilRemarkupDocumentLinkRule' => 'PhutilRemarkupRule', 'PhutilRemarkupEngine' => 'PhutilMarkupEngine', - 'PhutilRemarkupEngineTestCase' => 'PhutilTestCase', + 'PhutilRemarkupEngineTestCase' => 'PhabricatorTestCase', 'PhutilRemarkupEscapeRemarkupRule' => 'PhutilRemarkupRule', 'PhutilRemarkupEvalRule' => 'PhutilRemarkupRule', 'PhutilRemarkupHeaderBlockRule' => 'PhutilRemarkupBlockRule', diff --git a/src/infrastructure/markup/__tests__/PhutilRemarkupEngineTestCase.php b/src/infrastructure/markup/__tests__/PhutilRemarkupEngineTestCase.php index a51778a66c..4606d85fa3 100644 --- a/src/infrastructure/markup/__tests__/PhutilRemarkupEngineTestCase.php +++ b/src/infrastructure/markup/__tests__/PhutilRemarkupEngineTestCase.php @@ -3,7 +3,7 @@ /** * Test cases for @{class:PhutilRemarkupEngine}. */ -final class PhutilRemarkupEngineTestCase extends PhutilTestCase { +final class PhutilRemarkupEngineTestCase extends PhabricatorTestCase { public function testEngine() { $root = dirname(__FILE__).'/remarkup/'; -- 2.51.2