From 12a24263b60c065ebd9b753ce7675e106e7d85c5 Mon Sep 17 00:00:00 2001 From: Andre Klapper Date: Mon, 9 Jun 2025 23:53:54 +0200 Subject: [PATCH] PHPDoc: Replace non-existing param type id with int Summary: `id` is not a valid type. See https://docs.phpdoc.org/guide/references/phpdoc/types.html. Test Plan: Read docs; run static code analysis. Reviewers: O1 Blessed Committers, valerio.bozzolan Reviewed By: O1 Blessed Committers, valerio.bozzolan Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Differential Revision: https://we.phorge.it/D26075 --- .../differential/parser/DifferentialChangesetParser.php | 2 +- src/infrastructure/daemon/workers/PhabricatorWorker.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/applications/differential/parser/DifferentialChangesetParser.php b/src/applications/differential/parser/DifferentialChangesetParser.php index 2397f2b2a0..19dd678c91 100644 --- a/src/applications/differential/parser/DifferentialChangesetParser.php +++ b/src/applications/differential/parser/DifferentialChangesetParser.php @@ -240,7 +240,7 @@ final class DifferentialChangesetParser extends Phobject { * the left and right halves of the displayed diff to be correctly mapped to * storage changesets. * - * @param id $id The Differential Changeset ID that comments added to the + * @param int $id The Differential Changeset ID that comments added to the * right side of the visible diff should be attached to. * @param bool $is_new If true, attach new comments to the right side of the * storage changeset. Note that this may be false, if the left diff --git a/src/infrastructure/daemon/workers/PhabricatorWorker.php b/src/infrastructure/daemon/workers/PhabricatorWorker.php index e06b0dc560..e187623e13 100644 --- a/src/infrastructure/daemon/workers/PhabricatorWorker.php +++ b/src/infrastructure/daemon/workers/PhabricatorWorker.php @@ -287,7 +287,7 @@ abstract class PhabricatorWorker extends Phobject { * This method does not provide any assurances about when these tasks will * execute, or even guarantee that it will have any effect at all. * - * @param list $ids List of task IDs to try to awaken. + * @param array $ids List of task IDs to try to awaken. * @return void */ final public static function awakenTaskIDs(array $ids) { -- 2.51.2