From 113bdd9f7940748f3c381ea787cd2ce862ef5883 Mon Sep 17 00:00:00 2001
From: Chad Little <chad@phacility.com>
Date: Tue, 31 Jan 2017 19:34:16 -0800
Subject: [PATCH] Fix application name toolip hover

Summary: Ref T12174. We were always setting a name via builtins so the tooltip was always set. Fix the calls here.

Test Plan: Add "Badges", see tooltip, give "Badges" a name of "Badges", don't see tooltip.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Maniphest Tasks: T12174

Differential Revision: https://secure.phabricator.com/D17284
---
 .../home/engine/PhabricatorHomeProfileMenuEngine.php           | 2 +-
 .../search/menuitem/PhabricatorApplicationProfileMenuItem.php  | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/applications/home/engine/PhabricatorHomeProfileMenuEngine.php b/src/applications/home/engine/PhabricatorHomeProfileMenuEngine.php
index 888dec6a8e..d7ecd9db6f 100644
--- a/src/applications/home/engine/PhabricatorHomeProfileMenuEngine.php
+++ b/src/applications/home/engine/PhabricatorHomeProfileMenuEngine.php
@@ -39,7 +39,7 @@ final class PhabricatorHomeProfileMenuEngine
       }
 
       $properties = array(
-        'name' => $application->getName(),
+        'name' => '',
         'application' => $application->getPHID(),
       );
 
diff --git a/src/applications/search/menuitem/PhabricatorApplicationProfileMenuItem.php b/src/applications/search/menuitem/PhabricatorApplicationProfileMenuItem.php
index 3697de3403..92477522ba 100644
--- a/src/applications/search/menuitem/PhabricatorApplicationProfileMenuItem.php
+++ b/src/applications/search/menuitem/PhabricatorApplicationProfileMenuItem.php
@@ -89,7 +89,8 @@ final class PhabricatorApplicationProfileMenuItem
       ->setIcon($app->getIcon());
 
     // Don't show tooltip if they've set a custom name
-    if (strlen(($config->getMenuItemProperty('name')))) {
+    $name = $config->getMenuItemProperty('name');
+    if (!strlen($name)) {
       $item->setTooltip($app->getShortDescription());
     }
 
-- 
2.51.2