From 0c65f2d33333ed29bd0259c5d4dc2e5e586796ca Mon Sep 17 00:00:00 2001
From: Andre Klapper <a9016009@gmx.de>
Date: Sun, 1 Jun 2025 13:23:02 +0200
Subject: [PATCH] a11y: Set textarea name parameter also as aria-label

Summary:
Form elements should have associated labels per https://www.w3.org/WAI/tutorials/forms/labels/
Setting the `name` parameter for a `<textarea>` also as its `aria-label` is clearly more accessible than exposing no hints at all.

Ref T16072

Test Plan:
Go to http://phorge.localhost/D1, inspect comment field (below "Add Action..." dropdown) markup, see additional `aria-label="comment"` for `<textarea>`
Go to http://phorge.localhost/T1, inspect comment field (below "Add Action..." dropdown) markup, see additional `aria-label="comment"` for `<textarea>`
Go to http://phorge.localhost/maniphest/task/edit/1/, inspect Description field markup, see additional `aria-label="description"` for `<textarea>`
Go to http://phorge.localhost/paste/edit/1/, inspect Text field markup, see additional `aria-label="text"` for `<textarea>`
Optionally, run an Accessibility check in Chromium Lighthouse.

Reviewers: O1 Blessed Committers, chris

Reviewed By: O1 Blessed Committers, chris

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T16072

Differential Revision: https://we.phorge.it/D26045
---
 src/view/form/control/AphrontFormTextAreaControl.php | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/view/form/control/AphrontFormTextAreaControl.php b/src/view/form/control/AphrontFormTextAreaControl.php
index e548916fbb..d83edeb0d1 100644
--- a/src/view/form/control/AphrontFormTextAreaControl.php
+++ b/src/view/form/control/AphrontFormTextAreaControl.php
@@ -84,6 +84,7 @@ class AphrontFormTextAreaControl extends AphrontFormControl {
       'textarea',
       array(
         'name'        => $this->getName(),
+        'aria-label'  => $this->getName(),
         'disabled'    => $this->getDisabled() ? 'disabled' : null,
         'readonly'    => $this->getReadOnly() ? 'readonly' : null,
         'class'       => $classes,
-- 
2.51.2