From 0873b36569bfcf502a092870d7d5f4d088ed9003 Mon Sep 17 00:00:00 2001 From: Andre Klapper Date: Wed, 3 Jul 2024 08:38:35 +0200 Subject: [PATCH] Remove call to non-existing AphrontTypeaheadTemplateView::renderToken() Summary: `AphrontTypeaheadTemplateView::renderToken()` is an undefined method, and its result is stored in an orphan variable, and no child class extends `AphrontTypeaheadTemplateView` defining a `renderToken()`. Thus remove its call from `AphrontTypeaheadTemplateView::render()`. Test Plan: Read/grep the code in this class. Reviewers: O1 Blessed Committers, valerio.bozzolan Reviewed By: O1 Blessed Committers, valerio.bozzolan Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Differential Revision: https://we.phorge.it/D25721 --- src/view/control/AphrontTypeaheadTemplateView.php | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/view/control/AphrontTypeaheadTemplateView.php b/src/view/control/AphrontTypeaheadTemplateView.php index e536a7a7cf..08c7140edd 100644 --- a/src/view/control/AphrontTypeaheadTemplateView.php +++ b/src/view/control/AphrontTypeaheadTemplateView.php @@ -34,12 +34,6 @@ final class AphrontTypeaheadTemplateView extends AphrontView { $id = $this->id; $name = $this->getName(); - $values = nonempty($this->getValue(), array()); - - $tokens = array(); - foreach ($values as $key => $value) { - $tokens[] = $this->renderToken($key, $value); - } $input = javelin_tag( 'input', -- 2.51.2