From 0151c38b107fd23eb3c50382f1b4687138e142b5 Mon Sep 17 00:00:00 2001 From: Joshua Spence Date: Wed, 10 Sep 2014 06:49:56 +1000 Subject: [PATCH] Apply some autofix linter rules Summary: Self-explanatory. Test Plan: Eyeball it. Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D10454 --- .../configuration/AphrontApplicationConfiguration.php | 3 +-- src/aphront/exception/AphrontCSRFException.php | 4 +--- src/aphront/exception/AphrontException.php | 4 +--- .../management/PhabricatorAuditManagementWorkflow.php | 4 +--- .../auth/data/PhabricatorAuthHighSecurityToken.php | 4 +--- .../management/PhabricatorAuthManagementWorkflow.php | 4 +--- .../__tests__/PhabricatorTestController.php | 4 +--- .../management/PhabricatorCacheManagementWorkflow.php | 4 +--- .../PhabricatorCalendarEventInvalidEpochException.php | 3 +-- .../chatlog/constants/PhabricatorChatLogConstants.php | 4 +--- .../controller/PhabricatorChatLogController.php | 4 +--- .../exception/ConduitMethodNotFoundException.php | 4 +--- .../PhabricatorConfigValidationException.php | 4 +--- .../PhabricatorConfigManagementWorkflow.php | 4 +--- .../controller/PhabricatorDashboardController.php | 4 +--- .../PhabricatorDashboardPanelCustomField.php | 4 +--- .../editor/DifferentialTransactionEditor.php | 3 +-- .../DifferentialDiffCreationRejectException.php | 4 +--- .../exception/DifferentialFieldParseException.php | 4 +--- .../DifferentialFieldValidationException.php | 4 +--- .../management/PhabricatorHunksManagementWorkflow.php | 4 +--- .../controller/DiffusionBrowseSearchController.php | 6 ++---- .../controller/DiffusionPushLogController.php | 4 +--- .../exception/DiffusionCommitHookRejectException.php | 4 +--- .../diffusion/ssh/DiffusionSSHMercurialWorkflow.php | 4 +--- .../exception/DoorkeeperMissingLinkException.php | 4 +--- .../drydock/constants/DrydockConstants.php | 4 +--- .../customfield/DrydockBlueprintCustomField.php | 4 +--- .../drydock/management/DrydockManagementWorkflow.php | 4 +--- .../drydock/query/DrydockBlueprintSearchEngine.php | 4 +--- .../drydock/query/DrydockLogSearchEngine.php | 4 +--- .../fact/controller/PhabricatorFactController.php | 4 +--- .../management/PhabricatorFactManagementWorkflow.php | 4 +--- .../feed/constants/PhabricatorFeedConstants.php | 4 +--- .../management/PhabricatorFeedManagementWorkflow.php | 4 +--- .../files/editor/PhabricatorFileEditor.php | 11 +++-------- .../flag/constants/PhabricatorFlagConstants.php | 4 +--- .../flag/interface/PhabricatorFlaggableInterface.php | 4 +--- .../customfield/HarbormasterBuildStepCustomField.php | 4 +--- .../exception/HarbormasterBuildAbortedException.php | 4 +--- .../exception/HarbormasterBuildFailureException.php | 4 +--- .../management/HarbormasterManagementWorkflow.php | 4 +--- .../PhabricatorLipsumManagementWorkflow.php | 4 +--- .../metamta/constants/MetaMTAConstants.php | 4 +--- .../controller/PhabricatorMetaMTAController.php | 4 +--- .../PhabricatorMetaMTAPermanentFailureException.php | 4 +--- .../management/PhabricatorMailManagementWorkflow.php | 4 +--- src/applications/nuance/constants/NuanceConstants.php | 4 +--- .../nuance/controller/NuanceController.php | 4 +--- .../source/NuancePhabricatorFormSourceDefinition.php | 6 ++---- .../people/customfield/PhabricatorUserCustomField.php | 5 +---- .../lipsum/PhabricatorPeopleTestDataGenerator.php | 3 +-- .../handle/const/PhabricatorObjectHandleConstants.php | 4 +--- .../phortune/constants/PhortuneConstants.php | 4 +--- .../interface/PhrequentTrackableInterface.php | 4 +--- .../policy/constants/PhabricatorPolicyConstants.php | 4 +--- .../policy/controller/PhabricatorPolicyController.php | 4 +--- .../PhabricatorPolicyManagementWorkflow.php | 4 +--- src/applications/ponder/constants/PonderConstants.php | 3 +-- .../project/constants/PhabricatorProjectConstants.php | 4 +--- .../PhabricatorProjectNameCollisionException.php | 4 +--- .../project/interface/PhabricatorProjectInterface.php | 4 +--- .../project/query/PhabricatorProjectSearchEngine.php | 8 ++------ .../controller/request/ReleephRequestController.php | 4 +--- .../customfield/PhabricatorCommitCustomField.php | 5 +---- .../repository/editor/PhabricatorRepositoryEditor.php | 7 ++----- .../PhabricatorSearchManagementWorkflow.php | 4 +--- .../management/PhabricatorSystemRemoveWorkflow.php | 4 +--- .../management/CelerityManagementWorkflow.php | 4 +--- .../PhabricatorCustomFieldNotAttachedException.php | 4 +--- .../PhabricatorWorkerPermanentFailureException.php | 4 +--- .../edges/constants/PhabricatorEdgeConstants.php | 4 +--- .../events/PhabricatorAutoEventListener.php | 4 +--- ...bricatorInternationalizationManagementWorkflow.php | 4 +--- .../query/PhabricatorEmptyQueryException.php | 4 +--- .../management/PhabricatorSMSManagementWorkflow.php | 4 +--- .../lisk/__tests__/LiskIsolationTestDAOException.php | 2 +- .../PhabricatorPasswordHasherUnavailableException.php | 4 +--- 78 files changed, 84 insertions(+), 241 deletions(-) diff --git a/src/aphront/configuration/AphrontApplicationConfiguration.php b/src/aphront/configuration/AphrontApplicationConfiguration.php index 07f7a806e3..237acbb0a5 100644 --- a/src/aphront/configuration/AphrontApplicationConfiguration.php +++ b/src/aphront/configuration/AphrontApplicationConfiguration.php @@ -52,8 +52,7 @@ abstract class AphrontApplicationConfiguration { return $this->path; } - public function willBuildRequest() { - } + public function willBuildRequest() {} /* -( URI Routing )-------------------------------------------------------- */ diff --git a/src/aphront/exception/AphrontCSRFException.php b/src/aphront/exception/AphrontCSRFException.php index 58e00f0b61..c7ff45e82f 100644 --- a/src/aphront/exception/AphrontCSRFException.php +++ b/src/aphront/exception/AphrontCSRFException.php @@ -1,5 +1,3 @@ getConfig('enabled', parent::shouldRequireEnabledUser()); } - public function processRequest() { - - } + public function processRequest() {} } diff --git a/src/applications/cache/management/PhabricatorCacheManagementWorkflow.php b/src/applications/cache/management/PhabricatorCacheManagementWorkflow.php index a4b813c64e..72a9db071b 100644 --- a/src/applications/cache/management/PhabricatorCacheManagementWorkflow.php +++ b/src/applications/cache/management/PhabricatorCacheManagementWorkflow.php @@ -1,6 +1,4 @@ getTransactionType()) { - } + switch ($xaction->getTransactionType()) {} return parent::requireCapabilities($object, $xaction); } diff --git a/src/applications/differential/exception/DifferentialDiffCreationRejectException.php b/src/applications/differential/exception/DifferentialDiffCreationRejectException.php index 15f8383d91..e068084f0a 100644 --- a/src/applications/differential/exception/DifferentialDiffCreationRejectException.php +++ b/src/applications/differential/exception/DifferentialDiffCreationRejectException.php @@ -1,5 +1,3 @@ limit(8)->resolveAll(); - } catch (PhutilSyntaxHighlighterException $ex) { - } + } catch (PhutilSyntaxHighlighterException $ex) {} $rows = array(); foreach ($results as $result) { @@ -148,8 +147,7 @@ final class DiffusionBrowseSearchController extends DiffusionBrowseController { try { $string = $futures["{$path}:{$line}"]->resolve(); - } catch (PhutilSyntaxHighlighterException $ex) { - } + } catch (PhutilSyntaxHighlighterException $ex) {} $string = phutil_tag( 'pre', diff --git a/src/applications/diffusion/controller/DiffusionPushLogController.php b/src/applications/diffusion/controller/DiffusionPushLogController.php index 16b9bf5530..78890dd05b 100644 --- a/src/applications/diffusion/controller/DiffusionPushLogController.php +++ b/src/applications/diffusion/controller/DiffusionPushLogController.php @@ -1,5 +1,3 @@ createNewUser($user, $email_object); return $user; - } catch (AphrontDuplicateKeyQueryException $ex) { - } + } catch (AphrontDuplicateKeyQueryException $ex) {} } } diff --git a/src/applications/phid/handle/const/PhabricatorObjectHandleConstants.php b/src/applications/phid/handle/const/PhabricatorObjectHandleConstants.php index 053c86657c..411fb88c48 100644 --- a/src/applications/phid/handle/const/PhabricatorObjectHandleConstants.php +++ b/src/applications/phid/handle/const/PhabricatorObjectHandleConstants.php @@ -1,5 +1,3 @@ getTransactionType(); - switch ($type) { - } + switch ($type) {} return parent::mergeTransactions($u, $v); } @@ -271,9 +270,7 @@ final class PhabricatorRepositoryEditor $new = $xaction->getNewValue(); $type = $xaction->getTransactionType(); - switch ($type) { - - } + switch ($type) {} return parent::transactionHasEffect($object, $xaction); } diff --git a/src/applications/search/management/PhabricatorSearchManagementWorkflow.php b/src/applications/search/management/PhabricatorSearchManagementWorkflow.php index 00c3399610..23333665e3 100644 --- a/src/applications/search/management/PhabricatorSearchManagementWorkflow.php +++ b/src/applications/search/management/PhabricatorSearchManagementWorkflow.php @@ -1,6 +1,4 @@