From 587215db179a0257b0560d48d7dd0677b1d45d73 Mon Sep 17 00:00:00 2001 From: "ptr.pet" Date: Sun, 31 May 2026 09:06:50 +0300 Subject: [PATCH] bobbin: allow sh.tangled.string to be used when trying to list comments Signed-off-by: dawn --- bobbin/crates/xrpc/src/lib.rs | 2 +- bobbin/crates/xrpc/tests/aggregation.rs | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/bobbin/crates/xrpc/src/lib.rs b/bobbin/crates/xrpc/src/lib.rs index 3979f3a5..f8f883a0 100644 --- a/bobbin/crates/xrpc/src/lib.rs +++ b/bobbin/crates/xrpc/src/lib.rs @@ -1006,7 +1006,7 @@ impl HasSubject for PullRecord { } impl HasSubject for FeedCommentRecord { const SHAPE: SubjectShape = - SubjectShape::OneOfCollections(&["sh.tangled.repo.issue", "sh.tangled.repo.pull"]); + SubjectShape::OneOfCollections(&["sh.tangled.repo.issue", "sh.tangled.repo.pull", "sh.tangled.string"]); } impl HasSubject for LabelDefinitionRecord { const SHAPE: SubjectShape = SubjectShape::BareDid; diff --git a/bobbin/crates/xrpc/tests/aggregation.rs b/bobbin/crates/xrpc/tests/aggregation.rs index 6d2a0995..d3d5e4f0 100644 --- a/bobbin/crates/xrpc/tests/aggregation.rs +++ b/bobbin/crates/xrpc/tests/aggregation.rs @@ -1312,10 +1312,10 @@ async fn feed_comment_endpoints_reject_bare_did_or_wrong_collection() { let (status, body) = json_response(resp).await; assert_eq!(status, StatusCode::BAD_REQUEST, "{endpoint} input={input}"); let msg = body["message"].as_str().unwrap_or_default(); - assert!( - msg.contains("sh.tangled.repo.issue") && msg.contains("sh.tangled.repo.pull"), - "{endpoint} input={input}: {msg}", - ); + assert!( + msg.contains("sh.tangled.repo.issue") && msg.contains("sh.tangled.repo.pull") && msg.contains("sh.tangled.string"), + "{endpoint} input={input}: {msg}", + ); } }) .await; -- 2.51.2