From 0586265772d54f9f953ec61f17d2206cded4fb4c Mon Sep 17 00:00:00 2001 From: Anirudh Oppiliappan Date: Wed, 10 Jun 2026 21:20:53 +0300 Subject: [PATCH] appview/pages: fix following toggle hitbox on safari the trending widget used a stretched link (absolute inset-0) inside a position:relative table row. safari does not support positioned table rows as containing blocks, so each row link stretched to a distant ancestor and swallowed taps far outside the widget, e.g. the global/following toggle on mobile. replace the table with real anchor rows laid out on a grid. Signed-off-by: Anirudh Oppiliappan --- .../timeline/fragments/trending.html | 41 +++++++++---------- 1 file changed, 20 insertions(+), 21 deletions(-) diff --git a/appview/pages/templates/timeline/fragments/trending.html b/appview/pages/templates/timeline/fragments/trending.html index 97b4addc..ffe81b69 100644 --- a/appview/pages/templates/timeline/fragments/trending.html +++ b/appview/pages/templates/timeline/fragments/trending.html @@ -5,13 +5,11 @@ Trending {{ if .Repos }} - - +
{{ range $index, $repo := .Repos }} {{ template "singleLineRepo" (list $ $repo) }} {{ end }} -
-
+ {{ else }}
No trending repositories this week @@ -25,25 +23,26 @@ {{ $repo := index . 1 }} {{ with $repo }} {{ $repoOwner := resolve .Did }} - - -
- {{ i "star" "w-3 h-3 fill-current shrink-0" }} - {{ if .RepoStats }} - {{ scaleFmt .RepoStats.StarCount }} - {{ else }} - 0 - {{ end }} -
- - - + {{/* a real anchor per row: a stretched (absolute inset-0) link inside a + position:relative table row breaks hit-testing on safari, which does + not support positioned table rows as containing blocks */}} + +
+ {{ i "star" "w-3 h-3 fill-current shrink-0 mt-1" }} + {{ if .RepoStats }} + {{ scaleFmt .RepoStats.StarCount }} + {{ else }} + 0 + {{ end }} +
+
{{ $repoOwner }}/{{ .Name }} {{ with .Description }} {{ . | description }} {{ end }} - - +
+
{{ if and .RepoStats .RepoStats.Language }} {{ $lang := .RepoStats.Language }} {{ $display := $lang }} @@ -55,8 +54,8 @@ {{ $display }}
{{ end }} - - +
+ {{ end }} {{ end }} -- 2.51.2