From d721f5d3a5790354865bca474a37ab02b818f100 Mon Sep 17 00:00:00 2001 From: bryan newbold Date: Fri, 21 Feb 2025 12:21:44 -0800 Subject: [PATCH] events: omitempty on 't' in header --- events/cbor_gen.go | 44 ++++++++++++++++++++++++++------------------ events/events.go | 2 +- 2 files changed, 27 insertions(+), 19 deletions(-) diff --git a/events/cbor_gen.go b/events/cbor_gen.go index 8e13f833..909d05a8 100644 --- a/events/cbor_gen.go +++ b/events/cbor_gen.go @@ -25,32 +25,40 @@ func (t *EventHeader) MarshalCBOR(w io.Writer) error { } cw := cbg.NewCborWriter(w) + fieldCount := 2 - if _, err := cw.Write([]byte{162}); err != nil { + if t.MsgType == "" { + fieldCount-- + } + + if _, err := cw.Write(cbg.CborEncodeMajorType(cbg.MajMap, uint64(fieldCount))); err != nil { return err } // t.MsgType (string) (string) - if len("t") > 1000000 { - return xerrors.Errorf("Value in field \"t\" was too long") - } + if t.MsgType != "" { - if err := cw.WriteMajorTypeHeader(cbg.MajTextString, uint64(len("t"))); err != nil { - return err - } - if _, err := cw.WriteString(string("t")); err != nil { - return err - } + if len("t") > 1000000 { + return xerrors.Errorf("Value in field \"t\" was too long") + } - if len(t.MsgType) > 1000000 { - return xerrors.Errorf("Value in field t.MsgType was too long") - } + if err := cw.WriteMajorTypeHeader(cbg.MajTextString, uint64(len("t"))); err != nil { + return err + } + if _, err := cw.WriteString(string("t")); err != nil { + return err + } - if err := cw.WriteMajorTypeHeader(cbg.MajTextString, uint64(len(t.MsgType))); err != nil { - return err - } - if _, err := cw.WriteString(string(t.MsgType)); err != nil { - return err + if len(t.MsgType) > 1000000 { + return xerrors.Errorf("Value in field t.MsgType was too long") + } + + if err := cw.WriteMajorTypeHeader(cbg.MajTextString, uint64(len(t.MsgType))); err != nil { + return err + } + if _, err := cw.WriteString(string(t.MsgType)); err != nil { + return err + } } // t.Op (int64) (int64) diff --git a/events/events.go b/events/events.go index aeba2df7..34f77610 100644 --- a/events/events.go +++ b/events/events.go @@ -152,7 +152,7 @@ const ( type EventHeader struct { Op int64 `cborgen:"op"` - MsgType string `cborgen:"t"` + MsgType string `cborgen:"t,omitempty"` } var ( -- 2.51.2