From fb4f39d300cac0177c99f618dd6e597035eb3b5d Mon Sep 17 00:00:00 2001 From: Luis Pater Date: Mon, 1 Jun 2026 02:59:31 +0800 Subject: [PATCH] test(models, executor): add XAI video model test and fix Codex User-Agent assertions --- internal/registry/model_definitions_test.go | 18 ++++++++++++++++++ .../executor/codex_websockets_executor_test.go | 8 ++++---- 2 files changed, 22 insertions(+), 4 deletions(-) create mode 100644 internal/registry/model_definitions_test.go diff --git a/internal/registry/model_definitions_test.go b/internal/registry/model_definitions_test.go new file mode 100644 index 00000000..15e2a167 --- /dev/null +++ b/internal/registry/model_definitions_test.go @@ -0,0 +1,18 @@ +package registry + +import "testing" + +func TestWithXAIBuiltinsIncludesVideoPreviewModel(t *testing.T) { + models := WithXAIBuiltins(nil) + + for _, model := range models { + if model == nil { + continue + } + if model.ID == xaiBuiltinVideo15PreviewModelID { + return + } + } + + t.Fatalf("expected xAI builtin model %s", xaiBuiltinVideo15PreviewModelID) +} diff --git a/internal/runtime/executor/codex_websockets_executor_test.go b/internal/runtime/executor/codex_websockets_executor_test.go index a2ef16c2..ba01d2b6 100644 --- a/internal/runtime/executor/codex_websockets_executor_test.go +++ b/internal/runtime/executor/codex_websockets_executor_test.go @@ -163,11 +163,11 @@ func TestApplyCodexWebsocketHeadersDefaultsToCurrentResponsesBeta(t *testing.T) if !strings.HasPrefix(codexUserAgent, codexOriginator+"/") { t.Fatalf("default Codex User-Agent = %s, want prefix %s/", codexUserAgent, codexOriginator) } - if strings.HasPrefix(codexUserAgent, "codex-tui/") { - t.Fatalf("default Codex User-Agent = %s, must not use stale codex-tui prefix", codexUserAgent) + if !strings.HasPrefix(codexUserAgent, "codex-tui/") { + t.Fatalf("default Codex User-Agent = %s, want codex-tui prefix", codexUserAgent) } - if strings.Contains(codexUserAgent, "(codex-tui;") { - t.Fatalf("default Codex User-Agent = %s, must not include stale codex-tui suffix", codexUserAgent) + if !strings.Contains(codexUserAgent, "(codex-tui;") { + t.Fatalf("default Codex User-Agent = %s, want codex-tui suffix", codexUserAgent) } if got := headers.Get("Originator"); got != codexOriginator { t.Fatalf("Originator = %s, want %s", got, codexOriginator) -- 2.51.2