From 409ccb2349de9e5df64a9e23e2c1c8b9bd45f66b Mon Sep 17 00:00:00 2001 From: "@permadeath.com" Date: Tue, 11 Aug 2026 14:39:23 -0400 Subject: [PATCH] docs: note the Chrome floor AbortSignal.any would impose MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit AbortSignal.any is Chrome 116, above the manifest's minimum. No caller passes a signal, so the branch is unreachable and the floor is unaffected today — but the next caller to pass one would break Chrome 110-115 silently, so say so where that caller will be written. --- src/lib/http.ts | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/lib/http.ts b/src/lib/http.ts index 7d1fc5d..df86e91 100644 --- a/src/lib/http.ts +++ b/src/lib/http.ts @@ -127,6 +127,11 @@ export async function request(url: string, options: RequestOptions = {}): Promis let lastError: unknown for (let attempt = 0; ; attempt++) { + // AbortSignal.timeout is Chrome 103; AbortSignal.any is Chrome 116, above + // the manifest's minimum_chrome_version. Nothing passes `signal` today, so + // that branch is unreachable and the floor stays where it is — but the + // first caller to pass one makes 116 the real minimum. Raise + // minimum_chrome_version then, or combine the signals by hand here. const timeout = AbortSignal.timeout(timeoutMs) const signal = options.signal ? AbortSignal.any([options.signal, timeout]) : timeout // Decided rather than thrown: a `throw` here would be caught by this same -- 2.51.2