From ef6bcb49618f0f500838c0b41970bca146baadfa Mon Sep 17 00:00:00 2001 From: "@permadeath.com" Date: Wed, 26 Aug 2026 14:03:19 -0400 Subject: [PATCH] docs(plan): record the stamp-format exemption that did not hold The previous entry left state_of and latest_states as string compares on the grounds that one PDS means one stamp format; the account's own records hold both spellings, so it was the state read that broke. Change-Id: I83c1b240f7c0f3753f842f4d36290852a215ca96 --- plan/pull-requests.md | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/plan/pull-requests.md b/plan/pull-requests.md index 64141c8..000264f 100644 --- a/plan/pull-requests.md +++ b/plan/pull-requests.md @@ -200,6 +200,20 @@ line of work sit beside it: publishing the branch a pull claims is and stay — they read one PDS, so every stamp shares a writer and a format; `cmd/issue/read.rs`'s `newest_state` is not covered by that exemption, merging two accounts' records, and already parsed +- [x] the exemption the entry above claimed for `state_of` and + `latest_states` was wrong, and it was the one that decided a pull's + state. One PDS does not mean one format: this account's own records + hold `…+03:00` beside `…Z`, because Tangled's web UI writes the + offset the browser was in, and precision wanders too (`.74Z`, `.8Z`, + whole seconds). So a status record stamped `04:31:07+03:00` — 01:31Z — + outsorted a reopen written at `02:00:00Z` half an hour later, and + `…02:00:00.500Z` lost to `…02:00:00Z` because `'.' < 'Z'`. The pull + read `merged`, `pr resubmit` refused it as merged and `pr reopen` saw + nothing to do. Both now order on the parsed instant with the raw string + as a tie-break, the shape `Listed::instant` and `newest` already use, + so the doc comment's claim that the two agree stays true. The + newest-missing name in the staleness warning was the same string max + and moved with them - [x] `status pr` — your pull requests across every repo, moved out from under `pr`. `pr list` is a repo's pull requests and this is an account's, across all of them; that is the largest fact about either -- 2.51.2