From fee43b49c41c31375b2109e8d0cb78cef1dd28b1 Mon Sep 17 00:00:00 2001
From: eti <eti@eti.tf>
Date: Wed, 2 Sep 2026 23:13:41 +0200
Subject: [PATCH] web/components: make DropdownItem use ResolvedPathname

Signed-off-by: eti <eti@eti.tf>
---
 .../lib/components/profile/ProfileCard.svelte |  6 ++++-
 .../repo/pipelines/PipelineWorkflows.svelte   |  2 +-
 web/src/lib/components/shell/Topbar.svelte    | 22 +++++++++++++------
 web/src/lib/components/ui/DropdownItem.svelte |  6 ++---
 4 files changed, 24 insertions(+), 12 deletions(-)

diff --git a/web/src/lib/components/profile/ProfileCard.svelte b/web/src/lib/components/profile/ProfileCard.svelte
index 1059fa07d..5b9b56231 100644
--- a/web/src/lib/components/profile/ProfileCard.svelte
+++ b/web/src/lib/components/profile/ProfileCard.svelte
@@ -8,6 +8,7 @@
 	import Link from "$icon/link";
 	import Pencil from "$icon/pencil";
 	import Rss from "$icon/rss";
+	import { resolve } from "$app/paths";
 	import ReportItems from "$lib/components/moderation/ReportItems.svelte";
 	import Avatar from "$lib/components/ui/Avatar.svelte";
 	import Button from "$lib/components/ui/Button.svelte";
@@ -164,7 +165,10 @@
 						buttonVariant="default"
 						insetShadow={true}
 					>
-						<DropdownItem icon={Rss} href={`/${identity.handle}/feed.atom`}>
+						<DropdownItem
+							icon={Rss}
+							href={resolve(`/${identity.handle}/feed.atom` as "/")}
+						>
 							Atom feed
 						</DropdownItem>
 						<ReportItems authorDid={identity.did} authorHandle={identity.handle} />
diff --git a/web/src/lib/components/repo/pipelines/PipelineWorkflows.svelte b/web/src/lib/components/repo/pipelines/PipelineWorkflows.svelte
index 070363cbb..0e2770b99 100644
--- a/web/src/lib/components/repo/pipelines/PipelineWorkflows.svelte
+++ b/web/src/lib/components/repo/pipelines/PipelineWorkflows.svelte
@@ -145,7 +145,7 @@
 		{/snippet}
 
 		{#each pipeline.workflows as workflow (workflow.name)}
-			<DropdownItem href={workflowPath(workflow.name)} class={classes.item()}>
+			<DropdownItem href={resolve(workflowPath(workflow.name) as "/")} class={classes.item()}>
 				<span class={classes.row()}>
 					<span class={classes.name()}>
 						<PipelineStatusIcon status={workflow.status} colored />
diff --git a/web/src/lib/components/shell/Topbar.svelte b/web/src/lib/components/shell/Topbar.svelte
index 1c2a58c7d..f111c6d12 100644
--- a/web/src/lib/components/shell/Topbar.svelte
+++ b/web/src/lib/components/shell/Topbar.svelte
@@ -125,10 +125,10 @@
 								<Plus class="size-3.5" aria-hidden="true" />
 								<span class="hidden md:inline">New</span>
 							{/snippet}
-							<DropdownItem href="/repo/new" icon={BookPlus}
+							<DropdownItem href={resolve("/repo/new")} icon={BookPlus}
 								>New repository</DropdownItem
 							>
-							<DropdownItem href="/strings/new" icon={LineSquiggle}
+							<DropdownItem href={resolve("/strings/new")} icon={LineSquiggle}
 								>New string</DropdownItem
 							>
 						</Dropdown>
@@ -184,23 +184,31 @@
 									</DropdownItem>
 								{/each}
 							{/if}
-							<DropdownItem href={loginHref}>
+							<DropdownItem href={appPath(loginHref)}>
 								<span class={style.addBall()}>
 									<Plus class="size-3" aria-hidden="true" />
 								</span>
 								Add account
 							</DropdownItem>
 							<Separator />
-							<DropdownItem href={`/${user.handle}`} icon={UserIcon}
+							<DropdownItem href={appPath(`/${user.handle}`)} icon={UserIcon}
 								>Profile</DropdownItem
 							>
-							<DropdownItem href={`/${user.handle}?tab=repos`} icon={BookMarked}>
+							<DropdownItem
+								href={appPath(`/${user.handle}?tab=repos`)}
+								icon={BookMarked}
+							>
 								Repositories
 							</DropdownItem>
-							<DropdownItem href={`/${user.handle}?tab=strings`} icon={LineSquiggle}>
+							<DropdownItem
+								href={appPath(`/${user.handle}?tab=strings`)}
+								icon={LineSquiggle}
+							>
 								Strings
 							</DropdownItem>
-							<DropdownItem href="/settings" icon={Cog}>Settings</DropdownItem>
+							<DropdownItem href={resolve("/settings")} icon={Cog}
+								>Settings</DropdownItem
+							>
 							<DropdownItem danger icon={LogOut} onclick={onSignOut}
 								>Logout</DropdownItem
 							>
diff --git a/web/src/lib/components/ui/DropdownItem.svelte b/web/src/lib/components/ui/DropdownItem.svelte
index 0015862a6..d40021bee 100644
--- a/web/src/lib/components/ui/DropdownItem.svelte
+++ b/web/src/lib/components/ui/DropdownItem.svelte
@@ -18,14 +18,14 @@
 </script>
 
 <script lang="ts">
-	import { resolve } from "$app/paths";
+	import type { ResolvedPathname } from "$app/types";
 	import type { Component, Snippet } from "svelte";
 	import type { SvelteHTMLElements } from "svelte/elements";
 	import { getContext } from "svelte";
 	import Button, { type ButtonVariants } from "./Button.svelte";
 
 	interface Props {
-		href?: string;
+		href?: ResolvedPathname;
 		icon?: Component<SvelteHTMLElements["svg"]>;
 		danger?: DropdownItemVariants["danger"];
 		onclick?: (event: MouseEvent) => void;
@@ -71,7 +71,7 @@
 	{...rest}
 	bind:ref={el}
 	variant="ghost"
-	href={href ? resolve(href as "/") : undefined}
+	{href}
 	class={classes}
 	{icon}
 	role="menuitem"
-- 
2.51.2